[00:02:38] (03CR) 10Gergő Tisza: Skip userinfo request if no message depends on the gender (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127459 (owner: 10Gergő Tisza) [00:15:57] (03PS4) 10Gergő Tisza: Open license deed in new tab [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127392 [00:16:28] (03CR) 10jenkins-bot: [V: 04-1] Open license deed in new tab [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127392 (owner: 10Gergő Tisza) [00:21:25] (03PS5) 10Gergő Tisza: Open license deed in new tab [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127392 [00:21:59] (03CR) 10Gergő Tisza: Open license deed in new tab (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127392 (owner: 10Gergő Tisza) [00:34:28] (03PS9) 10Gergő Tisza: Cache API responses [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127438 [00:37:44] (03CR) 10Gergő Tisza: "I don't think we can do anything on client side about the private header, so this patch should be fine now. I'll write a core patch to mak" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127438 (owner: 10Gergő Tisza) [00:38:06] Hm, I made sure that the images are both there [00:38:11] But the tests still fail. [00:38:13] Sigh [00:39:16] (03CR) 10MarkTraceur: "I had Fabrice tone the page down, but still no luck." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [01:29:03] (03CR) 10Gergő Tisza: "We really should have a separate test page." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [07:03:34] (03PS2) 10Gilles: Set correct license link location in E2E test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 [07:04:58] (03CR) 10Gilles: "Now using http://en.wikipedia.beta.wmflabs.org/wiki/MediaViewerE2ETest" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [07:19:02] (03CR) 10Gilles: "Now that you mention it, I'm starting to wonder if that particular animation works at all this way. I'll double check. Maybe it's an issue" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [07:29:55] (03CR) 10Gilles: "Duh, the CSS statement is missing a semicolon." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [07:32:07] (03PS4) 10Gilles: Show metadata panel immediately. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [07:32:38] (03CR) 10jenkins-bot: [V: 04-1] Show metadata panel immediately. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [07:40:48] (03CR) 10Gilles: "Changing the names of the existing events is a pain in the ass, we would need to update the SQL that generates the TSVs with some clever m" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 (owner: 10Gilles) [07:42:37] (03CR) 10Gilles: [C: 032] Show error trace in console when catching an error in bootstrap [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127807 (owner: 10Gergő Tisza) [07:43:10] (03Merged) 10jenkins-bot: Show error trace in console when catching an error in bootstrap [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127807 (owner: 10Gergő Tisza) [07:45:48] (03CR) 10Gilles: "Ah, I see that some of the new ones are affected by bad naming, I'll do the cleaning up." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 (owner: 10Gilles) [08:20:42] (03PS4) 10Gilles: Track more user actions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 [08:21:27] (03CR) 10Gilles: "All concerns should be addressed. I figured that since I'm updating the schema I'm going to have to update the SQL anyway, so cleaned up e" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 (owner: 10Gilles) [08:30:56] (03CR) 10Gilles: [C: 032] Display correct file type on download button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127400 (owner: 10Gergő Tisza) [08:31:27] (03Merged) 10jenkins-bot: Display correct file type on download button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127400 (owner: 10Gergő Tisza) [08:45:55] (03CR) 10Gilles: Skip userinfo request if no message depends on the gender (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127459 (owner: 10Gergő Tisza) [08:47:42] (03CR) 10Gilles: [C: 032] Open license deed in new tab [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127392 (owner: 10Gergő Tisza) [08:48:12] (03Merged) 10jenkins-bot: Open license deed in new tab [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127392 (owner: 10Gergő Tisza) [08:55:08] (03CR) 10Gilles: Cache API responses (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127438 (owner: 10Gergő Tisza) [08:56:57] (03PS10) 10Gilles: Cache API responses [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127438 (owner: 10Gergő Tisza) [08:58:15] (03CR) 10Gilles: [C: 032] Cache API responses [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127438 (owner: 10Gergő Tisza) [08:58:46] (03Merged) 10jenkins-bot: Cache API responses [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127438 (owner: 10Gergő Tisza) [09:09:14] (03CR) 10Gilles: [C: 04-2] "This is an extreme UI change, unrequested by anyone. I think it's a premature measure as well, we haven't seen people's reaction to a prog" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 (owner: 10Gergő Tisza) [09:12:26] (03CR) 10Gilles: [C: 032] Split the progress bar into a component of its own. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 (owner: 10Gergő Tisza) [09:12:57] (03CR) 10jenkins-bot: [V: 04-1] Split the progress bar into a component of its own. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 (owner: 10Gergő Tisza) [09:17:53] (03CR) 10Gilles: "Also, if your comment on the Mingle card is correct and you copied CSS that came from Google's search engine verbatim, it's a serious lega" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 (owner: 10Gergő Tisza) [09:19:05] (03CR) 10Gilles: Split the progress bar into a component of its own. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 (owner: 10Gergő Tisza) [09:19:12] (03CR) 10Gilles: [C: 032] Split the progress bar into a component of its own. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 (owner: 10Gergő Tisza) [09:19:42] (03Merged) 10jenkins-bot: Split the progress bar into a component of its own. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127808 (owner: 10Gergő Tisza) [09:24:51] (03PS2) 10Gilles: Bigger, badder, animated progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 [14:30:35] (03CR) 10Yuvipanda: "Campaigns is 'Upload Campaigns' that provides https://commons.wikimedia.org/wiki/Campaign:wlm-in and similar things on commons." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:30:46] (03PS2) 10Yuvipanda: UploadWizard is missing a SpecialPageAlias for Campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:32:19] (03CR) 10Yuvipanda: "I know the Campaigns extension is confusing in this context, but I found out about that extension only after I wrote Campaigns in UploadWi" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:33:01] (03CR) 10Yuvipanda: [C: 032] "(https://commons.wikimedia.org/wiki/Special:Campaigns provides list of active campaigns)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [14:33:18] (03Merged) 10jenkins-bot: UploadWizard is missing a SpecialPageAlias for Campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [15:39:10] (03PS3) 10Cmcmahon: Set correct license link location in E2E test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [15:40:30] (03CR) 10Cmcmahon: "Added the polling "when_present" to make Chrome happy" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [15:42:07] (03CR) 10Cmcmahon: [C: 04-1] "The scrolling trick works in Firefox but does not seem to work for Chrome:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [16:02:11] (03CR) 10MarkTraceur: "I'm still getting the same error." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [16:08:39] (03CR) 10MarkTraceur: [C: 04-1] "Needs rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127459 (owner: 10Gergő Tisza) [16:10:26] (03PS5) 10MarkTraceur: Show metadata panel immediately. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [16:21:48] (03CR) 10MarkTraceur: [C: 032] "Thanks!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [16:23:00] (03Merged) 10jenkins-bot: Show metadata panel immediately. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [16:23:03] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/458 I merged your patch https://gerrit.wikimedia.org/r/127384 but I don't think it has the effect of immediately loading the metadata panel. [16:32:01] tgr: "the CSS is shamelessly stolen from the Google Image Search progressbar" are there licensing issues we may need to be cognisant of? [16:32:10] (https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/464) [16:34:23] hi marktraceur thanks for the error msg. in gerrit-- I know why you get "undefined method `close' for nil:NilClass (NoMethodError)", but I can't figure out how. when you run a test, do you launch a browser at all? [16:34:54] chrismcmahon: I don't, no [16:35:05] I thought that might be an issue [16:35:15] chrismcmahon: What setup is required for that? [16:35:21] I may have my firefox in a weird place [16:35:40] And chromium is only installed insofar as there's a binary on my computer that runs it [16:36:17] marktraceur: in the shared ruby gem, the line in question is "@browser.close". you have no browser object to close. [16:36:24] Sounds right [16:37:26] marktraceur: do you have more errors reported? [16:37:46] In the later tests, yeah [16:38:02] But not in the first test [16:38:34] Oh sorry, it does say "TimeoutError" but I figure that's because there continues to not be a browser object. [16:39:04] marktraceur: yeah, I was hoping for something complaining about not finding a browser executable or some such [16:40:03] marktraceur: in case you haven't found it, this might be of use: https://github.com/wikimedia/mediawiki-selenium [16:40:19] marktraceur: in the README [16:43:57] I'm trying phantomjs now [16:52:53] chrismcmahon: Same deal with phantomjs [16:53:45] chrismcmahon: Also, when I hit ctrl-c it opens the browser [16:53:57] But only briefly [16:53:59] And then exits [16:54:45] marktraceur: are you starting the test by "bundle exec cucumber features/basic_mmv_navigation.feature" ? [16:55:41] Just bundle exec cucumber [16:55:46] But should do the same thing [16:56:22] hrm [16:57:42] chrismcmahon: I could escalate to the actual cucumber community if you'd like [16:59:42] marktraceur: I'm pretty sure the problem is not in Cucumber [17:00:10] No but they may be able to poke around and debug in ways we can't think of [17:06:24] marktraceur: do we have a bugzilla ticket for your issue? [17:06:39] No, I figured we would just fix it [17:06:54] Since it's debugging my setup...but if you think it's a bigger issue we can file one [17:08:07] marktraceur: go ahead and make one under Wikimedia/Quality Assurance, so I can show it to Zeljko [17:08:15] 'kay [17:09:52] marktraceur: so if you actually do see a browser for a moment after ctrl-c, then something is blocking the step that creates the browser. that shouldn't be possible, but there it is. [17:10:29] Hm. [17:10:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=64249 [17:23:59] thanks marktraceur, there is a #selenium channel on freenode that is often helpful, I just asked in there. [17:26:15] marktraceur: although the guy who would really know doesn't seem to be answering atm. David Burns is the guy at Mozilla who maintains all the selenium-webdriver stuff. [17:26:20] we shall see [17:28:03] marktraceur: is Abrowser version 28 the same as FF version 28? [17:28:07] Yeah [17:28:11] It's just de-branded [17:36:08] marktraceur: I start to wonder if the Abrowser folks left behind the webdriver server/listener part when they forked FF [17:36:39] Hm, maybe. [17:36:49] Is there any way to test that? [18:19:37] marktraceur: Any idea why beta would be complaining with this? -- PHP Notice: Undefined variable: wmgBetaFeaturesWhitelist in /mnt/srv/common-local/wmf-config/CommonSettings.php on line 1812 [18:19:53] bd808: I blame James_F [18:20:03] Who will blame Roan. But don't let him. [18:20:04] bd808: Hmm. [18:20:25] Line is -- 1812: $wgBetaFeaturesWhitelist = $wmgBetaFeaturesWhitelist; [18:20:36] Ah, whoops. [18:20:58] That should be null || $wmgBetaFeaturesWhitelist I guess. [18:21:09] (It's meant to be null for Beta Labs. [18:21:13] Other way around, dear [18:21:29] Sure. [18:21:44] wouldn't fix the notice, though [18:22:18] also, that's $wmg... ?: null [18:22:29] || always returns boolean in PHP [18:22:30] * James_F nods. [18:22:35] Eurgh, yeah. [18:22:42] * James_F is too rusty on his PHP. [18:22:48] multiversion does such twisted things with the initialization path that I'm lost untangling. [18:23:13] InitialiseSettings-labs.php tries to set that to null I believe [18:23:21] bd808: Yeah. [18:23:29] s/that/wmgBetaFeaturesWhitelist/ [18:33:03] fabriceflorin: marktraceur: our weekly meeting overlaps the scrum of scrums now [18:33:06] isn't that bad? [18:33:22] tgr: "yes" [18:40:54] (03CR) 10Gergő Tisza: [C: 032] "Thanks!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 (owner: 10Gilles) [18:41:29] (03Merged) 10jenkins-bot: Track more user actions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 (owner: 10Gilles) [18:42:12] (03CR) 10MarkTraceur: [C: 04-1] "-1 because I'm furious about code conventions" (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [18:51:51] (03CR) 10Gergő Tisza: "Is this a convention, though? It is not mentioned on https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [19:19:29] (03CR) 10Gergő Tisza: "This is a simple geometric pattern, the use of which is standard industry practice; it is about five lines of CSS, plus browser fallbacks." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127809 (owner: 10Gergő Tisza) [19:36:39] (03PS1) 10Amire80: Add mediawiki.jqueryMsg as a dependency for mmv.ui.fileUsage [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129016 [19:42:50] (03CR) 10Gergő Tisza: "Yeah, the panel co-appears with the placeholder now, but there is still a period of blackness before they appear. Strange, that should not" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [19:49:28] Ugh metrics [19:49:34] I care so little about the state of this repository [20:01:44] gi11es: Is "for sqlpath in `ls $SQL_DIR/*wiki-*.sql`; do" your addition? [20:01:47] I don't recognize it [21:00:04] marktraceur: yes [21:00:20] gi11es: We still need it? [21:00:34] marktraceur: it's new, needed by the latest merge request I've sent your way [21:00:35] I'm adding the per-wiki-per-stat scripts and it looks like the regex there will catch them too [21:00:41] Well I merged that [21:00:46] But it doesn't look right [21:01:00] It looks like we'll wind up with one file per stat, for the last wiki alphabetically [21:01:10] that block is meant to handle per-wiki-per-metric [21:01:15] I worte it blindly, though [21:01:59] so yes, if you found out that it doesn't work and needs rewriting, it's not too surprising [21:02:10] I'm gonna do it [21:02:13] Er [21:02:14] Remove it [21:02:17] I haven't had time to reproduce your setup in my home directory to verify it [21:02:18] And try to get 'er working [21:02:48] I figured we'd try it and figure it out if need be when you'd merge the diff [21:02:53] which is now :) [21:03:37] Yeah [21:03:56] gi11es: The end goal is to have a tsv for each stat and each wiki, right? [21:04:01] right [21:04:06] 'kay, yeah [21:04:10] I should be able to sort it [21:04:20] I have two follow-up merge requests coming up that I wrote when I was offline [21:05:02] for one dashboard per wiki, percentiles and splitting up the graph with all perf metrics into a graph for each metric [21:07:43] 'kay [21:22:20] marktraceur: first one: https://gitorious.org/analytics/multimedia/merge_requests/9 this is the counterpart of "more actions" gerrit changeset that you guys merged earlier [21:23:05] gi11es: marktraceur: we should get that repo into gerrit, then puppetize the setup, and make a vagrant role for it [21:24:15] I guess [21:25:01] what would be the right place for it? a branch in the MMV repo, or a separate repo? [21:25:08] gi11es: Can you hold up while I move it to gerrit, then submit the new changes? [21:25:21] tgr: Separate repo; in fact they already exist [21:25:33] please get my changes in first, they were a lot of work and I don't expect to produce another one for a few days [21:25:55] Oh, 'kay. [21:25:58] the percentile graphs will be very useful for our current performance stuff [21:26:11] gi11es: Is the other one to multimedia-limn? [21:26:14] yes [21:26:21] have you gotten the tsvs to generate? [21:26:23] Well then I'm stuck :P [21:26:30] Yeah, they're good [21:26:38] They'll be on the public host soon [21:26:45] it'll take me a couple of minutes to check and upload the other changeset [21:27:04] can you give me the full name of one of them? just so that I don't mess up the format on the limn side [21:27:15] Uhhh [21:27:46] media-viewer-perf-en-imagehit.tsv [21:28:42] thanks, good thing I asked since I wrote it the other way around in the limn config (I had to go from memory since I was offline) [21:32:06] marktraceur: if you can regenerate the tsvs after merging https://gitorious.org/analytics/multimedia/merge_requests/9 that would be ace [21:32:30] the per-metric tsvs are already working (checked locally) [21:33:06] Sure [21:33:14] actually I don't see the percentiles, but I'll look into that later [21:33:45] maybe that "SET" trick doesn't work with the way you run the SQL from the command line [21:34:33] ah, it does work, the issue is on my end [21:38:10] found the typo, almost there [21:39:28] prepare to be dazzled by percentiles [21:41:57] marktraceur: https://gitorious.org/analytics/multimedia-limn/merge_requests/9 [21:42:01] 'kay [21:43:49] the new dashboards are /mmv_hu /mmv_mediawiki etc. [21:43:57] *nod* [21:44:11] I should probably put the tsvs in separate directories or something [21:44:14] Sigh [21:44:14] hmmm, checking media-viewer-actions-mediawiki.tsv it contains: [21:44:18] Ctrl-C -- sending "KILL QUERY 391340" to server ... [21:44:19] Ctrl-C -- query aborted. [21:44:23] ...hm [21:44:38] I noticed that the actions one is particularly long to run [21:44:59] Oh, right [21:45:03] The actions need to get fixed [21:45:11] Sorry about that [21:48:21] I’m reviewing the progress bar patchset: https://gerrit.wikimedia.org/r/#/c/127695/ [21:48:50] Is there any trick to stop the progress bar so that I can properly adjust it [21:49:32] inspect with firebug [21:49:39] remove "empty" class from the progress container [21:49:44] set the width of the bar to your liking [21:49:51] ok. Thanks [21:57:07] (03PS1) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129045 [21:57:35] marktraceur: gi11es: could someone review ^^? [21:57:58] tgr: sure [22:02:47] also this one: https://gerrit.wikimedia.org/r/129047 [22:03:13] (03CR) 10Gilles: [C: 032] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129045 (owner: 10Gergő Tisza) [22:03:33] (03PS2) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129045 [22:03:47] (just a commit msg change) [22:04:10] just in time, heh [22:04:47] (03CR) 10Gilles: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129045 (owner: 10Gergő Tisza) [22:04:53] (03CR) 10Gilles: [C: 032] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129045 (owner: 10Gergő Tisza) [22:05:24] (03Merged) 10jenkins-bot: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129045 (owner: 10Gergő Tisza) [22:06:58] fixed the core commit [22:08:38] Action tsvs should be fixed soon [22:08:53] (03PS1) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129048 [22:10:24] marktraceur: what was wrong with them? [22:10:55] (03PS1) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 [22:11:27] (03CR) 10jenkins-bot: [V: 04-1] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [22:13:05] (03PS2) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 [22:13:37] (03CR) 10jenkins-bot: [V: 04-1] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [22:14:00] oh come on. [22:14:15] (03PS3) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 [22:14:51] (03CR) 10jenkins-bot: [V: 04-1] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [22:15:15] (03PS4) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 [22:15:47] (03CR) 10jenkins-bot: [V: 04-1] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [22:16:04] (03PS5) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 [22:16:35] (03CR) 10jenkins-bot: [V: 04-1] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [22:16:52] this is getting ridiculous [22:17:07] (03PS3) 10Pginer: Bigger, badder, animated progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 (owner: 10Gilles) [22:17:10] yes I had a similar run earlier this week [22:17:28] (03PS6) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 [22:17:59] I made some small adjustments (size and transparency of the progress bar) [22:18:03] pginer: since you've updated it, I assume that's the solution for the more prominent progress bar you want to go for? [22:18:09] (03CR) 10jenkins-bot: [V: 04-1] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [22:18:29] eh [22:18:46] just try a while later [22:18:48] looks like no survey for French people, sorry :) [22:19:01] gi11es: yes, looks ok [22:19:12] it's antoine's fault, how appropriate [22:19:20] but I’m not sure if I’ allowed to +1 after doing some changes myself [22:19:58] pginer: it's common to +2 after tweaking a little thing that was wrong, saves a bit of time [22:20:21] since you're the one judging that one, makes sense for you to +1/+2 it [22:21:27] (03CR) 10Pginer: [C: 031] Bigger, badder, animated progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 (owner: 10Gilles) [22:21:39] ok, I +1ed, I don’t have +2 powers [22:22:00] (03CR) 10Gilles: [C: 032] Bigger, badder, animated progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 (owner: 10Gilles) [22:22:34] (03CR) 10jenkins-bot: [V: 04-1] Bigger, badder, animated progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 (owner: 10Gilles) [22:22:41] of course! [22:29:53] (03CR) 10Gilles: Bigger, badder, animated progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 (owner: 10Gilles) [22:30:00] (03CR) 10Gilles: [C: 032] Bigger, badder, animated progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 (owner: 10Gilles) [22:30:16] Jesus christ gi11es [22:30:20] This is a huge patch [22:30:27] most of these files are generated [22:30:32] (03Merged) 10jenkins-bot: Bigger, badder, animated progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127695 (owner: 10Gilles) [22:30:40] Yeah [22:30:44] just look at the changes to _template files and generator.php [22:31:10] about that, do we have stored procedure creation rights on that DB? [22:31:18] when we clean the whole thing up and repackage it we can run the generator before the daily builds, this way those files won't have to be in source control [22:31:21] that might be one option to clean the code up [22:31:43] I don't think so, that user has very limited rights [22:31:47] can't even create temporary tables [22:32:29] and stored procedures are rarely a good idea. they're not in source control, they're generally slow [22:32:49] ori's suggestion to send EventLogging data to something more statistics-friendly than mariadb makes more sense [22:33:32] there's only so much you can do to compile stats figures with mariadb's dumb sql [22:34:57] it's been hack after hack to compute those statistics that are all stats 101 metrics [22:35:29] tgr: that changeset just merged, it was segfaulting before, I think you can retry yours [22:35:42] makes sense as a long-term plan, but there needs to be a more statistics-friendly db first [22:36:06] but you are right, generating those files automatically is still a better options [22:36:28] mysql's procedure language is beyond horrible [22:36:47] (03PS7) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 [22:37:27] (03CR) 10jenkins-bot: [V: 04-1] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [22:39:37] I think the person who reviews it can V+2 it. it'll run into the same test during the merge check, but that saves you from editing the commit message that many times [22:40:19] then it just becomes an issue of +0 then +2ing it in gerrit instead of having to do all these local git manipulations [22:41:53] you can C:2 V:2, delete the -1, then press publish [22:42:00] that's the only way afaik [22:42:30] chrismcmahon: how do I run the cucumber tests on chrome? [22:42:34] but publish skips all tests, i don't know if that's a good idea on a production branch [22:43:14] since the tests are running against the future automerge, that's fine [22:43:31] as long as you know there won't be a doc issue [22:44:18] there won't be, since the same patch merged in two other branch [22:44:46] but i'm not sure that the tests done at merge are the same as the tests done at uploading a new patchset [22:44:51] and publish skips them all [22:45:14] it can differ depending on the repo setup, that's true, but when I saw it it seemed like a mistake more than anything [22:45:30] i.e. the merge tests ran less things than the gerrit update ones [22:45:43] gi11es: https://code.google.com/p/selenium/wiki/ChromeDriver then http://chromedriver.storage.googleapis.com/index.html should be easy [22:45:52] thanks [22:46:23] well, i'll leave this to the SWAT person, they have to do the merging anyway [22:46:49] chrismcmahon: is there a shell variable or something to turn it on for our tests? [22:47:00] worst case, these wikis only get the survey on Thursday with 1.24wmf1 [22:47:37] gi11es: export BROWSER=chrome (or whatever your shell does for bash-export) [22:48:55] righto [22:50:12] (03PS2) 10BryanDavis: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/127617 (owner: 10Reedy) [22:52:49] (03CR) 10BryanDavis: [C: 032] Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/127617 (owner: 10Reedy) [22:53:07] (03Merged) 10jenkins-bot: Fix Fatal error: Call to a member function doTransform() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/127617 (owner: 10Reedy) [23:00:40] (03PS8) 10Gergő Tisza: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 [23:01:50] (03CR) 10jenkins-bot: [V: 04-1] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [23:02:13] (03CR) 10Ori.livneh: "recheck" [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [23:02:50] (03CR) 10Ori.livneh: [C: 032] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [23:02:56] (03CR) 10Gilles: "The scrolling code works, I think it's just that in Chrome the back button is pressed too fast, before the Media Viewer has time to open. " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [23:03:00] (03CR) 10jenkins-bot: [V: 04-1] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [23:04:58] (03CR) 10Ori.livneh: [V: 032] "Overriding Jenkins" [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/129049 (owner: 10Gergő Tisza) [23:05:29] chrome driver is blazing fast compares to firefox... [23:05:34] compared [23:05:54] maybe too fast and that's what's causing the problem, heh [23:06:02] (03CR) 10Ori.livneh: [C: 032] Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129048 (owner: 10Gergő Tisza) [23:06:57] (03Merged) 10jenkins-bot: Add more survey languages (fr, de, pt/pr-br) [extensions/MultimediaViewer] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129048 (owner: 10Gergő Tisza) [23:15:43] woah, I was able to reproduce it manually, it seems that it's a bug when we exit and reopen media viewer super fast [23:15:54] so, the test rightfully fails in chrome [23:17:04] scroll down > open image > press escape then really quickly click on the image again -> press browser back button [23:17:13] you end up at the top of the article [23:17:26] it's race condition that only happens if you close and reopen media viewer fast enough [23:17:29] (03PS4) 10Gergő Tisza: Skip userinfo request if no message depends on the gender [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127459 [23:18:55] (03PS5) 10Gergő Tisza: Skip userinfo request if no message depends on the gender [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127459 [23:18:57] (03CR) 10Gilles: "Turns out that it's a real bug in Media Viewer, when you close and reopen the viewer really fast. The Firefox driver doesn't run the test " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127477 (owner: 10Gilles) [23:20:00] (03CR) 10jenkins-bot: [V: 04-1] Skip userinfo request if no message depends on the gender [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127459 (owner: 10Gergő Tisza) [23:29:28] (03CR) 10Gilles: "Even with a warm cache, it takes some time to pull a few kb of JS from the browser's cache and run its code." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127384 (owner: 10Gergő Tisza) [23:30:22] gi11es: ^^ two seconds, though? [23:30:30] that seems excessive [23:30:54] i haven't looked at the waterfall, didn't know it was that much [23:31:09] I have my cache disabled all the time anyway [23:31:30] i just measured the whole loadViewer() on warm cache and got 4 sec with warm cache [23:32:00] i made a card for it, i'll delve deeper once i finish fixing up all the pending commits [23:32:14] could be isCSSReady [23:32:22] which is a necessary evil [23:32:31] otherwise sizing code goes all buggy [23:33:00] yes, but it should still be below 100msIIRC [23:33:11] not if it takes a while to interpret the CSS [23:33:22] just throw a console.log in there and see if it does a few rounds of waiting [23:33:54] beyond that, the next suspect would be mw.loader.using [23:34:05] chrome has a console.time() / console.timeEnd(), pretty cool stuff [23:34:40] i'm thinking of adding it to our perf logging hour some evening [23:35:03] but yeah, i also suspect the loader [23:45:17] (03PS6) 10Gergő Tisza: Skip userinfo request if no message depends on the gender [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127459 [23:46:13] (03CR) 10jenkins-bot: [V: 04-1] Skip userinfo request if no message depends on the gender [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127459 (owner: 10Gergő Tisza) [23:46:43] (03PS7) 10Gergő Tisza: Skip userinfo request if no message depends on the gender. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/127459 [23:52:04] wow, google's "would you like to translate it" bar does really nasty things with the mediaviewer resize handler [23:52:13] chrome's bar i mean