[00:58:37] (03PS5) 10Gergő Tisza: Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 [01:01:00] (03CR) 10Gergő Tisza: "Thanks Gilles, that's a great test case! I added the tests and rounding Aaron asked for, plus tests for a few more edge cases." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [01:03:08] (03CR) 10Gergő Tisza: [C: 031] "IMO this is good to merge." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [01:03:18] (03PS4) 10Gergő Tisza: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 [01:03:20] (03CR) 10jenkins-bot: [V: 04-1] Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [01:05:49] marktraceur tgr : I tested all this sprint’s cards ready for testing that I can check on my own, and accepted them all. I will let you test the rest that are too technical for me on your end. [01:07:40] If you have time between now and tomorrow’s sprint planning, you may want to look at these two cards for estimation purposes: [01:07:41] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/460 [01:08:07] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/447 [01:08:42] I’m heading home now, shutting down IRC, but still on email if you need anything from me tonite. Cheers … [01:18:07] (03PS6) 10Gergő Tisza: Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 [01:18:09] (03PS5) 10Gergő Tisza: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 [01:18:37] (03CR) 10jenkins-bot: [V: 04-1] Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [01:19:04] (03CR) 10jenkins-bot: [V: 04-1] Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [01:19:09] (03PS7) 10Gergő Tisza: Guess thumbnail URL without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 [01:19:11] (03CR) 10jenkins-bot: [V: 04-1] Guess thumbnail URL without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [01:21:37] (03PS8) 10Gergő Tisza: Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 [01:23:23] (03CR) 10Gergő Tisza: "Not sure what the 18:19 error message was, it was based on top of the current HEAD... gerrit is getting cranky. A commit message edit solv" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [01:24:10] (03CR) 10Gergő Tisza: "Oh, we apparently keep the +1s across rebases now, cool! Maybe the error was related to that, too." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [01:58:40] (03PS6) 10Gergő Tisza: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 [01:59:37] (03CR) 10Gergő Tisza: "Added a config switch to disable guessing." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [01:59:52] (03PS7) 10Gergő Tisza: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 [02:00:24] (03CR) 10jenkins-bot: [V: 04-1] Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [02:13:00] (03PS8) 10Gergő Tisza: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 [02:22:22] (03CR) 10Gergő Tisza: [C: 031] "The tests look good (I might add a few more, but in a separate changeset, because I want to play around with Sinon); one comment could use" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [03:01:16] (03PS1) 10Gergő Tisza: [WIP] Use sinon.js mocks to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 [03:02:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use sinon.js mocks to test the thumbnail fetching [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126912 (owner: 10Gergő Tisza) [08:19:47] (03CR) 10Gilles: [C: 032] Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [08:20:33] (03Merged) 10jenkins-bot: Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [08:35:42] (03PS9) 10Gilles: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [08:38:57] (03CR) 10Gilles: [C: 032] Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [08:39:26] (03Merged) 10jenkins-bot: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [09:10:32] (03CR) 10Gilles: "Can you give me some context about what the Campaigns page is, its history and relationship with UploadWizard?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [09:40:56] (03CR) 10Dan-nl: "i’m not that familiar with the history of the Campaign namespace in regards to UploadWizard. i do know that it’s being used in conjunction" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [10:29:42] (03CR) 10Gilles: [C: 04-1] "As far as I can see the special page is defined in the Campaigns extension: https://www.mediawiki.org/wiki/Extension:Campaigns" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [10:49:55] (03PS8) 10Gilles: Test to compare the performance of MMV and the Commons File: page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 [10:50:41] (03CR) 10Gilles: [C: 032] Test to compare the performance of MMV and the Commons File: page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [10:51:11] (03Merged) 10jenkins-bot: Test to compare the performance of MMV and the Commons File: page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [14:37:16] (03CR) 10Dan-nl: "ja, that is confusing. i’m also not 100% familiar with the entire process, but i checked out the Campaign extension and it isn’t adding a " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/125913 (owner: 10Dan-nl) [16:30:45] hmmm I don't see the video chat link nor the option to add one [16:31:35] gi11es: We just saw it for Fabrice... [16:31:56] https://www.dropbox.com/s/wncrz081y0tq3a3/Screenshot%202014-04-17%2018.31.49.png [16:33:28] Inviting [17:29:59] http://ur1.ca/h3sen [17:30:28] [[File:Lunar eclipse April 15 2014 California Alfredo Garcia Jr1.jpg|100x100px||April 15 lunar eclipse|alt=The moon appeared red during the April 15 lunar eclipse.|link=File:Lunar eclipse April 15 2014 California Alfredo Garcia Jr1.jpg]] [17:30:34] that wikicode triggers the issue [17:44:57] |link= is the actual cause [17:51:47] gi11es: fabriceflorin says goodbye. [17:53:48] that's weird becazse the link part doesn't do anything useful there [17:54:19] i wonder if it is added intentionally, or someone was just lazy to add an if to the template [17:54:55] gi11es: https://en.wikipedia.org/wiki/Special:ExpandTemplates is the one which substitutes templates [17:55:44] also https://en.wikipedia.org/wiki/Main_Page?action=raw&ctype=text/css&templates=expand [17:56:02] https://en.wikipedia.org/wiki/Special:TemplateSandbox can be used to test modified templates [18:05:36] (03CR) 10Gergő Tisza: Track more user actions (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 (owner: 10Gilles) [20:10:08] Well we're out on huwiki at least [20:10:45] woo! [20:10:48] And enwv [20:22:13] tgr: Our first survey comment from the Hungarian community, from someone who finds the tool useful: Tökéletes, hol lehet letölteni, hogy ezután ezt a képmegjelenítőt használhassam? [20:23:20] that's something like 'perfect, where can i download it so i can use this one in the future?' [20:26:53] So fwiw the metrics on mw.org shot up this past week, I hope we see something similar on the other wikis [20:33:50] tgr: I just filed the ticket we discussed for the progress bar issue: #464 Make progress bar more prominent and always active — feel free to add your thoughts on how we might resolve it. I have flagged it as ‘design needed’ for Pau. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/464 [20:39:33] marktraceur: Yeah, on MediaWiki.org, we jumped from 100 image views per day to 1k/day, about a 10 x increase. And on Commons it was much higher, due to the ‘View Expanded’ button: from 240 image views per day to 24k/day yesterday — that’s a 1000 x increase ! [20:39:46] http://multimedia-metrics.wmflabs.org/dashboards/mmv [20:40:04] Well, 100x [20:40:08] But yeah, loads [20:40:35] ...that does seem like a lot though [21:17:39] (03CR) 10MarkTraceur: [C: 04-1] "Apart from Gergo's comment I think this is pretty much set to go." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125746 (owner: 10Gilles) [21:36:32] Merged units patch [21:44:31] I'm currently still seeing oojs-ui load on beta [21:44:32] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/426 [21:44:50] Or so I think [21:45:17] Yeah, it gets loaded [22:15:49] I'm accepted-ing the lazy-load patches because I don't think I can easily test them [22:15:57] But I'm convinced they're working [22:17:26] gi11es: https://wmf.ci.cloudbees.com/view/mv/ I don't see our speed comparison test? [22:19:56] Oh, hm [22:20:32] Ignore me, looks good [22:20:45] Previous sprint all accepted, 32.5 points