[00:03:55] <fabriceflorin>	 Hi tgr: I just created two new surveys for you for Catalan and Hungarian: https://www.surveymonkey.com/s/media-viewer-1-ca and https://www.surveymonkey.com/s/media-viewer-1-hu They are separate surveys, even if they look the same. Will add translations tomorrow, based on what’s up on this page: https://www.mediawiki.org/wiki/Multimedia/Media_Viewer/Survey Thanks!
[00:52:54] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Choose feedback survey based on user language [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125936 
[00:53:14] <grrrit-wm>	 (03CR) 10Gergő Tisza: Choose feedback survey based on user language (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125936 (owner: 10Gergő Tisza)
[01:29:10] <grrrit-wm>	 (03PS8) 10Gergő Tisza: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 
[01:31:41] <grrrit-wm>	 (03PS8) 10Gergő Tisza: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 
[09:40:22] <grrrit-wm>	 (03CR) 10Ricordisamoa: Slideshow Functionality (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107023 (owner: 10Apsdehal)
[09:58:49] <grrrit-wm>	 (03PS1) 10Gilles: Don't show "expand view" when Media Viewer is disabled [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126217 
[10:03:05] <gi11es>	 marktraceur: create local branch based on tag we want to backport against, cherry pick commit and solve conflicts in any, test locally, upload to gerrit, add reference to deploy calendar, be present on -dev during SWAT timeframe
[10:03:11] <gi11es>	 marktraceur: am I missing any step?
[10:08:23] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Choose feedback survey based on user language [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125936 (owner: 10Gergő Tisza)
[10:08:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Choose feedback survey based on user language [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125936 (owner: 10Gergő Tisza)
[10:19:20] <grrrit-wm>	 (03PS2) 10Gilles: Don't show "expand view" when Media Viewer is disabled [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126217 
[10:23:06] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Do not load too-big thumbnails for SVGs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125918 (owner: 10MarkTraceur)
[10:23:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do not load too-big thumbnails for SVGs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125918 (owner: 10MarkTraceur)
[10:32:28] <grrrit-wm>	 (03CR) 10Gilles: Replace current URL generation logic with routing classes (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza)
[10:40:23] <grrrit-wm>	 (03PS9) 10Gilles: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:41:19] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:41:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:43:02] <grrrit-wm>	 (03CR) 10Gilles: [V: 032] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:47:00] <grrrit-wm>	 (03CR) 10Gilles: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:47:06] <grrrit-wm>	 (03CR) 10Gilles: [C: 032 V: 032] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:47:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:49:00] <grrrit-wm>	 (03CR) 10Gilles: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:49:07] <grrrit-wm>	 (03CR) 10Gilles: [C: 032 V: 032] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:49:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:50:23] <grrrit-wm>	 (03CR) 10Gilles: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:50:33] <grrrit-wm>	 (03CR) 10Gilles: [C: 032 V: 032] Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:51:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125891 (owner: 10Gergő Tisza)
[10:51:46] <grrrit-wm>	 (03PS9) 10Gilles: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza)
[11:01:39] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza)
[11:02:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace current URL generation logic with routing classes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125932 (owner: 10Gergő Tisza)
[11:58:44] <grrrit-wm>	 (03PS1) 10Gilles: Fix bug when exiting Media Viewer while image is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126233 
[12:00:08] <grrrit-wm>	 (03PS2) 10Gilles: Fix bug when exiting Media Viewer while image is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126233 
[14:16:40] <marktraceur>	 gi11es: Seems right to me. The branch will already exist though.
[15:51:13] * marktraceur  waves

[15:51:17] <marktraceur>	 Working from home today
[17:07:52] <marktraceur>	 gi11es, anything on your mind that we need to bring up at SoS?
[17:16:23] <marktraceur>	 tgr: Do you have anything important for Scrum of Scrums?
[17:16:47] <tgr>	 marktraceur: no
[17:58:15] <fabriceflorin>	 marktraceur: Could you post the usual multimedia links on #wikimedia-office? Thanks
[17:58:40] <marktraceur>	 fabriceflorin: The what? In the topic?
[17:58:59] <marktraceur>	 I'm not sure what "usual" means, maybe you could just use /topic to set it - make sure you keep the existing topic in it though
[18:23:12] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "Merging with some comments:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles)
[18:30:36] <gi11es>	 hooray! thanks, chrismcmahon
[18:31:31] <chrismcmahon>	 sorry for the delay gi11es, I didn't realize that had slipped, and I've been all -Mobile all the time for the last 2+ weeks
[18:31:48] <chrismcmahon>	 gi11es: seems it has a path conflict though, sorry
[18:31:52] <gi11es>	 chrismcmahon: is targetting mediawiki.org something I can do myself by fiddling with cloudbees settings?
[18:32:02] <gi11es>	 chrismcmahon: I'll take care of the conflict tomorrow
[18:32:33] <chrismcmahon>	 gi11es: we can create a new build that targets mw.o for it, no reason why not
[18:33:13] <chrismcmahon>	 gi11es:  what time zone are you? 
[18:35:16] <gi11es>	 chrismcmahon: CET
[18:36:40] <chrismcmahon>	 gi11es:  great, my colleague Zeljko Filipin (zeljkof) is in Croatia, and he is the expert on Jenkins builds.  we are in the process of moving from template-based builds to jenkins-job-builder builds
[18:36:55] <gi11es>	 alright, I'll get at him tomorrow, then
[19:14:43] <fabriceflorin>	 marktraceur: Thanks for teaching me the use of /topic on IRC, much appreciated.
[19:14:51] <marktraceur>	 Yup
[19:15:06] <marktraceur>	 Didn't we have a bug link?
[19:15:59] <fabriceflorin>	 marktraceur: I owe you a bug report for images not displaying on Media Viewer on enwiki main page. Is that what you’re referring to? If so, I will work on that ticket now.
[19:16:31] <marktraceur>	 No, I mean, in the topic
[19:16:33] <marktraceur>	 For reporting bugs
[19:17:45] <fabriceflorin>	 Oh, I just copied what was there and reinserted it. But I can add a link to the discussion page or Bugzilla for bugs.
[19:17:51] <bawolff>	 when I got here the topic was
[19:17:53] <bawolff>	 Topic for #wikimedia-multimedia is “Multimedia team at the Wikimedia Foundation | Wiki page http://ur1.ca/g0xdy | Mingle http://ur1.ca/g0xdz | Logs http://ur1.ca/g0xe1 | Gerrit http://ur1.ca/fygnb”
[19:18:31] <marktraceur>	 That seems right
[19:18:38] <marktraceur>	 Missing the logs and gerrit links then
[19:18:42] <bawolff>	 Guess we should probably have the logs link. People don't like being logged without being notified
[19:18:44] <fabriceflorin>	 My apologies, I didn’t see all this on my Colloquy client. So let’s restore it.
[19:19:11] <fabriceflorin>	 Is that better?
[19:19:15] <marktraceur>	 Yeah, it's fine
[19:19:53] <fabriceflorin>	 Thanks for your understanding. IRC is not my strong suit, but I’m learning, thanks to your help :)
[19:34:33] <marktraceur>	 chrismcmahon: Hey - https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/439 looks like it needs your review, too... https://gerrit.wikimedia.org/r/125992 and https://gerrit.wikimedia.org/r/125997
[19:38:04] <chrismcmahon>	 marktraceur: gotcha
[19:39:53] <marktraceur>	 gi11es: Not applicable to the current review, but should we add parsing for YYYY:MM:DD dates ourselves?
[19:40:16] <marktraceur>	 Probably™ not upstream
[19:56:03] <tgr>	 marktraceur: who uses that?
[19:56:11] <marktraceur>	 tgr: We do, apparently
[19:56:18] <marktraceur>	 Maybe it's a bug in mediawiki though
[19:56:20] <marktraceur>	 Or CMD
[19:56:29] <tgr>	 it's a weird format
[19:56:53] <marktraceur>	 It is!
[19:57:41] <marktraceur>	 http://en.wikipedia.org/w/api.php?action=query&titles=File:Test.jpg&prop=imageinfo&iilimit=50&iiend=20071231235959&iiprop=extmetadata&format=json&iiurlwidth=1000
[19:57:49] <marktraceur>	 Hm, I didn't want an iilimit
[19:58:08] <tgr>	 not mentioned on https://en.wikipedia.org/wiki/Date_format_by_country so i'm calling it a bug
[19:58:10] <marktraceur>	 http://en.wikipedia.org/w/api.php?action=query&titles=File:Test.jpg&prop=imageinfo&iiprop=extmetadata&format=json better
[19:58:14] <marktraceur>	 Fun times
[20:00:52] <tgr>	 it's from EXIF
[20:01:28] <tgr>	 and yeah, apparently this is the standard format for EXIF
[20:01:31] <marktraceur>	 Ugh
[20:01:35] <marktraceur>	 That's terrible
[20:01:40] <bawolff>	 Exif date formats are horrible
[20:01:50] <tgr>	 i'll open a CMD bug to handle it
[20:01:57] <bawolff>	 Just look at the subsecond field
[20:03:18] <marktraceur>	 ...subsecond
[20:03:42] <marktraceur>	 Am I misguided in trying to search for "EXIF standard"?
[20:04:11] <marktraceur>	 Hahahaha
[20:04:18] <marktraceur>	 Just started cracking up in my living room reading this
[20:05:22] <bawolff>	 marktraceur: ITs a horrible document, don't read it
[20:05:48] <bawolff>	 marktraceur: Did you know the exif standard also includes an audio format in it
[20:06:00] <marktraceur>	 Hahaha
[20:06:03] <marktraceur>	 Of course it does
[20:07:44] <bawolff>	 Also things like saying - This field has two parts, the character encoding (A string of either "ASCII", "UNICODE", or "JIS") followed by a null character, followed by the actual value
[20:08:19] <bawolff>	 and then doesn't specify what type of unicode data (as best as I know, it really meant either UTF-16 or UCS-2)
[20:08:53] <marktraceur>	 Wow
[20:09:28] <marktraceur>	 (in other news I'm reviewing the moment JIT patch now)
[20:09:33] <marktraceur>	 (JIT may be a stretch)
[20:09:44] <marktraceur>	 (lazy-loading)
[20:10:47] <bawolff>	 Not as bad as the iptc-iim metadata standard, which uses the string "\x1b%G" to specify utf-8 (Because that was an escape sequence some terminal used to change character encoding)
[20:31:50] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles)
[20:32:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Load moment.js on demand [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125402 (owner: 10Gilles)
[20:38:53] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Looks fine, thanks!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126233 (owner: 10Gilles)
[20:39:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix bug when exiting Media Viewer while image is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/126233 (owner: 10Gilles)
[20:44:19] <tgr>	 gi11es, marktraceur: was https://gerrit.wikimedia.org/r/126190 deployed properly? if i understand correctly just merging a config change but not scapping it will cause problems
[20:45:35] <marktraceur>	 It should have worked
[20:45:46] <marktraceur>	 IIRC mwalker put it out in a SWAT
[20:46:06] <marktraceur>	 I can check though, if you aren't sure
[20:47:08] <marktraceur>	 Hm, I'm not seeing it on mw.org
[20:47:48] <marktraceur>	 Wait
[20:47:50] <marktraceur>	 What the
[20:48:07] <marktraceur>	 This is so not OK
[20:48:12] <marktraceur>	 So not Raven, guys
[20:48:44] <marktraceur>	 gi11es: You cannot merge things in mediawiki-config without deploying them immediately
[20:49:10] <marktraceur>	 I don't even know how you have +2 there, I thought you needed deploy rights first
[20:56:02] <tgr>	 marktraceur: fabriceflorin will update the translation in a few minutes, and then we can deploy the change fully, if that is the easiest way to make things consistent
[20:58:33] <marktraceur>	 I mean
[20:58:35] <marktraceur>	 We could
[20:58:39] <bawolff>	 marktraceur: I thought all the wmf people got in the wmf-deployment group. Isn't it tied to being able to view the profiling stats on gdash?
[20:58:43] <marktraceur>	 Or we could just push it during SWAT
[20:58:55] <marktraceur>	 bawolff: I wasn't given deploy rights for a while
[20:59:03] <fabriceflorin>	 tgr: How would you translate ‘Your feedback’ in Hungarian, as the header that appears above the survey form? We could also just have it say ‘Media Viewer’ or ‘Survey’, if you prefer.
[20:59:32] <tgr>	 'Visszajelzés' maybe
[20:59:43] <bawolff>	 marktraceur: Let me put it this way, sumanah is in the wmf-deployment group on gerrit
[21:00:14] <bawolff>	 I imagine she doesn't have actual deploy rights (I would assume)
[21:00:36] <marktraceur>	 Ah.
[21:00:43] <tgr>	 bawolff: i am not, for example
[21:00:53] <tgr>	 i don't think it is automatic
[21:01:00] <bawolff>	 tgr: Hmm, you're right
[21:01:02] <tgr>	 maybe it was at a time
[21:01:11] <bawolff>	 Maybe wmf groups are just utterly random
[21:01:26] <tgr>	 would not surprise me terribly
[21:02:30] <fabriceflorin>	 Thanks, tgr. Visszajelzés it is. Should have the Hungarian survey up in a couple minutes for your review.
[21:02:30] <bawolff>	 tgr: out of curiosity, do you get access to https://graphite.wikimedia.org/
[21:03:37] <tgr>	 yeah
[21:03:38] <bawolff>	 btw, the meeting for reducing image quality on mobile is happening now if anyone is interested (seems multimedia-esque to me)
[21:03:49] <bawolff>	 tgr: Hmm, guess its not tied to that group then
[21:04:52] <fabriceflorin>	 tgr: Could you please translate this question as well? “2. What do you think of this new viewing experience? How could it be improved?”
[21:20:14] <fabriceflorin>	 tgr: OK, let me know if this survey works for you: https://www.surveymonkey.com/s/media-viewer-1-hu
[21:22:25] <tgr>	 fabriceflorin: ' is not used in hungarian for quoting
[21:22:31] <tgr>	 maybe something like this:
[21:23:56] <tgr>	 gah
[21:24:09] <tgr>	 how do i enter unicode escape sequences on linux?
[21:24:53] <bawolff>	 tgr: ctrl+u then a plus sign then the code point
[21:25:09] <tgr>	 Szeretnénk hallani a véleményedet a képmegjelenítő funkcióról, amit most használsz („Képnézegető”)
[21:25:28] <tgr>	 bawolff: thx
[21:25:53] <tgr>	 fabriceflorin: or just link the "képmegjelenítő funkcióról" part
[21:26:25] <tgr>	 the hungarian name for the extension is fairly silly, MediaViewer does not translate well
[21:26:47] <fabriceflorin>	 tgr: Thanks. Will have this updated shortly. Learning new languages is fun!
[21:27:21] <tgr>	 (personally i think the world would be better off if the word 'media' was banned)
[21:31:29] <bawolff>	 "Viewer thingy"
[21:36:24] <fabriceflorin>	 Yeah, we use the word ‘media’ way too often — and we have so many similar brand names that they are hard to tell apart (Wikimedia, MediaWiki, Wikipedia, Wikimania). I alway get them confused for a few milliseconds, which shouldn’t be happening. But good product names are really hard, because most names have already been taken. So for now, we’ll have to live with what we have. 
[21:38:18] <fabriceflorin>	 tgr: One last question for you. Can you please translate ‘Submit’, ‘Done’ and ‘Previous’ for me?
[21:39:06] <tgr>	 Küldés, Kész, Előző
[21:39:44] <fabriceflorin>	 tgr: Köszönjük!
[21:40:00] <fabriceflorin>	 tgr: Hálás köszönet.
[21:41:00] <tgr>	 fabriceflorin: wow, you are getting good at it :)
[21:41:06] * marktraceur  looks forward to helping with angwiki

[21:41:19] <marktraceur>	 ...except not actually
[21:41:30] <fabriceflorin>	 tgr: I am lucky to have a great coach :)
[21:45:32] <fabriceflorin>	 OK, here’s a second pass at the Hungarian survey for your review: https://www.surveymonkey.com/s/media-viewer-1-hu
[21:46:11] <fabriceflorin>	 And I will ask quim to review the Catalan survey now:
[21:46:13] <fabriceflorin>	 ere’s a second pass at the Hungarian survey for your review: https://www.surveymonkey.com/s/media-viewer-1-hu
[21:46:37] <fabriceflorin>	 Sorry, here’s the Catalan survey link: https://www.surveymonkey.com/s/media-viewer-1-ca
[21:49:12] <tgr>	 thx fabriceflorin 
[21:49:40] <tgr>	 i guess we can enable this in the SWAT deploy coming up in an hour then?
[21:50:03] <marktraceur>	 ...can, yes.
[21:50:19] <tgr>	 i'll add it to the schedule
[21:50:37] <marktraceur>	 tgr: You can make me the on-call person if you'd like
[21:51:24] <tgr>	 well, it's about time for me to learn this
[21:51:40] <tgr>	 not that i have to actually do anything
[21:53:37] <marktraceur>	 True
[21:53:45] <marktraceur>	 tgr: I will write an email about training now.
[21:54:41] <fabriceflorin>	 marktraceur: angwiki? Is that an old english wiki? It would be fun to survey people from the past about this new tool :) https://ang.wikipedia.org/wiki/H%C4%93afodtramet
[21:55:02] <tgr>	 btw, how do you check whether the config change was deployed?
[21:55:36] <marktraceur>	 I think it's middle english.
[21:55:59] <marktraceur>	 Oh, you're right, old english.
[21:56:04] <marktraceur>	 Middle is enm.
[21:56:21] <marktraceur>	 (which doesn't have a wikipedia but is included in our i18n)
[21:57:09] <marktraceur>	 Or...I thought it was
[22:00:25] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Choose feedback survey based on user language [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126852 
[22:10:16] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Fix E2E scroll assertion logic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125992 (owner: 10Gilles)
[22:10:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix E2E scroll assertion logic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125992 (owner: 10Gilles)
[22:15:31] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Add history back button test to E2E [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125997 (owner: 10Gilles)
[22:16:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add history back button test to E2E [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125997 (owner: 10Gilles)
[23:02:42] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Choose feedback survey based on user language [extensions/MultimediaViewer] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126852 (owner: 10Gergő Tisza)
[23:41:17] * marktraceur  updating data with the new scripts to see what happens