[00:00:21] tgr: Did we lose the locally hosted commons icon in the "more prominent link" patch? [00:00:28] I'm seeing a blurry favicon instead [00:01:21] Hm, maybe I'm dreaming [00:01:25] Ignore me! [00:02:17] (03CR) 10MarkTraceur: [C: 032] "Seems AOK :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124769 (owner: 10Gergő Tisza) [00:02:47] (03Merged) 10jenkins-bot: Make Commons link more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124769 (owner: 10Gergő Tisza) [00:06:56] (03PS10) 10MarkTraceur: Selects html embed by default for logged-out users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121064 (owner: 10Gilles) [00:07:09] Trying to rebase, it looks like gi11es got hit by the qunit issues recently [00:09:49] (03CR) 10MarkTraceur: [C: 032] "Seems good." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121064 (owner: 10Gilles) [00:10:25] (03Merged) 10jenkins-bot: Selects html embed by default for logged-out users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121064 (owner: 10Gilles) [00:11:56] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/379 there's one point not addressed at all; should we postpone it or at least stick it in a more different card so it's not sitting there in CR just because of one point? [00:14:21] one of those, yes [00:14:45] i think Pau asked for this at some point, don't know if it is still needed / what for exactly [00:18:52] Especially given it's "figure out..." I'm inclined to shunt it off, say design needed, postpone it. [00:18:58] s/postpone/unschedule/ [00:19:40] it is the technical means that needs to be figured out [00:19:51] but yeah, nice to have category, i'll split it [00:20:09] Not sure if it'd be that hard...CSS should be the only thing required [00:20:14] Ta though [00:20:25] While you're doing that I'm going to make it be in testing [00:20:46] probably... Pau said he tried that and failed, might have looked at the wrong class or something i guess [00:21:56] (03CR) 10Aarcos: Selects html embed by default for logged-out users (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121064 (owner: 10Gilles) [00:23:16] wow [00:23:28] looks like we will hit 30 points this week [00:23:33] Heh [00:23:42] Good thing after two weeks of like 7 [00:23:51] Oh, 15 last week [00:24:14] 5.5 the week prior [00:26:58] * marktraceur created https://wikimedia.mingle.thoughtworks.com/projects/scrum_of_scrums/cards/101 a day too late [00:37:19] (03PS3) 10MarkTraceur: Fix z-index bug in Firefox that would make navigation buttons appear on top of the metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123838 (owner: 10Gilles) [00:37:29] (03CR) 10MarkTraceur: "Basically trivial rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123838 (owner: 10Gilles) [00:38:27] (03CR) 10MarkTraceur: [C: 032] "Excellent stuff, thanks." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123838 (owner: 10Gilles) [00:38:56] (03Merged) 10jenkins-bot: Fix z-index bug in Firefox that would make navigation buttons appear on top of the metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123838 (owner: 10Gilles) [00:39:06] Cod review... [00:52:47] (03CR) 10Aarcos: "I tested this change and it doesn't work for me. When I go from a small image to a bigger one the menus are broken and the message "Loadin" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121064 (owner: 10Gilles) [01:09:45] tgr aaron_arcos gi11es : Hi guys, I just filed this bug which I think we should try to fix for tomorrow’s launch, if it’s possible: #423 - Shared and Embed links don't open images in Media Viewer. I can reproduce this issue for all files I tested on beta, using their share or embed links display a black screen in Media Viewer. I think that’s a serious issue, which people will call us on right away, since it makes Share and Embed [01:09:45] unusable. How hard do we think it would be to fix it? https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/423 [01:10:09] (03PS1) 10Gergő Tisza: Fix tipsy bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125056 [01:12:30] (03CR) 10Aarcos: [C: 032] Fix tipsy bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125056 (owner: 10Gergő Tisza) [01:13:37] (03Merged) 10jenkins-bot: Fix tipsy bug [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125056 (owner: 10Gergő Tisza) [01:41:20] (03CR) 10Gergő Tisza: "Fixed jshint + rebase conflicts (trivial changes only)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124750 (owner: 10MarkTraceur) [01:43:56] (03CR) 10Gergő Tisza: [C: 031] "LGTM. Leaving up for a second set of eyeballs since we are so close to deploy." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124750 (owner: 10MarkTraceur) [02:12:05] (03PS3) 10Gergő Tisza: [WIP] Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 [02:12:07] (03PS1) 10Gergő Tisza: Shuffle things around so original file sizes are easier to access [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125066 [02:12:09] (03PS1) 10Gergő Tisza: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 [02:12:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [02:13:49] (03CR) 10jenkins-bot: [V: 04-1] Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [06:40:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124750 (owner: 10MarkTraceur) [06:45:50] (03CR) 10Siebrand: Make Commons link more prominent (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124769 (owner: 10Gergő Tisza) [06:46:32] (03CR) 10Siebrand: Make Commons link more prominent (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124769 (owner: 10Gergő Tisza) [06:51:24] (03CR) 10Gilles: [C: 032] Workaround for OOJS ES3 incompatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124365 (owner: 10Gergő Tisza) [06:51:56] (03Merged) 10jenkins-bot: Workaround for OOJS ES3 incompatibility [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124365 (owner: 10Gergő Tisza) [07:00:10] (03CR) 10Gilles: "It probably broke due to the OOJS update, it was working on the previous version. I'll look into it" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121064 (owner: 10Gilles) [07:12:47] (03CR) 10Gilles: [C: 032] Shuffle things around so original file sizes are easier to access [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125066 (owner: 10Gergő Tisza) [07:13:53] (03Merged) 10jenkins-bot: Shuffle things around so original file sizes are easier to access [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125066 (owner: 10Gergő Tisza) [07:15:03] (03PS1) 10Gilles: Fix spacing in i18n files [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125077 [07:15:11] (03CR) 10Gilles: "https://gerrit.wikimedia.org/r/125077" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124769 (owner: 10Gergő Tisza) [07:15:33] (03CR) 10jenkins-bot: [V: 04-1] Fix spacing in i18n files [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125077 (owner: 10Gilles) [07:17:45] (03PS12) 10Gilles: Open MMV on hash change on file pages, add link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124750 (owner: 10MarkTraceur) [07:18:16] (03CR) 10jenkins-bot: [V: 04-1] Open MMV on hash change on file pages, add link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124750 (owner: 10MarkTraceur) [07:18:18] (03CR) 10Gilles: Open MMV on hash change on file pages, add link (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124750 (owner: 10MarkTraceur) [07:34:10] (03PS13) 10Gilles: Open MMV on hash change on file pages, add link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124750 (owner: 10MarkTraceur) [07:36:20] (03CR) 10Gilles: [C: 032] Open MMV on hash change on file pages, add link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124750 (owner: 10MarkTraceur) [07:36:57] (03Merged) 10jenkins-bot: Open MMV on hash change on file pages, add link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124750 (owner: 10MarkTraceur) [07:59:40] (03PS1) 10Gilles: Fix overlap of info box and right sidebar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125098 [08:14:31] (03CR) 10Siebrand: [C: 032 V: 032] "Thanks, Gilles. Ignoring Jenkins here. It's not having its day." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125077 (owner: 10Gilles) [08:14:33] (03CR) 10jenkins-bot: [V: 04-1] Fix spacing in i18n files [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125077 (owner: 10Gilles) [08:18:23] (03CR) 10Siebrand: [C: 04-1] "Hmm, this has a merge conflict, apparently." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125077 (owner: 10Gilles) [08:20:30] (03Abandoned) 10Gilles: Fix spacing in i18n files [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125077 (owner: 10Gilles) [09:57:36] (03PS1) 10Pginer: Removed white background from SVG assets Two images contained a white background that was limiting their use over other background colours. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125118 [09:58:11] (03CR) 10jenkins-bot: [V: 04-1] Removed white background from SVG assets Two images contained a white background that was limiting their use over other background colours. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125118 (owner: 10Pginer) [11:06:31] (03CR) 10Gilles: [C: 032 V: 032] Removed white background from SVG assets Two images contained a white background that was limiting their use over other background colours. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125118 (owner: 10Pginer) [11:10:20] (03Merged) 10jenkins-bot: Removed white background from SVG assets Two images contained a white background that was limiting their use over other background colours. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125118 (owner: 10Pginer) [11:20:50] (03PS1) 10Gilles: Fix commons icon to avoid pixelation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125168 [12:13:00] (03CR) 10Gilles: [C: 032] Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [12:13:46] (03Merged) 10jenkins-bot: Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [12:14:37] (03CR) 10Gilles: "This can probably be abandoned, since this got merged: https://gerrit.wikimedia.org/r/#/c/121309/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115849 (owner: 10Gergő Tisza) [12:33:22] (03PS3) 10Gilles: Split button line adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [12:35:20] (03PS4) 10Gilles: Split button line adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [12:36:22] (03CR) 10jenkins-bot: [V: 04-1] Split button line adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [12:37:06] (03CR) 10Gilles: [C: 032 V: 032] Split button line adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [12:39:28] (03CR) 10jenkins-bot: [V: 04-1] Split button line adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [12:57:43] (03CR) 10Gilles: Split button line adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [12:57:51] (03CR) 10Gilles: [C: 032 V: 032] Split button line adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [12:58:31] (03Merged) 10jenkins-bot: Split button line adjustment [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [14:11:24] (03PS4) 10Gilles: Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [14:12:12] (03CR) 10Gilles: [C: 031] Guess thumbnail URLs without extra API call [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [14:14:15] (03PS2) 10Gilles: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [14:57:05] (03PS3) 10Gilles: Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [14:58:07] (03CR) 10Gilles: [C: 031] Use thumbnail guessing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125067 (owner: 10Gergő Tisza) [15:03:28] marktraceur: is the SWAT happening now when the backport of gergo's bugfix to commons should happen? [15:03:56] Uh [15:03:58] or will that go out with the regular deploy later on? [15:04:07] It should go out in the later SWAT [15:04:20] Or you could poke them now if you wanted [15:04:38] I have no idea how that stuff works, haven't done any backport commit [15:04:59] The SWAT folks will sort it out [15:44:27] gi11es: Did you get it in? [15:53:03] marktraceur: no, I had to be afk for a while [15:53:32] Ah. [15:54:09] what's the process? just asking in -operations? [15:54:23] gi11es: Too late now, SWAT is over [15:54:27] ok [15:54:33] We'll just have Reedy do it during the MW deploy window, I guess [15:54:59] frankly, reading the backlog of the channel, I don't follow where it starts, ends, and how people ask for stuff [15:55:03] gi11es: In general, put it on the deployments page and poke the SWAT folks until they do your bidding [15:55:27] Because you don't just pop in and say "PLZ CAN BE DEPLOYINK CHANGE NOW" [15:55:30] https://wikitech.wikimedia.org/wiki/Deployments [15:55:47] Oh, actually there are five minutes left [15:55:52] But too little time [16:01:10] gi11es: Do you want me to shepherd the cherry-pick? [16:01:19] marktraceur: sure [16:02:07] (03PS1) 10MarkTraceur: Quick fix for black screen of death [extensions/MultimediaViewer] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125213 [16:03:22] 'kay, added to deployments calendar [16:17:25] tgr: I've added a battery of tests to your 2 thumbnail guessing changesets [16:17:31] they're good to go, as far as I'm concerned [16:17:55] Argh, code splitting [16:18:49] i overslept, will be ~15 min late from the meeting, don't wait for me [16:21:52] ...Argentina [16:21:55] tgr: Ack [16:30:07] (03CR) 10Aarcos: [C: 032] Fix overlap of info box and right sidebar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125098 (owner: 10Gilles) [16:31:30] (03CR) 10jenkins-bot: [V: 04-1] Fix overlap of info box and right sidebar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125098 (owner: 10Gilles) [16:31:59] (03CR) 10Gilles: [C: 032 V: 032] "Damn you, jenkins" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125098 (owner: 10Gilles) [16:32:29] (03Merged) 10jenkins-bot: Fix overlap of info box and right sidebar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125098 (owner: 10Gilles) [16:33:45] aaron_arcos: while you're at it, here's another small one: https://gerrit.wikimedia.org/r/#/c/125168/ [17:42:34] (03PS2) 10Robmoen: Create base UI module. [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 [17:44:53] (03PS3) 10Robmoen: Create base UI module. [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 [17:45:53] (03CR) 10Robmoen: [C: 04-1] "Still WIP. Loads more to do. UW is mostly working inside OO Dialog. :)" [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen) [18:11:58] (03CR) 10Aarcos: [C: 032] Fix commons icon to avoid pixelation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125168 (owner: 10Gilles) [18:12:35] (03Merged) 10jenkins-bot: Fix commons icon to avoid pixelation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125168 (owner: 10Gilles) [18:13:19] u88 [18:13:52] sorry for the stray characters, not meant for public use :) [18:15:13] * marktraceur kicks fabriceflorin for the atrocity of three accidental characters, how dare you really [18:15:26] hehe [18:15:46] didn’t want you guys to be confused :) [18:16:38] FYI, I’m updating the Mingle site now, changing project variables so the current sprint is this new one that starts today. [18:17:39] Oh someone did that already. Never mind. [18:30:46] (03CR) 10Reedy: [C: 032] Quick fix for black screen of death [extensions/MultimediaViewer] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125213 (owner: 10MarkTraceur) [18:31:19] (03Merged) 10jenkins-bot: Quick fix for black screen of death [extensions/MultimediaViewer] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/125213 (owner: 10MarkTraceur) [18:34:08] Backport was synced [18:34:52] Wonderful. Does that also include the fix for showing files on Commons in Media Viewer using the share/embed links? [18:35:20] No, just doesn't have black screen of death anymore [18:35:20] Well [18:35:26] It still flashes the black screen of death [18:36:49] OK, let me know if you need any testing — also, let’s confirm with Reedy about the patch to Commons, so it comes out about the same time Media Viewer is released to Media Viewer by default. [18:37:02] It's already *on* commons. [18:37:36] yeah, flashing cannot be avoided [18:37:55] since we black things out before MMV is even loaded [18:46:33] We're pushed to mw.org but it looks like there's a caching issue [18:47:39] And we are *out* [18:47:41] fabriceflorin: ^^ [18:48:14] tgr: Feedback isn't enabled [18:48:41] should it? [18:48:47] On mw.org? Think so [18:48:51] For all pilots, I thought [18:48:58] But maybe I misread the config patch [18:49:03] Or dreamt about it only [18:49:22] i thought we would handle that manually [18:49:46] Oh, sure [18:49:53] fabriceflorin: Should feedback be enabled on mw.org? [18:50:03] hm, yeah, apparently it should [18:50:05] tgr: Separately I'm seeing "background-image: url('undefined');" for the stripebutton that is the Commons link [18:50:12] Which is silly [18:50:24] mark: yes, please [18:50:30] but we still need to handle it manually since it needs to be disabled after 30 days [18:50:43] at least that's wwhat the spec says [18:51:04] i'll check the url issue [18:58:37] seems to be a site config issue, the favicon is missing from the repoinfo API response [18:58:48] there should have been a fallback, of course [18:58:52] i'll fix that [18:59:35] tgr: I'll write a config change for mw.org so we can SWAT at it later in the day [19:05:37] I'm not sure of "exapnd view" (multimediaviewer-view-expanded) is the best phrasing for the open mediaviewer link on file page - The media file is already "expanded" since you're on the image page [19:06:04] fabriceflorin: ^^ [19:07:24] bawolff: Thanks for your feedback. We will pass it on to Pau, along with other comments from users. Though I would argue that in most cases, the image will appear to be larger in Media Viewer, which would make the user think it is expanded. [19:07:57] I guess it depends on your monitor size [19:10:30] fabriceflorin: For me, the expasion is from 800 pixels, to 833 pixels, which is small enough you don't even know if it actually expanded [19:10:46] (03PS1) 10Gergő Tisza: Show a fallback repo icon for the "go to file page" button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125262 [19:10:47] for todays fp [19:11:43] marktraceur: ^^ [19:13:18] tgr: Critical enough to go out in SWAT today, you think? [19:13:41] the bug is critical, i think [19:14:06] but either this or a site config patch fixes it, no need for both to go out [19:57:44] tgr: Your call [19:58:30] if we do have the site config patch, that would be the nicer way, since that shows the mw.org logo, this one would just show a fallback [19:58:52] Righty-o [19:59:14] tgr: "If we do have..." I assume means "If Mark writes..." [20:00:16] i can write it if you prefer [20:00:37] That would work or I could [20:00:42] Either way is fine [20:00:58] ok, i'll do [20:01:04] by when? [20:01:10] 16:00 is the SWAT [20:01:36] I will also merge this fallback thing but it will go out normally [20:09:01] (03CR) 10MarkTraceur: [C: 032] "Seems fine, thanks :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125262 (owner: 10Gergő Tisza) [20:09:38] (03Merged) 10jenkins-bot: Show a fallback repo icon for the "go to file page" button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125262 (owner: 10Gergő Tisza) [20:56:05] fabriceflorin: James_F talked me into reviewing legoktm's patch that adds notifications of new features, so that will go in soon. [20:59:59] marktraceur: That sounds very encouraging. Is the code solid? Do you know which parts of the proposed spec was implemented by Lego? https://www.mediawiki.org/wiki/Beta_Features/Roadmap#Echo_notifications [21:00:23] Uhh [21:00:52] fabriceflorin: Only "new feature available" [21:03:37] OK, thanks for the clarification. Does the code seem good to you? If so, is it the case that ‘New feature available’ notification could be available to us soon? [21:03:52] It seems OK but for an l10n issue [21:04:53] marktraceur: Got it. Does it include anchors for links? yellow highlights to confirm which notification to look at? [21:05:43] It doesn't include section anchors, nor highlights [21:05:47] Just the notification [21:09:46] marktraceur: Thanks for the heads-up. I added a note in both of our cards about this project. From your standpoint, how much more work be needed on our end to deliver the features described here: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/425 [21:11:07] Hm [21:11:16] I misunderstood 425, but I'd still call it a week of work [21:11:34] fabriceflorin: I thought there was something there about notifying people about features that were *about* to graduate [21:13:43] The initial thought was to let folks know that a new feature is available for testing and invite them to try it out. We may have later uses for a reminder that a feature is about to graduate, but let me discuss all this with Howie, then Pau and others. The one-week guess is helpful, thanks. [21:16:46] marktraceur: If we also wanted to develop a second notification that a feature is about to graduate, how much more work are we looking at? Also, would you still need to develop a framework and maintenance script, as outlined in this complementary card? https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/432 [21:17:41] The graduation notification would still be 'round about a week, I think. Maybe as few as 3 days but I don't want to be too optimistic [21:21:25] OK, and do we still need to add a framework and maintenance script to BetaFeature, or did Legokm just do that? [21:22:22] Well [21:22:29] He started it by adding the first notification type [21:22:34] But it could still be built out a bit more [21:26:50] (03CR) 10Aarcos: [C: 04-1] "Looks pretty good, thanks for the thorough testing. Still have some testing suggestions, ;-)." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124796 (owner: 10Gergő Tisza) [21:37:37] marktraceur: OK, I’ll stick to the preliminary 2-week estimate, which I already mentionned along with the overall team response to this idea. Will discuss with Howie at our 1:1 today and see how far he wants to push on this. [21:58:23] (03PS4) 10Robmoen: Create base UI module. [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 [21:58:39] (03CR) 10Robmoen: [C: 04-1] "WIP" [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen) [21:58:41] tgr: I can still write that config patch if you need me to [22:01:48] marktraceur: https://gerrit.wikimedia.org/r/#/c/125335/ [22:01:59] Aha [22:09:50] e2e tests falling due to changes in https://gerrit.wikimedia.org/r/#/c/121309, asked marktraceur to take a look [22:32:44] mediaviewer is badly broken on enwiki, created some cards [22:33:23] Wuh oh [22:33:50] only on enwiki though, other wikipedias seem to work [22:58:44] (03PS1) 10MarkTraceur: Miscellaneous fixes to truncatable text fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 [22:59:17] (03CR) 10jenkins-bot: [V: 04-1] Miscellaneous fixes to truncatable text fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [22:59:32] Oh FFS [23:01:47] (03PS2) 10MarkTraceur: Miscellaneous fixes to truncatable text fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 [23:02:33] (03CR) 10jenkins-bot: [V: 04-1] Miscellaneous fixes to truncatable text fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 (owner: 10MarkTraceur) [23:03:49] (03PS3) 10MarkTraceur: Miscellaneous fixes to truncatable text fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/125342 [23:03:52] Bit schizophrenic there [23:09:46] tgr: I'm watching https://www.mediawiki.org/w/api.php?action=query&format=jsonfm&meta=filerepoinfo but no dice yet [23:11:56] marktraceur: maybe it is cached? [23:12:03] We're investigating in -operations [23:12:15] Caching doesn't seem to be the case [23:12:52] i have no clue how to test foreigndbrepo setups locally, unfortunately :( [23:12:59] Hyup [23:13:03] so it might have a typo or wjatever [23:13:04] That's the perpetual issue [23:18:26] https://www.mediawiki.org/wiki/Greeters#mediaviewer/File:Pair%20of%20Merops%20apiaster%20feeding.jpg looks marginally less bad now [23:18:59] when's the next SWAT slot by the way? [23:19:30] Monday, 08:00 PDT [23:20:01] apparently we are missing some strings in wmf21 [23:20:39] Oh? [23:20:52] although the very weird thing is that the error only happens on enwiki [23:21:38] That doesn't seem that weird [23:21:41] What's the issue? [23:21:48] yeah, on second thought it doesn't [23:22:09] some stuff from the download tab was not added to the json [23:22:23] I, um...I see it just fine [23:22:23] and i suppose non-english wikis get it via localizationupdate [23:22:37] not added in wmf21 i mean [23:23:04] Ah. [23:23:05] Wait [23:23:08] No, I see it on enwiki [23:23:14] multimediaviewer-download-tab for example [23:23:25] Unless it's a string I'm not seeing in this interface...yeah, I see that as "Download" without issue [23:25:24] screenshot here: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/438 [23:26:08] tgr: No screenshot, only link to page where I can see it working just fine [23:26:34] Oh, attachment [23:26:49] See, I saw that happen last Thursday on mw.org [23:26:52] But it got fixed somehow [23:54:07] fabriceflorin: FYI [23:54:18] fabriceflorin: There's a bug on enwiki right now [23:54:27] Logged out users will not see the download tab's text properly [23:54:37] They'll see something ugly like [23:54:53] fabriceflorin: My instinct is to live with this because logged-out users can't really get to the viewer easily anyway [23:55:05] The other option AFAIK is to revert MMV to an earlier version until Monday [23:55:20] But that seems unwarranted [23:55:26] i can still see this logged in [23:55:28] marktraceur: Hmm. That’s pretty ugly. How did it happen? [23:55:40] fabriceflorin: Still not sure, seems to be an issue with l10n cache but it's not clear [23:55:41] revert to 1.23wmf20? [23:55:47] that sounds more scary [23:55:48] ish [23:55:49] Yeah. [23:55:52] I am less concerned about enwiki now, because it’s still Beta. [23:55:59] Basically my opinion is that, yes. [23:56:08] So my initial reaction is not to revert and live with it. [23:56:14] anyway, not deeply convinced this has anything at all to do with the code [23:56:20] greg-g: ^^ [23:56:26] There's always the option of convincing a friendly enwiki admin to just create the message, if its a temporary issue [23:56:45] Are we sure this would be fixed on Enwiki on Monday? I thought that wouldn’t be until Thursday? Would you run a SWAT? [23:56:48] bawolff: Not sure that would help...AFAICT we have the message, just the l10n cache is messed up [23:56:53] basically it seems the messages which have been added last week did not get into the message cache [23:56:55] fabriceflorin: Yeah, we'd fix it ASAP [23:57:04] Your sure its not resource loader cache? [23:57:05] * greg-g nods [23:57:17] thanks fabriceflorin, we can let this ride until next week [23:57:24] And I guess we can’t run a SWAT now in enwiki? [23:57:28] if its not in l10n cache, it would probably appear no where [23:57:41] We *are* running a SWAT now [23:57:44] That's the issue [23:57:45] bawolff: you are probably right [23:57:45] I will hold off on starting the enwiki discussion until this is fixed, then. [23:57:47] But it ends in 3 minutes [23:57:52] the MediaWiki: page works [23:58:05] tgr: Maybe the module doesn't load the message? [23:58:13] greg-g: can’t we extend the SWAT a bit longer today to let us fix the enwiki problem? [23:58:17] No. [23:58:35] worked for me when i checked out 1.23wmf21 locally [23:58:49] There's no reason to deviate from the deployment schedule [23:59:07] We just decided it isn't that critical anyway [23:59:16] also, the whole lightbox is completely broken sometimes [23:59:26] which might or might not be related [23:59:46] It appears the problem is more than just the download button. The entire metadata panel seems to be missing for me.