[00:04:18] (03PS7) 10Gergő Tisza: Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 [00:06:15] (03PS7) 10Gergő Tisza: Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 [00:07:04] (03PS8) 10Gergő Tisza: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 [00:10:55] (03PS9) 10Gergő Tisza: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 [00:30:27] (03CR) 10Gergő Tisza: Split button line adjustment (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123609 (owner: 10Pginer) [00:33:33] it's a little sad that in the ~2 weeks it has been running, our Selenium test didn't even get to the point of logging in successfully [00:34:33] -.- [00:35:14] we had four different kinds of alerts by now, i think, network error, too many connections, timeout, whatever [00:35:52] but it never got to the point where it could actually begin the MediaViewer test [00:56:00] (03CR) 10Gergő Tisza: [C: 032] "My public IP changes a lot; I did try tunneling through Runscope but that didn't work either. Anyway, this patch is simple enough, so I'm " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122422 (owner: 10Gilles) [00:58:17] (03Merged) 10jenkins-bot: Disable IE < 9 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122422 (owner: 10Gilles) [01:07:13] (03PS1) 10Robmoen: Create base UI module. [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 [01:08:12] (03CR) 10Robmoen: [C: 04-1] "WIP" [extensions/UploadWizard] (oojsify) - 10https://gerrit.wikimedia.org/r/123818 (owner: 10Robmoen) [01:36:24] (03PS1) 10Gergő Tisza: Make sure the download attribute has no value [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123819 [01:48:25] marktraceur: can you review ^^? a trivial change and i'm too lazy to create a card for it [01:52:35] (03CR) 10MarkTraceur: [C: 032] "Ew." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123819 (owner: 10Gergő Tisza) [01:53:05] (03Merged) 10jenkins-bot: Make sure the download attribute has no value [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123819 (owner: 10Gergő Tisza) [06:09:02] (03CR) 10Gilles: [C: 032] Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [06:09:36] (03Merged) 10jenkins-bot: Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [06:14:43] (03CR) 10Gilles: [C: 032] Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [06:15:15] (03Merged) 10jenkins-bot: Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [06:25:06] marktraceur: I thought you caught that during the scrum of scrums call? there is actually some great news about the thumbnail pregeneration. they've received the hard drives for swift and they plan on installing them when they come back from their greece meetup [06:25:57] unless I misunderstood something, it seems that 2-3 weeks from now, maybe a bit more, they'll have the capacity to let us pregenerate thumbs [06:26:18] gi11es: I meant specifically the list of sizes [06:26:51] we haven't discussed figures, but last time I talked to faidon he didn't seem to care about which buckets we pregenerate [06:26:59] 'kay, good [06:27:05] we'll just do the math once we know exactly how much capacity we're playing with [06:27:43] if we're constrained we can at least generate the bucket size that corresponds to the average/most common screen resolution [06:28:00] tgr: are you talking about the performance cucumber test? [06:28:28] am i talking about what where? [06:28:37] oh [06:28:47] selenium test not logging in [06:28:58] no, i think that was aaron's first e2e test [06:29:35] haven't really looked at it, i'm just getting the alert every day and it is always some framework-level error [06:29:39] right [06:29:39] that's been a series of issues on QA's end [06:30:16] it's worked most of the time [06:30:33] the weakness comes from the steps we share with QA, that they wrote, to log you in [06:30:39] that's the part that broke several times [06:30:56] now that we support mmv logged out, though, we can probably get rid of that step [06:31:03] well, the test runs twice a day iirc, and i am pretty sure i got at least one errorr message per day [06:31:16] yeah, it was always the login part [06:32:09] I'll see if I can get rid of the login step for the e2e test [06:32:41] better acceptance test coverage is also something that would be good to have by the time we launch, by the way [06:33:03] although if the false positive ratio stays like this, maybe not... [06:34:30] (03PS9) 10Gilles: Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [06:35:31] (03CR) 10Gilles: [C: 032] Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [06:36:00] (03Merged) 10jenkins-bot: Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [06:43:24] (03CR) 10Gilles: [C: 032] Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [06:43:27] (03CR) 10jenkins-bot: [V: 04-1] Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [06:46:16] (03PS8) 10Gilles: Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [06:47:00] (03CR) 10Gilles: [C: 032] Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [06:47:30] (03Merged) 10jenkins-bot: Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [06:48:40] marktraceur: "use this file" is still broken by oojs ui, albeit slightly differently. are they still working on fixing it? [06:48:57] gi11es: No, I am...sort of [06:49:01] I can push a WIP patch [06:49:32] what happened? have they tossed the hot potato back to us saying that we weren't using those ui elements the way they're supposed to? [06:49:38] Sort of [06:49:47] gi11es: There's something messy with select events [06:51:33] (03PS1) 10MarkTraceur: WIP fix share tabs' select events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123833 [06:52:04] (03CR) 10jenkins-bot: [V: 04-1] WIP fix share tabs' select events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123833 (owner: 10MarkTraceur) [06:52:33] (03PS8) 10Gilles: Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 (owner: 10Gergő Tisza) [06:53:43] (03CR) 10Gilles: [C: 032] Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 (owner: 10Gergő Tisza) [06:54:12] (03Merged) 10jenkins-bot: Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 (owner: 10Gergő Tisza) [06:56:57] (03PS8) 10Gilles: Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [06:57:44] (03CR) 10Gilles: [C: 032] Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [06:58:15] (03Merged) 10jenkins-bot: Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [07:12:19] (03PS10) 10Gilles: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [07:13:02] (03CR) 10Gilles: [C: 032] Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [07:13:34] (03Merged) 10jenkins-bot: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [07:52:57] (03PS5) 10Gilles: Test to compare the performance of MMV and the Commons File: page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 [07:53:38] marktraceur: tgr: I've just noticed that changes as old as march 31st haven't been deployed to mediawiki.org [07:53:48] did something go wrong with yesterday's deploy? [07:54:56] not that i know of [07:55:34] how can we check at which commit it's at? [07:55:41] most changes have been deployed, i have seen the download tab there, for example, and that was merged yesterday [07:57:04] it's 95111d2b7341cc19e2da113a76181e93b56ff948 I'm not seeing [07:57:12] the classes are still mlb-* [07:57:23] and I'm not seeing the download tab [07:57:34] well, you can pull the 1.23wmf20 branch, then check with git branch --contains [07:57:49] that tells you whether it got into the deploy branch [07:58:05] by what magic can you see the download tab on mediawiki.org and I can't? [07:58:40] whether it actually got deployed is trickier, you can check the core version in the Special:Version page of mediawiki.org, i don't think there is a way to check for extensions though [07:59:52] hm, i don't see it now either [08:00:15] mediawiki.org is on 1.23wmf20 [08:00:19] should be 1.23wmf21 [08:01:04] rolled back, apparently [08:01:20] ah, yes, just saw that [08:01:21] i see now its mentioned in the "Localisation not working on MediaWiki.org" thread on Engineering [08:01:29] yep [08:01:32] makes sense [09:34:08] (03PS1) 10Gilles: Fix z-index bug in Firefox that would make navigation buttons appear on top of the metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123838 [18:35:59] (03CR) 10Gergő Tisza: [C: 031 V: 031] "Tested in Chrome, works fine." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123838 (owner: 10Gilles) [19:04:24] (03PS1) 10Gergő Tisza: Show a tooltip for the repo link button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123899 [19:58:48] (03PS1) 10Gergő Tisza: Add site/language conditions for feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123917 [22:03:04] (03PS1) 10Gergő Tisza: Rename setRepoInlineStyle to setInlineStyle [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124018 [22:08:51] (03PS1) 10Gergő Tisza: Hide buttons while loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124020 [23:10:07] (03PS1) 10Gergő Tisza: Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 [23:10:42] (03CR) 10jenkins-bot: [V: 04-1] Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 (owner: 10Gergő Tisza) [23:17:32] (03PS2) 10Gergő Tisza: Show tooltip when all sorts of conditions are met [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/124032 [23:23:29] (03CR) 10Gergő Tisza: [C: 032] Improving zoom of embedded map, on address search [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/118978 (owner: 10Inchikutty) [23:23:42] (03Merged) 10jenkins-bot: Improving zoom of embedded map, on address search [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/118978 (owner: 10Inchikutty)