[00:01:38] (03CR) 10Aarcos: Download tab, basic download and preview (0322 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [00:02:11] (03CR) 10Aarcos: "Mark, took care of all your comments based on our conversation, PTAL." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [00:21:40] (03PS1) 10Gergő Tisza: Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 [00:22:15] (03CR) 10jenkins-bot: [V: 04-1] Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [00:27:23] marktraceur: do we some sort of tooltip bubble widget in mediawiki? jquery.tipsy or something like that? [00:27:37] i'm looking for something for the second mockup in https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/226 [00:27:41] tipsy. [00:27:42] Yeah. [00:28:27] thx [00:28:43] missed it when i went through the resources folder the first time [00:39:11] (03PS2) 10Gergő Tisza: Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 [00:42:51] (03PS1) 10Gergő Tisza: Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 [00:49:57] (03PS1) 10Gergő Tisza: Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 [00:50:29] (03CR) 10jenkins-bot: [V: 04-1] Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [00:52:15] (03PS2) 10Gergő Tisza: Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 [00:52:44] (03CR) 10jenkins-bot: [V: 04-1] Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [01:06:21] (03PS3) 10Gergő Tisza: Only show file description page button for logged-in users. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 [01:06:55] (03CR) 10jenkins-bot: [V: 04-1] Only show file description page button for logged-in users. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [01:23:02] (03PS4) 10Gergő Tisza: Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 [02:04:34] (03PS1) 10Gergő Tisza: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 [02:05:10] (03CR) 10jenkins-bot: [V: 04-1] Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [02:06:21] (03PS2) 10Gergő Tisza: Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 [02:06:23] (03PS3) 10Gergő Tisza: Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 [02:06:25] (03PS5) 10Gergő Tisza: Only show file description page button for logged-in users [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 [02:06:27] (03PS3) 10Gergő Tisza: Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 [02:06:29] (03PS5) 10Gergő Tisza: Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 [02:06:31] (03PS3) 10Gergő Tisza: Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 [02:06:33] (03PS2) 10Gergő Tisza: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 [02:09:31] (03CR) 10jenkins-bot: [V: 04-1] Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [02:14:27] (03PS3) 10Gergő Tisza: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 [02:25:42] (03PS1) 10Aarcos: Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 [02:26:26] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [02:29:57] (03PS2) 10Aarcos: Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 [04:19:36] (03CR) 10Gergő Tisza: "fixDownArrowPosition() kind of sucks - it makes a component depend on a (mostly) unrelated other component. Not sure what would be the rig" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [08:30:51] (03CR) 10Siebrand: "The dependency has been merged, so this can go in now." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/121981 (owner: 10Siebrand) [08:46:50] (03PS1) 10Pginer: Layout adjustment for explanatory text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123185 [09:16:20] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [09:17:24] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [09:17:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [12:47:37] (03CR) 10Zfilipin: "Almost all scenarios fail on my machine. Am I doing something wrong?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [12:50:15] (03CR) 10Zfilipin: "Here is a nicely formatted console output: http://etherpad.wikimedia.org/p/119917" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [12:54:51] (03CR) 10Gilles: "It doesn't work for test2 at the moment because we've changed some CSS selectors that haven't made their way there yet. It should work bet" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [13:05:52] (03CR) 10Gilles: "This is the output for me when pointing to beta, which is what I expect (failures only on the performance criteria which are set too low f" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [13:09:57] (03CR) 10Gilles: [C: 032] Layout adjustment for explanatory text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123185 (owner: 10Pginer) [13:10:32] (03Merged) 10jenkins-bot: Layout adjustment for explanatory text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123185 (owner: 10Pginer) [13:10:53] thanks gi11es [13:11:01] np [13:26:34] (03CR) 10Gilles: [C: 04-1] "The layout is changed in a way that seems unintentional." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [13:34:26] (03CR) 10Nikerabbit: [C: 032] Migrate to JSON i18n [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/121981 (owner: 10Siebrand) [13:34:37] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/121981 (owner: 10Siebrand) [13:35:52] (03CR) 10Gilles: [C: 04-1] "I think there might a ticket for this already somewhere, but the credit area should really have it width constrained or something to avoid" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [13:41:39] (03CR) 10Gilles: [C: 04-1] "The window needs to be wider, otherwise the "submit" button is cut off on Firefox/standard 13 inch macbook: https://www.dropbox.com/s/wejm" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [13:48:53] (03CR) 10Zfilipin: "I plan to make a few changes and I would like to check that I did not break anything. Where should I run the file so it passes? Do I need " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [13:54:25] (03CR) 10Gilles: [C: 04-1] "I don't know if it got removed from the card acceptance criteria or I forgot to add it, but when I talked to Pau about it, he told me that" (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [13:58:19] (03CR) 10Gilles: [C: 04-1] "Only the feedback one has a relevant message. "More details"'s tooltip just states "More details"." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 (owner: 10Gergő Tisza) [14:01:49] (03CR) 10Gilles: [C: 031] Only show file description page button for logged-in users (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [14:12:45] (03CR) 10Gilles: [C: 04-1] Hide metadata top button texts (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza) [14:15:39] (03CR) 10Gilles: "If you want to make sure it passes, point it to beta and change the percent values in mmv_performance.feature:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [14:31:36] (03CR) 10Gilles: [C: 04-1] Fix problems with size menus for embed and download (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [14:55:32] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. That's okay." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [15:57:19] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/123268 [16:46:53] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/123268 (owner: 10Siebrand) [17:48:49] (03CR) 10Gergő Tisza: Only show file description page button for logged-in users (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123151 (owner: 10Gergő Tisza) [20:24:59] gi11es: bingle is whining about something, is that your problem or is it magically mine? (I got sent an email for some reason) [20:26:32] (03PS3) 10Aarcos: Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 [20:27:08] (03CR) 10jenkins-bot: [V: 04-1] Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [20:38:01] (03PS4) 10Aarcos: Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 [20:38:43] (03CR) 10Aarcos: "PTAL" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [20:53:45] (03CR) 10MarkTraceur: [C: 031] "I'm good to merge this now if there are no objections from e.g. gi11es or tgr." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [20:54:05] gi11es, tgr, looking for objections to merging the DL patch within the next hour or two, then I'm going [21:22:29] (03CR) 10MarkTraceur: [C: 032] "LGTM, will get merged once dependency goes in." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [21:29:04] gi11es: Re using jquery elements, the issue is that I need to be able to identify text elements, not just HTML elements as a whole... [21:29:18] Traversing them is not as easy [21:29:23] (with jquery) [21:34:30] Whoa, a comment about nesting in JS [21:34:37] I'm genuinely shocked. :) [21:40:35] (03CR) 10MarkTraceur: "Patch incoming." (038 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [21:40:43] (03PS6) 10MarkTraceur: Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 [21:40:45] (03CR) 10jenkins-bot: [V: 04-1] Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [21:41:33] (03PS24) 10Aarcos: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 [21:43:02] (03CR) 10Aarcos: Download tab, basic download and preview (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [21:50:19] (03CR) 10MarkTraceur: [C: 031] "Again, unless tgr or gi11es objects, I'm merging this at 16:00 PDT today" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [21:52:22] (03PS5) 10MarkTraceur: Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [21:52:38] (03CR) 10MarkTraceur: [C: 032] "Trivial rebase is trivial, see comments on PS4" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [22:06:45] marktraceur: how are you dealing with long texts in the title? [22:07:03] tgr: By truncating them; as with source/author [22:07:09] That's what the card says unless I misread it [22:07:21] i mean, how do you do that? [22:07:47] If the text is too long, I traverse the DOM and append things piecemeal [22:08:03] oh, so it is done in JS? [22:08:03] Until either I cannot do so without going over the limit or I run out of things [22:08:07] Yeah [22:08:15] Only way to support everything we want AFAICT [22:08:28] i am asking because i am just about to stick a bunch of floats in there [22:08:45] Oh, dear. Well, it should be fine [22:08:47] and i just realized that might mess up width calculations [22:09:00] Though the way I answered your question did make me think that we're cocking up RTL support with thsi. [22:09:04] this* [22:09:14] I'll add a card for that, I don't think we're releasing on any RTL wikis in the pilot [22:09:36] the buttons on the bottom right are floated now since there was no way to avoid text overlap with absolute positioning [22:09:54] *nod* [22:10:54] so the way you do it is to check mw-mmv-title-para/mw-mmv-credit width and cut the text if it is longer? [22:11:09] or are you directly testing for linebreaks somehow? [22:11:24] No test for linebreaks [22:11:30] It's just a character limit [22:11:46] 80 for making the text smaller, 100 hard upper limit [22:11:53] i see [22:11:56] no conflict then [22:12:01] 160/200 for the double field that authour/source comprise [22:12:09] Yup [22:28:32] (03CR) 10Gergő Tisza: "Apparently the height of an absolutely positioned element width inline contents is calculated based on the line-height of said content and" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 (owner: 10Gergő Tisza) [22:43:39] (03CR) 10Gergő Tisza: "Mark is working for a character limit for the title strings, but for now I have rearranged the styles (in the parent commit which introduc" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [22:43:54] (03PS7) 10MarkTraceur: Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 [22:44:26] (03CR) 10jenkins-bot: [V: 04-1] Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [22:44:32] (03CR) 10Aarcos: [C: 04-1] Refactor dropdown size calculation (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122611 (owner: 10Gergő Tisza) [22:47:29] Oh, eff you Jenkins [22:48:08] (03PS8) 10MarkTraceur: Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 [22:59:04] * marktraceur does final flight check [22:59:10] We're merging the download patch now [23:00:26] (03CR) 10Gergő Tisza: "In the three button version the normal texts will be hidden so they will need some sort of popup text." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 (owner: 10Gergő Tisza) [23:00:29] (03PS25) 10MarkTraceur: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [23:00:39] (03CR) 10MarkTraceur: [C: 032] "Here we go!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [23:01:27] (03Merged) 10jenkins-bot: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [23:22:16] (03PS6) 10MarkTraceur: Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [23:22:20] (03CR) 10MarkTraceur: [C: 032] Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [23:23:55] (03Merged) 10jenkins-bot: Fix problems with size menus for embed and download [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123161 (owner: 10Aarcos) [23:32:04] (03CR) 10Aarcos: Add truncatable text field, use for some fields (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [23:32:23] (03CR) 10Aarcos: [C: 04-1] Add truncatable text field, use for some fields (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur) [23:37:22] (03CR) 10Gergő Tisza: "I don't know about the card, but the reason to add this button was to give a convenient way to power-users to get to the image description" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [23:51:02] (03CR) 10Gergő Tisza: "Changed so that the popup is only shown when there is a site name. I'll change it back in the commit which hides the button texts." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 (owner: 10Gergő Tisza) [23:56:55] (03PS3) 10Gergő Tisza: Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 [23:56:57] (03PS4) 10Gergő Tisza: Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 [23:56:59] (03PS4) 10Gergő Tisza: Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 [23:57:01] (03PS6) 10Gergő Tisza: Create StripeButtons class, convert reuse button to use it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122631 [23:57:03] (03PS4) 10Gergő Tisza: Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 [23:57:05] (03PS4) 10Gergő Tisza: Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 [23:57:07] (03CR) 10jenkins-bot: [V: 04-1] Add tooltips to metadata buttons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123148 (owner: 10Gergő Tisza) [23:57:09] (03CR) 10jenkins-bot: [V: 04-1] Feedback button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/122877 (owner: 10Gergő Tisza) [23:57:11] (03CR) 10jenkins-bot: [V: 04-1] Make survey open in popup window instead of normal one [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123109 (owner: 10Gergő Tisza) [23:57:13] (03CR) 10jenkins-bot: [V: 04-1] Add metadata button to go to file description page directly [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123141 (owner: 10Gergő Tisza) [23:57:15] (03CR) 10jenkins-bot: [V: 04-1] Hide metadata top button texts [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123158 (owner: 10Gergő Tisza)