[00:03:03] cool! [00:03:21] Not without debug=true [00:03:26] So...imperfect, but whatever [00:03:40] this is for all sites? or this was merged into today's deployment train and goes out on Tuesday/Thursday? [00:03:46] Just mw.org I think [00:03:54] Because it needs the config/pref fixes to work afaik [00:04:42] is the debug param needed because not all caches are cleared on a SWAT deployment, or is that a more general problem? [00:06:11] I assume yes? But not sure [00:51:10] (03PS6) 10Aarcos: [WIP] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 [00:51:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [01:26:51] (03PS7) 10Aarcos: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 [01:26:54] (03CR) 10jenkins-bot: [V: 04-1] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [01:46:20] (03PS8) 10Aarcos: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 [01:47:01] (03CR) 10jenkins-bot: [V: 04-1] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [01:57:53] (03PS9) 10Aarcos: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 [01:58:31] (03CR) 10jenkins-bot: [V: 04-1] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [01:59:07] (03CR) 10Aarcos: Download tab, basic download and preview (0323 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [02:06:05] (03CR) 10Aarcos: "Hi team," [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [08:07:04] (03PS1) 10Gilles: Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 [09:21:17] (03CR) 10Siebrand: Download tab, basic download and preview (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [10:06:33] (03PS1) 10Gilles: [WIP] Display thumbnail placeholder ASAP [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 [10:06:41] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121614 [10:10:00] (03CR) 10Gilles: [C: 04-1] "Don't merge, depends on https://gerrit.wikimedia.org/r/121601" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 (owner: 10Gilles) [10:37:17] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121614 (owner: 10Siebrand) [10:37:55] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121614 (owner: 10Siebrand) [10:43:14] (03PS1) 10Gilles: Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 [10:44:39] (03CR) 10Gilles: [C: 04-1] "Don't merge, depends on https://gerrit.wikimedia.org/r/#/c/121601/ and https://gerrit.wikimedia.org/r/#/c/121606/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [11:04:27] (03PS2) 10Gilles: Display thumbnail placeholder ASAP [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 [11:05:55] (03CR) 10Gilles: [C: 04-1] "Don't merge, depends on https://gerrit.wikimedia.org/r/121601" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 (owner: 10Gilles) [13:42:26] (03CR) 10Gilles: [C: 032] Utilities to transform HTML to plain or filtered text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza) [13:43:18] (03Merged) 10jenkins-bot: Utilities to transform HTML to plain or filtered text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza) [13:45:31] (03CR) 10Gilles: [C: 032] Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza) [13:46:11] (03Merged) 10jenkins-bot: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza) [13:47:42] (03CR) 10Gilles: [C: 032] Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 (owner: 10Gergő Tisza) [13:48:24] (03Merged) 10jenkins-bot: Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 (owner: 10Gergő Tisza) [14:00:25] (03CR) 10Gilles: [C: 04-1] Download tab, basic download and preview (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [14:05:16] (03CR) 10Gilles: "The jshint issue is simply that it forbids bitwise operations by default "Because their use is rare in JS" Which seems dumb to me, I think" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [14:06:12] (03PS10) 10Gilles: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [14:06:14] (03CR) 10jenkins-bot: [V: 04-1] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [14:52:09] (03PS11) 10Gilles: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [14:52:46] (03CR) 10jenkins-bot: [V: 04-1] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [15:19:16] (03PS12) 10Gilles: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [15:20:38] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [15:45:37] (03PS13) 10Gilles: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [15:47:52] (03PS14) 10Gilles: Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [15:48:03] (03CR) 10Gilles: Download tab, basic download and preview (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [15:48:42] (03CR) 10jenkins-bot: [V: 04-1] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [15:51:40] (03CR) 10Gilles: [C: 04-1] "Fixed a bunch of issues, but download still doesn't work for sizes other than Original in Firefox, which is a major problem. I'm not going" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [18:00:00] Stand-up! [18:00:00] Order: bd808 -> tgr -> marktraceur -> fabriceflorin [18:00:06] ...what [18:00:11] ...the [18:00:16] * marktraceur kills it with fire [18:00:20] come on, bd808 stand up and dance for us [18:00:33] -\o/- [18:00:45] _/o\_ [18:00:53] ~o~ [18:00:58] That's all I've got [18:01:04] \o\ [18:01:06] |o| [18:01:08] /o/ [18:01:57] tgr: So you're missing the PM tool conversation in -office, and it sounds like gi11es and I are conspiring to overthrow Mingle :P [18:02:27] http://25.media.tumblr.com/tumblr_ljgi4ojfZk1qhrxyao1_500.gif [18:03:21] * marktraceur puts this in an empty workspace [18:03:24] * marktraceur leaves open all day [18:16:22] (03PS1) 10Gergő Tisza: Rename Buttons to CanvasButtons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121703 [18:17:34] fyi faidon will merge my varnish change early next week [18:17:51] he understandably didn't want to do it on a friday night [18:18:01] the one about Content-Disposition? [18:18:04] yes [18:18:15] cool [18:31:01] (03CR) 10Gergő Tisza: "You can -2 for "don't merge yet" comments, that does not fall off with every patchset." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 (owner: 10Gilles) [18:45:06] (03CR) 10Gergő Tisza: [C: 04-1] "The overlay was opaque and now it is 10% transparent. Was that intentional? Looks bad IMO, particularly because some of the page content i" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [18:46:03] (03CR) 10Gilles: [C: 04-2] Display thumbnail placeholder ASAP (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 (owner: 10Gilles) [18:50:02] (03CR) 10Gilles: Display black overlay while the viewer JS is loading (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [18:59:22] (03PS2) 10Gilles: Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 [18:59:35] (03CR) 10Gilles: Display black overlay while the viewer JS is loading (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [19:00:28] (03CR) 10jenkins-bot: [V: 04-1] Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [19:02:19] (03PS3) 10Gilles: Display thumbnail placeholder ASAP [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 [19:02:31] (03CR) 10Gilles: Display thumbnail placeholder ASAP (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 (owner: 10Gilles) [19:21:41] (03PS2) 10Gilles: Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 [19:26:22] (03PS3) 10Gilles: Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 [20:30:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [21:00:22] Hi! I am working on a bug, and need to upload an erroneous file for testing purposes. However, the I am not able to do so as the Upload mechanisim prevents me. I even disabled $wgVerifyMimeType but still cannot upload [21:00:42] Any one has any suggestions? [21:10:53] umang13: depending on what exactly you want to do, you might be able to just upload a normal file and then replace it [21:14:12] <+tgr> I want to upload a file that I downloaded from the commons, link : https://commons.wikimedia.org/wiki/File:2013-11-22_Ein_Entz%C3%BCcklop%C3%A4discher_Abend.webm , here there is a link at the end of the page [21:14:26] saying Error ..and so on [21:15:17] you are trying to upload it on your own server, right? [21:15:21] yes [21:15:45] so upload the original file and then replace it with the modified one [21:16:38] I did not get that clearly, Wont it check its contents and prevent me from uploading it? [21:16:51] that is while replacing [21:17:51] i mean, replace the file directly on your server [21:17:59] you have access to the file system [21:18:03] oh, yeah ok [21:18:20] thanks, simple solution :) [21:30:28] (03CR) 10Gergő Tisza: [C: 04-1] "I still don't like this... the solution seems more problematic then the original problem." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [21:37:12] (03CR) 10Gergő Tisza: ""something that is loaded on every single page should ideally not be extension-specific" -- that was poorly phrased and obviously not true" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [21:42:01] (03CR) 10Gergő Tisza: "Let me try rephrasing it more coherently: you can set any number of event handlers on an image but only a single onclick attribute, so we " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [21:53:22] (03CR) 10Gergő Tisza: ""but would still feel cleaner to check MultimediaViewerHooks::shouldHandleClicks() and make the hook a noop if it is false."" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [22:02:13] (03CR) 10Gilles: "I don't see the point of reading the media viewer config variables an additional time for this, we're just replaying a user action. The ex" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [22:04:18] (03CR) 10Gilles: "I didn't know that external head scripts blocked rendering (I've just checked on all major browsers to be sure). I would have done somethi" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [22:09:12] (03CR) 10Gergő Tisza: [C: 04-1] Display black overlay while the viewer JS is loading (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [22:28:33] (03CR) 10Gergő Tisza: "The point of checking the settings would be extra insurance that potential bugs do not affect wikis where MediaViewer is still in beta (bu" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [22:45:08] (03PS3) 10Gilles: Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 [22:45:50] (03CR) 10jenkins-bot: [V: 04-1] Replay early thumb link clicks when bootstrap is ready to receive them [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [22:48:09] (03PS4) 10Gilles: Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 [22:48:27] (03CR) 10Gilles: Display black overlay while the viewer JS is loading (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [22:48:38] (03CR) 10jenkins-bot: [V: 04-1] Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [22:51:13] (03CR) 10Gergő Tisza: [C: 031] "Wow! Feels amazingly fast." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121613 (owner: 10Gilles) [22:52:48] (03PS5) 10Gilles: Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 [22:53:18] (03CR) 10jenkins-bot: [V: 04-1] Display black overlay while the viewer JS is loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121600 (owner: 10Gilles) [22:55:10] gi11es: should i do the thumbnail URL guessing now that we have the full size in the HTML? [22:55:30] i thought we had a card for it but can't find any [23:11:24] tgr: sure [23:13:02] (03CR) 10Gilles: "This should be much better. QUnit failure is a red herring, it's caused by https://gerrit.wikimedia.org/r/#/c/117150/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles) [23:59:07] (03CR) 10Gergő Tisza: Replay early thumb link clicks when bootstrap is ready to receive them (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121629 (owner: 10Gilles)