[00:03:42] <quiddity>	 Is there an easy/fast way to move an image from mediawiki.org to commons? I uploaded in the wrong place, and want to link it in a discussion on Enwiki... >.>
[00:06:31] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[00:07:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza)
[00:13:15] <tgr>	 quiddity: CommonsHelper? haven't used it in a while, though
[00:15:44] <grrrit-wm>	 (03PS2) 10Gergő Tisza: Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[00:16:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza)
[00:18:50] <quiddity>	 tgr, hmm, it doesn't seem to like mediawiki. Possibly it's expecting a language prefix ("www" doesn't work). Thanks anyway!
[00:21:44] <tgr>	 seems to work for me
[00:21:56] <tgr>	 it finds the image at least
[00:38:55] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[00:39:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza)
[00:40:26] <grrrit-wm>	 (03PS4) 10Gergő Tisza: Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[00:41:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza)
[00:52:05] <grrrit-wm>	 (03PS5) 10Gergő Tisza: Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[00:52:32] <tgr>	 i am disabling jsduck global warnings, feel free to turn them back if you can figure out WTF is its problem with r/121282 
[00:52:48] <tgr>	 the variables are definitely not global though
[00:54:41] <grrrit-wm>	 (03CR) 10Gergő Tisza: "PS5 disables the global warning for JSDuck since it seems broken (I actually rewrote the function declarations to follow the exact same pa" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza)
[01:38:41] <grrrit-wm>	 (03PS5) 10Aarcos: [WIP] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 
[01:38:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos)
[01:47:33] <grrrit-wm>	 (03PS6) 10Gergő Tisza: Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[01:50:08] <grrrit-wm>	 (03CR) 10Aarcos: "Took care of most of the comments. Still need to write a few tests and there is some clean off left but early feedback on usability and co" (037 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos)
[01:52:59] <grrrit-wm>	 (03PS7) 10Gergő Tisza: Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[02:03:27] <grrrit-wm>	 (03PS5) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 
[02:03:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza)
[02:04:19] <bawolff>	 You know what's dumb - how uploading a chemical/x-pdb file explodes, because the database doesn't support a mime type of "chemical"
[02:04:47] <bawolff>	 which is of course not quite as dumb as using a major mime type of chemical instead of "model" or "application"
[02:11:57] <grrrit-wm>	 (03PS8) 10Gergő Tisza: Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[02:11:59] <grrrit-wm>	 (03PS6) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 
[02:13:13] <grrrit-wm>	 (03PS7) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 
[02:14:28] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 
[02:15:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 (owner: 10Gergő Tisza)
[02:17:39] <grrrit-wm>	 (03PS4) 10Gergő Tisza: Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 
[02:19:41] <grrrit-wm>	 (03CR) 10Gergő Tisza: Sanitize embed HTML (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 (owner: 10Gergő Tisza)
[02:21:16] <grrrit-wm>	 (03CR) 10Gergő Tisza: Add more information to embed HTML (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza)
[02:25:56] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] Increase the contrast of the share&embed input/textarea (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121074 (owner: 10Gilles)
[02:29:59] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Just a heads-up that in https://gerrit.wikimedia.org/r/#/c/120709/ I renamed some variables that are added here (those that had 'wt' + tho" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121064 (owner: 10Gilles)
[04:22:16] <grrrit-wm>	 (03PS2) 10Gilles: Adds help link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120524 
[04:23:08] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Adds help link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120524 (owner: 10Gilles)
[04:23:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adds help link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120524 (owner: 10Gilles)
[04:28:09] <grrrit-wm>	 (03PS2) 10Gilles: Increase the contrast of the share&embed input/textarea [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121074 
[04:29:33] <grrrit-wm>	 (03CR) 10Gilles: Increase the contrast of the share&embed input/textarea (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121074 (owner: 10Gilles)
[04:32:54] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Makes the size information (WxH) in Embed lighter [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles)
[04:33:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Makes the size information (WxH) in Embed lighter [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles)
[04:37:41] <grrrit-wm>	 (03PS2) 10Gilles: Add explanatory one-liners to share & embed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121052 
[04:38:57] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Add explanatory one-liners to share & embed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121052 (owner: 10Gilles)
[04:39:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add explanatory one-liners to share & embed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121052 (owner: 10Gilles)
[06:00:21] <grrrit-wm>	 (03PS1) 10MarkTraceur: Add model base class, description model [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 
[06:06:24] <grrrit-wm>	 (03PS1) 10MarkTraceur: WIP Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 
[06:06:35] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-2] WIP Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur)
[06:06:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP Add truncatable text field, use for some fields [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121309 (owner: 10MarkTraceur)
[06:31:01] <grrrit-wm>	 (03PS1) 10MarkTraceur: Sliiightly less painful module management [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121310 
[06:52:17] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "I think I may have cocked up some dependency loading, but I want to do this with UI elements too anyway" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121310 (owner: 10MarkTraceur)
[07:09:30] <grrrit-wm>	 (03PS2) 10MarkTraceur: WIP Better module management [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121310 
[07:09:49] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-2] "Not working; some issues still; going to bed" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121310 (owner: 10MarkTraceur)
[07:10:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP Better module management [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121310 (owner: 10MarkTraceur)
[07:47:48] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Increase the contrast of the share&embed input/textarea [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121074 (owner: 10Gilles)
[07:47:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Increase the contrast of the share&embed input/textarea [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121074 (owner: 10Gilles)
[07:50:36] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Increase the contrast of the share&embed input/textarea [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121074 (owner: 10Gilles)
[07:51:05] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Increase the contrast of the share&embed input/textarea [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121074 (owner: 10Gilles)
[07:51:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Increase the contrast of the share&embed input/textarea [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121074 (owner: 10Gilles)
[07:56:27] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 04-1] "Still not quite right. I'll amend." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur)
[07:57:23] <grrrit-wm>	 (03PS3) 10Ori.livneh: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur)
[08:01:41] <grrrit-wm>	 (03PS4) 10Ori.livneh: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur)
[08:11:10] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur)
[08:11:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur)
[09:38:05] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Use the new way of specifying beta screenshots [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121057 (owner: 10Amire80)
[09:38:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use the new way of specifying beta screenshots [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121057 (owner: 10Amire80)
[09:47:10] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Clean parsed HTML [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/120948 (owner: 10Gergő Tisza)
[09:47:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clean parsed HTML [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/120948 (owner: 10Gergő Tisza)
[09:54:15] <grrrit-wm>	 (03PS2) 10Gilles: Use the new way of specifying beta screenshots [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121057 (owner: 10Amire80)
[09:55:05] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Use the new way of specifying beta screenshots [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121057 (owner: 10Amire80)
[09:55:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use the new way of specifying beta screenshots [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121057 (owner: 10Amire80)
[10:04:21] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos)
[10:25:06] <grrrit-wm>	 (03CR) 10Gilles: [WIP] Download tab, basic download and preview (0323 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos)
[10:28:18] <grrrit-wm>	 (03CR) 10Gilles: "For some reason clicking "download" on anything but the original still doesn't work in Firefox. It just goes to the image instead of downl" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos)
[10:28:29] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] [WIP] Download tab, basic download and preview [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos)
[10:44:51] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] Utilities to transform HTML to plain or filtered tests (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza)
[10:46:39] <grrrit-wm>	 (03CR) 10Gilles: [C: 031] "Not +2ing it because it accesses the singleton, which is a concern in the parent commit. Otherwise LGTM." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 (owner: 10Gergő Tisza)
[12:48:02] <grrrit-wm>	 (03CR) 10Gilles: [C: 031] "Only +1 because use of singleton raised as a concern in the parent changeset" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza)
[13:34:12] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] Add model base class, description model (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/121308 (owner: 10MarkTraceur)
[14:11:47] <grrrit-wm>	 (03CR) 10Gilles: "I'm going to leave this one aside for now, since there will also be conflicts with Aaron's Download changeset, which is a lot more urgent " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121064 (owner: 10Gilles)
[16:56:09] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 04-1] Test to compare the performance of MMV and the Commons File: page (0313 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles)
[17:51:21] <umang13>	 hey, can anyone tell me if mediawiki is compatible with php 5.5 yet?
[17:53:51] <grrrit-wm>	 (03CR) 10Gilles: "Thanks for the review! I've answered your questions." (0312 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles)
[17:54:56] <marktraceur>	 umang13: Ehhhh
[17:55:02] <marktraceur>	 I doubt we'll try very hard to get it there
[17:55:18] <marktraceur>	 Like, if you happen to be writing new code, and make it PHP 5.5y, you can
[17:55:23] <marktraceur>	 But it doesn't seem high priority
[17:55:36] <marktraceur>	 umang13: You might ask in #wikimedia-dev.
[17:55:52] <umang13>	 Ok, Thanks :)
[17:59:18] <gillesgilles>	 marktraceur: do you mind if I turn off the old multimedia-alpha or at least reboot it? my old ZNC session is still running there and I can't SSH to that machine anymore
[18:00:21] <gillesgilles>	 alternatively, if you can still SSH to it, I'd appreciate if you can kill my running ZNC :)
[18:00:45] <marktraceur>	 That's fine
[18:00:53] <marktraceur>	 gillesgilles: You...shouldn't have your ZNC there though.
[18:01:01] <gillesgilles>	 where should I put it?
[18:01:01] <marktraceur>	 I probably should have noticed and killed it or something.
[18:01:05] <marktraceur>	 Not on labs.
[18:01:08] <gillesgilles>	 ok
[18:01:15] <marktraceur>	 gillesgilles: Labs isn't allowed to store passwords to important stuff
[18:02:01] <gillesgilles>	 it doesn't store passwords
[18:02:13] <gillesgilles>	 the IRC client is what truly connects
[18:02:43] <gillesgilles>	 someone who'd somehow figure out the ZNC password wouldn't be able to impersonate my cloak
[18:02:52] <marktraceur>	 Ah.
[18:03:01] <marktraceur>	 Oh, right, this was the issue with Subway, not ZNCs
[18:03:11] <gillesgilles>	 ZNC is just a proxy, pretty much
[18:04:03] <marktraceur>	 OK, that's fine then
[18:04:06] <marktraceur>	 But still sort of weird. :)
[18:04:47] <gillesgilles>	 I could try to install it on my NAS, but it has a weird CPU, installing anything on that thing is a major pain
[18:05:06] <marktraceur>	 Yeah, I believe you
[18:06:43] <gillesgilles>	 wikitech interface tells me it's rebooted it, I think that's a lie...
[18:08:13] <gi11es>	 ah! success
[18:08:27] <gi11es>	 the impostor has been defeated
[18:08:36] <marktraceur>	 Woo
[18:08:48] <marktraceur>	 wmfmedia-standup: What the fuck are you doing here
[18:09:02] <gi11es>	 mourning libel
[18:12:37] <marktraceur>	 Hah
[18:12:45] <marktraceur>	 I think it was running in a screen on my user account
[18:51:02] <grrrit-wm>	 (03PS9) 10Gergő Tisza: Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[18:51:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Utilities to transform HTML to plain or filtered tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza)
[19:03:32] <grrrit-wm>	 (03PS10) 10Gergő Tisza: Utilities to transform HTML to plain or filtered text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[19:06:27] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Figured out the problem with JSDuck (I forgot an @class, duh). Apparently anything that does not belong to a class results in a "global me" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 (owner: 10Gergő Tisza)
[19:06:55] <grrrit-wm>	 (03PS8) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 
[19:06:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza)
[19:08:27] <grrrit-wm>	 (03PS9) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 
[19:08:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza)
[19:08:36] <grrrit-wm>	 (03PS5) 10Gergő Tisza: Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 
[19:08:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 (owner: 10Gergő Tisza)
[19:09:49] <grrrit-wm>	 (03PS6) 10Gergő Tisza: Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 
[19:09:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 (owner: 10Gergő Tisza)
[19:14:35] <grrrit-wm>	 (03PS11) 10Gergő Tisza: Utilities to transform HTML to plain or filtered text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121282 
[19:14:36] <grrrit-wm>	 (03PS7) 10Gergő Tisza: Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 
[19:14:39] <grrrit-wm>	 (03PS10) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 
[20:44:43] <tgr>	 marktraceur: the exceptions in https://gerrit.wikimedia.org/r/#/c/119886/ don't seem to be working
[20:45:01] <marktraceur>	 ...wat
[20:45:01] <tgr>	 i do not see MMV in the beta menu on dewiki or enwiktionary
[20:45:31] <marktraceur>	 Yeah, that's weird
[20:46:15] <marktraceur>	 Fact that I can't fucking load any scripts or styles for enwikt is maybe contributing
[20:46:51] <marktraceur>	 Yeah, I don't..wait
[20:46:58] <tgr>	 maybe a https cert issue? i have those from time to time on beta
[20:47:01] <marktraceur>	 Fucking hell
[20:47:06] <marktraceur>	 mediawiki.org doesn't have it either
[20:47:22] <marktraceur>	 Whew, at least it's not on by default
[20:47:47] <marktraceur>	 Or...it is, but it's not working?
[20:47:49] <marktraceur>	 Argh
[20:48:23] <tgr>	 could it be related to   https://gerrit.wikimedia.org/r/121057 ?
[20:48:50] <tgr>	 i mean it is still in beta but cannot be displayed because the config format is wrong?
[20:53:43] <marktraceur>	 That would...maybe make sense
[20:54:06] <marktraceur>	 Hm, no
[20:54:20] <marktraceur>	 If the BetaFeatures class exists we stay in beta
[20:54:48] <marktraceur>	 OH WAIT
[20:54:49] <marktraceur>	 Crap
[20:55:02] <marktraceur>	 I remember now
[20:56:08] <marktraceur>	 tgr: Your comment (I think) to check wgMediaViewerInBeta in MMV.php was the cause; I'm fixing, will show you after
[21:02:17] <grrrit-wm>	 (03PS1) 10MarkTraceur: Fix failed attempt at configuration defaults [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121526 
[21:02:25] <marktraceur>	 tgr: There you go
[21:04:44] <tgr>	 this works but gives me lots of warnings
[21:05:00] <marktraceur>	 Ugh
[21:05:07] <marktraceur>	 What sort of warnings?
[21:05:16] <tgr>	 Warning: strtr() expects parameter 1 to be string, array given in /vagrant/mediawiki/includes/Html.php on line 555
[21:05:23] <marktraceur>	 Weird
[21:05:35] <marktraceur>	 Maybe that's a BetaFeatures bug that we weren't seeing because we weren't using BF?
[21:05:57] <marktraceur>	 I'd like to see a stacktraceu
[21:05:57] <tgr>	 not sure if it is related, but it happened after switching to your changeset from master
[21:06:02] <marktraceur>	 stacktraceur.
[21:06:23] <marktraceur>	 Yeah, because BF is suddenly in use...I imagine, anyway
[21:06:34] <marktraceur>	 That may be 121057 in play?
[21:06:34] <tgr>	 http://pastebin.com/dtimakGT
[21:07:07] <tgr>	 might be
[21:07:16] <tgr>	 let me check if my betafetures is current
[21:07:17] <marktraceur>	 Yeah, BF
[21:07:54] <marktraceur>	 I'd guess it's lack of compatibility somewhere
[21:08:18] <tgr>	 yeah, i wasn't using the most recent version
[21:08:22] <tgr>	 all good now
[21:08:28] <marktraceur>	 Aha.
[21:08:30] <marktraceur>	 Wonderful
[21:08:36] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Fix failed attempt at configuration defaults [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121526 (owner: 10MarkTraceur)
[21:14:14] <tgr>	 looks like this got stuck
[21:14:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix failed attempt at configuration defaults [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121526 (owner: 10MarkTraceur)
[21:15:09] <tgr>	 or not
[21:16:47] <marktraceur>	 Right so
[21:17:00] <tgr>	 i still don't see the beta option for dewiki
[21:17:03] <marktraceur>	 Mighty silly to check if the config variable is true when we've just set it to false :)
[21:17:09] <marktraceur>	 The code update prolly hasn't run yet
[21:17:42] <marktraceur>	 Should maybe add unit tests for the preference/bf integration
[21:19:52] <tgr>	 sounds painful
[21:20:08] <marktraceur>	 Not that bad, IMO
[21:20:24] <marktraceur>	 Would catch shit like this
[21:20:37] <tgr>	 you don't really have a unit to test there
[21:21:06] <tgr>	 MediaWikiHooks is testable, but that would not have caught this
[21:21:14] <marktraceur>	 Set config variables, call getPreferences, call getBetaFeaturePreferences
[21:21:28] <marktraceur>	 Er; include MMV.php then do the latter two
[21:21:36] <marktraceur>	 Or do it first or so
[21:22:13] <tgr>	 as in, call wfRunHooks?
[21:22:30] <tgr>	 if you simply call them by hand, that would not have caught this
[21:22:37] <marktraceur>	 Oh, yeah.
[21:23:04] <tgr>	 which is not to say it could not catch other bugs...
[21:23:17] <tgr>	 so yeah, probably a good idea
[21:23:44] <marktraceur>	 Not that we have time for it -.-
[21:27:02] <chrismcmahon>	 marktraceur:  was the betafeature config problem merged earlier today, or yesterday? 
[21:27:40] <marktraceur>	 Uh...even before that, I thought
[21:27:41] <grrrit-wm>	 (03CR) 10Krinkle: jquery audit of mw.DestinationChecker.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86804 (owner: 10MarkTraceur)
[21:27:51] <marktraceur>	 We weren't seeing working config on beta before, but had no idea why
[21:28:25] <marktraceur>	 It's clearer now.
[21:30:08] <chrismcmahon>	 marktraceur:  oic. yeah, browser tests catch config problems on beta labs (often on Thu morning) but that wouldn't have helped here 
[21:30:21] <tgr>	 marktraceur: looking at the userinfo api, most flag-type options are either true or false, but multimediaviewer-enable is either true or ''
[21:30:30] <tgr>	 is that normal?
[21:30:39] <marktraceur>	 ...ugh maybe not
[21:30:45] <marktraceur>	 tgr: Looking
[21:32:12] <marktraceur>	 tgr: It's not doing anything special
[21:32:28] <marktraceur>	 But maybe I fucked it up in a way even I don't understand
[21:33:07] <marktraceur>	 tgr: What other options are you seeing?
[21:33:38] <tgr>	 a bunch of echo stuff, some flagrev
[21:33:45] * marktraceur  looks at echo

[21:33:48] <tgr>	 core usually uses 0/1
[21:34:44] <marktraceur>	 I don't see anything different between our pref and echo-show-alert
[21:34:59] <marktraceur>	 I'm using whatever the 'toggle' type uses, I didn't mess with that
[21:35:09] <marktraceur>	 I assumed it wouldn't be broken
[21:35:12] <marktraceur>	 My fault there
[21:35:29] <marktraceur>	 Really though, as long as it's working I don't mind it looking funny
[21:36:08] <tgr>	 opt-out still doesn't work on beta, that's why i am looking at it
[21:36:24] <tgr>	 it did work for me locally
[21:36:28] <marktraceur>	 Hmmm.
[21:36:44] <marktraceur>	 Maybe the extension gets included after the config vars are set and we override the config vars
[21:36:48] <tgr>	 btw shouldn't we hide the pref if we are still in beta?
[21:36:57] <marktraceur>	 tgr: Yes, yes we should
[21:36:59] <marktraceur>	 Argh
[21:38:45] <marktraceur>	 Fixing, tgr
[21:42:34] <grrrit-wm>	 (03PS1) 10MarkTraceur: More preference and config fixes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121533 
[21:42:41] <marktraceur>	 tgr: There
[21:46:57] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] More preference and config fixes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121533 (owner: 10MarkTraceur)
[21:47:52] <marktraceur>	 Thanks
[21:54:10] <grrrit-wm>	 (03PS1) 10MarkTraceur: Fix failed attempt at configuration defaults [extensions/MultimediaViewer] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121539 
[21:55:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: More preference and config fixes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121533 (owner: 10MarkTraceur)
[21:55:42] <grrrit-wm>	 (03PS1) 10MarkTraceur: More preference and config fixes [extensions/MultimediaViewer] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121540 
[22:33:38] <tgr>	 marktraceur: either we are doing something wrong, or beta is really misconfigured
[22:33:45] <marktraceur>	 Ugh
[22:33:52] <marktraceur>	 It cannot possibly still be broken
[22:33:52] <tgr>	 wgMediaViewerOnClick is a user setting
[22:33:53] <marktraceur>	 Like
[22:33:58] <marktraceur>	 I will hurt someone
[22:34:02] <tgr>	 but it is actually loaded from http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector&*
[22:34:35] <tgr>	 there is no user id in that url and bits.beta does not get cookies so there is no way this file would be split per user
[22:34:58] <marktraceur>	 tgr: Ugh, that's bad.
[22:35:02] <marktraceur>	 That does explain a lot though
[22:35:10] <tgr>	 are we sure ResourceLoaderGetConfigVars is the right hook for this?
[22:35:16] <marktraceur>	 Apparently js config vars are meant for per-site and not per-user stuff...
[22:35:22] <marktraceur>	 TIL.
[22:35:38] <tgr>	 it has some vague comments about how MakeGlobalVariablesScript should be used instead in some cases
[22:37:08] <marktraceur>	 Yeah, sounds right
[22:37:13] <marktraceur>	 OK, 23 minutes to fix that -.-
[22:37:33] <tgr>	 LD window?
[22:37:39] <marktraceur>	 SWAT
[22:37:41] <marktraceur>	 They changed the name
[22:38:10] <tgr>	 it doesn't break anything so no huge deal if it does not get fixed...
[22:38:20] <tgr>	 but i'll give it a shot
[22:39:05] <marktraceur>	 Oh, you'll give it a shot? I meant I would, but that works too
[22:48:55] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Use MakeGlobalVariablesScript to set wgMediaViewerOnClick [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121551 
[22:49:14] <tgr>	 works for me locally
[22:49:18] <marktraceur>	 See it
[22:49:21] <tgr>	 but then, so did the old one...
[22:49:42] <marktraceur>	 wgMediaViewer should probably be in there too but whatev
[22:49:51] <tgr>	 would be nice to have the bits setup vagrantized
[22:50:05] <marktraceur>	 Hyuuuup
[22:50:19] <tgr>	 as long as we set it to constant true, it should be fine this way
[22:50:25] <marktraceur>	 I know
[22:50:29] <tgr>	 smaller page size and whatnot
[22:50:36] <tgr>	 these actually go to the HTML
[22:52:40] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "This *does* explain why it was so hard to get the user object in that method..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121551 (owner: 10Gergő Tisza)
[22:52:56] <marktraceur>	 All right Jenkins
[22:53:00] <marktraceur>	 You slow son of a bitch
[22:53:10] <marktraceur>	 Pedal to the metal
[22:53:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use MakeGlobalVariablesScript to set wgMediaViewerOnClick [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121551 (owner: 10Gergő Tisza)
[22:53:55] <marktraceur>	 Haha
[22:53:57] <marktraceur>	 Excellent
[22:54:07] <grrrit-wm>	 (03PS1) 10MarkTraceur: Use MakeGlobalVariablesScript to set wgMediaViewerOnClick [extensions/MultimediaViewer] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121553 
[23:14:38] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Use MakeGlobalVariablesScript to set wgMediaViewerOnClick [extensions/MultimediaViewer] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121553 (owner: 10MarkTraceur)
[23:14:51] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] More preference and config fixes [extensions/MultimediaViewer] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121540 (owner: 10MarkTraceur)
[23:15:09] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Fix failed attempt at configuration defaults [extensions/MultimediaViewer] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121539 (owner: 10MarkTraceur)
[23:15:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use MakeGlobalVariablesScript to set wgMediaViewerOnClick [extensions/MultimediaViewer] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/121553 (owner: 10MarkTraceur)
[23:58:03] <marktraceur>	 FYI https://www.mediawiki.org/wiki/Lightbox_demo?debug=true#mediaviewer/File:Tuhala%20Witches%20Well1-21-03-2013.jpg now works even if logged out.