[00:09:38] (03PS1) 10MarkTraceur: Load MMV scripts for everyone; handle hashes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120718 [00:28:07] FFS [00:28:15] The thumbnail clicks are getting lost again [00:28:25] What do we have to do to get things to work properly [00:28:49] ori changed the schema recently [00:28:55] maybe related to that? [00:28:58] Argh, probably [00:29:10] although that might have been the perf schema, i'm not sure [00:29:26] https://meta.wikimedia.org/w/index.php?title=Schema:MediaViewer&action=history no he didn't [00:29:30] Yejah [00:29:30] yeah* [01:06:17] Hm, http://multimedia-metrics.wmflabs.org/dashboards/mmv#performance-graphs-tab looks weird [01:28:30] (03PS1) 10MarkTraceur: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 [01:29:34] marktraceur: speaking of that, you have merge requests waiting for you on gitorious [01:29:40] I merged them! [01:29:43] And deployed them! [01:29:47] ah, awesome [01:29:48] I suspect that's why it looks funny [01:30:06] what looks funny? the gaps? [01:30:07] Especially since I decided my sanity would be better preserved not trying to trace fifty recursive selects [01:30:11] Yeah, the gaps [01:30:20] they're the gaps in the actual data [01:30:26] that's why I've increased the sampling rate [01:30:39] the old graphs were completely wrong because of the avg() issue [01:31:06] so I take it that the new requests I've created don't automatically turn into graphs [01:31:15] I've added two I think [01:31:37] Oh, yeah, we need to add them to the config [01:31:39] Which is...sec [01:31:49] I can just add them so long as I know where they are [01:32:13] perf/country-api.sql [01:32:21] perf/country-image.sql [01:32:23] 'kay [01:32:32] I guess that's pretty manual then. Fun. [01:32:35] and perf/mmv-versus-filepage.sql [01:32:47] gi11es: By the way, isn't it like...02:00 where you are [01:33:01] 02:32 [01:33:03] (03PS1) 10Aarcos: Phase 0: Download tab, plain download button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 [01:33:09] I'm on baby night shift [01:34:25] (03CR) 10jenkins-bot: [V: 04-1] Phase 0: Download tab, plain download button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [01:34:25] image hit vs image miss is pretty striking (already visible on your update) [01:34:33] Oh? [01:34:52] imagemiss_time_mean imagehit_time_mean [01:35:09] Oh, wow [01:36:19] * marktraceur needs a script for "don't show any lines" so he can enable only ones he wants [01:36:31] yeah, I find that annoying [01:36:39] is there a way to define a preset or something? [01:36:45] I mean yes [01:36:46] (03PS2) 10Aarcos: Phase 0: Download tab, plain download button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 [01:36:49] But it's not as easy [01:36:52] std and sample size you really only need on demand [01:37:02] Yeah [01:37:14] I could probably write a userscript for this in about an hour, if that [01:37:38] * marktraceur looks at clock, still-mostly-full stomach...yeah sure let's do it [01:37:40] would be better if it's the experience for everyone [01:37:46] Well yeah [01:37:53] considering we need to add explanations/labels, etc. [01:37:56] Userscript to actual script isn't a painful experience [01:46:25] (03CR) 10Aarcos: [C: 031] "LGTM but I will let the QA folks have a look at this and merge if appropriate." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [02:00:33] so, good news, pending confirmation that my varnish code works, it seems like we can do Content-Disposition: attachment everywhere (thumb.php, img_auth.php, mediawiki vagrant and varnish) [02:00:44] Woo [02:00:58] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/385 links to the diffs [02:01:39] all we'll need to do from the JS side is add "?original" to the URL of any thumb or original [02:11:02] (03CR) 10Ori.livneh: "You are assuming too much about the order in which hooks fire and modules are registered. The decision to register the schema module shoul" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur) [02:11:10] (03CR) 10Ori.livneh: [C: 04-1] "Per comment" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 (owner: 10MarkTraceur) [02:25:17] (03PS4) 10Mattflaschen: Fixed css issue where long copyright text and radio buttons are separated [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [02:27:10] (03PS5) 10Mattflaschen: Fixed css issue where long copyright text and radio buttons are separated [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [02:28:02] (03CR) 10Mattflaschen: "Patch set 4 is a rebase, since otherwise you run into unrelated bugs when testing with recent core." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [03:49:53] (03CR) 10Mattflaschen: [C: 032] "Tested in recent Firefox and Chromium, and IE 7 through 11" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [03:50:06] (03Merged) 10jenkins-bot: Fixed css issue where long copyright text and radio buttons are separated [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [07:00:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [07:43:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120738 (owner: 10Aarcos) [13:35:14] Is multimediaviewer activated by default in local machine copy of mediawiki [14:34:48] apsdehal: Yes, if you haven't touched the configuration variables. Oh! I should really document that. [14:38:09] Actually multimedia brokes for after 68399ff [14:38:27] I checked the diff it changes the configuration file [14:38:36] So maybe I haven't changed something [14:40:56] Kindly checkout to the mentioned diff and tell me what I have to do its Add client-side flag for disabling the viewer [14:40:56] [14:40:56] Also set it on server-side. Use mw.config to override. [14:41:20] marktraceur: Can you tell me about this mw.config [14:41:34] and I am checking it too, if I can figure [15:05:44] I fixed it :D It was due to because I didn't updated the core ever [15:11:33] apsdehal: ha ! [15:11:44] never thought of that one [15:51:42] apsdehal: In the future, this is the place to ask for support, PMing me is not as effective :) [15:53:47] marktraceur: I believe that now :) [17:44:21] (03CR) 10Aarcos: [C: 04-1] "I found a problem with the HTML size menu in the embed tab, the Small entry in the pulldown menu has an empty tag, I am sending attachment" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [17:57:02] (03PS2) 10Inchikutty: Improving zoom of embedded map, on address search [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/118978 [17:57:16] Hey! I have been asked to fix a bug whose number I dont know. It is about changing the max Size handling code in the validateParam method. I have been told that this bug has been reported and does have a number. If anyone has an idea about which bug number it might be please do tell. [18:02:48] Hm. [18:03:15] umang13: https://bugzilla.wikimedia.org/show_bug.cgi?id=1790 [18:03:26] umang13: I searched for "validateParam" [18:03:27] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=validateParam&list_id=292090 [18:04:01] It is should not be 1790, let me check the other one [18:04:30] oh thats just the search link. My bad [18:05:15] I was asked to fix the bug in the comments of 1790, so I am guessing it surely would not be 1790 :P [18:05:31] Oh hm [18:06:14] I dunno then [18:07:04] I have tried various keywords as searches, did not see any thing relevant yet. [18:07:31] Your guess is as good as mine...though bawolff may be more help with it, later tonight [18:08:24] Will wait for him :) [18:08:46] Tonight PDT* it should be said [18:41:00] (03PS2) 10MarkTraceur: Fix EventLogging schema registry [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120737 [19:18:14] (03CR) 10Gilles: "Aaron, you're referring to the OOJS UI bug I've fixed in the dependency that I've mentioned above in the comment." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [19:21:05] (03PS5) 10Gilles: Makes the size information (WxH) in Embed lighter [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 [19:21:23] (03CR) 10Gilles: Makes the size information (WxH) in Embed lighter (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [19:21:32] For all the uploader what should I add in iiprop, to get all the uploaders? [19:21:43] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/238 [19:21:58] (03CR) 10Gilles: [C: 04-1] "Don't merge, depends on https://gerrit.wikimedia.org/r/#/c/120685/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [19:37:52] (03PS2) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 [19:38:01] (03CR) 10jenkins-bot: [V: 04-1] Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza) [19:40:21] apsdehal: you probably need to change that in CommonsMetadata [19:40:46] I would go with the first uploader instead of the last, that's an easy change [19:41:17] showing all is a lot more complex, you need to change the UI, think about limiting the results and so on [19:41:20] I saw all the codes and got that api calls user and pushes it further through promises as lastuploader [19:41:53] Can't see how api can get all the uploaders [19:43:28] hm, not sure [19:43:41] normally you do that by getting more than one revision [19:43:56] but we don't want to get all revisions, could be lots [19:44:23] and we don't want to make an extra API call just because of this, either [19:45:18] Let me see their is a iilimit to get no. of revisions, maybe it can return something [19:46:20] yes, you would set iilimit to 500 or something to get all the revisions [19:47:01] not sure we want to do that though, seems like a lot of unnecessary data when we are only interested in the first and last revision [19:48:07] How would we now who was the first uploader until we don't know how many revisions are there [19:48:47] you can set revision number to 500 (that is the max allowed, i think) [19:49:07] if there are less than that, you get all of them and just have to check the first [19:49:34] if there are more, you get a continuation key, and you need to repeat the API call with that key to get the next 500 [19:49:52] But it will increase load as you said, is it feasible? [19:50:13] in practice it is rare to have more than a few revisions, even so i am not sure this is a good idea [19:51:07] You can discuss this among others and tell me anytime if you want to do this. [19:52:14] And in https://bugzilla.wikimedia.org/show_bug.cgi?id=62589, what kind of result you want if it doesn't load? [19:52:34] especially the extmetadata field can be huge, getting that for several revisions is a huge waste of bandwidth [19:53:06] i would probably add the first uploader as a new field to CommonsMetadata [19:54:55] (03CR) 10Aarcos: [C: 031] "I still see the wrong alignment? Approving, assuming you will fix it. Merge at your convenience if no other issues left." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [20:07:06] apsdehal: re bug, 62589, we have some crappy-looking error page now, and we have designs for a nice-looking one [20:07:19] added a link to the bug [20:08:00] the example of the french image loads fine as I checked now [20:08:35] yeah, I am not sure how the bug can be reproduced [20:09:11] probably not the best issue for you to work on, after all [20:11:05] I am going to a conclusion there isn't much work to on mmv as it is in development stage as of now and much of the big features are implemented by the core team. [20:12:51] there is a lot to work on, but a lot of it is not properly documented [20:13:20] and it is a moving target at the moment, yeah [20:13:52] probably for two more months, after that the MM team will shift to other tasks [20:17:33] Good luck for all of you [21:04:04] (03PS3) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 [21:05:29] (03CR) 10jenkins-bot: [V: 04-1] Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza) [21:10:58] (03PS4) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 [21:41:49] * marktraceur decides to make a TruncatableTextField UI class [21:49:29] (03PS1) 10Gergő Tisza: Clean parsed HTML [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/120948 [22:19:20] (03PS1) 10Gergő Tisza: Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 [22:20:02] (03CR) 10jenkins-bot: [V: 04-1] Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953 (owner: 10Gergő Tisza) [22:21:02] (03PS2) 10Gergő Tisza: Sanitize embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120953