[02:57:45] (03PS3) 10Gergő Tisza: Update MultimediaViewerNetworkPerformance schema rev. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120339 (owner: 10Ori.livneh) [02:58:22] (03CR) 10jenkins-bot: [V: 04-1] Update MultimediaViewerNetworkPerformance schema rev. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120339 (owner: 10Ori.livneh) [04:18:03] (03PS4) 10Gergő Tisza: Update MultimediaViewerNetworkPerformance schema rev. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120339 (owner: 10Ori.livneh) [04:19:38] (03CR) 10Gergő Tisza: [C: 032] Update MultimediaViewerNetworkPerformance schema rev. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120339 (owner: 10Ori.livneh) [04:20:12] (03Merged) 10jenkins-bot: Update MultimediaViewerNetworkPerformance schema rev. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120339 (owner: 10Ori.livneh) [09:48:44] (03CR) 10Gilles: [C: 032] Fix some text selection issues with share/embed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119649 (owner: 10Aarcos) [09:49:23] (03Merged) 10jenkins-bot: Fix some text selection issues with share/embed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119649 (owner: 10Aarcos) [10:46:59] (03CR) 10Gilles: [C: 032] Get more license info [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 (owner: 10Gergő Tisza) [11:43:08] Morning y'all [11:43:16] I'll be flying soon, see you around lunchtime [11:43:20] Maybe a bit after. [11:50:39] (03PS1) 10Siebrand: Use correct Creative Commons license abbreviation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120509 [12:01:58] (03CR) 10Raimond Spekking: [C: 032] Use correct Creative Commons license abbreviation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120509 (owner: 10Siebrand) [12:02:06] (03Merged) 10jenkins-bot: Use correct Creative Commons license abbreviation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/120509 (owner: 10Siebrand) [12:17:06] (03CR) 10Gilles: [C: 032] Improve embed credit line [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 (owner: 10Gergő Tisza) [12:17:44] (03Merged) 10jenkins-bot: Improve embed credit line [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 (owner: 10Gergő Tisza) [12:18:19] (03Merged) 10jenkins-bot: Get more license info [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119680 (owner: 10Gergő Tisza) [12:26:55] (03CR) 10Gilles: [C: 032] Add getSiteLink() to Repo model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119918 (owner: 10Gergő Tisza) [12:27:29] (03Merged) 10jenkins-bot: Add getSiteLink() to Repo model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119918 (owner: 10Gergő Tisza) [13:35:45] (03PS1) 10Gilles: Adds help link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120524 [13:36:55] (03CR) 10Gilles: [C: 04-1] "Don't merge, https://www.mediawiki.org/wiki/Multimedia/About_Media_Viewer/Help is currently empty" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120524 (owner: 10Gilles) [14:44:54] (03PS1) 10Gilles: Makes the size information (WxH) in Embed lighter [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 [14:50:23] (03CR) 10Gilles: [C: 04-1] "Buggy, don't merge. I'm trying to figure the bug out in more detail to see if the issue comes from OOJS UI." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [15:10:10] (03CR) 10Gilles: "Strangely enough the bug goes away if you open the dropdown, then close and reopen Media Viewer. But it will only work on a dropdown you'v" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [16:25:17] About this: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/238 [16:25:36] Do we need the first uploader or all? [16:29:50] The card says all [16:32:04] (03PS2) 10Gilles: Makes the size information (WxH) in Embed lighter [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 [16:37:15] (03CR) 10Gilles: "Depends on https://gerrit.wikimedia.org/r/#/c/120554/ and https://gerrit.wikimedia.org/r/#/c/120555/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [16:52:48] (03PS3) 10Gilles: Makes the size information (WxH) in Embed lighter [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 [16:54:42] (03CR) 10Gilles: [C: 04-1] "Feel free to review but don't merge, depends on https://gerrit.wikimedia.org/r/#/c/120555/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [17:34:03] Hey marktraceur. I was started re-implementing the uploadWizard ui in OOui elements. My goal is to get the main UI loadable in a dialog. James_F and I thought it best to ping you for your thoughts. Ideally, I would like to avoid any toe stepping. [17:35:11] Uhhhh [17:35:52] rmoen: We should probably have a really long conversation about this and maybe also talk to Fabrice or someone about prioritizing this so I can maybe help [17:36:04] Maybe not really long. But in person ideally. [17:36:18] marktraceur: The limiting factor on that is you; rmoen's here. :-) [17:36:50] I know! I'm flying as fast as I can! Christ! [17:37:01] marktraceur: You're in an SR-71? [17:37:38] marktraceur: of course. I think that is definitely in order due to the amount of 'one off' stuff in the UI that could possibly be eliminated. Also it would be good to get queued in on the teams plans for the future of UW [17:37:40] As fast as *I* can. Currently the laws of physics and FAA regulations put that at about $theSpeedOfThisAirplane, and I can't do much to alter it [17:38:17] Quoth the TV screen, "470 mph" [17:39:11] rmoen: The problem is we haven't had that discussion, so I'd rather just have a simple conversation about what you need and how to get there from here [17:39:25] We can worry about grander stuff later IMO [17:43:37] marktraceur: correct. Right now 'what i need' is fairly simple. In basic words, I need to abstract the UI from the core code [17:44:16] That may not be that simple, but we'll see what we can do [17:44:38] marktraceur: yeah there will be some bumps in the road [17:49:35] marktraceur: to start, my plans are to re-implement the current UI that is spit out on Special:UploadWizard in a OOui like class. Then the rest of the code goes from using selectors to references in the ui object. This will not be be a complete ui / model abstraction but it is a good place to start. [17:50:58] Yeah, it is [17:51:58] I guess I would prefer to start with models, but the UI could work. [17:52:12] Maybe we could trade off, depending on how we can structure this. [17:52:16] sure [18:17:13] tgr: how about configuring varnish to add a download http header when the url contains a given parameter? [18:17:17] like ?download [18:18:30] Would that work for third parties not using Varnish? [18:18:59] they'd have to reproduce the same thing [18:19:21] we can definitely do the same for default mediawiki sans-varnish [18:19:42] (images served by php) [18:19:49] it's only an issue for 3rd-party wikis that wouldn't use stock mediawiki nor varnish to serve files [18:20:36] Aha. [18:33:53] gi11es: Just to be in the same page, I will start with the Download today, just one button that does the download if supported or opens a new window otherwise, sounds good? [18:34:24] arcos: yep [18:34:34] I'll try to shake the ops tree in the meantime [18:35:08] sounds like a plan, ;-). [18:50:19] marktraceur: do you know by any chance which PHP script serves images by default? with links such as http://127.0.0.1:8080/images/8/8d/WMF_office.jpg [18:50:48] Hm, no [18:58:34] seems like straight files, ugh [18:59:26] now I have to figure out how to do this written in apache config [19:13:23] (03CR) 10Siebrand: [C: 04-1] Makes the size information (WxH) in Embed lighter (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [19:14:25] gi11es: depends a lot on your configuration [19:14:45] private wikis do pipe all images through a php script [19:16:00] some wikis (incl. Wikimedia) use a 404 handler so if the thumbnail does not exist then it is rendered on demand, and then piped through the PHP script for that request [19:16:32] that's what happens if you use vagrant with the multimedia role enabled [19:17:40] the entry points are thumb.php / thumb_handler.php / img_auth.php depending on configuration [19:46:22] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120524 (owner: 10Gilles) [20:30:41] If any body is available, I would like to know about how different the new planned Upload wizard is going to be from the existing one? [20:32:06] And what is the scope of compatibilty and reusage of code for some feature, between the two? [20:49:31] (03PS4) 10Gergő Tisza: Add user preference for non-beta disabling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [20:56:48] (03CR) 10Gergő Tisza: [C: 031] "Fixed per Bawolff's recommendation, seems to work now. Feel to merge if you are OK with the changes in PS2-4." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [21:05:43] umang13: Hi! [21:05:52] umang13: rmoen and I were just chitchatting about that [21:06:03] umang13: The new designs are pretty different, and a lot of the code will change [21:06:27] umang13: We'll refactor to use something closer to an MVC architecture, and we'll use OOJSUI for the UI code [21:07:57] marktraceur: If I were to implement a new feature based on the existing structure, is not possible that the implementation is done in a manner that it is easier to merge into the newer designs? [21:08:13] I am talking specifically about the Upload Wizard [21:08:34] Hm. [21:08:38] umang13: What new feature? [21:08:49] Support for a new file format [21:09:03] Basically to support 3D graphics and models [21:10:38] marktraceur: For a brief outline have a look at : https://www.mediawiki.org/wiki/User:Umang13/Gsoc14#Support_for_New_Media_file_types_.28X3D_OR_COLLADA.29_in_commons: [21:15:04] Ah. [21:15:14] umang13: I think rmoen isn't changing the model structure, just the UI [21:15:17] So you should be OK [21:15:25] But I'd be interested in refactoring models too?- [21:15:54] So basically I'd just suggest Not Leaving Town after you finish the feature - then when we come around to changing the model framework we can ask you for help, or you could even do it yerself :) [21:16:13] marktraceur, umang13, the 'models' will have some small ui bits, until we completely factor that out [21:16:46] I'd love to continue with it if given the oppurtunity :) [21:17:02] but yes, at this point we shouldn't be crossing streams too much [21:17:02] That is why I am asking if this is feasible to work on this project [21:17:18] (03CR) 10Aarcos: [C: 04-1] "This looks pretty good !, just have some minor requests. Also, it would be good if Chris or someone in the QA team takes a second look." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [21:17:35] umang13: I tend to say go for it and worry about merging and rebasing later [21:18:00] umang13: One thing that will help is if you manage to write your feature in such a way that doesn't touch any of the code we'll be refactoring - essentially putting it in its own file, e.g. [21:18:12] thank you!! did you read my proposal? [21:18:29] I didn't; but if you want to work on a feature I'm not one to stop you :) [21:18:38] I have a faint idea what it's about [21:18:56] Wait. [21:19:01] umang13: Do you need to touch UW for this? [21:19:14] That depends [21:19:43] I have been advised to keep this as a seperate feature. [21:19:54] Um [21:20:07] the existing UW I have an idea about [21:20:12] chrismcmahon: Can you or someone in your team take a look at https://gerrit.wikimedia.org/r/#/c/119917/. Gi11es is retrofitting the e2e tests to measure performance, I think this a great reuse of the e2e tests. [21:20:34] arcos: reading now thanks [21:20:47] and I am confident that I can implement it without disturbing much of the pre existing code [21:21:13] However, Gilles has told me that to merge this feature into the new UW might pose a problem [21:21:33] umang13: I'm asking whether supporting *viewing* of these files is the project, and whether *uploading* them takes any extra software support [21:21:51] I think it's just a matter of working the viewer into core (or an extension) and then configuring Commons to accept the filetype [21:21:56] But maybe I'm vastly wrong? [21:22:53] The problem is that to make these files viewable is not trivial. Since these are 3D models, they have camera views, angles, textures associated with them [21:23:07] tgr: are you sure originals are getting piped through a php script? thumbs are, but not images on the vagrant mediawiki [21:23:31] umang13: But that's the *viewer* doing that work. I'm asking you what *UploadWizard* needs to do. [21:23:40] gi11es: on private wikis, yes [21:23:49] it checks for the right permission [21:23:58] img_auth, is that the one? [21:24:10] in vagrant neither tumbs nor full images are piped i think [21:24:12] I've found the magic parameters for Apache anyway [21:24:16] that's the one, yes [21:24:39] We need to extract the appropriate files from the uploaded file to provide an image for the viewer. [21:25:42] I do not have an in-depth idea about the UW at the moment, but I am guessing we need not do much tinkering with it. [21:25:52] I may be wrong here [21:26:01] marktraceur: as i understand the main complication is that these are multi-file formats and you need to fetch on upload all textures and whatnot which are referenced from the base file by URL [21:26:17] but gi11es can probably explain better [21:26:17] that is why I wanted a more clear picture on the UW [21:26:25] OK, things that should be included in your proposal [21:26:31] The list starts with that [21:26:51] I think...hm. [21:26:55] I think that will be separate enough. [21:27:09] So you should be go to start work on it as soon as you'd like :) [21:28:04] Should I make my proposal more detailed? As in put in more implementation details? [21:28:21] umang13: I mean, talking about the formats a little bit and why they're complicated would be helpful [21:29:11] Sure. From the feedback I have recieved so far, X3D seems to be a more common request. Any inputs? [21:29:52] I don't know [21:30:14] I have only an anecdote about uploading unsavoury 3D files to commons which probably wouldn't help [21:31:07] Ok, never mind :) [21:56:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [22:00:31] Hm, have we seen any data on beta cluster's load since we turned things on there? [22:01:15] did we actually turn things on? [22:01:20] Yeah [22:01:30] It's on by default for erryone now on betalabs [22:01:33] i still get the file page there when logged out [22:01:36] Except on dewiki and enwikt IIRC [22:01:38] Oh, hm. [22:01:47] was that patch merged? [22:01:50] Maybe it's not, but I could swear I had it working [22:02:15] Weird [22:09:56] Oh, right [22:10:47] Hm, no [22:10:56] https://gerrit.wikimedia.org/r/119981 isn't merged but that shouldn't matter? [22:14:02] I believe MarkTraceur has the viewer enabled even though there's no preference [22:14:43] tgr: Caching issue, debug=true works logged [22:14:44] out [22:14:54] http://devopsreactions.tumblr.com/post/50716775316/damn-cached-js-filehttp://devopsreactions.tumblr.com/post/50716775316/damn-cached-js-file [22:15:20] http://devopsreactions.tumblr.com/post/50716775316/damn-cached-js-file sorry [22:23:36] tgr: https://bugzilla.wikimedia.org/show_bug.cgi?id=63034 [22:24:53] so basically non-debug JS on beta is never updated? [22:25:04] when you are logged out, anyway [22:25:14] Probably for some inane amount of time [22:25:19] 30 days, a week, whatever [22:25:26] not much point using it for testing then [22:25:28] chrismcmahon says hashar will work on it [22:25:30] No indeed [22:25:32] oh, ok [22:25:39] Well, logged in users see the new versions [22:26:57] (03CR) 10Gilles: Makes the size information (WxH) in Embed lighter (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [22:27:42] (03CR) 10Gergő Tisza: Add user preference for non-beta disabling (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [22:28:27] So the test users work fine [22:32:19] (03CR) 10Gilles: "Now depends on https://gerrit.wikimedia.org/r/120685" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [22:35:09] marktraceur: js cached on beta bits? [22:35:29] Uhhh probably? [22:35:41] you got to restart varnish on the bits cache [22:35:46] Grumble. [22:35:52] hashar: How I do? [22:36:55] I assume it's on deployment-cache-bits01 [22:38:23] I could just restart it? [22:38:30] yup [22:38:52] (03CR) 10Gergő Tisza: Makes the size information (WxH) in Embed lighter (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [22:52:04] (03CR) 10Gergő Tisza: [C: 031] Adds help link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120524 (owner: 10Gilles) [23:09:11] (03PS4) 10Gilles: Makes the size information (WxH) in Embed lighter [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 [23:09:19] (03CR) 10Gilles: Makes the size information (WxH) in Embed lighter (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120531 (owner: 10Gilles) [23:22:21] (03PS2) 10Gilles: Test to compare the performance of MMV and the Commons File: page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 [23:22:33] (03CR) 10Gilles: Test to compare the performance of MMV and the Commons File: page (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 (owner: 10Gilles) [23:45:48] (03PS1) 10Gergő Tisza: Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 [23:47:59] (03CR) 10jenkins-bot: [V: 04-1] Add more information to embed HTML [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/120709 (owner: 10Gergő Tisza)