[00:02:42] OK, now I'm seeing our client-side flags turned "on" but not seeing any modules on beta [00:02:44] rdwrer tgr: Hey guys, do you know why the new version of MediaViewer on MediaWiki.org is not displaying the 'Use this file' label? Is that because the SCAP did not complete, or is there another reason? : https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:Tamme-Lauri tamm suvepäeval.jpg [00:02:46] Except when I'm logged in [00:03:35] Maybe a caching issue [00:03:43] Hahaha [00:03:54] fabriceflorin: Probably an l10n update fail; I'll poke ops [00:04:51] rdwrer: Thanks! Do we think this will be cleared by tomorrow's quarterly review? Should we be worried about the version going to Commons on Monday? [00:06:59] Uhhh, maybe. [00:07:08] We'll sort it out, though [00:08:19] rdwrer: CommonSettings.php gets loaded for labs, right? [00:09:36] I thought it did but it's really not clear anymore [00:10:04] We could try changing the names of the settings [00:10:25] But that doesn't explain why it's out of BetaFeatures and still turned on for my user account [00:10:31] I strongly suspect caching [00:10:59] Oh, hey, there it is [00:26:48] (03CR) 10Ori.livneh: [C: 04-1] "Could you file a bug suggesting how this could be fixed comprehensively (even if only in outline), and note it in a TODO comment in the co" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/117916 (owner: 10Aaron Schulz) [00:27:46] rdwrer: the embed panel spec says to link to the site in the "via $SITE" part [00:28:09] what's the least crappy way to do that? replace $1 with '' in articlepath? [00:29:30] Hm. [00:29:40] tgr: To the site, or to the article page? [00:29:45] Because that sounds terrible [00:30:01] tgr: I think replacing it with '' would work but may not be the least crappy way. I dunno. [00:30:16] Anyway, /away commute [00:30:32] ok, thanks [00:30:52] i'll do that and anyone finding a less crappy one can fix :) [00:45:09] (03PS2) 10Ori.livneh: Try to reduce lock contention due to duplicated INSERTS [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/117916 (owner: 10Aaron Schulz) [00:45:37] (03CR) 10Ori.livneh: [C: 032] "Added a comment in PS2" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/117916 (owner: 10Aaron Schulz) [00:45:43] (03Merged) 10jenkins-bot: Try to reduce lock contention due to duplicated INSERTS [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/117916 (owner: 10Aaron Schulz) [01:19:00] (03PS1) 10Gilles: Test to compare the performance of MMV and the Commons File: page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119917 [01:19:18] (03PS1) 10Gergő Tisza: Add getSiteLink() to Repo model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119918 [01:19:42] (03PS2) 10Gergő Tisza: Add getSiteLink() to Repo model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119918 [04:54:28] gi11es: I'm going to steal bug 32551 away from you if that's ok [08:40:05] It would be really cool if we could do something to fix https://commons.wikimedia.org/wiki/Commons:VP#Stats_for_audio.2F_video [12:26:27] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 (owner: 10Gergő Tisza) [12:31:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119649 (owner: 10Aarcos) [12:50:59] (03PS1) 10MarkTraceur: Add user preference for non-beta disabling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 [12:51:08] (03CR) 10MarkTraceur: "Git is HARD, GUYS." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [12:51:35] (03CR) 10jenkins-bot: [V: 04-1] Add user preference for non-beta disabling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [12:51:36] * rdwrer facepalms [13:04:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [14:17:16] (03PS1) 10Cmcmahon: WIP: merge after https://gerrit.wikimedia.org/r/#/c/119996/ [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119999 [14:36:11] damn you upload wizard, I hate you so much [14:37:12] Why, why do you hang on "submitting details and publishing" when only 6 of my 50 uploads are published? [14:37:56] And why, why did I spend an hour and a half filling in all the metadata for a big batch all at once? [14:38:16] AAAAAAAAAAAAAAAAAAAAHHHHHHHHHH!!!!!!! [14:55:47] ragesoss: Mighty foolish of you to expect UW to work properly [14:55:59] I know. [14:56:51] The "file preview" popup breaks for all the ones that stall on "submitting and publishing", I notice. [14:57:45] although with my latest batch of just 7, they all actually published even though one is hanging on the UW page. [16:12:27] (03PS2) 10Cmcmahon: MobileFrontend and UW share upload steps. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119999 [16:13:35] (03CR) 10Cmcmahon: [C: 032] "mediawiki-selenium 2.16 is available now" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119999 (owner: 10Cmcmahon) [16:13:43] (03Merged) 10jenkins-bot: MobileFrontend and UW share upload steps. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119999 (owner: 10Cmcmahon) [16:38:56] gi11es, tgr, etc., I'm on IRC from the plane but probably won't be able to do Hangouts. [16:39:08] Let me know if you need me to answer questions, etc. [16:39:37] will do [16:40:19] fabrice is going through the slides at the moment [16:40:44] KK [16:48:54] rdwrer: unrelated, but do you get notified automatically when I send you merge requests on gitorious? [16:49:52] Not really [16:49:57] I know there's an open one though [16:50:13] I think my gitorious account sends mail to marktraceur@gmail.com, which is wrong [17:19:32] Knowledge for life: Wifi on planes is not easy to accomplish, and will not be what you want. [17:20:25] at least it lets us know that your plane hasn't vanished yet [18:31:10] Did the meeting go OK, guys? [18:31:21] * rdwrer pokes tgr, gi11es [18:35:21] on average i think it did [18:36:20] "on average"? :/ [18:36:25] we did have a few facepalm moments [18:37:12] like logging the close icon clicks but not logging the Esc keypresses [18:38:19] the etherpad is at http://etherpad.wikimedia.org/p/multimedia-quarterly-meeting-2014-03-21 [18:42:13] Didn't we know about that? [18:42:54] we did, but still [18:44:37] the above-fold icons got a lot of negative feedback [18:45:19] like how its confusing to have an edit icon that does not actually take you to an edit screen [18:45:35] YES [18:45:45] I hadn't put it into words yet but that had been bugging me [18:47:40] directing users to SurveyMonkey [18:47:59] not doing usertests on a real wiki [18:48:02] Yeah, go figure [18:48:27] tgr: Did SurveyMonkey get axed, or are we still doing that? [18:48:32] those are the criticisms i can remember [18:48:54] we are doing it [18:49:00] Righto [18:49:24] i am not sure there was any conclusion other than making sure it is obvious that the user is not on Wikipedia anymore [18:50:14] Good plan [20:29:10] (03CR) 10Gergő Tisza: "There is a typo, I'll fix." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [20:43:09] rdwrer: do you need anything special after adding a new preference? [20:43:22] db update? logout/login or something? [20:43:31] i am trying to test but don't see anything [21:47:47] Hello everyone, Is there any bug I can try upon, I don't want to get in between MMV's active development :) [21:48:20] hi apsdehal [21:48:35] hello tgr [21:48:45] you mean a MultimediaViewer bug specifically, or just a multimedia bug in general? [21:49:04] I mean a MMV's bug specifically [21:52:15] https://bugzilla.wikimedia.org/show_bug.cgi?id=57308 should be easy and i don't think we will get to it anytime soon [21:52:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=62594 is also easy, although setting up a testing environment for it might be more complex [21:55:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=62518 does not look too bad either [21:56:59] https://bugzilla.wikimedia.org/show_bug.cgi?id=62589 is basically just bug triage [21:58:06] I am going to see them, thanks tgr [21:59:20] thank *you* for working on MediaWiki :) [21:59:45] You are welcome :) [23:51:21] tgr: Shouldn't need to - it should just show up [23:52:35] rdwrer: yeah, a hook call was missing, i figured out in the meantime [23:52:48] i still can't get it working though [23:53:02] the option is there now but it is not saved [23:53:16] tgr: Hrm, weird [23:54:26] i tried to track it down in xdebug and seems like php just dies at some random point [23:54:39] no relation to mediaviewer code at all [23:55:35] (03PS2) 10Gergő Tisza: Add user preference for non-beta disabling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [23:55:49] Also weird [23:56:11] (03CR) 10jenkins-bot: [V: 04-1] Add user preference for non-beta disabling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119981 (owner: 10MarkTraceur) [23:59:13] lol, php just dying randomly. That does sound like php