[00:22:59] (03PS35) 10Gergő Tisza: Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 [00:23:38] (03CR) 10jenkins-bot: [V: 04-1] Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [00:23:44] (03CR) 10Gergő Tisza: "Fix text overlap on reuse button (in a not-so-robust way)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [00:26:51] (03PS36) 10Gergő Tisza: Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 [00:30:11] (03CR) 10Gergő Tisza: Add share and embed panel, replace reuse (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [01:03:34] (03PS37) 10Aarcos: Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [01:48:44] (03PS38) 10Gergő Tisza: Add share panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 [01:49:24] (03CR) 10jenkins-bot: [V: 04-1] Add share panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [01:51:07] (03PS39) 10Gergő Tisza: Add share panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 [01:52:12] (03CR) 10Gergő Tisza: "Removed everything related to embed, will readd in separate patchset. This patchset is ready for review and fully implements mingle ticket" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [01:55:11] (03PS40) 10Gergő Tisza: Add share panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 [01:56:56] (03CR) 10Gilles: "If we only accepted images that meet this selector:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118124 (owner: 10MarkTraceur) [01:57:18] (03PS41) 10Gergő Tisza: Add share panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 [01:57:52] (03CR) 10jenkins-bot: [V: 04-1] Add share panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [02:06:32] (03PS42) 10Gergő Tisza: Add share panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 [02:12:07] (03CR) 10Aarcos: [C: 031] "This LGTM but another pair of eyes to review and extra test wouldn't hurt before merging." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [02:29:30] (03PS1) 10Gergő Tisza: Add embed tab to reuse dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119434 [02:32:41] (03CR) 10Gergő Tisza: "I willtry to further split this into wikitext and HTML part, as the wikitext part is ready for review." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119434 (owner: 10Gergő Tisza) [03:06:45] (03PS2) 10Gergő Tisza: Add embed tab to reuse dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119434 [03:06:47] (03PS1) 10Gergő Tisza: Add HTML text to embed tab [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119439 [03:07:23] (03CR) 10jenkins-bot: [V: 04-1] Add embed tab to reuse dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119434 (owner: 10Gergő Tisza) [05:02:54] (03PS3) 10Gergő Tisza: Add embed tab to reuse dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119434 [05:15:42] (03CR) 10Gergő Tisza: "There are cases where an image does not have a .thumb parent and we want to show it, for example enwiki mainpage images or the top image o" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118124 (owner: 10MarkTraceur) [05:25:19] (03CR) 10Gergő Tisza: "Basically, the .thumb will be there when the image has a float CSS attribute (that's what the |thumb wikitext parameter which causes the ." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118124 (owner: 10MarkTraceur) [05:48:09] (03PS4) 10Gergő Tisza: Add embed tab to reuse dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119434 [05:48:11] (03PS2) 10Gergő Tisza: Add HTML text to embed tab [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119439 [06:25:40] (03PS3) 10Krinkle: Use checkboxShiftClick for "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [06:25:57] (03CR) 10Krinkle: "Rebased, ping UploadWizard maintainers." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [13:24:56] mmm I can't seem to be able to ssh to multimedia-alpha, it complains about failing to fork [13:25:00] rdwrer: can you ssh to it? [13:57:01] (03CR) 10Gilles: [C: 032] "I don't know how we go about making people running the big wikis to update their templates and how long it takes. I think that for the tim" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118124 (owner: 10MarkTraceur) [13:57:43] (03Merged) 10jenkins-bot: Don't launch in articles with no text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118124 (owner: 10MarkTraceur) [14:10:39] (03CR) 10Gilles: [C: 032] Use checkboxShiftClick for "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [14:10:52] (03Merged) 10jenkins-bot: Use checkboxShiftClick for "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [14:23:50] (03CR) 10Gilles: [C: 032] Add share panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [14:24:34] (03Merged) 10jenkins-bot: Add share panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [14:32:18] (03CR) 10Gilles: [C: 032] Add embed tab to reuse dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119434 (owner: 10Gergő Tisza) [14:33:15] (03Merged) 10jenkins-bot: Add embed tab to reuse dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119434 (owner: 10Gergő Tisza) [14:38:27] (03CR) 10Gilles: [C: 032] Add HTML text to embed tab [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119439 (owner: 10Gergő Tisza) [14:39:01] (03Merged) 10jenkins-bot: Add HTML text to embed tab [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119439 (owner: 10Gergő Tisza) [14:51:18] rdwrer: tgr: I can't reproduce https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/288 did either of you file this one? [14:52:21] gi11es: not sure who did, but i saw the error several times [14:52:44] on chrome? I've tried several times, I can't make it happen [14:53:40] on chrome, yes [14:53:58] although i can't reproduce with those steps either [14:55:50] I have an idea for a blind fix, but I'd like to find a way to reproduce it [14:58:17] last time i saw it was about a week ago, i dont think we did anything that could fix it since then [14:58:38] i'm not sure how exactly i got it though, just that it was connected to fullscreen [15:02:25] (03PS1) 10Gilles: Clear the cursor hiding class when attaching the lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119485 [15:31:11] (03CR) 10Yuvipanda: "Also note that this is using MapQuest tiles, which I guess is against WMF's Privacy Policy." [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [16:29:45] gi11es: We moved it to eqiad, so try "ssh multimedia-alpha.eqiad.wmflabs" [17:20:19] (03CR) 10Aarcos: Add HTML text to embed tab (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119439 (owner: 10Gergő Tisza) [17:55:37] gi11es: This SQL query scares me [17:56:56] Not that I'm not going to merge it [17:56:57] But ugh [18:01:45] (03PS1) 10Cmcmahon: Improve text of message attached to uploaded image [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119519 [18:04:17] gi11es: Mind if I pop over to analytics and ask them to do CR, possibly help out a bit more? [18:04:29] (03CR) 10Gergő Tisza: "UploadWizard is already calling Flickr APIs, not sure how that is conceptually different from calling MapQuest APIs. There is no personall" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [18:06:48] rdwrer: we're only dealing with a few hundred rows, it's not a big deal [18:07:15] I think the issue with that specific problem is that if you show it to other people they'll think there's a simpler way to achieve this, but there really isn't [18:07:34] the alternative is to break things down into more graphs [18:07:50] which we can do if we end up with hundreds of thousands of rows and the query starts being too slow [18:08:20] but then we'd have as many graphs as (number of API calls tracked) * (number of wikis tracked) [18:08:52] Yeah [18:09:20] how often does the query run? on a cron? [18:09:55] (03CR) 10Gergő Tisza: "Could not reproduce the error but in theory the fix seems good." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119485 (owner: 10Gilles) [18:09:59] (as for multimedia-alpha, I am trying to ssh eqiad. still gives me the error now) [18:10:41] It's once a day [18:11:15] (03CR) 10Gergő Tisza: [C: 032] Clear the cursor hiding class when attaching the lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119485 (owner: 10Gilles) [18:11:19] gi11es: You need to set up some config for ssh eqiad to work; I had to do it the first time I set up labs on this box because it was Ye Olden Times, but maybe there's a better way now [18:11:54] (03CR) 10Gergő Tisza: [C: 032] Improve text of message attached to uploaded image [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119519 (owner: 10Cmcmahon) [18:12:03] (03Merged) 10jenkins-bot: Improve text of message attached to uploaded image [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119519 (owner: 10Cmcmahon) [18:12:35] (03Merged) 10jenkins-bot: Clear the cursor hiding class when attaching the lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119485 (owner: 10Gilles) [18:12:56] oh well, if it's once a day, this query will only start being a problem when we start dealing with gigabytes of data [18:13:43] even then, if the index is decent, the amount of subqueries isn't that big a deal, if every query hits an index [18:14:56] Right, so [18:15:08] This sounds like an instance of not needing any help [18:15:44] I think asking for help would result in unnecessary bike shedding over that query, yes [18:15:52] Arright [18:16:02] complex queries are only problematic on a large amount of data, basically [18:16:17] Well, or if we wanted to, say, maintain this code at all [18:16:59] I can document that query, it's actually not that complicated, SQL just makes it very verbose [18:17:40] what makes it look nasty is that you need a join for each metric [18:18:04] the only tricky part is that you have to start with the whole set of possible dates as the first thing on the left of the first join [18:18:33] maybe there's a way to make it a bit less verbose, but there's no escaping that many joins [18:18:46] because of the avg/std issue [18:20:42] adding a new metric is as simple as adding a SELECT * FROM ( at the beginning and copying/pasting the section about the last metric [18:21:23] * rdwrer deploys [18:21:38] another solution, but it makes us a bit blind regarding regarding some wikis, would be to only track the global average for each API call [18:21:53] and then maybe pick one or two wikis, instead of all of them, for which we're also going to track each API call [18:22:35] and then have a graph where we track the average performance of all API calls together, per wiki [18:23:22] but then we're more likely to miss a specific API call on a specific wiki being slower than it should be, because it would make less of a spike on the global average [18:25:26] so, how do you actually deploy that change from gitorious? manually on stat1? [18:28:33] (03CR) 10MarkTraceur: "Yeah, I don't see why we wouldn't want to display images not inside of thumbs or galleries. If we wanted to make that decision on a produc" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118124 (owner: 10MarkTraceur) [18:32:20] Yeah [18:32:30] In my home directory, which is sort of sad but the way it works right now [18:32:38] We can maybe sort out a better way [18:32:59] I also want to make it so it's not the same code in ten different places - would much rather have a template and then build things out per-wiki and per-stat [18:34:30] (03CR) 10Gergő Tisza: "Another example (although we are already too restrictive for this one) is bug 62594. We have to make this fixable by third parties or we w" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118124 (owner: 10MarkTraceur) [18:35:48] (03CR) 10Gergő Tisza: "Might have more to do with the server-side code thinking there are no images on the page, though." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118124 (owner: 10MarkTraceur) [18:41:19] (03CR) 10Aarcos: [C: 031] "LGTM, not pretty but better than nothing. Feel free to merge if no other concerns left." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [18:41:36] rdwrer: do the limn graphs adapt autmatically to the columns in the data source? because I've changed some things (added sample size and got rid of total) [18:42:04] (03PS7) 10Gergő Tisza: Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 [18:44:01] (03CR) 10jenkins-bot: [V: 04-1] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [18:44:05] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [18:45:29] Yeah, they do [18:45:41] Breaking things now [18:45:57] Should update in about 15 minutes [18:52:43] (03PS8) 10Gergő Tisza: Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 [18:53:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [18:55:10] (03CR) 10Gergő Tisza: [C: 032] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [18:55:47] (03Merged) 10jenkins-bot: Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [19:51:05] tgr arcos rdwrer : I quickly tested the new Embed feature on beta and added an HTML link to my test page. The author link doesn't work. I think it would be best if the image title linked to the file page on Commons, in addition to the author link, which is less important. Also, the CC license info should be linked, at least to the file page 'License' section. Here's my test page: http://69.195.124.160/~fabricef/test/ [20:19:58] (03PS1) 10Gergő Tisza: Improve embed credit line [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 [20:21:34] (03CR) 10jenkins-bot: [V: 04-1] Improve embed credit line [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 (owner: 10Gergő Tisza) [20:51:46] (03PS2) 10Gergő Tisza: Improve embed credit line [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 [20:52:23] (03CR) 10jenkins-bot: [V: 04-1] Improve embed credit line [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 (owner: 10Gergő Tisza) [20:52:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 (owner: 10Gergő Tisza) [20:54:39] (03PS3) 10Gergő Tisza: Improve embed credit line [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 [20:57:01] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119554 (owner: 10Gergő Tisza) [21:25:16] (03PS1) 10Robmoen: Delint and general mw.UploadWizardUpload cleanup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 [21:31:47] (03PS2) 10Robmoen: Delint and general mw.UploadWizardUpload cleanup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 [21:35:01] (03PS6) 10Gergő Tisza: Make sure local URLs in image description are always absolute [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96528 [21:35:07] (03CR) 10jenkins-bot: [V: 04-1] Make sure local URLs in image description are always absolute [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96528 (owner: 10Gergő Tisza) [21:36:03] rdwrer: are you in the mood for some core merging? [21:36:15] tgr: Only ALWAYS [21:36:25] Let's break out the champagne and cigars [21:36:29] Throw us a party [21:36:34] Or just link me to a patch [21:36:43] Sans frills [21:37:05] except it seems to have broken all the unit tests [21:37:10] back in a minute... [21:37:23] Righto [21:41:02] (03PS3) 10Robmoen: Delint and general mw.UploadWizardUpload cleanup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/119639 [21:42:19] (03PS7) 10Gergő Tisza: Make sure local URLs in image description are always absolute [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96528 [21:43:38] rdwrer: ^^ [21:43:54] * rdwrer looks at -feed [21:44:16] tgr: Not core, CMD? [21:44:31] it has +1 from anomie and aaron, i just had to do a lot of rebasing since [21:44:37] um, right [21:44:45] messes with the core though [21:45:05] Ahm...it does? [21:45:12] * rdwrer looks at patch [21:45:20] I'll just review, that will help [22:40:08] (03PS1) 10Aarcos: Fix some text selection issues with share/embed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119649 [22:40:53] tgr: All right, so...you're replacing a hook in this code, or just setting a new one? [22:59:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/119649 (owner: 10Aarcos) [23:03:09] rdwrer: setting a new one, temporarily [23:03:23] just for the getDescription() clal [23:03:28] ...call [23:03:36] Right [23:05:48] Hm, seems pretty magical but also seems like it will work [23:17:31] tgr: I'm weirdly not seeing this working locally, but I bet it's my fault. I've put a link to a local page in and called extmetadata on the image [23:18:01] rdwrer: you need to clear the cache [23:18:09] redis, if you use vagrant [23:18:10] Server-side? [23:18:14] yes [23:18:14] I don't think I'm caching at all [23:18:30] nobe.jpg [23:18:35] nope.jpg even [23:18:57] also, the image itself has to be local [23:19:02] It is [23:19:17] Picture of mah kittycat. [23:19:24] i'll pass then, works for me that way [23:19:34] i would still suspect some sort of cache [23:20:00] you can try setting wgCacheEpoch, i think that clears everything [23:20:34] Hm. [23:21:55] No dice [23:23:00] you can edit the description page of the file then, that will decide things one way or another [23:35:51] Well, yeah, that's what I did [23:37:27] Aha [23:37:29] Because I cannot read [23:37:34] Traditionally id attributes were used to tag the name call in the first column in a row. To get the data, you would need to get the contents of the following cell in the second column. [23:37:38] Told you it was my fault [23:37:55] 'kay seems to work [23:37:58] * rdwrer merges [23:38:16] (03CR) 10MarkTraceur: [C: 032] Make sure local URLs in image description are always absolute [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96528 (owner: 10Gergő Tisza) [23:39:32] (03Merged) 10jenkins-bot: Make sure local URLs in image description are always absolute [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96528 (owner: 10Gergő Tisza)