[00:03:17] (03PS5) 10MarkTraceur: Add feature flags for Media Viewer [extensions/MultimediaViewer] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117374 [00:20:35] Multimedia post from mholmquist@wikimedia.org requires approval [00:20:38] What [00:20:39] The [00:20:40] Fuck [01:00:30] rdwrer: I got moderated too, when I'm already a list member. [01:08:53] (03CR) 10Gergő Tisza: [C: 031] Add feature flags for Media Viewer [extensions/MultimediaViewer] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117374 (owner: 10MarkTraceur) [01:30:11] (03PS2) 10Gergő Tisza: Extract embed formatting into separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117639 [01:30:14] (03CR) 10jenkins-bot: [V: 04-1] Extract embed formatting into separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117639 (owner: 10Gergő Tisza) [08:10:54] (03CR) 10Gilles: [C: 04-1] "Great idea!" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116781 (owner: 10Gergő Tisza) [08:33:29] (03CR) 10Gilles: jquery audit of mw.GroupProgressBar.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86810 (owner: 10MarkTraceur) [08:37:56] (03CR) 10Gilles: "Gergo, are you happy with those browser compatibility criteria?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115368 (owner: 10Pginer) [10:02:00] Hi, I got some design feedback from kaity, I would like to try using a different width for the two columns on the metadata panel but unfortunately both have the same mw-mlb-image-metadata-column class [10:02:27] Would it be possible to add an additional class to differentiate them? [10:25:02] (03CR) 10Gilles: [C: 04-1] [WIP] Handle image loading rejections (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [10:36:43] (03PS21) 10Gilles: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [10:36:45] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [10:48:39] (03PS22) 10Gilles: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [10:49:17] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [12:13:04] (03PS23) 10Gilles: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [12:34:44] (03PS24) 10Gilles: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [12:35:48] (03CR) 10Gilles: WIP Add share and embed panel, replace reuse (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [12:39:10] (03CR) 10Gilles: "Fixed the jshint & jsduck errors + implemented the small improvement suggested by Gergo to avoid passing a callback." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [12:51:17] (03CR) 10Gilles: Add feature flags for Media Viewer (031 comment) [extensions/MultimediaViewer] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117374 (owner: 10MarkTraceur) [13:07:28] (03CR) 10Gilles: [C: 032] Comply with WCAG 2.0 H44 - label form control association [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117414 (owner: 10Rillke) [13:09:30] (03Merged) 10jenkins-bot: Comply with WCAG 2.0 H44 - label form control association [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117414 (owner: 10Rillke) [13:18:56] (03CR) 10Gilles: [C: 032] Replacing deprecated $j.browser with $.client [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [13:19:04] (03Merged) 10jenkins-bot: Replacing deprecated $j.browser with $.client [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/74425 (owner: 10Rillke) [13:33:12] (03PS3) 10Gilles: Remind user to select a license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117428 (owner: 10Rillke) [13:33:47] (03CR) 10Gilles: [C: 032] Remind user to select a license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117428 (owner: 10Rillke) [13:33:55] (03Merged) 10jenkins-bot: Remind user to select a license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/117428 (owner: 10Rillke) [14:21:10] (03PS1) 10Pginer: Use different widths for metadata columns [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118075 [14:40:36] (03CR) 10Gilles: [C: 032] Use different widths for metadata columns [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118075 (owner: 10Pginer) [14:41:08] (03CR) 10jenkins-bot: [V: 04-1] Use different widths for metadata columns [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118075 (owner: 10Pginer) [15:02:25] (03CR) 10Addshore: Improving functions documentation (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97172 (owner: 10Dereckson) [15:03:15] (03PS1) 10Gilles: Point the navigation E2E test to the right image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118085 [15:05:44] (03PS2) 10Gilles: Use different widths for metadata columns [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118075 (owner: 10Pginer) [15:06:43] (03CR) 10Gilles: [C: 032] Use different widths for metadata columns [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118075 (owner: 10Pginer) [15:07:16] (03Merged) 10jenkins-bot: Use different widths for metadata columns [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118075 (owner: 10Pginer) [16:08:34] pginer: Yeah, shouldn't be too hard - I can show you where to change them [16:10:04] I saw a notification and IRC client crashed [16:10:13] anything for me here? [16:10:18] pginer: In resources/mmv/ui/mmv.ui.metadataPanel.js there's a function called MPP.initializeImageMetadata - go there and change the classes :) [16:10:48] thanks. but that was already done [16:11:19] on https://gerrit.wikimedia.org/r/#/c/118075/ [16:13:59] Oh! [16:14:22] pginer: In that case notification that you've solved your issue is usually helpful :) [16:15:15] True. Sorry about that [16:15:30] Not a problem at all [16:49:01] (03CR) 10Aarcos: "Hi Gilles," [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [17:00:33] (03CR) 10Aarcos: [C: 032] "Thanx for the fix !" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118085 (owner: 10Gilles) [17:01:07] (03Merged) 10jenkins-bot: Point the navigation E2E test to the right image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118085 (owner: 10Gilles) [17:03:59] Didn't we have a card for "always enable media viewer when there's a query param telling you to"? [17:04:04] Or something [17:05:00] Like, ignore preference, turn it on [18:07:00] gi11es, aarcos - do you remember talking about the query parameter for loading the MMV scripts? [18:15:41] rdwrer: I remember, this is an alternative to a cookie solution to enable/disable MMV, not sure if a card was created though? [18:16:03] I don't think it's an alternative, I think it's a different feature [18:16:17] tgr: you missed me asking "do you remember talking about the query parameter for loading the MMV scripts?" [18:21:53] rdwrer: you mean loading mmv for mvm-vspecific urls even if the user has it disabled? [18:22:48] Yup [18:23:31] we kind of went in the opposite direction with jquery.hashchange [18:23:59] Well, sort of [18:24:26] because we now have full client-side support for shareable urls [18:25:03] with query params, we would have modern browser support only, and presumably some sort of server-side support as fallback [18:25:55] Hm [18:26:07] the easy solution would be to load the bootstrap even if you disabled mmv, but only use it to listen to hash changes [18:27:00] Ah, yeah. [18:30:58] (03CR) 10Addshore: [C: 04-1] "needs a rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/22273 (owner: 10MarkTraceur) [18:31:51] Or rather, only use it on page load and if there's a hash that already has mediaviewer/ in it, then load [18:32:03] I'll make such a card. [18:32:25] con is that it adds unneeded JS (bootstrap is 16K according to Juliusz, probably could work it down a bit) and errors in bootstrap affect users who disabled mmv [18:32:40] on the whole, seems like a good deal to me [18:32:41] Yeah [18:33:34] probably not typical, but a hash change can occur after page load, if someone links to an image on the same page [18:33:52] Ah, yeah. [18:40:23] (03CR) 10Aarcos: "Gilles," [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [18:45:09] (03PS1) 10Pginer: Simplify uses box and adjust layout [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118122 [18:45:43] (03CR) 10jenkins-bot: [V: 04-1] Simplify uses box and adjust layout [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118122 (owner: 10Pginer) [18:45:51] (03PS2) 10Pginer: Simplify "Usage box" and layout adjustments [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118122 [18:46:25] (03CR) 10jenkins-bot: [V: 04-1] Simplify "Usage box" and layout adjustments [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118122 (owner: 10Pginer) [18:48:59] (03PS4) 10Aarcos: Split share class into dialog and content tabs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [18:49:01] (03CR) 10jenkins-bot: [V: 04-1] Split share class into dialog and content tabs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [18:53:31] (03PS1) 10MarkTraceur: Don't launch in articles with no text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/118124 [18:54:32] What a silly billy bug. [19:00:11] Ugh, I guess I'll work on 198 [19:00:35] (03CR) 10Aarcos: "Just finish tests for mmv.ui.reuse.embed.js. I will continue writing tests for mmv.ui.reuse.tab.js, mmv.ui.reuse.tab.js and mmv.ui.reuse.d" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [19:07:08] tgr: Can you poke fabriceflorin to get on? [19:11:36] Never mind, will email [22:55:18] fabriceflorin: Hey, thoughts on the image load analysis card? [22:56:14] rdwrer: I am working on it, but was held back by a PM meeting, which ends in 5 mins. Can I get back to you in 15 mins? [22:56:21] Sure [22:56:28] I've been working on other stuff anyway [22:56:41] (perf data for each wiki) [22:57:09] Thanks, and sorry for not responding sooner. I had a series of short meetings today, so I didn’t bother to turn on IRC, to avoid all the annoying 'log on / off’ messages. [22:58:27] You can turn those off...they shouldn't notify you anyway [23:19:31] fabriceflorin: Ping [23:32:29] Yep, working on it. Was just distracted by RobLa. Back to work. ... [23:47:31] rdwrer: Hi Mark, I took a first stab at image load metrics dashboard, at this URL: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/198 [23:47:47] "The card was updated" okay I'll refresh it [23:48:04] fabriceflorin: You want a bargraph, not a timeseries? [23:48:10] Let me know what you think. This is just a first stab, and I'm open to other ways to display the main events. [23:49:11] fabriceflorin: If there's something that needs to be a separate card, please make it a separate card instead of putting it in the list of things for this card [23:49:13] I am not sure that a time series is necessarily useful to us right now, though if it's easier to do, that would work for me too (seconds on the vertical axis, days on the horizontal axis). [23:49:40] It's "easier" in some respects but if the ordinal is more helpful then I can do it [23:49:45] rdwrer: Before creating a lot of cards, I first wanted to find out from you what is easy and what is hard. [23:50:02] Adding instrumentation for connection speed is definitely Hard. [23:50:27] rdwrer: Cool. Then I will create a separate card for the connection speed. [23:51:29] fabriceflorin: Also, note that you're having me create five different columns and at least seven different graphs, so 45 total select queries roughly [23:51:34] It's gonna be a bit of busywork :) [23:52:53] If you like, you can begin with the first few dashboards (up to and including image sizes), then we can pause and review those before doing the rest. [23:53:18] 'kay [23:54:11] I think the key events are all important: thumbnail > media viewer open > server request > server response > blurred thumbnail > full image. [23:55:48] But I am not certain that they are exactly in that sequence. And one might argue that the media viewer open or the blurred thumbnail may be better tracked in a separate graph, so we focus on the key sequence: user request > server request > server response > full image. [23:56:44] So I am open to your thoughts on this, and more interested in getting something up and running quickly for team review, before finalizing the spec. [23:58:32] As for the bar graph vs. line graph question, there is an advantage in visualizing the respective lengths of time each process takes. But if it's faster for you to start with a line graph, that's OK with me for now. We can then get some team / community feedback and tweak as needed. [23:59:17] Ordinal is harder, but not by that much