[00:01:00] (03PS14) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [08:18:49] (03CR) 10Gergő Tisza: [C: 032] Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [08:37:28] (03CR) 10Gergő Tisza: "I don't see more problems with the code. If you don't plan more changes, please remove the remaining console.log commands, and I will merg" (031 comment) [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty) [09:09:40] (03Merged) 10jenkins-bot: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [10:18:21] (03Abandoned) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 (owner: 10Inchikutty) [10:19:32] (03Abandoned) 10Inchikutty: [WIP]UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 (owner: 10Inchikutty) [10:51:30] (03PS15) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [10:54:33] (03PS16) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [12:58:55] (03CR) 10Nikerabbit: "Even if this is in a branch, you should still follow coding conventions. There are many whitespace issues which will need to be fixed befo" [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 (owner: 10Inchikutty) [17:23:00] tgr: https://gerrit.wikimedia.org/r/117624 was there a problem in the review or are we just waiting to see if the other patch fixes it? [17:24:25] no, i just didn't get around to test it since my working copy was all messed up [17:24:29] i'll do it now [17:28:58] 'kay cool [17:34:21] (03CR) 10Gergő Tisza: [C: 032] Loads of fix-ups to our module definitions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [17:34:23] (03CR) 10jenkins-bot: [V: 04-1] Loads of fix-ups to our module definitions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [17:54:22] (03CR) 10Gergő Tisza: [C: 04-1] "A global declaration is missing." (032 comments) [extensions/MultimediaViewer] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117374 (owner: 10MarkTraceur) [17:59:13] (03CR) 10Gergő Tisza: "Also, shouldn't it skip the BetaFeatures hook when it is not in beta?" [extensions/MultimediaViewer] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117374 (owner: 10MarkTraceur) [18:02:21] (03PS3) 10Gergő Tisza: [WIP] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 [18:03:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [18:17:48] (03PS17) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 [18:25:57] (03PS4) 10Gergő Tisza: [WIP] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 [18:26:40] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [18:38:42] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [18:55:33] (03PS5) 10Gergő Tisza: [WIP] Handle image loading rejections [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 [19:01:05] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116629 (owner: 10Gergő Tisza) [19:01:56] (03CR) 10Gergő Tisza: [C: 032] Do not add icons to media viewer image list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117337 (owner: 10MarkTraceur) [19:02:28] (03Merged) 10jenkins-bot: Do not add icons to media viewer image list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117337 (owner: 10MarkTraceur) [19:11:39] (03PS2) 10Gergő Tisza: Loads of fix-ups to our module definitions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [19:12:18] (03CR) 10jenkins-bot: [V: 04-1] Loads of fix-ups to our module definitions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [19:15:32] (03PS3) 10Gergő Tisza: Loads of fix-ups to our module definitions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [19:56:18] (03CR) 10Gergő Tisza: [C: 032] Loads of fix-ups to our module definitions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [19:56:52] (03CR) 10jenkins-bot: [V: 04-1] Loads of fix-ups to our module definitions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [19:57:36] (03CR) 10Gergő Tisza: [C: 032] UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty) [19:57:46] (03Merged) 10jenkins-bot: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130 (owner: 10Inchikutty) [21:08:46] (03PS3) 10Aarcos: Split share class into dialog and content tabs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [21:08:48] (03PS20) 10Aarcos: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [21:09:25] (03CR) 10jenkins-bot: [V: 04-1] Split share class into dialog and content tabs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117473 (owner: 10Gergő Tisza) [21:10:00] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [21:27:51] (03CR) 10Gergő Tisza: "Retrying after segfault." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [21:31:55] jsduck segfauling is bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60138 [21:32:30] there is a workaround there iirc [21:32:54] (03PS4) 10MarkTraceur: Add feature flags for Media Viewer [extensions/MultimediaViewer] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117374 [21:56:04] (03CR) 10Gergő Tisza: "Like this, then, maybe." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [21:56:09] (03CR) 10Gergő Tisza: [C: 032] Loads of fix-ups to our module definitions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [21:56:52] (03Merged) 10jenkins-bot: Loads of fix-ups to our module definitions [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [21:58:42] (03CR) 10Gergő Tisza: [C: 031] Add feature flags for Media Viewer [extensions/MultimediaViewer] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117374 (owner: 10MarkTraceur) [22:03:11] (03CR) 10Gergő Tisza: "Is this intentionally on the wmf branch?" [extensions/MultimediaViewer] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117374 (owner: 10MarkTraceur) [22:31:20] wb gi11es [22:31:38] thanks :)