[00:24:26] tgr_: So DarTar and I chatted about metrics, and the only reason I can think of that we're missing events (which is the hypothesis now) is that the full viewer wasn't loaded during bootstrapping, and the EventLogging stuff was only marked as a dependency for 'mmv', not 'mmv.logger', which is silly. [00:24:31] https://gerrit.wikimedia.org/r/117624 should fix that [00:24:42] It'd be super to get that in so next week's metrics will make sense again [00:25:25] i see [00:26:03] I cleaned up most of the dependency mistakes I saw too [00:26:19] Just because proper housekeeping is good, especially since we don't often touch that part of the code [00:26:47] (03PS10) 10Gergő Tisza: Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 [00:27:02] definitely [00:27:39] i was thinking of splitting it out to one php file per resource directory since it is pretty impossible to keep track of now [00:27:46] Yeah [00:27:48] only i don't know if it is cached [00:27:49] That may be better [00:28:03] tgr: If what is cached? [00:28:24] the hook which gets the dependencies [00:28:44] 3-4 extra file access per page load would not be nice [00:28:46] (I was actually thinking of writing a few functions to do this stuff for us so we can make a prettier, easier-to-follow list of modules) [00:28:55] Hm, true [00:36:04] (03CR) 10Gergő Tisza: "Is this commit housekeeping only or is it supposed to fix something about eventlogging? As far as I can see it does not change when eventl" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [00:38:16] (03CR) 10MarkTraceur: "My current running theory (mostly due to lack of any better ideas) is that there was a race condition, but I'm not really sure about that." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [00:38:52] (03CR) 10Gergő Tisza: "The bootstrap dependency was only added last Friday in I8fa0d286997a27b46d2d0506513254694c1927ec and wasn't deployed until yesterday, mayb" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [00:39:29] (03CR) 10MarkTraceur: "That....might do it." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117624 (owner: 10MarkTraceur) [00:40:48] tgr: That might explain why the mediawikiwiki graph is looking better the past two days [00:42:12] is it looking better or just different? [00:42:21] Slightly better [00:42:30] i'm not sure more close than open makes more sense than more open than close [00:42:51] ideally i would expect them to be pretty close [00:43:00] Other way around [00:43:01] But [00:43:05] Yeah, it's close on mw.org now [00:43:23] I expect something like 15-30% of people will use escape consistently [00:43:41] Like meeee [00:43:55] oh i see, i was looking at the aggregate stats [00:44:26] would be nice to have an event for all possible open/close methods though [00:45:08] Yeah [00:45:17] DarTar said we should log impressions instead of clicks [00:45:21] btw i am a bit surprised no one complained yet about the several dozen log requests per page [00:45:21] But meh, work, and unscheduled [00:45:26] Haha [00:45:37] there should be a way to batch them [00:45:40] Maybe [00:45:45] ori may have thoughts [00:46:05] But really, if there are multiple events for the same action then maybe they shouldn't be different events [00:46:23] stash in localstorage, send on beforeunload [00:46:27] Sure [00:46:34] Will slow down unload [00:46:41] But whatever, people can deal with it [00:46:50] Wait, localstorage? Why not just memory? [00:47:01] logger.events = [] [00:47:08] logger.events.push( event ); [00:47:19] so you can log it on next page load if the sending didn't work out [00:47:23] Ahhh. [00:47:30] might be unnecessary [00:47:33] Probably [00:48:15] are the thumbnail requests logged in squid? [00:48:33] that would be the most useful stat for us imo [00:48:51] see how much image views go up once MMV is enabled [00:49:16] Heh, maybe [00:49:23] But "thumbnail request" !== image view [00:49:27] It could be a preload [00:50:17] true [00:50:35] Or a prerender if we do that sort of thing [00:50:54] even so, having the same setup for images that Domas'/Henrik's tool has for wiki pages would be cool [00:51:09] glam people would be happy too [00:53:20] What's the tool? [00:57:29] http://stats.grok.se/ [00:57:38] Ah. [01:10:19] (03CR) 10MarkTraceur: [C: 031] Some refactoring to get LightboxInterface closer to a proper UI component (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [01:10:26] tgr: Is ^^ ready to merge? [01:10:45] I could wait for more input but aarcos is buried neck-deep in tests and gi11es is the proud papa [01:12:35] yes [01:13:34] Coolio [01:13:47] gi11es +2-d it at some point but it wasn't merged because of some dependency issue [01:13:48] (03CR) 10MarkTraceur: [C: 032] "Leeeerooooooooy" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [01:14:05] Next, the dependent commit! [01:14:08] (03PS4) 10Gergő Tisza: Merge MultiLightbox into LightboxInterface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116921 [01:14:22] (03Merged) 10jenkins-bot: Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [01:51:03] (03CR) 10Aarcos: [C: 032] Merge MultiLightbox into LightboxInterface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116921 (owner: 10Gergő Tisza) [01:51:42] (03CR) 10Aarcos: [C: 031] Add checkered background to make black-on-transparent images visible [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117090 (owner: 10Gergő Tisza) [01:51:51] (03CR) 10Aarcos: [C: 032] Add checkered background to make black-on-transparent images visible [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117090 (owner: 10Gergő Tisza) [01:54:29] (03Merged) 10jenkins-bot: Merge MultiLightbox into LightboxInterface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116921 (owner: 10Gergő Tisza) [01:55:07] (03Merged) 10jenkins-bot: Add checkered background to make black-on-transparent images visible [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117090 (owner: 10Gergő Tisza) [02:49:51] (03PS1) 10Gergő Tisza: Extract embed formatting into separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117639 [02:49:53] (03CR) 10jenkins-bot: [V: 04-1] Extract embed formatting into separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/117639 (owner: 10Gergő Tisza) [22:02:23] (03PS10) 10Inchikutty: UploadWizard: OSM embedding: Geocoding, reverse geocoding [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116130