[00:00:31] #54: (MH) S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/54 [00:01:17] fabriceflorin: Trying to coordinate metrics plans with analytics - on a scale of 1-10, how critical is it that we get metrics dashboards and how does that number change over the next two weeks? [00:04:17] rdwrer: Having metrics is a high priority before deployment to any large wiki (on the order of 10), because we can't be flying blind. It's a bit less important for smaller wikis like MediaWiki.org (8 out of 10), but if we're going do this anyway, might as well debug it on MediaWiki.org. We now are planning to deploy on MW.org April 10 - and do large wiki deployments around mid-April (starting with Commons, then Frwiki, then Enwiki). [00:05:16] fabriceflorin: I should clarify [00:05:25] fabriceflorin: We *will have data*, because we have data now [00:05:25] rdwrer: Who are you working with in Analytics? Can I help organize things with them? [00:05:34] fabriceflorin: Having the graphs is a separate issue [00:05:41] We're in -analytics talking [00:05:47] But I can handle it [00:05:54] It's just a matter of sorting out what path I want to take [00:06:04] rdwrer: Yes, but data is not useful if you cannot analyze it and share it with the community. The dashboards help make that possible. [00:07:23] OK, sounds good. I guess my point is that this is a high priority for the project. Thanks for taking that in consideration, and please let me know how I can help. [00:08:17] fabriceflorin: 1-10 scale. [00:08:20] For right now. [00:08:37] Assuming for the moment that we deploy to mw.org on the 20th, I guess, unless we've decided absolutely that's impossible [00:10:13] rdwrer: We already discussed moving back the deploy to MediaWiki.org deployment to April 10th. I don't think you should unilaterally change the dates without discussing with the team. [00:14:20] For clarity's sake - we had discussed going on the 20th but then decided it might be unrealistic and considered April 10th another option. [00:14:33] I had not until now heard that we had absolutely made that decision [00:14:40] Only that we had speculated [00:30:42] (03PS3) 10MarkTraceur: Add events for image views and "use this file" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116072 (owner: 10Gilles) [00:43:47] (03CR) 10MarkTraceur: [C: 032] Add events for image views and "use this file" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116072 (owner: 10Gilles) [00:43:51] Chaaaarge [00:44:22] (03Merged) 10jenkins-bot: Add events for image views and "use this file" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116072 (owner: 10Gilles) [00:49:46] (03CR) 10MarkTraceur: [C: 032] "Sure." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116079 (owner: 10Gilles) [00:50:22] (03Merged) 10jenkins-bot: Add test for clicking prev/next [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116079 (owner: 10Gilles) [00:59:11] (03PS1) 10Gergő Tisza: Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 [00:59:43] (03CR) 10jenkins-bot: [V: 04-1] Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [01:35:13] (03CR) 10MarkTraceur: [C: 032] Add rejection logging to providers [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116628 (owner: 10Gergő Tisza) [01:35:49] (03Merged) 10jenkins-bot: Add rejection logging to providers [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116628 (owner: 10Gergő Tisza) [01:47:20] #277: (GT) O:GT|S:ID|R:#MVv-PR|I:#F2-S4|T:SI( Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/277 [01:50:22] (03CR) 10Gergő Tisza: "I think this works, but the tests fail because of the global viewer objects which randomly picks up events triggered in unrelated tests, A" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [02:06:22] (03PS1) 10Aarcos: Fix resize issues (Part III, Fin) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116685 [02:07:00] (03CR) 10jenkins-bot: [V: 04-1] Fix resize issues (Part III, Fin) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116685 (owner: 10Aarcos) [02:24:31] (03PS2) 10Aarcos: Fix resize issues (Part III, Fin) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116685 [02:26:12] (03CR) 10Aarcos: "Address your comments in https://gerrit.wikimedia.org/r/#/c/116685/" (0310 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115678 (owner: 10Aarcos) [02:45:19] #239: (AA) https://gerrit.wikimedia.org/r/#/c/116685/ S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/239 [03:28:33] (03PS1) 10Vikassy: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116707 [03:39:18] (03PS1) 10Vikassy: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/116711 [08:25:28] (03CR) 10Gilles: Test to check that events are not trapped after the viewer is closed (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 (owner: 10Gilles) [08:28:04] (03PS3) 10Gilles: Test to check that events are not trapped after the viewer is closed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 [08:28:40] (03CR) 10jenkins-bot: [V: 04-1] Test to check that events are not trapped after the viewer is closed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 (owner: 10Gilles) [08:29:09] (03PS4) 10Gilles: Test to check that events are not trapped after the viewer is closed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 [08:30:19] #232: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... DTS:0M2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [08:30:43] (03CR) 10Gilles: [C: 032] Test to check that events are not trapped after the viewer is closed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 (owner: 10Gilles) [08:31:17] (03Merged) 10jenkins-bot: Test to check that events are not trapped after the viewer is closed [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116470 (owner: 10Gilles) [08:31:19] #232: (GD) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/232 [08:33:19] #274: (GD) DDE:0M2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/274 [08:33:19] #274: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... DTS:0M2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/274 [08:35:19] #145: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... DTS:0M2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/145 [09:24:20] #277: (GD) The point of having events that don't have to b... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/277 [09:51:07] (03CR) 10Gilles: [C: 04-1] "The issue isn't with the instances you create in the tests, it's with the global mw.mmv.mediaViewer instance that exists no matter what. T" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [09:51:20] #278: (GD) P:Mh|S:ID|R:#MVv-PR|T:Td Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/278 [09:51:20] #278: (GD) I:#F2-S4 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/278 [09:51:20] #278: (GD) O:GD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/278 [11:04:18] (03PS1) 10Gilles: Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 [11:05:02] (03CR) 10jenkins-bot: [V: 04-1] Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [11:29:01] (03PS2) 10Gilles: Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 [11:29:36] (03CR) 10jenkins-bot: [V: 04-1] Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [11:30:19] #278: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/278 [11:36:31] (03PS1) 10Gilles: Useless change to check jenkins+qunit sanity [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116734 [11:36:33] (03CR) 10jenkins-bot: [V: 04-1] Useless change to check jenkins+qunit sanity [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116734 (owner: 10Gilles) [11:38:18] (03PS2) 10Gilles: Useless change to check jenkins+qunit sanity [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116734 [11:40:05] (03Abandoned) 10Gilles: Useless change to check jenkins+qunit sanity [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116734 (owner: 10Gilles) [11:51:56] (03PS3) 10Gilles: Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 [11:51:58] (03CR) 10jenkins-bot: [V: 04-1] Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [12:29:59] (03PS4) 10Gilles: Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 [12:32:28] I've just discovered the jenkins double-whammy: it seems like jenkins will automerge locally before running the tests [12:33:08] so you can end up with failures in the tests being run by jenkins, because the changeset is incompatible with the latest from master (without merge conflict) [12:34:23] bottom line is, we really need to set this up differently, unless your commit happens to be based on the latest one on master, jenkins doesn't run what we run when we have the changeset applied locally [12:34:57] (03CR) 10Gilles: "Done: https://gerrit.wikimedia.org/r/116731 if you rebase this changeset on that one, the test overlap issue should go away entirely. I th" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [12:42:20] #277: (GD) Since #278 is done now, I'd argue that this cha... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/277 [12:57:50] (03PS2) 10Gilles: Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [12:58:25] (03CR) 10jenkins-bot: [V: 04-1] Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [13:00:52] (03PS3) 10Gilles: Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [13:01:24] (03CR) 10jenkins-bot: [V: 04-1] Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [13:01:52] (03PS4) 10Gilles: Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [13:03:22] (03CR) 10Gilles: [C: 032] "Works perfectly now that it's rebased. Great changeset, btw, I'm glad that we're getting rid of passing the viewer." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 (owner: 10Gergő Tisza) [13:06:25] #178: (GD) B:B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/178 [14:46:58] (03PS5) 10Gilles: Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 [14:47:37] (03CR) 10jenkins-bot: [V: 04-1] Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [14:48:54] (03PS6) 10Gilles: Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 [14:51:09] (03CR) 10Gilles: "FYI, the purpose of "autostart" is that it's not included in the tests' dependencies." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [17:18:07] (03CR) 10Aarcos: "Comments + maybe some tests where providers are chained and failure happens?" (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116628 (owner: 10Gergő Tisza) [17:27:57] #270: (RL) I concur with Fabrice on this one. I think we ... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/270 [17:28:57] #260: (AA) All these calculations are now under ThumbnailW... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/260 [17:29:57] #260: (AA) O:AA|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/260 [17:29:57] #260: (AA) See previous comment. S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/260 [17:42:02] (03PS5) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] (osm) - 10https://gerrit.wikimedia.org/r/116129 [18:34:58] #279: (MH) S:IA|T:T Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/279 [18:50:50] gi11es: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/198 we already have all of this data, right? [18:50:57] #54: (MH) B:B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/54 [18:57:11] I assume yes [18:57:57] #198: (MH) B:B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/198 [19:01:58] #54: (MH) I've blocked this because we're waiting on a st... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/54 [19:01:58] #198: (MH) I've blocked this because we're waiting on a st... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/198 [19:02:02] (03PS5) 10Gergő Tisza: Some refactoring to get LightboxInterface closer to a proper UI component [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116675 [19:08:34] (03CR) 10Aarcos: [C: 04-1] "There are quiet a few tests missing, in particular for the mmv.ui.fileEmbed.js component, I will work on that !, ;-)." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [19:08:58] #197: (F) Hi guys, thanks for fixing the broken permissio... S:A Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/197 [19:08:58] #148: (AA) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [19:09:58] #147: (AA) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/147 [19:19:58] #8: (e) PC:0 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/8 [19:28:58] #277: (GT) Thanks for doing #278! That was the main motiva... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/277 [19:31:40] (03PS1) 10Gergő Tisza: [WIP] make event passing between lightbox and viewer non-global [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116781 [19:31:58] #277: (GT) https://gerrit.wikimedia.org/r/116781 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/277 [19:32:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] make event passing between lightbox and viewer non-global [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116781 (owner: 10Gergő Tisza) [19:42:59] #280: (AA) P:Sh|S:IA|R:#MVv-PR|T:Td Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/280 [20:02:22] (03CR) 10Gergő Tisza: "Ahh. So good to see all those globals go!" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [20:42:28] (03CR) 10Gilles: "Go ahead and do those changes, I'm already OOO" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [20:47:32] errrrr [20:47:33] http://multimedia-alpha.wmflabs.org/w/index.php?title=Main_Page&diff=149868&oldid=26 [20:47:41] http://multimedia-alpha.wmflabs.org/wiki/Special:RecentChanges [20:47:44] the whole wiki is trash [20:47:53] rdwrer: ^ [20:55:16] Hahahaha [20:55:31] legoktm: We can probably safely nuke it, nothing special in the DB, just the lightbox demo [20:55:39] do it :D [20:58:20] Hm, except for users. [20:58:30] I'll tell folks [20:59:19] legoktm: Is there some magic we should perform to avoid this in the future? [20:59:32] install SpamBlacklist [21:00:06] also https://www.mediawiki.org/wiki/Extension:StopForumSpam if you just don't want to deal with it :) [21:30:39] legoktm: I guess I'll do that at the same time as our migration [21:30:52] And my other migrations [21:30:55] Ugh other projects [22:19:57] #74: (F) Hi Pau, we agreed to postpone this task until w... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/74 [22:19:58] #74: (F) R:#MQ-R1|I:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/74 [22:58:58] #281: (F) S:IA|P:Ch|R:#MVv-PR|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/281 [23:31:59] (03CR) 10Gergő Tisza: "Oh, sorry, forgot about that. Good luck and all that!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [23:45:39] (03PS7) 10Gergő Tisza: Get rid of global viewer instance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [23:46:52] (03CR) 10Gergő Tisza: [C: 031] "LGTM, but I made some changes so someone else should do the final review." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/116731 (owner: 10Gilles) [23:50:58] #277: (GT) I:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/277