[04:49:51] (03CR) 10Gergő Tisza: [C: 031] "Everything works now. This will be good for prototyping; before it gets merged, some UX issues need to be solved:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 (owner: 10Inchikutty) [04:50:47] (03CR) 10Gergő Tisza: "One more thing for this patchset: could you make "OpenStreetMap" in the " Map data by OpenStreetMap contributors" link to the OSM website?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 (owner: 10Inchikutty) [05:28:00] (03CR) 10Gergő Tisza: "I realize this is still WIP, but a few comments about the UI:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 (owner: 10Inchikutty) [05:58:40] (03CR) 10Prtksxna: [C: 04-1] "Check out the MediaWiki code conventions for CSS and JS" (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [06:00:33] (03CR) 10Gergő Tisza: "Let's kill it. Unit tests should just work without knowing much about the details of how the test framework is set up. Maybe we can create" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [06:01:40] (03PS8) 10Gergő Tisza: Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 [06:02:40] (03CR) 10jenkins-bot: [V: 04-1] Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [06:12:33] (03CR) 10Prtksxna: [C: 04-1] "Check out the MediaWiki code conventions for JS - https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript" (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 (owner: 10Inchikutty) [06:13:37] (03CR) 10Aarcos: [C: 04-1] "First pass, just small suggestions on some tests, otherwise is looking good." (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [06:29:35] (03CR) 10Gergő Tisza: "Still times out after removing the external file test, and I still cannot reproduce locally..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [06:36:50] (03CR) 10Aarcos: Use cross-origin img attribute instead of data URI (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [06:37:41] (03CR) 10Aarcos: Use cross-origin img attribute instead of data URI (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [06:43:16] (03CR) 10Aarcos: "Maybe the part that's failing is the local case (/favicon.ico)? I remember I tried to use a local image when I wrote the first load test b" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [07:04:51] (03CR) 10Gergő Tisza: [C: 04-1] "Fails to load the first clicked image for me (it is either small or completely missing). Every later action works fine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114728 (owner: 10Gilles) [07:08:13] (03PS9) 10Gergő Tisza: Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 [07:08:56] (03CR) 10jenkins-bot: [V: 04-1] Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [07:20:20] (03CR) 10Gergő Tisza: "Indeed that is the case. (In reflection, it makes sense - /favicon.ico has to be set up as a separate apache redirect rule, that probably " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [07:33:08] (03PS7) 10Gilles: Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 [07:34:04] (03PS8) 10Gilles: Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 [07:56:06] (03PS10) 10Gergő Tisza: Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 [08:00:36] (03PS11) 10Gergő Tisza: Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 [08:01:38] (03PS9) 10Gergő Tisza: Show permission [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 [08:02:14] (03CR) 10jenkins-bot: [V: 04-1] Show permission [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 (owner: 10Gergő Tisza) [08:18:18] #242: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/242 [08:43:57] (03CR) 10Gergő Tisza: [C: 032] "This is probably caused by the original lazy-load patch, I get it for other patchsets as well. This patch does not make the situation wors" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114728 (owner: 10Gilles) [08:44:33] (03CR) 10jenkins-bot: [V: 04-1] Fixes hash handling issues [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114728 (owner: 10Gilles) [08:45:09] (03PS6) 10Gilles: Fixes hash handling issues [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114728 [08:48:19] (03CR) 10Gergő Tisza: [C: 032] "Test segfaulted, resubmitting." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114728 (owner: 10Gilles) [08:48:52] (03Merged) 10jenkins-bot: Fixes hash handling issues [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114728 (owner: 10Gilles) [09:22:24] (03CR) 10Gilles: "Found the cause: the mmv was reacting to hash changes it initiated itself, resulting in a double-load. Since all API requests are cached i" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114728 (owner: 10Gilles) [09:23:03] well, should have looked at my irc window... [09:23:51] I've fixed the bug, tgr, see comment [09:24:38] I'll upload the changeset once I've rebased it in a sec [09:25:08] i'm pretty sure the bug existed before the hash patchset [09:25:31] or the old lazy-load patch already called hash() twice? [09:30:17] I think it's always called hash on itself, it's just that with different timing it wouldn't cause a visible bug [09:32:05] maybe that's not the bug either, in fact, and fixing the double-hash handling is just something that affects timing again :) [09:32:25] it seemed wrong to me anyway that updating the hash as part of an image load triggers the same image load again [09:32:56] even if things are cached in the providers, it's asking for trouble on the UI side [09:35:02] I definitely can't trigger the thing you describe anymore with that latest change anyway [09:35:29] (03PS1) 10Gilles: Fixes hash self-reaction [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 [09:37:18] #254: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/254 [09:38:17] #254: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/254 [09:43:26] (03PS10) 10Gergő Tisza: Show permission [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 [09:44:00] tgr: why not use enwiki's favico or a similar external image to test non-cors? [09:44:45] oh, you turned it into local-only requests, alright [09:45:01] i don't like using external images [09:45:20] people will run the tests behind a firewall, or on an airplane, or whatever [09:45:31] and then they have to figure out why they break [09:45:54] (03CR) 10Gilles: [C: 032] Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [09:47:00] (03Merged) 10jenkins-bot: Use cross-origin img attribute instead of data URI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114403 (owner: 10Gergő Tisza) [09:47:44] (03CR) 10Gergő Tisza: [C: 04-1] "This messes up the page height somehow, scrolling does not stop when it reaches bottom of the metadata box." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 (owner: 10Gergő Tisza) [09:49:18] #234: (GD) DDE:2F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/234 [09:55:18] #234: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... O:GD|DTS:2F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/234 [09:55:18] #118: (GD) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118 [10:02:37] (03CR) 10Gergő Tisza: [C: 031] "Looks good. I still see the bug with loading the first image, though." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 (owner: 10Gilles) [10:04:37] (03CR) 10Gilles: "I think that bug is unrelated to all this stuff" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 (owner: 10Gilles) [10:05:08] (03CR) 10Gilles: "If it's persistent anyway. Like I mentioned on IRC, I think it's timing-related, a race condition of some kind, so any change might influe" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 (owner: 10Gilles) [10:07:50] (03CR) 10Gergő Tisza: "Definitely unrelated. I only held the +2 back in case Aaron wants to look at this (I only skimmed the tests)." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 (owner: 10Gilles) [10:39:52] (03CR) 10Gergő Tisza: Blurred thumbnail preview + progress bar (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [13:11:08] (03PS19) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [13:23:21] (03PS14) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [13:38:28] (03PS9) 10Gilles: Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 [13:38:30] (03CR) 10jenkins-bot: [V: 04-1] Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [13:38:51] (03CR) 10Gilles: Blurred thumbnail preview + progress bar (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [14:33:05] (03PS10) 10Gilles: Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 [14:35:01] (03PS1) 10Gilles: Better way to detect CORS support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115166 [14:35:34] (03CR) 10jenkins-bot: [V: 04-1] Better way to detect CORS support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115166 (owner: 10Gilles) [14:36:29] (03PS2) 10Gilles: Better way to detect CORS support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115166 [14:37:01] (03CR) 10jenkins-bot: [V: 04-1] Better way to detect CORS support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115166 (owner: 10Gilles) [14:43:15] (03PS3) 10Gilles: Better way to detect CORS support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115166 [15:30:15] alright, I've solved the chrome bug mystery (ending up with a small image) [15:31:07] to make the image fit in the lightbox some measuring is done in JS, checking the width, height of the image wrapper [15:33:21] the problem is that on chrome, mw.loader things it's done when it's not. i.e. it resolves its deferred too early. either it's premature altogether, or it's resolving when it adds the CSS to the page, not when said CSS has been interpreted by the browser [15:34:09] *think it's done [15:35:13] as a result, by the time JS tries to measure the size of the wrapper, it's CSS hasn't been applied to it yet [15:40:59] so, it's a bug/design flaw in ResourceLoader [15:43:01] it should be appending a rule to the end of the CSS injected into the page and waiting for that rule to be interpreted. and on the JS side it should insert some function call at the end of the injected JS [15:43:20] as far as I can see it's not doing either [15:45:44] although it seems like it doesn't need to for JS when injecting after domready since it uses onload in that case, which is probably truthful [15:46:59] yeah, CSS seems like just inserting elements to the head, which won't even account for the time it takes to download the stylesheet [15:47:11] that explains why the bug is so common in chrome [15:47:30] I'll check rollup order, if it's consistent then I should be able to wait in mmv.bootstrap for a specific rule at the end of the last file to be loaded [15:55:09] it also expains why I'd sometimes see messed up UI in chrome flashing [16:41:37] (03CR) 10Jhall: [C: 032] Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114922 (owner: 10Zfilipin) [16:42:19] (03CR) 10jenkins-bot: [V: 04-1] Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114922 (owner: 10Zfilipin) [16:46:21] (03PS3) 10Zfilipin: Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114922 [16:47:40] (03CR) 10jenkins-bot: [V: 04-1] Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114922 (owner: 10Zfilipin) [16:52:15] (03CR) 10Aarcos: [C: 031] Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114922 (owner: 10Zfilipin) [17:01:18] #258: (GD) O:GD|P:Mh|S:ID|R:#MQ-R2|I:#F2-S3|T:SI( Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/258 [17:06:29] (03PS1) 10Gilles: Wait for CSS to be truly loaded before opening the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115196 [17:07:03] (03CR) 10jenkins-bot: [V: 04-1] Wait for CSS to be truly loaded before opening the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115196 (owner: 10Gilles) [17:07:12] (03CR) 10Cmcmahon: [C: 032] Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114922 (owner: 10Zfilipin) [17:07:17] #258: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/258 [17:07:45] (03Merged) 10jenkins-bot: Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114922 (owner: 10Zfilipin) [17:09:05] (03PS2) 10Gilles: Wait for CSS to be truly loaded before opening the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115196 [17:12:10] (03CR) 10Gilles: "Gergő, I believe this is the fix for the elusive Chrome bug you were experiencing. The image wrapper's height was incorrectly measured whe" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115196 (owner: 10Gilles) [17:13:18] #258: (GD) https://gerrit.wikimedia.org/r/115196 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/258 [17:32:05] Haha [17:41:20] (03CR) 10Aarcos: Fixes hash handling issues (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/114728 (owner: 10Gilles) [17:55:18] Wow @ gry's post to Multimedia-l [17:55:33] Interesting stuff [17:56:50] :) [18:02:21] (03CR) 10Aarcos: [C: 031] "LGTM, +2 at your convenience." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 (owner: 10Gilles) [18:13:37] (03PS2) 10Gilles: Fixes hash self-reaction [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 [18:14:21] (03CR) 10jenkins-bot: [V: 04-1] Fixes hash self-reaction [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 (owner: 10Gilles) [18:15:00] (03PS3) 10Gilles: Fix hash self-reaction [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 [18:15:57] (03CR) 10Gilles: [C: 032] Fix hash self-reaction [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 (owner: 10Gilles) [18:16:30] (03Merged) 10jenkins-bot: Fix hash self-reaction [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115129 (owner: 10Gilles) [18:25:18] #199: (F) P:Mh -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/199 [19:06:57] (03PS4) 10Gergő Tisza: Better way to detect CORS support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115166 (owner: 10Gilles) [19:12:35] (03CR) 10Gergő Tisza: [C: 032] "Clarified in the jsdoc what the feature detection is meant to check exactly. I'm not sure checking for CORS support is a good test for tha" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115166 (owner: 10Gilles) [19:13:09] (03Merged) 10jenkins-bot: Better way to detect CORS support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115166 (owner: 10Gilles) [19:24:17] (03CR) 10Gergő Tisza: [C: 032] "Wow that must have been nasty to debug." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115196 (owner: 10Gilles) [19:24:19] (03CR) 10jenkins-bot: [V: 04-1] Wait for CSS to be truly loaded before opening the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115196 (owner: 10Gilles) [19:29:36] (03PS3) 10Gergő Tisza: Wait for CSS to be truly loaded before opening the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115196 (owner: 10Gilles) [19:29:51] (03CR) 10Gergő Tisza: [C: 032] Wait for CSS to be truly loaded before opening the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115196 (owner: 10Gilles) [19:30:39] (03Merged) 10jenkins-bot: Wait for CSS to be truly loaded before opening the viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/115196 (owner: 10Gilles) [19:34:18] #254: (GT) DDE:2F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/254 [19:34:18] #258: (GT) DDE:2F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/258 [19:45:13] (03CR) 10Gergő Tisza: Blurred thumbnail preview + progress bar (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [20:17:56] (03CR) 10Aarcos: [C: 04-1] "I think there is an issue while handling "real" vs "css" units? Some other details with the tests." (039 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [20:57:36] (03Restored) 10Hashar: validate jenkins jobs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/36974 (owner: 10Hashar) [20:57:41] (03PS2) 10Hashar: validate jenkins jobs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/36974 [21:07:23] (03PS1) 10Hashar: flag API tests with @medium [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115272 [21:07:27] (03PS1) 10Hashar: Typo TesVideoTranscode -> TestVideoTranscode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115273 [21:08:27] tgr_: it's actually the 3rd time I catch that bug in my career (dynamic asset loader not waiting for CSS to be truly loaded), but just like the previous times it took hours of debugging to figure out that's what was happening :) [21:09:46] (03PS2) 10Hashar: flag API tests with @medium [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115272 [21:20:31] (03Abandoned) 10Hashar: validate jenkins jobs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/36974 (owner: 10Hashar) [21:21:42] ah hello :-] [21:21:56] we have so many channels [21:22:10] hashar: Mais bien sur! [21:22:19] hashar: What's up? [21:22:26] I filled a bug for TimedMediaHandler, its tests are failing :( [21:22:34] Aw, hm [21:22:42] and it is now a dependency for CirrusSearch extension so CirrusSearch is failing as well now :]] [21:23:00] hashar: phpunit tests? [21:23:10] yeah I have enabled them for TimedMediaHandler :] [21:23:21] they were not enabled because the extension depends on MwEmbedSupport [21:23:41] and I had no support to declare dependencies until a few months ago [21:23:56] some tests are simple warnings reported by mediawiki so are easily fixed https://gerrit.wikimedia.org/r/#/c/115272/ [21:24:19] but then I still have four tests failing and no clue what is wrong ( https://integration.wikimedia.org/ci/job/mwext-TimedMediaHandler-testextensions-master/5/console ) [21:24:24] I assume there are bugs filed? [21:24:39] ah yeah filled https://bugzilla.wikimedia.org/show_bug.cgi?id=61875 :-] [21:24:53] so was merely wondering whether I should just @broken the currently failing tests [21:25:02] then fill bug for each of them to make sure they get fixed [21:25:46] I think that's an OK plan [21:25:52] I've added mdale on the bug [21:25:56] \O/ [21:26:03] * hashar fills bugs [21:28:57] files* :) [21:36:33] (03PS1) 10Hashar: Ignore TestVideoThumbnail::testApiThumbnails [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115303 [21:36:39] (03PS1) 10Hashar: Ignore TestVideoTranscode::testTranscodeJobs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115304 [21:36:58] if that last job pass, we can get everything merged :] [21:37:06] *nod* [21:37:10] and they pass [21:37:17] so I filled a different bug for each test failling [21:37:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=61877 [21:37:24] https://bugzilla.wikimedia.org/show_bug.cgi?id=61878 [21:37:37] and a trackign bug https://bugzilla.wikimedia.org/show_bug.cgi?id=61875 :-] [21:37:41] (03PS2) 10Hashar: Typo TesVideoTranscode -> TestVideoTranscode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115273 [21:37:55] (03PS2) 10Hashar: Ignore TestVideoThumbnail::testApiThumbnails [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115303 [21:37:57] Arrrghhhhh [21:38:00] (03PS2) 10Hashar: Ignore TestVideoTranscode::testTranscodeJobs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115304 [21:38:01] sorry :( [21:38:09] Gerrit is in so much trouble with me right now [21:38:11] No not you [21:38:20] I will destroy Gerrit [21:38:30] yeah there is a plan for it [21:38:51] phabrication or something like that [21:39:03] Yeah, that will be better I think [21:39:18] I am not volunteering to write the PHabricator / Zuul glue though :] [21:39:42] (03CR) 10MarkTraceur: [C: 032] flag API tests with @medium [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115272 (owner: 10Hashar) [21:39:45] True [21:39:51] (03Merged) 10jenkins-bot: flag API tests with @medium [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115272 (owner: 10Hashar) [21:40:09] (03CR) 10MarkTraceur: [C: 032] Typo TesVideoTranscode -> TestVideoTranscode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115273 (owner: 10Hashar) [21:40:18] (03Merged) 10jenkins-bot: Typo TesVideoTranscode -> TestVideoTranscode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115273 (owner: 10Hashar) [21:41:01] (03CR) 10MarkTraceur: [C: 032] Ignore TestVideoThumbnail::testApiThumbnails [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115303 (owner: 10Hashar) [21:41:09] (03Merged) 10jenkins-bot: Ignore TestVideoThumbnail::testApiThumbnails [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115303 (owner: 10Hashar) [21:41:30] (03CR) 10MarkTraceur: [C: 04-1] Ignore TestVideoTranscode::testTranscodeJobs (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115304 (owner: 10Hashar) [21:41:36] :-] [21:41:45] Almost [21:42:09] oh you fix it [21:42:11] \O/ [21:42:19] will make the job voting after that [21:42:23] 'kay [21:42:24] (03PS3) 10MarkTraceur: Ignore TestVideoTranscode::testTranscodeJobs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115304 (owner: 10Hashar) [21:42:40] you will be praised! [21:42:54] (03CR) 10MarkTraceur: [C: 032] "\o/ speed" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115304 (owner: 10Hashar) [21:42:57] thank you very much for stepping in, that will unblock the CirrusSearch tests [21:43:00] (03Merged) 10jenkins-bot: Ignore TestVideoTranscode::testTranscodeJobs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/115304 (owner: 10Hashar) [21:43:02] Yeah [21:43:07] My pleasure [21:43:16] Patches that only make tests pass are easy enough to review. :0 [21:43:18] :) [21:43:43] I wanted to make sure it was not going to cause disruptions / havoc / drama [21:43:48] Yeah [21:43:51] I think it's fine [21:43:52] with bugs to back up my a** I guess I am fine :] [21:43:59] Truth [21:46:18] rdwrer: thank you very much :-] [21:46:23] I escape to another extension [21:46:43] Heh, good luck [21:53:29] (03PS11) 10Gilles: Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 [21:54:00] (03CR) 10Gilles: Blurred thumbnail preview + progress bar (039 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [21:59:06] (03PS12) 10Gilles: Blurred thumbnail preview + progress bar [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 [22:01:22] (03PS11) 10Gergő Tisza: Show permission [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 [22:02:10] (03CR) 10Gergő Tisza: "Seems fixed after a rebase. Probably related to the CSS delay issue fixed by Gilles." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 (owner: 10Gergő Tisza) [22:03:56] (03CR) 10Gergő Tisza: [C: 032] "Merging per Aarcos." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 (owner: 10Gergő Tisza) [22:04:29] (03Merged) 10jenkins-bot: Show permission [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 (owner: 10Gergő Tisza) [22:07:18] #254: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... DTS:2F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/254 [22:07:19] #258: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... DTS:2F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/258 [22:08:18] #208: (GT) S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/208 [22:10:19] #208: (GT) Still very broken, image is tiny (smaller even ... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/208 [22:14:26] (03PS6) 10MarkTraceur: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [22:14:28] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [22:15:43] (03PS7) 10MarkTraceur: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [22:16:17] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [22:16:19] #208: (GD) The small image issue is #239 because going ful... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/208 [22:16:20] (03PS8) 10MarkTraceur: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [22:16:33] I don't get it [22:16:38] It won't open the lightbox anymroe [22:16:41] anymore* [22:16:44] There are no errors [22:16:47] Just doesn't bloody open [22:17:07] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [22:17:47] no slow requests spinning? [22:17:59] No, no requests at all from what I can see [22:18:06] The modules get loaded, but the interface never shows up [22:18:48] works fine for me on beta/firefox, for what it's worth [22:19:26] could be the CSS wait not working for you [22:20:23] Hm. [22:20:26] Might be [22:20:32] can you run the qunit tests? [22:20:33] Is that a newer-browser thing? [22:20:35] Sure [22:20:48] shouldn't be, it's pretty low-tech [22:21:05] Hm, modules in error state [22:21:07] But no errors [22:21:32] run the mmv.boostrap tests specifically [22:21:47] ...there are none [22:21:48] What [22:21:50] isCSSReady is the one you want to check [22:22:01] hah! I've had that before [22:22:05] broken rollups [22:22:27] something in your CSS or JS isn't compiling properly [22:22:41] Sounds about right [22:22:49] It usually gives me a broken dependency error though [22:22:54] missing modules in qunit is a dead giveaway [22:23:16] There should really be a less error log somewhere... [22:25:21] I'll compile it manually and figure it out from there. [22:28:33] ...weird, the less files still compile [22:29:25] The JS doesn't compile per se, so... [22:29:44] Hm, oojs-ui is in an error state, that's weird [22:30:13] Oh, because I'm bad at fucking with oojs-ui [22:30:25] Better now [22:30:55] I had ln -s'd ~/projects/wikimedia/oojs/ui/dist but forgot to call it oojs-ui [22:31:00] So none of the files were found [22:32:18] #253: (GT) https://gerrit.wikimedia.org/r/115314 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/253 [22:32:18] #253: (GT) O:GT|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/253 [22:32:19] #253: (GT) . S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/253 [22:34:34] rdwrer: Oops. :-) [22:34:42] Yeah [22:34:52] James_F: Having two separate repos for this is making things complicated [22:34:58] We need a better dependency manager for MW. [22:35:02] What else is new [22:35:30] Quite. [22:39:18] #118: (GD) DDE:2F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118 [22:46:14] gi11es, rdwrer: mw.loader.using does not send broken dependency errors :( [22:46:18] #118: (GD) I tried making one: http://en.wikipedia.beta.wm... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118 [22:46:27] now fixed on our side [22:46:48] Hah, fun. [23:08:08] any objections to bringing #177 (merge multilighbox and mmv) forward to this week? [23:08:33] tgr_: If you think you can get it done, naw [23:08:43] There are things in CR though [23:08:43] i'm looking at resize issues and it is very annoying that i have to look in two different places for every function [23:08:50] Heh, yeah [23:08:59] tgr_: I'm in favour [23:10:19] #177: (GT) I:#F2-S3 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/177 [23:11:19] #177: (GT) O:GT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/177 [23:11:19] #177: (GT) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/177 [23:11:19] #177: (GT) S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/177 [23:14:19] #239: (GT) I think this is largely related to autoResizeIm... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/239 [23:35:26] (03CR) 10Aarcos: Blurred thumbnail preview + progress bar (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [23:38:45] (03CR) 10Aarcos: [C: 04-1] "I am testing in my mac and this doesn't seem to work? The images are blowout, reminds me of the pixel ratio bugs of the past. Investigatin" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113963 (owner: 10Gilles) [23:53:09] aarcos: Do you have an account on mediawiki.org [23:53:50] I thought you did but cannot find. [23:53:53] rdwrer: I think so: aarcos [23:54:15] https://www.mediawiki.org/wiki/User:Aarcos [23:54:16] Nope [23:54:46] how about: https://www.mediawiki.org/wiki/User:Aaron_arcos [23:55:12] Better [23:55:18] Thanks