[00:11:47] (03PS1) 10MarkTraceur: Fix keydown event handling leak [extensions/MultimediaViewer] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113302 [00:12:03] (03CR) 10MarkTraceur: [C: 032] Fix keydown event handling leak [extensions/MultimediaViewer] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113302 (owner: 10MarkTraceur) [00:13:25] (03Merged) 10jenkins-bot: Fix keydown event handling leak [extensions/MultimediaViewer] (wmf/1.23wmf14) - 10https://gerrit.wikimedia.org/r/113302 (owner: 10MarkTraceur) [00:13:31] I'm an idiot [00:20:43] OK, backport out, now I don't have to have a heart attack [00:39:54] tgr: Can I do any code review for you right now? [00:40:02] I think I'm sufficiently interrupted that I may as well [00:41:07] I can merge the debounce thing, I guess [00:41:14] (03CR) 10MarkTraceur: [C: 032] Move jquery.throttle-debounce to core [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112959 (owner: 10Gergő Tisza) [00:41:51] https://gerrit.wikimedia.org/r/#/c/113047/ is the only other one I have [00:41:52] (03Merged) 10jenkins-bot: Move jquery.throttle-debounce to core [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112959 (owner: 10Gergő Tisza) [00:42:06] and https://gerrit.wikimedia.org/r/#/c/111704/ if you feel like reviewing a core patch [00:42:28] Hell yes to both! [00:51:01] (03PS1) 10Gergő Tisza: Show permission [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 [00:51:25] rdwrer: also, ^^ [00:51:36] That can be next! :) [00:52:03] (03CR) 10jenkins-bot: [V: 04-1] Show permission [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 (owner: 10Gergő Tisza) [00:53:38] tgr: Do you know of an image that has permissions that I can test with? :) [00:53:43] #118: (GT) https://gerrit.wikimedia.org/r/113312 Needs a ... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118 [00:54:19] wow, that's a lot of failures [00:54:45] Yayyyy failures [00:55:12] one is linked from the ticket [00:55:44] but the partial eclipse image in the enwikibeta lightbox has some as well, i think [00:55:57] Hm [00:56:07] I guess I won't be able to test with a remote file though [00:56:13] So uh [00:56:18] * rdwrer thinks [00:57:16] why not? [00:57:49] I'm just not seeing a Permissions value returned from Commons [00:58:57] that's strange, it worked for me [00:59:05] tgr: I thought, given two versions, CMD went with the older one or something [00:59:08] although now that you mention it, it shouldn't have [00:59:37] Heh. [01:00:52] tgr: Once you figured out how you managed to break it for your test, let me know [01:02:19] CMD parses the file again if the version at the server is different, I forgot to bump the version though, so I have no idea why it works [01:02:29] but it does [01:05:01] OTOH all tests succeed for me locally, and jenkins shows totally random failures, mediawiki.toc and whatnot [01:11:54] Maybe Commons has a different version anyway? But that wouldn't explain why it's failing for me. [01:12:39] you don't have a Permission field in the local API response? [01:12:48] you merged the CMD patch, right? [01:13:26] i mean, checked out locally [01:13:57] Yeah, it's on my machine [01:14:09] + 'fileinfotpl_perm' => 'Permission', [01:14:13] (git diff HEAD^) [01:14:59] if you did load the image before that, you need to clear redis [01:21:20] I don't think I have redis running? [01:21:28] But I also didn't load the image beforehand [01:28:47] tgr: Thoughts/ [01:29:24] uh, sorry, i was trying to figure out why half the core tests break [01:29:30] Heh, probably more important :) [01:29:36] let me check where i get the permission field from [01:29:37] Maybe related! [01:35:37] heh [01:35:43] that's a bug in CMD [01:35:49] Fun! [01:35:57] so it always parses the file description locally [01:36:05] which means it should work [01:36:16] until i fix it, anyway [01:36:24] what file are you looking at? [01:37:07] Uhhh [01:37:12] The one frmo the ticket [01:38:36] (03PS2) 10Gergő Tisza: Add Information template Permission field to API output [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/113047 [01:38:51] Trying [01:39:05] Casmerodius something? [01:39:11] Yup [01:39:51] this probably won't change anything, only makes whatever worked because of the bug work for proper reasons now [01:40:13] I would guess some sort of caching issue [01:40:36] 'kay [01:40:37] on vagrant api calls are cached in redis, on your setup maybe memcached? [01:40:46] Maybe [01:41:11] Is there a way to clear the cache? [01:42:10] service memcached restart? [01:42:13] not sure [01:42:26] i use redis-cli flushall, but different setup [01:43:00] Oh, not running memcache [01:43:04] So...I have no caching [01:44:49] (03CR) 10MarkTraceur: [C: 032] "Seems all right to me! Thanks, Gilles, this was long overdue and will make it easier to kill multilightbox with fire later." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112670 (owner: 10Gilles) [01:44:51] (03CR) 10jenkins-bot: [V: 04-1] Get rid of lightboxHooks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112670 (owner: 10Gilles) [01:44:57] Lollercopter [01:45:11] you can test with &iiextmetadatalanguage=gr or something, that should break any local cache [01:45:31] maybe there is a file cache [01:45:44] Still no dice [01:48:49] (03PS2) 10MarkTraceur: Get rid of lightboxHooks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112670 (owner: 10Gilles) [01:49:16] (03CR) 10MarkTraceur: [C: 032] "Trivial-ish rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112670 (owner: 10Gilles) [01:49:43] #176: (MH) DDE:1F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/176 [01:50:01] (03Merged) 10jenkins-bot: Get rid of lightboxHooks [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112670 (owner: 10Gilles) [01:50:42] #176: (MH) Woohoo DTS:1F2|O:MH|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/176 [01:50:42] #176: (MH) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/176 [01:51:53] (03CR) 10Gergő Tisza: [C: 032] Fix missing dependency for mmv.performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113134 (owner: 10Gilles) [01:52:26] (03Merged) 10jenkins-bot: Fix missing dependency for mmv.performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113134 (owner: 10Gilles) [01:57:19] fullscreen is broken on master [01:58:56] seems related to the hooks patch [01:59:28] Ugh, I tested it [02:00:26] Seems to work on beta [02:00:40] And that patch has been merged sufficiently long to be there [02:06:43] #210: (MH) S:IA|P:Ch|R:#Q|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/210 [02:06:43] #210: (MH) P:Sh -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/210 [02:06:43] #210: (MH) S:RfE -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/210 [02:06:43] #210: (MH) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/210 [02:06:46] (03CR) 10MarkTraceur: [C: 04-1] "I'll fix, then test, then merge" (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 (owner: 10Gilles) [02:08:47] (03CR) 10Gergő Tisza: Avoid double requests when measuring performance of image load (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 (owner: 10Gilles) [02:10:27] (03CR) 10MarkTraceur: "Patch incoming" (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 (owner: 10Gilles) [02:11:12] (03PS2) 10MarkTraceur: Avoid double requests when measuring performance of image load [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 (owner: 10Gilles) [02:11:19] tgr: Want to re-review? [02:11:43] yeah, i'm looking at it [02:13:56] 'keee [02:14:03] I might fuck off to get dinner or something [02:14:15] So y'all have a good night [02:15:15] see you tomorrow [02:15:40] (03CR) 10Gergő Tisza: Avoid double requests when measuring performance of image load (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 (owner: 10Gilles) [02:17:29] (03CR) 10Gergő Tisza: [C: 04-1] "Doesn't work anymore with current master, although I think the errors are unrelated." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [02:20:54] oh wow [02:21:00] we are so broken on mw.org [02:21:35] we really need those end-to-end tests [08:05:17] (03CR) 10Gilles: Avoid double requests when measuring performance of image load (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 (owner: 10Gilles) [08:13:54] (03CR) 10Gilles: [C: 032] Big credits patch [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113259 (owner: 10MarkTraceur) [08:14:32] (03Merged) 10jenkins-bot: Big credits patch [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113259 (owner: 10MarkTraceur) [08:44:43] #211: (GD) O:GD|S:ID|R:#Q|I:#F2-S2|T:SI( Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/211 [10:41:48] (03PS1) 10Gilles: Record detailed network performance of API calls [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113344 [10:43:42] #211: (GD) https://gerrit.wikimedia.org/r/113344 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/211 [10:43:42] #211: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/211 [12:55:41] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113312 (owner: 10Gergő Tisza) [14:10:53] (03PS3) 10Gilles: Avoid double requests when measuring performance of image load [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 [14:17:49] (03PS4) 10Gilles: Avoid double requests when measuring performance of image load [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 [14:34:52] (03Abandoned) 10Gilles: WIP Prototype low to hight resolution transition. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111688 (owner: 10Aarcos) [16:45:10] (03CR) 10Cmcmahon: [C: 032] Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112676 (owner: 10Zfilipin) [16:54:09] (03PS4) 10Zfilipin: Moved tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112895 [16:55:00] (03CR) 10Cmcmahon: [C: 032] Moved tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112895 (owner: 10Zfilipin) [16:55:06] (03Merged) 10jenkins-bot: Moved tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112895 (owner: 10Zfilipin) [17:31:20] rdwrer: do you already have a WIP for #136, or is it up for grabs? (I'm done right now, but I could work on it on monday my time) [17:37:15] gi11es: Yes. [17:37:24] I havej a WIP, and it is also up for grabs. [17:37:44] quantic card [17:42:18] Well [17:42:23] I made the WIP during the summit [17:42:31] And then I abandoned it because it wasn't scheduled [17:42:39] So now it's scheduled, anyone who wants to can take it [17:45:07] sounds good [18:14:31] fabriceflorin: Thanks [18:15:45] You're very welcome. :) What's today's thanks for? joining you on IRC? being a nice person? Valentine's day? :) [18:16:53] IRC mostly [18:18:25] rdwrer: Just saw your email, which explains everything. For the record, I joined IRC before reading the email ... [18:18:45] Ah, 'kay [18:18:50] I will update the Mingle ticket right away, as discussed in last night's email. [18:18:55] Rockin' [18:20:24] Not completely sure about showing the description instead of the image title. This could lead to some gibberish that's abridged after only a few words. Can we stick with the image title for now, and revisit the description after we've discussed this idea with our community and designers? [18:20:38] (03PS2) 10MarkTraceur: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [18:20:50] (03CR) 10MarkTraceur: "Rebased" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [18:21:14] (03CR) 10jenkins-bot: [V: 04-1] WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 (owner: 10MarkTraceur) [18:21:21] Of course it bloody well fails [18:21:41] I'd rather stick to the current status quo, as it works now on , as it exists on the file page -- and tweak it later on, as we get further along. [18:22:04] (03PS3) 10MarkTraceur: WIP Add share and embed panel, replace reuse [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112928 [18:22:20] fabriceflorin: I guess so [18:22:50] OK, I'll make a note of this idea for future reference, and will include it in upcoming community discussions. [18:22:58] fabriceflorin: We can get text-only, and stop it after the first paragraph or so, or at a sentence break, so it doesn't have to look weird [18:25:56] My concern is that some descriptions are not written in a way that makes the first sentence intelligible. The best long-term approach, in my view, is to implement a new image title field when we restructure data on Commons, and encourage the community to use it for english-sounding titles. We should also implement a new caption field where captions can be stored, though that one is trickier. All this has to be [18:25:57] near-term work but is crucial, IMHO. [18:26:40] Yeah [18:26:49] What's the status on the whole structured data thing? [18:28:43] #212: (MH) S:IA|P:Mh|R:#Q|T:B Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/212 [18:43:54] (03CR) 10Gergő Tisza: [C: 04-1] "Reconstructing the URL by copying code from mw.Api looks really fragile. If that is our only option, we'll have to do it, but I want to tr" (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113344 (owner: 10Gilles) [19:08:58] rdwrer: We will write a plan for structured data in coming weeks, once we catch our breath on Media Viewer. The goal is to start prototyping in April, and start implementing, then migrating in early summer. It's likely to be a long haul ... [19:09:22] Cool. [19:10:24] that assumes Wikibase will be working on commons by early summer? [19:10:35] i'm not sure i'd hold my breath [19:14:38] Yes, the future is full of mysteries. All I can say is that I hope we can devote most of the summer, fall and winter to this important goal, and start the planning process this quarter, with prototyping and solid design throughout next quarter. [19:15:09] Better get back to my assigned tasks now, or I'll never catch up with that elusive future :) [19:35:42] #148: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [19:36:41] Hm, has pginer gone home? [19:36:42] #148: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [19:37:43] #148: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [19:38:02] rdwrer: Embed spec updated: [19:38:03] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [19:38:08] Going out to lunch now. [19:38:11] Wunderbar. [19:38:33] fabriceflorin: Actually [19:38:43] #148: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [19:38:44] Uhh....never mind. [19:38:54] I thought I had a question but it makes very little sense [20:09:45] Attention [20:09:47] I hate CSS [20:09:48] That is all [20:24:28] (03PS1) 10Gergő Tisza: Get rid of JSDuck temporary logfile [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113453 [21:44:03] tgr: So I'm thinking we should have a singleton for ThumbnailProvider, and ImageInfoProvider...else the caching may not be very useful. Unless I'm missing something, which is possible [21:44:27] Doesn't look like I am... [21:44:32] Maybe we can just make the cache static [21:44:52] singletons are not a very useful pattern in general [21:45:20] they have global state, and that is always a pain [21:45:29] tests start interacting with each other [21:45:40] Yeah [21:45:52] The cache is the only thing we need to be static [21:46:14] still, it would mess up testing [21:46:43] there should not be more then one ThumbnailProvider object, yes [21:46:50] Well [21:47:05] I don't want to pass mmv's provider all the way down into the fileReuse object [21:47:12] Seems clumsy [21:47:13] but that is easy to do without enforcing it by using some sort of global state [21:47:23] Ugh. [21:47:28] Arright, clumsy it is [21:47:50] dependency injection is generally the right way to go [21:48:07] for example, when you test your class, you want the provider to be a fake [21:48:22] a lot easier to do if it is passed and not created in place [21:49:00] that said, is a provider really needed at such a low level? [21:49:12] Hm, no. [21:49:26] I guess the provider should get used in mmv.js; I was overthinking [21:49:27] ideally, mmv.js would use it to obtain the model, and everything else only had to know about models [21:49:57] ideally, mmv.js would use it to obtain the model, and everything else only had to know about models [21:50:58] fabr crap [21:51:10] Not sure what default size I should use. [21:51:25] Sigh, guess I'll take a whack [21:51:46] default thumbnail size? [21:53:22] For embed, yeah [21:53:33] The mock says something like "Medium - 640x328px [21:53:50] So I'll go with some sane-looking sizes from the bucketing code [21:53:52] for wikis, there is a system default [21:54:03] [[File:Foo|thumb]] [21:54:21] Hm, but I'd need to know what the default is if I wanted to display it [21:54:22] that will depend on the reader's settings, some wikis like to use it [21:54:40] But I could do that, maybe with just "Default thumb size" instead of a number [22:09:47] This is odd. Sometimes it seems like recently uploaded videos get their transcode jobs queued but never executed [22:09:53] e.g. https://commons.wikimedia.org/wiki/File:Wikimania_HongKong_2013_by_Olaf_Kosinsky_Video_13.ogv [22:45:13] (03PS15) 10Nemo bis: [WIP] Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [22:46:15] (03CR) 10Nemo bis: "Did some minor copyediting of the commit message. Thanks again for working on UploadWizard, we love it. ;-)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [22:53:47] (03PS16) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [23:38:45] libel: You crashin' again? [23:54:50] (03PS20) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [23:58:54] (03PS4) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342