[00:00:43] #118: (GT) https://gerrit.wikimedia.org/r/113047 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118 [08:45:07] rdwrer: I was off yesterday [08:45:29] hence no scrum notes for that day [08:51:42] #191: (GD) Prototype reviews and conclusions drawn from it DTE:1F2|S:RfS -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/191 [08:51:42] #191: (GD) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/191 [08:53:42] #146: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [08:55:45] (03CR) 10Gilles: "Just to clarify why I changed what element the events are being listened on in Mark's prior code: I took advantage of event bubbling so th" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112670 (owner: 10Gilles) [08:58:42] #206: (GT) S:IA|P:Ch|I:#B|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/206 [09:13:29] (03CR) 10Gilles: [C: 032] Fix fullscreen bug where image was replaced with self [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112835 (owner: 10Gergő Tisza) [09:14:20] (03Merged) 10jenkins-bot: Fix fullscreen bug where image was replaced with self [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112835 (owner: 10Gergő Tisza) [09:21:24] by the way the performance dependency issue is fixed in that (unrelated) changeset, I believe: https://gerrit.wikimedia.org/r/#/c/112670/1/MultimediaViewer.php,unified [09:29:06] (03CR) 10Gilles: [C: 04-1] Preload fullscreen image (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [09:35:01] (03CR) 10Gilles: [C: 032] Add TaskQueue class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 (owner: 10Gergő Tisza) [09:35:38] (03Merged) 10jenkins-bot: Add TaskQueue class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 (owner: 10Gergő Tisza) [09:40:33] (03CR) 10Gilles: Preload prev/next images (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [09:45:08] (03CR) 10Gilles: [C: 032] Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [09:45:10] (03CR) 10jenkins-bot: [V: 04-1] Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [09:53:07] (03PS20) 10Gilles: Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [09:53:23] (03CR) 10Gilles: [C: 032] Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [09:54:30] (03Merged) 10jenkins-bot: Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [14:35:42] #207: (GD) O:GD|S:ID|R:#Q|I:#F2-S1|T:SI( Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/207 [15:48:19] (03PS1) 10Gilles: Avoid double requests when measuring performance of image load [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113130 [15:49:43] #207: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/207 [15:49:43] #207: (GD) https://gerrit.wikimedia.org/r/113130 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/207 [15:52:26] (03PS1) 10Gilles: Fix missing dependency for mmv.performance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113134 [16:28:42] #208: (GD) O:GT|S:R|R:#Q|I:#F2-S1|T:SI( Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/208 [16:29:42] #155: (GD) DDE:1F2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 [16:29:42] #208: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/208 [16:31:42] #142: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... S:IT|DTS:1F2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [16:31:42] #142: (GD) Tested on beta, it works DTE:1F2|S:RfS -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [16:32:42] #142: (GD) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [16:33:46] #142: (GD) These last two comments were a mistake, wrong t... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [16:34:41] #142: (GD) . S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [16:34:41] #142: (GD) S:RfT|DDE:1F2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [16:34:41] #155: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... O:GD|DTS:1F2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 [16:34:41] #155: (GD) Tested on beta, it works DTE:1F2|S:RfS -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 [16:34:41] #155: (GD) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 [17:24:41] #167: (F) P:Sh -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/167 [17:25:42] #172: (F) P:Sh -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/172 [17:27:41] #45: (F) P:Mh -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/45 [17:27:41] #197: (F) P:Mh -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/197 [17:30:41] #200: (F) P:Mh -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/200 [17:35:42] #209: (GD) S:A|R:#Q|I:#F2-S2|T:TM Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/209 [17:37:41] tgr: rdwrer: meeting room issue? [17:45:14] gi11es: no, just being stupid [17:45:37] rdwrer tgr : Hey guys, where are you? Please join us on Google Hangouts, we've been waiting for 15 mins now. [17:45:39] forgot that fabriceflorin is not coming in today and were waiting for him [17:45:52] although we do have meeting room issues now [18:05:41] #146: (GD) O:GD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [18:05:41] #142: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/142 [18:06:41] #143: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/143 [18:06:41] #126: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [18:06:41] #154: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/154 [18:06:41] #207: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/207 [18:06:41] #176: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/176 [18:06:41] #208: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/208 [18:07:42] #146: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [18:07:42] #118: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/118 [18:07:42] #148: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [18:07:42] #147: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/147 [18:07:42] #124: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 [18:09:42] #197: (MH) O:MH|S:RfE -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/197 [18:09:42] #197: (MH) S:RfD|O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/197 [18:09:42] #197: (GD) S:RfE -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/197 [18:09:42] #136: (MH) O:(s|S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136 [18:09:42] #197: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/197 [18:11:43] #79: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79 [18:11:43] #79: (MH) O:MH|S:RfE -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79 [18:12:42] #79: (MH) S:RfD|O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79 [18:14:43] #202: (GD) I:#F2-S3 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/202 [18:16:45] #202: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/202 [18:16:45] #202: (GD) I:#F2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/202 [18:24:43] phabricator's current basic board view: http://fab.wmflabs.org/project/board/5/ I didn't add all the code review states because when you put patches on phabricator that lives in a different dimension [18:26:54] they have a bunch of UI improvements in the works for that view, already filed as tasks on their end [18:28:09] and I've filed a ticket of my own for the main thing I miss from mingle (story points sum on columns): https://secure.phabricator.com/T4427 [18:28:44] overall it's a lot more basic than mingle, but I think with points sums it will do most of what we really need [18:29:12] plus I don't think I'll miss having to set up all these transitions, being able to drag things anywhere you want is just easier [18:30:06] "accepted" is also non-existant because you just close a task in phabricator when it's tested, launched and verified to work [18:33:03] do we intend to use it for a limited-time demo/trial thing, or permanently? [18:33:23] the goal is permanent, but I don't want to rush things, we should make sure that it does everything we need first [18:33:31] because using a nonstandard patch/bug tracker sounds very painful [18:33:46] and keeps volunteers away, too [18:34:00] it can be public-facing [18:34:20] the same way that some teams use trello, others mingle, we'd be the first to use phabricator for our task tracking [18:34:35] yeah, that part is no problem [18:34:42] mingle is an internal thing [18:34:54] bugzilla is part public relations [18:35:18] James_F: You might be interested in this ^^ [18:35:32] we'll see about that part later, but I think it wouldn't be that hard to point people who want to submit bugs for our projects to phabricator [18:35:45] for that we need it to be hosted outside of labs [18:35:54] and we need sufficient oauth options [18:36:01] or even LDAP with other wikis [18:36:19] anything that can let people using it by pressing a button instead of having to register an account [18:36:19] i think multiple bug tracker options would be really really confusing [18:36:35] why? if bugzilla links to phabricator for that project [18:36:45] most of the people using bugzilla are not programmers [18:37:00] phabricator's UI is a lot simpler than bugzilla's [18:37:36] the old toolserver used had its own tracker, and it was basically off the map, no one even went there [18:37:57] even though they used jira which is way more user-friendly than bugzilla [18:38:04] I think the best option is to have a two-way link [18:38:14] people can still submit bugs on bugzilla [18:38:25] and every comment is posted both ways [18:38:48] closing it in phabricator closes it in bugzilla, etc. [18:38:55] with oauth? [18:39:01] gerrit already has some of that, right? changing state when a patch comes in, etc. [18:39:26] or with all comments attributed to phabricatorbot? [18:39:59] whichever we can do, but I think developers would be happy with getting the notifications and emails on phabricator [18:41:16] i think doing this for a limited time just to test phabricator/show it off to others is a good idea, but i have doubts about using it for the long term, unless we can somehow convince the whole organization to switch [18:41:41] robla was interested in the idea of switching the whole organization to it for bug tracking [18:41:58] but I think we need to demo it working for real for people to adhere to the idea [18:42:07] not just mock data, actual bugs, tickets, etc. [18:42:34] the bugs we find ourselves will probably be enough [18:42:39] already we file those directly to mingle [18:43:30] yes, demoing it for a limited amount of time, like a month or two, that makes sense, what i'm concerned about is what will happen after that [18:44:18] a separate communication channel tends to become a ghetto in the long run [18:48:16] totally, although in that case I would argue that bugzilla is already a dusty ghetto where communication goes to die [18:48:45] bug triaging, merging, etc. is so much more pleasant in phabricator, we'd be a lot more responsive to people's requests than we are now [18:48:49] "We don't talk to that bug. It comes from the other side of the tracks. In Tampa." [18:49:14] Bugs from pmtpa are irrationally discriminated against [18:54:43] gi11es: Nice; thanks for the flag, rdwrer [18:54:54] Hyup, no prob [18:55:41] gi11es: If I don't get tied up writing a Twitter -> pump.io script this weekend, I might consider dumping our current iteration into Phabricator. [19:00:46] rdwrer: I'll try to do the points sum patch, then, I think it's a real loss to be unable to view the sum of columns [19:01:01] 'kay [19:01:14] also I need to configure a custom field to get started, ^d gave me ssh access to the fab machine, I'll do it tomorrow [19:01:35] "today" scrum-wise [19:03:18] Right [19:31:27] (03CR) 10Gergő Tisza: Preload fullscreen image (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [19:31:44] gi11es: ^^ [19:40:37] (03CR) 10Gilles: [C: 032] Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [19:40:39] (03CR) 10jenkins-bot: [V: 04-1] Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 (owner: 10Gergő Tisza) [19:41:11] i'll fix that [19:42:01] Do we have any way of knowing the full screensize before it's loaded? [19:42:26] yeah, it's just screen.width/screen.height [19:43:54] (03PS4) 10Gergő Tisza: Preload fullscreen image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112753 [19:44:04] tgr: Isn't that for the browser window, not the full screen? [19:44:10] I didn't know this was possible [19:44:33] http://mdn.beonex.com/en/DOM/window.screen.html oooooh [19:44:45] that's the fullscreen, it was originally added to collect system stats, i think [19:45:01] That's awesome [19:47:16] probably not the kind of thing that would make it into new specs nowadays :) [19:47:21] it's part of the many things you can use to fingerprint people online [19:47:51] afaik it's very old, it's been in analytics software for as long as I can remember [19:49:16] https://panopticlick.eff.org/ fonts and browser plugins being the biggest offenders in that respect, though [20:04:26] rdwrer: could you suggest a reviewer for https://gerrit.wikimedia.org/r/#/c/112956/ ? [20:06:07] Uh, yes! Me. [20:06:15] I added Krinkle too, but I can look. [20:13:56] rdwrer: thx [20:14:18] it's more of a do-we-want-this-in-core issue, the patch is trivial [20:19:13] fyi, I'm noticing increasingly odd scrolling behavior on mediawiki.org with media viewer enabled [20:29:11] Eloquence: after opening/closing the lightbox? [20:29:20] or even if you don't use it at all? [20:29:41] even if I don't use it, but have enabled it in beta features [20:29:58] example page: https://www.mediawiki.org/wiki/Universal_Language_Selector/WebFonts [20:30:07] if I cursor-down on this page, it will mysteriously cursor back up [20:30:51] this does not occur with MV disabled [20:30:59] ouch [20:31:04] sorry :) [20:31:26] that will be the scolling logic for the metadata panel [20:32:01] we may need to push out a fix for that today as it makes mediawiki.org pretty unusuable .. although of course people can turn off the viewer [20:32:44] at least I'm not seeing it in wmf13 wikis [20:34:06] https://bugzilla.wikimedia.org/show_bug.cgi?id=61337 [20:50:48] (03PS1) 10Gergő Tisza: Fix keydown event handling leak [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113177 [20:51:00] Ah, FFS [20:51:08] * rdwrer swears about backwards cursor logic [21:27:07] tgr rdwrer : do you need any help to test your fix for bug 61337, as reported by eloquence ? can we deploy this fix later today? [21:35:51] We can backport it, sure [21:38:49] (03PS1) 10MarkTraceur: Big credits patch [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113259 [21:40:45] (03CR) 10MarkTraceur: [C: 032] Fix keydown event handling leak [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113177 (owner: 10Gergő Tisza) [21:41:18] (03Merged) 10jenkins-bot: Fix keydown event handling leak [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/113177 (owner: 10Gergő Tisza) [21:48:25] tgr: Do we have the anti-commit for debounce in MMV? [21:48:53] Or are we just pushing it to core first [21:49:04] Or are you at lunch >.< [21:49:42] Got it, testing [21:56:11] (03PS2) 10Gergő Tisza: Move jquery.throttle-debounce to core [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112959 [21:57:16] (03CR) 10jenkins-bot: [V: 04-1] Move jquery.throttle-debounce to core [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112959 (owner: 10Gergő Tisza) [22:01:34] MarkTraceur around here somewhere? [22:11:15] yes, under the name rdwrer [22:11:34] http://fab.wmflabs.org/T17 now with story points, custom field was really easy to set up [22:37:02] (03PS18) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [22:39:27] Agh, fuck [22:39:38] Need to manually cherry-pick [22:39:40] I hate my life [22:41:08] Fuck. We defined this...wrong [22:41:41] HOTFIX WOO [22:42:27] Not reall hotfix, but still [22:42:33] Most hot fix I'll ever have to do, I think [22:46:27] (03PS1) 10MarkTraceur: Branch-specific fix for keydown listeners [extensions/MultimediaViewer] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113283 [22:46:50] I can't believe that worked [22:48:11] ...why can't I repro locally [22:48:56] (03PS14) 10Inchikutty: [WIP]Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [22:49:48] Eloquence: Can you reproduce your keydown bug on a local isntance? I'm not able to [22:50:21] don't have time to test right now [22:50:24] 'kay [22:50:39] tgr: Were *you* able to reproduce locally? [22:50:58] (03PS2) 10MarkTraceur: Branch-specific fix for keydown listeners [extensions/MultimediaViewer] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113283 [22:50:59] yes [22:51:11] Weird. [22:51:27] tgr: Can you pull 113283 and see if it works for you? [22:51:41] Maybe it's chromium-specific...sec [22:52:23] Hm, nope [22:54:01] (03PS3) 10MarkTraceur: Move jquery.throttle-debounce to core [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112959 (owner: 10Gergő Tisza) [22:54:06] works [22:54:16] tgr: And the parent commit is broken? [22:54:24] (git checkout HEAD^) [22:54:53] tgr: And remove your -2 on 112959 at your leisure, by the way [22:55:59] parent is half-broken, the bug only appears after first opening the lightbox [22:56:19] (03CR) 10Gergő Tisza: Move jquery.throttle-debounce to core [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112959 (owner: 10Gergő Tisza) [22:58:09] (03PS10) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [22:58:23] which is weird because on mw.org i can still reproduce without opening the lightbox, and it should be the exact same code [23:31:02] (03PS19) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [23:43:15] Hm. [23:43:22] I'm going to say "good enough" and merge this and then go [23:43:33] (03CR) 10MarkTraceur: [C: 032] Branch-specific fix for keydown listeners [extensions/MultimediaViewer] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113283 (owner: 10MarkTraceur) [23:44:05] (03Merged) 10jenkins-bot: Branch-specific fix for keydown listeners [extensions/MultimediaViewer] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113283 (owner: 10MarkTraceur) [23:48:15] (03PS3) 10Inchikutty: [WIP] UploadWizard:OSM embedding- Geocoding, reverse geocoding [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112342 [23:51:11] tgr: Can you add information about the spec we're following on https://www.mediawiki.org/wiki/Extension:CommonsMetadata ? [23:51:18] I remember reading about it in a conversation about Source/Credit [23:54:47] tgr: Also, should I backport the fix for the performance dependency issue? [23:55:15] i don't know, did that cause any problems? [23:55:32] i remember you mentioning it, but i never encountered it myself [23:56:06] Hm [23:56:23] I'm not seeing it in prod, so I might say "no" [23:56:52] 'kay, we're good