[08:06:50] (03CR) 10Gilles: [V: 032] Refactor thumbnail size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111950 (owner: 10Gergő Tisza) [08:10:52] (03CR) 10Gilles: [C: 032] Refactor thumbnail size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111950 (owner: 10Gergő Tisza) [08:11:34] (03Merged) 10jenkins-bot: Refactor thumbnail size calculation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111950 (owner: 10Gergő Tisza) [08:20:54] (03CR) 10Gilles: "Minor concern, I'll fix it right now" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [08:31:42] (03CR) 10Gilles: [C: 04-2] "This brought back an old bug that I had fixed in the fullscreen/buttons handling. If you open in fullscreen, press X to close and then reo" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [08:36:13] (03CR) 10Gilles: "I've spotted a bunch of issues with the rebase, mainly the fact that profileStart and profileEnd calls reappeared and should have been con" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [08:38:23] (03CR) 10Gilles: "Ignore my last comment, I got confused by another branch." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111197 (owner: 10Gilles) [08:39:40] (03PS8) 10Gilles: Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [08:40:24] (03CR) 10Gilles: "The bug went away with the rebase, yay" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [08:41:10] (03PS9) 10Gilles: Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [08:41:51] (03CR) 10Gilles: [C: 032] Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [08:42:25] (03Merged) 10jenkins-bot: Refactor button things into a separate class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111372 (owner: 10MarkTraceur) [08:55:31] Yaaaaaaaayyyyyyyyy [09:06:09] (03PS1) 10Gilles: Fix fullscreen and close icons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112426 [09:07:11] (03CR) 10Gilles: [C: 032] "CSS quickfix" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112426 (owner: 10Gilles) [09:07:43] (03Merged) 10jenkins-bot: Fix fullscreen and close icons [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112426 (owner: 10Gilles) [09:12:47] (03PS1) 10Gilles: Fix defullscreen icon duplicate CSS [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112428 [09:13:05] (03CR) 10Gilles: [C: 032] "CSS quickfix" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112428 (owner: 10Gilles) [09:13:49] (03Merged) 10jenkins-bot: Fix defullscreen icon duplicate CSS [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112428 (owner: 10Gilles) [09:14:03] rdwrer: libel keeps dying, doesn't it? [13:45:04] (03Abandoned) 10Zfilipin: WIP Moved Selenium tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/92879 (owner: 10Zfilipin) [14:58:11] (03PS1) 10Zfilipin: Added basic readme file to test/browser folder [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112453 [15:33:30] gi11es: Oh, hm, it seems to have [15:33:35] I can start it back up [15:36:49] is it hanging or dying? we could just make a cron entry to keep it alive if the process dies [15:37:36] Yeah [15:37:45] I will check [16:51:58] (03CR) 10Gilles: [C: 04-1] Preload prev/next images (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [21:32:26] (03PS13) 10Gergő Tisza: Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 [21:32:28] (03PS1) 10Gergő Tisza: Add TaskQueue class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 [21:33:33] (03CR) 10jenkins-bot: [V: 04-1] Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [21:34:06] (03CR) 10jenkins-bot: [V: 04-1] Add TaskQueue class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 (owner: 10Gergő Tisza) [21:48:16] (03PS2) 10Pginer: Icons for share link and assessments [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112024 [21:48:20] (03CR) 10MarkTraceur: [C: 032] Icons for share link and assessments [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112024 (owner: 10Pginer) [21:49:17] (03Merged) 10jenkins-bot: Icons for share link and assessments [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112024 (owner: 10Pginer) [23:27:56] rdwrer: As discussed, I updated the 'Embed files' card #148 with recommended embed contents to be displayed next to the embedded images. I believe this will address the needs of content creators. Even if editors end up not using the required attributions, they have no excuse not to provide them, as they are now truly embedded along with the image. https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/148 [23:50:06] (03PS14) 10Gergő Tisza: Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 [23:50:08] (03PS2) 10Gergő Tisza: Add TaskQueue class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/112581 [23:50:43] (03CR) 10jenkins-bot: [V: 04-1] Preload prev/next images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/111428 (owner: 10Gergő Tisza) [23:52:41] Coolio [23:52:54] fabriceflorin, tgr, FYI I'm building the share/embed patch with oojs-ui [23:53:02] I've been assured by James_F|Away that they'll have it in core this week