[00:03:12] I wonder if there's an image equivalent of ZIP bombs [00:03:23] a very small upload that's actually a gigantic image [00:03:45] i.e. that would trigger very expensive thumbnailing if you don't have max image dimensions set up on your site [00:03:47] gi11es: PNG's with indexed colours [00:03:57] (03CR) 10Gergő Tisza: Add categories to the interface (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [00:04:22] We've got examples that are like 800kb but cause the image scalars to run past memory limits [00:04:43] Tee hee scalar. [00:04:58] It's funny because they're PNGs [00:05:15] nice, I'm surprised some russians somewhere haven't attacked large sites that accept image uploads with that [00:05:32] I imagine that's why we have the examples [00:05:53] those weird files tend to come from real users [00:05:59] I've never seen them used in attacks [00:06:26] I wonder if we've tried imgur [00:06:48] Or MediaGoblin [00:06:59] bawolff: Where might I find these examples? :) [00:07:47] marktraceur: You could ask reedy for the thumbnail fail log. indexed pngs that are just slightly smaller than the vips cut off are about the only thing regularly failing [00:09:16] There's a bug comment somewhere that mentions them [00:09:20] one of my faves https://en.wikipedia.org/wiki/Billion_laughs [00:12:22] marktraceur: Here's an example: https://upload.wikimedia.org/wikipedia/commons/thumb/c/c2/014c04d520f6cb4286db835ee934a2d7.png/900px-014c04d520f6cb4286db835ee934a2d7.png [00:12:33] (error code 137 means killed for taking too much memory) [00:13:24] https://commons.wikimedia.org/wiki/File:014c04d520f6cb4286db835ee934a2d7.png [00:13:49] can we actually process any indexed PNGs? [00:14:15] or does this file have something special besides being indexed? [00:15:01] Wow [00:15:55] gi11es: Its special for being rather high resolution [00:16:13] It's on the edge, if you scale it at 500px, it works [00:16:29] oh right, basically it allows you to do huge res with small disk space [00:16:35] yep [00:17:08] We also change image scalars at about 35 megapixels for pngs, so to trigger the error on wikimedia, it needs to be less than that [00:20:12] Which reminds me, we should really do something about tiff files not rendering at high resolution [00:35:25] #124: (MH) Rough notes: https://etherpad.wikimedia.org/p/m... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 [00:38:24] Did someone change the list admin password? [00:38:56] (03CR) 10Gergő Tisza: [C: 04-1] "Some general problems:" (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 (owner: 10Inchikutty) [00:40:12] Can somebody give me the list admin password? (Just saying I get all the moderation emails, but I have no idea what the pass is) [00:40:19] Hah [00:40:35] bawolff: Presumably you got the same email I did that had it, but that password is no longer working for me [00:40:45] I'll email fabrice if I don't find the email in my 1000 unread [00:41:02] I don't remember ever getting an email with a password in it, but maybe I just forgot [00:41:18] Also, what's the deal with shard passwords anyways... [00:41:32] Totally silly [00:42:05] oh nevermind, search found me an admin password [00:42:17] I guess I just never read that email too closely [00:53:48] A user just raised concerns with me that the feedback on https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer is going unoticed [01:01:56] That's maybe the case [01:02:18] I think Sven's issue is fixed [01:02:38] The issues with the license and other link should also be fixed [01:03:21] These are actually getting fixed, we just aren't responding here [01:03:42] I'll put this in my list of things to email fabrice about [01:04:30] ok. I directed the person who mentioned it to talk to fabrice if he has concerns about multimedia related things [01:04:38] Right [01:18:12] (03CR) 10Alex Monk: jquery audit of mw.DestinationChecker.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86804 (owner: 10MarkTraceur) [01:21:40] Oh dear. [01:26:45] (03CR) 10MarkTraceur: "In the future, this is _not_ how we format commit messages:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109268 (owner: 10Aarcos) [01:31:46] marktraceur: you missed, needs newline between first sentence and body [01:37:45] Ugh, yeah [01:37:47] Double newline [01:37:57] Paragraph break [03:46:57] (03PS3) 10Gergő Tisza: Add imageinfo, thumbnail info, repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 [03:47:07] (03CR) 10jenkins-bot: [V: 04-1] Add imageinfo, thumbnail info, repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 (owner: 10Gergő Tisza) [03:50:06] (03PS4) 10Gergő Tisza: Move providers into their own subdirectory [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110474 [03:50:08] (03PS4) 10Gergő Tisza: Add imageinfo, thumbnail info, repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 [03:51:42] (03CR) 10jenkins-bot: [V: 04-1] Add imageinfo, thumbnail info, repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 (owner: 10Gergő Tisza) [03:52:31] (03PS5) 10Gergő Tisza: Add imageinfo, thumbnail info, repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 [03:57:25] #123: (GT) https://gerrit.wikimedia.org/r/#/c/110496/ -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 [07:51:24] (03PS8) 10Inchikutty: [WIP] Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [09:33:57] (03PS10) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [12:37:43] (03PS11) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [13:10:36] (03PS12) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [13:15:54] (03PS13) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [17:00:32] (03PS5) 10AalekhN: resources/ext.multimediaViewer/ext.multimediaViewer.css : added css for the download icon resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js : added download js command resources/ext.multimediaViewer/img/download.svg : download image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108526 [17:00:34] (03CR) 10jenkins-bot: [V: 04-1] resources/ext.multimediaViewer/ext.multimediaViewer.css : added css for the download icon resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js : added download js command resources/ext.multimediaViewer/img/download.svg : download image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108526 (owner: 10AalekhN) [17:19:02] (03PS6) 10AalekhN: resources/ext.multimediaViewer/ext.multimediaViewer.css : added css for the download icon resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js : added download js command resources/ext.multimediaViewer/img/download.svg : download image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108526 [17:19:04] (03CR) 10jenkins-bot: [V: 04-1] resources/ext.multimediaViewer/ext.multimediaViewer.css : added css for the download icon resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js : added download js command resources/ext.multimediaViewer/img/download.svg : download image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108526 (owner: 10AalekhN) [17:22:08] (03PS7) 10AalekhN: resources/ext.multimediaViewer/ext.multimediaViewer.css : added css for the download icon resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js : added download js command resources/ext.multimediaViewer/img/download.svg : download image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108526 [17:22:10] (03CR) 10jenkins-bot: [V: 04-1] resources/ext.multimediaViewer/ext.multimediaViewer.css : added css for the download icon resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js : added download js command resources/ext.multimediaViewer/img/download.svg : download image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108526 (owner: 10AalekhN) [17:25:51] (03Abandoned) 10AalekhN: resources/ext.multimediaViewer/ext.multimediaViewer.css : added css for the download icon resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js : added download js command resources/ext.multimediaViewer/img/download.svg : download image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108526 (owner: 10AalekhN) [19:15:56] (03PS14) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [20:05:16] (03PS9) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [20:34:14] (03PS8) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [21:50:04] (03CR) 10MarkTraceur: "Why did you abandon this change?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108526 (owner: 10AalekhN)