[00:10:11] (03PS1) 10Gergő Tisza: Move providers into their own subdirectory [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110474 [00:10:42] (03CR) 10jenkins-bot: [V: 04-1] Move providers into their own subdirectory [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110474 (owner: 10Gergő Tisza) [00:11:26] #123: (GT) https://gerrit.wikimedia.org/r/110474 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 [00:12:06] (03PS2) 10Gergő Tisza: Move providers into their own subdirectory [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110474 [01:46:26] #44: (GT) Global usage link ends up in the wrong place an... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44 [01:47:27] #44: (GT) O:GT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44 [01:47:27] #44: (GT) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44 [02:06:48] (03PS1) 10Gergő Tisza: WIP add imageinfo + repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 [02:07:21] (03CR) 10jenkins-bot: [V: 04-1] WIP add imageinfo + repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 (owner: 10Gergő Tisza) [02:35:33] (03PS3) 10Gergő Tisza: Move providers into their own subdirectory [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110474 [02:35:34] (03PS2) 10Gergő Tisza: WIP add imageinfo + repoinfo provider [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110496 [02:35:58] Woo [02:46:26] #146: (AA) S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [03:52:45] (03PS1) 10Gergő Tisza: WIP Add ApiCollector class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110508 [03:53:45] (03CR) 10jenkins-bot: [V: 04-1] WIP Add ApiCollector class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110508 (owner: 10Gergő Tisza) [03:59:20] (03CR) 10Gergő Tisza: [C: 032] Swap position of caption and description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110341 (owner: 10Gilles) [03:59:22] (03CR) 10jenkins-bot: [V: 04-1] Swap position of caption and description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110341 (owner: 10Gilles) [04:05:46] (03PS2) 10Gergő Tisza: Swap position of caption and description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110341 (owner: 10Gilles) [04:09:55] (03CR) 10Gergő Tisza: [C: 032] Swap position of caption and description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110341 (owner: 10Gilles) [04:10:25] (03Merged) 10jenkins-bot: Swap position of caption and description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110341 (owner: 10Gilles) [07:34:17] (03PS6) 10Inchikutty: Adding Leaflet scripts to UploadWizard( OPW Round 7 Project-Part 2) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [07:38:23] (03CR) 10MarkTraceur: [C: 04-1] Adding Leaflet scripts to UploadWizard( OPW Round 7 Project-Part 2) (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 (owner: 10Inchikutty) [07:52:25] #122: (GD) O:(s|S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/122 [07:52:26] #126: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [07:52:26] #124: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/124 [07:52:26] #151: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [07:52:26] #154: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/154 [07:52:26] #155: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/155 [07:52:26] #153: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/153 [07:52:27] #152: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/152 [07:52:27] #141: (GD) O:(s|S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/141 [07:52:28] #150: (GD) S:RfD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/150 [07:53:25] #120: (GD) S:RfT|DDE:3J2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/120 [07:54:26] #120: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... S:IT|O:GD|DTS:3J2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/120 [07:56:18] (03CR) 10Gilles: [C: 032] Handle PD licenses on frontend [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110460 (owner: 10Gergő Tisza) [07:56:54] (03Merged) 10jenkins-bot: Handle PD licenses on frontend [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110460 (owner: 10Gergő Tisza) [07:59:26] #44: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44 [07:59:26] #117: (GD) S:RfT|DDE:3J2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/117 [08:03:26] #117: (GD) Could you find or create a link on beta that sh... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/117 [08:04:25] #117: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/117 [08:06:44] marktraceur: do you know any way to repro https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/122 ? [08:13:36] (03PS8) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [08:19:33] (03PS7) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [08:20:16] gi11es: I think it got fixed and I forgot to move it, sorry [08:20:31] it's alright, less work to do :) [08:20:36] Yup yup [08:21:25] #122: (GD) O:GD|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/122 [08:21:26] #122: (GD) Old report, works now S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/122 [08:22:26] #122: (GD) Old report, works now DTS:3J2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/122 [08:22:26] #122: (GD) Old report, works now DTE:3J2|S:RfS -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/122 [08:22:26] #122: (GD) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/122 [08:25:32] (03PS9) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [08:30:42] (03PS1) 10Gilles: Fix the "view all uses" link when there are both local and global results [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110517 [08:31:25] #44: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44 [08:31:26] #44: (GD) https://gerrit.wikimedia.org/r/110517 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44 [08:32:53] marktraceur: I'm letting you finish https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/41 whenever you get back to work [08:33:21] most of the concerns raised by aaron on the diff are your code, it'll be faster if you're the one responding [08:34:26] #126: (GD) O:GD|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/126 [08:35:40] 'kay [08:35:46] I can do it tomorrow [08:35:50] today* [08:36:26] #141: (GD) O:GD|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/141 [09:29:57] (03PS1) 10Gilles: Make mmv handle urlencoded hashes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110522 [09:31:25] #153: (GD) https://gerrit.wikimedia.org/r/110522 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/153 [09:31:26] #153: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/153 [09:36:26] #8: (e) PC:0 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/8 [09:39:26] #152: (GD) O:GD|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/152 [09:50:26] #152: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/152 [09:58:45] (03PS1) 10Gilles: Hide the fullscren button when fullscreen is unavailable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110525 [09:59:26] #152: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/152 [10:00:17] (03CR) 10Gilles: "Don't merge until the corresponding core changeset is approved: https://gerrit.wikimedia.org/r/#/c/110523/" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110525 (owner: 10Gilles) [10:01:25] #152: (GD) https://gerrit.wikimedia.org/r/#/c/110523/ htt... S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/152 [10:02:25] #107: (GD) DDE:3J2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/107 [10:02:26] #107: (GD) B:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/107 [10:02:26] #107: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/107 [10:03:25] #107: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... O:GD|DTS:3J2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/107 [10:36:00] (03PS1) 10Gilles: Place the metadata correctly before opening the lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110530 [10:36:25] #141: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/141 [10:37:25] #141: (GD) https://gerrit.wikimedia.org/r/110530 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/141 [10:39:25] #154: (GD) B:B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/154 [10:40:25] #137: (GD) B:B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/137 [10:41:26] #150: (GD) O:GD|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/150 [12:31:07] marktraceur: Hi! For https://gerrit.wikimedia.org/r/#/c/105459/ I think I should set both title and alt [14:19:26] #8: (e) PC:0 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/8 [15:23:25] (03PS1) 10Gilles: Hide the controls after some time when in fullscreen mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110579 [15:24:26] #150: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/150 [15:24:26] #150: (GD) https://gerrit.wikimedia.org/r/110579 S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/150 [15:37:12] (03CR) 10Gilles: Add file usage data to MMV metadata panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [15:39:18] (03CR) 10Gilles: "Is this still WIP? Remember to update mingle if you want this reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110474 (owner: 10Gergő Tisza) [15:49:59] (03PS4) 10Gilles: Fix the i18n source string for the chunked preference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 [17:23:21] * marktraceur RETURRRRRNS [17:23:24] Fear me mortals [17:56:45] Are we doing Hangout, or Mumble, or what [17:57:06] Ah. [17:59:19] (03CR) 10Aarcos: [C: 04-1] "Just suggestions on comments." (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110522 (owner: 10Gilles) [17:59:19] I was thinking Google Hangout, if that works for you guys. Short and sweet :) [17:59:48] "works" sure [17:59:59] See you there, gi11es and I are already in [18:12:03] marktraceur: after the categories card, I think the best thing is to help gergo and arron with the refactoring they're working on [18:12:25] Sounds like fun [18:12:37] *aaron [18:12:38] I can sneak peeks at my email in between [18:13:43] my pile of stuff up for review can wait, I think the refactor is more important, even if that means I might have painful rebases to do later [18:14:33] Sure [18:14:46] Oh! [18:15:24] I should have told you guys to put the lazy-loading card into this iteration [18:15:35] #150 was interesting... with 10 lines of code I had something almost working, but then to make it really work, jquery shortcoming disappointment after jquery shortcoming disappointment, it ended up with 190... [18:15:48] https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136 [18:15:55] or more like 130 if you ignore the tests [18:16:26] #123: (GT) S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/123 [18:16:41] that one is a must-do, yes, but not directly related to slow image load [18:16:47] True [18:16:53] I'd say blocker for coming out of beta at least [18:17:09] Which I suppose is our definition of "must have" [18:17:29] I think next week we'll have bandwidth for that one, especially since the weekly meeting is on wednesday instead of thursday, I think a good portion of this week is going to spill into next's [18:18:08] a lot of hard stuff being worked on, I doubt they'll all get out of code review during a short week [18:18:53] Yeah [18:19:01] We'll do what we can [18:19:25] #136: (GD) I:#F2-S1 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136 [18:19:26] #136: (GD) O:GD|S:RfE -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136 [18:22:57] (03PS1) 10MarkTraceur: WIP: Pulling init stuff into lightweight module [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110599 [18:23:00] So not ready. [18:23:26] (03CR) 10jenkins-bot: [V: 04-1] WIP: Pulling init stuff into lightweight module [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110599 (owner: 10MarkTraceur) [18:23:31] Hurr durr [18:40:54] (03CR) 10Gergő Tisza: [C: 032] Fix the "view all uses" link when there are both local and global results [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110517 (owner: 10Gilles) [18:41:27] (03Merged) 10jenkins-bot: Fix the "view all uses" link when there are both local and global results [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110517 (owner: 10Gilles) [18:49:43] (03PS1) 10Gergő Tisza: Fix globalusage link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110607 [18:50:26] #44: (GT) https://gerrit.wikimedia.org/r/110607 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44 [18:50:57] (03CR) 10Aarcos: Hide the fullscren button when fullscreen is unavailable (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110525 (owner: 10Gilles) [19:07:21] OK, for unknown reasons, the eventlogging tests freak out for me [19:08:24] (03PS8) 10MarkTraceur: Add categories to the interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 [19:08:26] (03CR) 10jenkins-bot: [V: 04-1] Add categories to the interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [19:08:40] (03CR) 10MarkTraceur: Add categories to the interface (038 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [19:08:46] Tests, breaking!? the horrors [19:08:50] Yeah [19:08:52] Oh FFS [19:08:59] Probably need a rebase or something similarly stupid [19:11:46] (03PS9) 10MarkTraceur: Add categories to the interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 [19:11:47] Doooone [19:12:59] Hm, maybe the test fails on my localhost are a firefox bug or something [19:22:46] gi11es: Did you change the categories patch to use commas as separators? [19:23:24] And if so...where [19:23:29] Because I don't see it [19:30:35] Oh, hm [19:30:38] It's hidden in the CSS [19:30:42] That's kinda annoying [19:30:54] Especially since it's not localisable or really even discoverable [19:31:31] Will comment [19:32:20] (03CR) 10Gergő Tisza: [C: 031] Hide the fullscren button when fullscreen is unavailable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110525 (owner: 10Gilles) [19:33:39] (03CR) 10Raimond Spekking: Add file usage data to MMV metadata panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [19:43:05] (03CR) 10Gergő Tisza: Add file usage data to MMV metadata panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [19:45:06] (03CR) 10Raimond Spekking: "Hmmm I am wrong? Calling Niklas as reviwer." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [19:52:07] (03CR) 10MarkTraceur: [C: 04-1] Add categories to the interface (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [19:52:59] (03CR) 10MarkTraceur: Add categories to the interface (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [19:53:06] gi11es: Back in your court [20:02:48] aarcos: I've been told to assist you with refactoring things [20:03:08] I will do this immediately upon return from purchasing delicious pig corpse bits from the corner store [20:03:32] But a pointer as to where I will be most useful might be good [20:03:52] I assume this is card 124 which is quite a beast [20:11:08] marktraceur: Hey !, #124 is really big and that will be the main topic of discussion on Monday, how are we going to do this? I have some ideas, Gergo and Gilles too. Not sure if actual work can start on that card before we agree on something. If you are idle, I think card #151 hasn't been taken yet. [20:16:02] Ah. [20:16:05] 'kay [20:16:09] Oh, hm. [20:22:37] marktraceur: or if you have some ideas on what to do with this card, start sketching them in a patch and send them to the team. That will bring some concrete options to the discussion. [20:23:05] marktraceur: Your call, I trust your judgement, ;-). [20:29:44] aarcos: I'm intrigued by the fullscreen one, and would like to work on it, but I first want to understand who made this decision and why [20:32:25] #151: (MH) I thought that we would want to preserve all po... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [20:32:36] This is something we discussed in the planning meeting, you can ask Fabrice for the details if you need them. [20:36:12] Yeah, will do [20:39:05] Asked [20:39:11] I'll draw up thoughts about ui refactor [20:41:23] (03Abandoned) 10MarkTraceur: Dumb commit (DO NOT MERGE PLEASE GOD) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108866 (owner: 10MarkTraceur) [20:42:06] Didn't I add a ui directory at some point [20:42:10] Hrm [20:42:17] Maybe that should happen [20:49:44] (03CR) 10Gergő Tisza: [C: 04-1] "Very elegant code! There is one issue with handling unsuccessful fullscreen transitions (you can test e.g. by setting the fullscreen permi" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110579 (owner: 10Gilles) [20:51:25] #150: (GT) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/150 [20:53:20] (03CR) 10Gergő Tisza: [C: 032] Place the metadata correctly before opening the lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110530 (owner: 10Gilles) [20:53:53] (03Merged) 10jenkins-bot: Place the metadata correctly before opening the lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110530 (owner: 10Gilles) [20:54:25] #141: (GT) DDE:3J2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/141 [20:55:25] #152: (GT) B:B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/152 [21:03:39] (03CR) 10Aarcos: [C: 04-1] "Looking good !, only some readability issues and organization of tests." (038 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110579 (owner: 10Gilles) [21:05:01] Did we, um...break native browser arrow scrolling? [21:05:25] #153: (GT) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/153 [21:05:32] Like, the whole thing about one-touch expansion of the metadata is cool [21:05:36] But doing it backwards is silly [21:12:25] #151: (F) Yes, we still want to use all the possible scre... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [21:14:37] (03CR) 10Gergő Tisza: "I would prefer if we used anchor-encoding for the hash in the first place:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110522 (owner: 10Gilles) [21:15:25] #151: (MH) Hm. OK, I can see the value there. Can you plea... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [21:15:54] fabriceflorin: ^^ responded on #151 [21:15:58] fabriceflorin: Do you know why the arrow actions in the lightbox are reversed? [21:17:52] Specifically when I try to scroll down, it does nothing, but scrolling up scrolls me down [21:17:55] Which arrow actions seem to be reversed? The left/right or up/down? They work for me on beta. [21:18:05] And then when I'm scrolled down and try scrolling down more it scrolls me up [21:18:41] I expect this is us overriding native browser behaviour for some reason but I'm not sure what that reason is [21:21:27] #151: (MH) Also there's nothing about it being invisible b... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [21:25:38] marktraceur: Hmm. I'm not able to reproduce this behavior in Chrome. Which browser are you using? Are you testing on the usual beta site? http://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo#mediaviewer/File:Wikimedia Foundation 2013 All Hands Offsite - Day 2 - Photo 24.jpg/1 [21:25:56] fabriceflorin: I'm testing locally, let me try on beta [21:26:40] fabriceflorin: Yeah, beta does the same thing. If I press the down arrow it does nothing, and if I press the up arrow it inexplicably scrolls down [21:26:51] Totally borked from a what-I-expect-my-browser-to-do perspective [21:27:35] Still cannot reproduce on my end. Which browser are you using? [21:27:41] Firefox [21:27:47] * marktraceur tries with chromium [21:27:54] OK, let me try my Firefox as well. [21:28:07] Oh, hah, wonderful [21:28:15] Chromium isn't in the repos for Trisquel [21:28:20] * marktraceur loves this idea [21:30:05] Hmm, I can't reproduce in Firefox either. When I click on the up arrow, it goes up as intended. Same for the down arrow. Arrow keys also seem to work for me. Trying Safari now. All this is for the link above. [21:30:33] No [21:30:47] fabriceflorin: Watch the _scroll bar_. You're scrolling _down_ when you push the up arrow. [21:31:01] The metadata div is below the image [21:31:07] So when you see more of the metadata, that's scrolling down [21:31:08] Not up [21:33:11] I personally don't have any issues with the current behavior on my end, and I don't believe any of the other team members have experience this issue. Perhaps you could ask Pau to look at this again? The best way to do this would be to do some usability testing, and see if users are confused. [21:33:23] Was this a Pau decision? [21:33:48] I can sort of see users being able to adopt to any control scheme [21:33:53] marktraceur: Yes, Pau approved everything, so I don't understand what the problem is. [21:34:00] But it would be better if we weren't reinventing a scheme that already exists [21:34:03] Like scrolling down [21:34:58] marktraceur: Is this a bug, or is this a user experience issue? If it's a user experience issue, you can bring it up to Pau, and I defer to his judgment. But from a product perspective, I am happy with the current behavior. [21:35:15] It's sort of both [21:35:37] Can this wait until Monday, so I can see if your computer behaves differently? [21:36:30] Meanwhile, I will expand the Mingle card to include more details, as you suggest. [21:36:31] fabriceflorin: We're unnecessarily isolating the user from the fact that they're in a browser. This adds work for us, and adds confusion for users (like me) who understand how their browsers work, adds confusion when scrolling up and down works sometimes (with swiping or scroll wheels) but is backwards other times (arrow keys) [21:37:07] marktraceur: Bring this up with Pau, it's his domain of expertise, not mine. I defer to his judgment. [21:37:11] Righty-o [21:38:05] But I am not experiencing the same problem as you do, so it's possible this may be a bug on your end. On my end, scrolling and arrows work the same. [21:38:18] You *are* experiencing it [21:38:42] fabriceflorin: When you open the lightbox, and the metadata div is hidden, and you hit the up arrow, the metadata div expands. Right? [21:38:47] Let's revisit this on Monday, and compare our computers to see if they are behaving differently. [21:41:41] I would also want Gilles in the loop, as he may be the one who made the final call on his end. [21:42:13] FFS OK [21:42:33] gi11es: If you're around, your thoughts on this may be useful [21:42:43] If they're brief [21:42:47] I guess we can talk about it more on Monday [21:49:26] #151: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [21:50:01] * marktraceur grumbles about crashes [21:50:26] #151: (F) OK, I updated this card based on comments below... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [21:59:55] [/jf [21:59:57] Argh [22:24:26] #151: (MH) Yup: Now you've changed the criteria and it's a... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/151 [22:24:42] fabriceflorin: ^^ minor question [22:29:42] (03CR) 10Aarcos: [C: 031] "LGTM, feel free to merge at your convenience." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110607 (owner: 10Gergő Tisza) [22:37:08] * marktraceur is vaguely weirded out by the

for the file usage data [22:37:16] I'm a picky bastard [22:40:22] (03CR) 10Gergő Tisza: [C: 032] "Merge per Aarcos." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110607 (owner: 10Gergő Tisza) [22:41:13] (03Merged) 10jenkins-bot: Fix globalusage link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110607 (owner: 10Gergő Tisza) [22:41:22] * marktraceur is writing things in https://etherpad.wikimedia.org/p/multimediaviewer-ui-refactor [22:42:25] #44: (GT) S:RfT|DDE:3J2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44 [22:51:18] Hi marktraceur : Thanks for writing up your concern to Pau in such a clear way. I now understand what you mean. Sometimes, longer form can be clearer for me than short bursts over IRC. [22:52:39] Interestingly, this relates to my own proposal, voiced a month ago, that the chevron should be pointing down by default, not up; I was also thinking along the same lines as you did regarding scrolling, but Pau had a strong rationale for why he wanted it up, so I didn't push it further, since it's his area of expertise, not mine. I have now grown accustomed to the current UI, though I see your point about the down [22:52:39] scrolling expectation. I think Pau will give it due consideration, and I also recommend some usability study on this point. [22:53:18] I mean [22:53:23] To some extent that's nice [22:53:26] Either way, we'll get to the bottom of it. But thanks for bringing this up and articulating the issue clearly. [22:53:33] But to a greater extent in my opinion it seems like a largely technical issue [22:55:26] This is a tricky issue, which impacts both technology and psychology. So much so that Apple gives the users the option to have their mouses scroll up or down when they swipe them up. Given their focus on UI simplicity, they wouldn't be giving this option to users if this wasn't an area where people are divided in their desires. [22:55:50] There is no such option for arrows [23:05:20] marktraceur fabriceflorin regarding the scrolling issue, I think it's the same debate as the chevron and I don't think we can really come to a consensus, we might as well A/B test that stuff [23:05:37] for example OS X by default makes the trackpad work in the same direction for scrolling as touchscreens [23:05:54] I always turn it to the opposite setting, but I know I'm probably the minority [23:05:59] There's ambiguity in that, though! [23:06:14] You could either be dragging the viewport or the thing behind the viewport [23:06:17] I think different people find one or the other the more logical one [23:06:27] The arrow key has always always meant "move the viewport this direction" [23:06:33] Nobody is confused about that [23:06:47] And that's why Mac doesn't have some mystical and very confusing "reverse the arrow keys" option [23:06:55] you consider the screen going down, fabrice considers the panel going up [23:07:11] nobody's right and everyone's right [23:07:21] that doesn't answer what most users think is right [23:07:40] which is what matters, not our respective preferences [23:07:56] Hm. [23:07:57] 'kay [23:08:11] personally, I don't care either way for this particular one and I don't think that voting within the team is going to give us a better answer than flipping a coin [23:08:14] A/B test sounds like fun - let's start a card for such things [23:08:45] gi11es: Yes, I agree. I think it's a tough issue to resolve, but usability tests can help, even before we go to A/B tests, which are hard to do in our environment. I also don't think it's a catastrophic issue. We have voiced our concerns clearly. Now let's Pau do his job, in the same way as he lets us do ours. I trust his judgment. [23:11:23] here's a version that hasn't been considered: what if up arrow and down arrow just flip between open and closed, regardless of which one you press? [23:11:49] this way it works regardless of one's logical preference [23:11:58] That "fixes" it, except for situations where we're in-between, or where the metadata div has more information than we can show on one screen [23:12:18] We haven't really thought about the latter yet anyway, but we can deal with it soon [23:12:54] having a bigger-than-one-screen metadata area changes the dynamic of the page, I think, if it becomes the common case [23:13:37] With the amount of stuff in the mockups, that's where we're heading [23:13:49] At which point having arrow keys that do what you expect might be useful [23:14:16] when we get to that point I think it should look less like a panel. the current graphic design suggests that what underneath is small [23:14:39] and if you change the look, the perception of what would happen with scrolling could change too [23:15:09] This is Pau's deal, but I think the idea is that the little tip we have now would become a static header once it reaches the top of the page, and you could continue scrolling [23:15:20] right now it doesn't feel like "you're looking at the top and there's so much more below" as in can on medium or on the fancy NYT interactive articles, imho [23:15:32] *as it can [23:17:40] Right [23:18:12] I look forward to usability tests and Pau's recommendation on this issue. There is no sense debating endlessly without our designer being present. But I appreciate that you brought this up marktraceur :) [23:18:22] Well yeah [23:18:27] It's gonna bug me 'til it's fixed so [23:18:37] Makes sense that I would, I suppose [23:18:39] https://www.macupdate.com/app/mac/39694/natkeyscroll-safari-extension/ <- further proof that people are weird, marktraceur ;) [23:18:54] Because I need to distrust humans more right now [23:19:12] Oh my god why [23:19:25] 181 downloads [23:19:27] I have some faith left [23:19:51] gi11es: For the record, I too always reset my Magic Mouse to be the opposite of default, for what it's worth :) I can't explain why, it just feels more natural to me than what they call the 'natural' setting. I guess some people are wired differently than others. C'est la vie :) [23:20:09] I guess we're not the tablet generation [23:20:44] Personally, I like that we're not as perfect as machines. It makes us more endearing as a species ... [23:21:33] On that note, I guess I better get back to my scheduled work ... and let you enjoy your weekend, Gilles. Adios! [23:21:33] as for the CSS commas marktraceur I'm getting mixed signals... full-blown icons as pseudo elements that required me to write 10 lines of JS injecting inline styles are ok, but commas aren't? [23:22:39] again I don't care either way, I'm capable of comma-separating in JS, but in that case I think we should lay the icons out with classic CSS, if we're avoiding pseudo-elements because they require inspecting the page [23:22:44] (03CR) 10Aarcos: [C: 04-1] "As discussed verbally, I don't see much value out of creating this component. It is non-trivial to write and it will increase complexity. " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110508 (owner: 10Gergő Tisza) [23:23:52] gi11es: We can fix both! I'm not married to list-items-as-metadata-containers. [23:24:02] It seemed elegant when I wrote it at first, not necessarily anymore [23:24:21] alright, then let's do that. we can say that pseudo-elements should be reserved for situations where they achieve something that can't be done easily in a classical fashion [23:25:13] also, in case you haven't seen pau's latest designs, the comma-separation is just temporary [23:25:57] the new look is having each category on a grey background [23:26:53] but doing that on its own, just for categories, didn't seem like it would really fit well in the old design [23:28:10] Right [23:28:22] gi11es: The additional concern over i18n was the real biggie though [23:28:46] so the entire thing should be wrapped in an i18n call? [23:29:03] as soon as it's comma-separated? [23:29:18] No no [23:29:28] gi11es: The comma itself needs to be localisable [23:29:35] So use the comma-separator message [23:29:40] oh, got it [23:29:40] But you can't use messages in CSS [23:30:15] Maybe that should be possible, but I don't think it's the LangEng team's first priority right now [23:30:19] :P [23:30:20] for a moment I thought it went further than that in case some languages uses different separators depending on the amount of items in the list, for example [23:30:35] Hm, I don't think so [23:33:42] we also do quotation marks properly, fancy! [23:34:16] it's a nice change from my previous workplaces where the i18n strategy pretty much boiled down to "the rest of the world should learn english" [23:35:01] Heh [23:35:20] gi11es: We, the Multimedia team? I don't remember needing to do anything with quotation marks so far... [23:35:32] I remember wringing my hands over the geolocation stuff, but that was recent [23:35:49] no I meant mediawiki in general, I just saw the i19n definitions of all those things when I looked for the comma in other languages [23:35:57] i18n [23:36:12] Ah, yup [23:37:52] gi11es: You're around pretty late today! [23:38:24] (03CR) 10Gergő Tisza: [C: 04-1] "* Thumbs.db is something added by your computer, not a part of Leaflet (Windows has the annoying habit of creating it in every directory w" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 (owner: 10Inchikutty) [23:38:30] I'm not really working, I just left the laptop open by accident and saw the notifications when I walked by [23:38:41] Hah [23:38:45] Gotta be careful about that [23:39:02] about ninjas climbing through the window and stealing my laptop? [23:39:15] I have anti-ninja systems [23:39:43] No, letting yourself see the computer after work hours [23:39:47] Dangerous stuff [23:42:15] I mainly came to check on my IE vm downloads. I can barely contain the excitement of installing all these IEs on that new laptop... [23:43:33] Hah, I think I remember seeing that site [23:43:42] http://modern.ie/en-us/virtualization-tools#downloads [23:43:43] Stallman protect you, brave soul [23:47:22] (03CR) 10Gergő Tisza: [C: 04-1] Embedding Static Map to UploadWizard [OPW Round 7 project part 1] (036 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [23:50:21] lol [23:53:44] I've just verified something that's going to allow me to pull off the greatest trick... [23:53:58] HEAD requests are enough to trigger thumbnail generation [23:54:04] Oh man. [23:54:09] which means that we can add a little hack in uploadwizard... [23:54:20] that's going to generate the bucket sizes we need [23:54:20] That should totally not be the case but still [23:54:33] without wasting people's bandwidth [23:54:40] all we need is the green light from ops [23:54:41] gi11es: HTTP standards aside, will ops be OK with that? [23:54:44] Ah, OK [23:54:52] bryan thinks so [23:55:01] * marktraceur eyes bd808|BUFFER cautiously [23:55:04] I'm waiting on an opsoid to respond [23:55:50] Are there ops still on staff this week? I've lost count >.< [23:56:18] well my friend chase is interviewing right now, fingers crossed :) [23:56:20] (of course I'm kidding, but still) [23:56:27] Ooh, cool beans [23:56:33] Hm, I should tell my roommate. [23:56:58] if chase gets in, I'll be our permanent backdoor into ops ;) [23:57:00] Then again, friction maybe. [23:57:02] Hah [23:57:16] (03CR) 10Aarcos: [C: 04-1] "Found some more nits, plus Mark's concerns." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [23:58:18] re: HEAD, I figured than even if that didn't work, it's just a matter of doing a GET and cutting off the connection ASAP [23:58:39] which has almost the same effect, so really preventing HEAD from behaving that way isn't that much protective [23:59:10] (03CR) 10MarkTraceur: Add categories to the interface (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [23:59:17] that being said, our current free-for-all thumbnail sizing has great DDOS potential... [23:59:33] Oh yeah. [23:59:36] Even with HEAD. [23:59:43] Maybe especially with HEAD.