[00:06:26] #139: (GT) S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/139 [00:06:26] #44: (GT) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/44 [00:07:59] (03PS1) 10Aarcos: Refactor image load code, add unit tests. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110105 [00:08:31] (03CR) 10jenkins-bot: [V: 04-1] Refactor image load code, add unit tests. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110105 (owner: 10Aarcos) [00:11:53] (03PS2) 10Aarcos: Refactor image load code, add unit tests. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110105 [00:16:28] #144: (AA) S:IA|O:AA|I:#B|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/144 [00:16:28] #144: (AA) R:#MQ|I:#J2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/144 [00:16:28] #144: (AA) S:RfE -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/144 [00:16:28] #144: (AA) DAE:2J2|S:RfD|O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/144 [00:17:27] #144: (AA) O:AA|DDS:2J2|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/144 [00:18:27] #144: (AA) https://gerrit.wikimedia.org/r/#/c/110105/ S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/144 [00:45:57] (03PS9) 10Aarcos: Add functionality to specify the MEDIAWIKI_PASSWORD_VARIABLE environment variable that points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [01:03:27] (03CR) 10Aarcos: Fixes bug where next/prev would exit fullscreen mode (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109682 (owner: 10Gilles) [01:11:24] (03CR) 10Aarcos: [C: 04-1] Test metadata visibility in fullscreen mode (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109866 (owner: 10Gilles) [01:56:01] (03CR) 10Gergő Tisza: Chevron/metadata UI behavior improvements (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109023 (owner: 10Gilles) [01:58:36] Hmm, DjVu commits don't go over here? [02:16:28] (03CR) 10Aarcos: [C: 04-1] Chevron/metadata UI behavior improvements (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109023 (owner: 10Gilles) [02:21:45] (03CR) 10Aarcos: [C: 031] "I just changed this so we have 3 options to get the password: argument, MEDIAWIKI_PASSWORD and MEDIAWIKI_PASSWORD_VARIABLE. This is more c" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [02:42:55] (03CR) 10Gergő Tisza: [C: 04-1] "IMO the bug description is wrong; these help texts should be set as the alt attribute, not the title attribute. See for example http://sta" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 (owner: 10Apsdehal) [02:53:09] (03CR) 10MarkTraceur: "w/r/t title vs. alt, that's super annoying, sometimes standards annoy me." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 (owner: 10Apsdehal) [02:53:43] (03CR) 10Gergő Tisza: "I think this can be abandoned, everything is embedded already." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104325 (owner: 10Apsdehal) [03:22:57] (03CR) 10Gergő Tisza: "> that the difference (IIRC) was that prop sets the value in the DOM and attr sets it in the HTML and triggers a re-parse (or similar)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 (owner: 10Apsdehal) [03:28:49] (03CR) 10Gergő Tisza: [C: 032] Add functionality to specify the MEDIAWIKI_PASSWORD_VARIABLE environment variable that points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [03:28:59] (03Merged) 10jenkins-bot: Add functionality to specify the MEDIAWIKI_PASSWORD_VARIABLE environment variable that points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [05:46:39] (03PS3) 10Inchikutty: (WIP)Embedding Static Map to UploadWizard- part of OPW round 7 Project [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [05:59:32] (03PS4) 10Inchikutty: (WIP)Embedding Static Map to UploadWizard- part of OPW round 7 Project [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [07:09:42] (03CR) 10Gilles: Fixes bug where next/prev would exit fullscreen mode (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109682 (owner: 10Gilles) [07:11:25] #139: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/139 [07:14:25] #140: (GD) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/140 [07:30:55] (03CR) 10Gilles: Chevron/metadata UI behavior improvements (036 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109023 (owner: 10Gilles) [07:32:25] #145: (GD) S:IA|I:#B|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/145 [07:33:25] #145: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/145 [07:33:25] #96: (GD) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/96 [07:38:06] (03CR) 10Gilles: Test metadata visibility in fullscreen mode (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109866 (owner: 10Gilles) [08:25:17] (03PS2) 10Gilles: Test metadata visibility in fullscreen mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109866 [08:25:28] (03CR) 10Gilles: Test metadata visibility in fullscreen mode (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109866 (owner: 10Gilles) [09:07:53] (03PS4) 10Gilles: Chevron/metadata UI behavior improvements [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109023 [09:08:00] (03CR) 10Gilles: Chevron/metadata UI behavior improvements (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109023 (owner: 10Gilles) [09:35:00] (03CR) 10Gilles: [C: 04-1] Refactor image load code, add unit tests. (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110105 (owner: 10Aarcos) [09:36:26] #144: (GD) S:R -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/144 [10:50:32] (03PS9) 10Gilles: Fix resize engine for fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 (owner: 10MarkTraceur) [10:52:45] (03CR) 10Gilles: [C: 032] "I had to tweak a few things once rebased + fix the broken logic for passing the viewer" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 (owner: 10MarkTraceur) [10:53:14] (03Merged) 10jenkins-bot: Fix resize engine for fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 (owner: 10MarkTraceur) [10:54:25] #73: (GD) O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [10:54:26] #73: (GD) DDE:2J2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [10:54:26] #73: (GD) http://en.wikipedia.beta.wmflabs.org/wiki/Light... O:GD|DTS:2J2|S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/73 [11:05:25] #107: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/107 [11:59:34] pginer: is there a mockup that shows when an image is in multiple categories? marktraceur implemented it this way: https://www.dropbox.com/s/8vgedwp0dsbooqo/Screenshot%202014-01-29%2012.59.17.png I wanted to make sure that's what you wanted [12:01:34] (03CR) 10Gilles: "I'm going to rebase first since it's a PIA with a ton of conflicts, then I'll address my own concerns about add/set and assertions." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [12:02:11] gi11es: we do not need to repeat the category icon if that appears as the last section. [12:02:49] pginer: ok, so 2nd and 3rd have no icon, but do they need to be on their own line like they are now? [12:02:56] My original idea was to allow them to appear as a comma separated list, [12:03:43] maybe in practice category names tend to be very long [12:03:59] should I make it a comma-separated list with line wrapping? [12:04:52] (03PS4) 10Gilles: Add categories to the interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [12:06:20] (03PS5) 10Gilles: Add categories to the interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [12:06:25] In the recent discussions, to integrate the concept of "assessment" I proposed to present assessment info ("picture of the day") as well as categories in a different way: https://docs.google.com/a/wikimedia.org/document/d/1sWzN4Qo-5lqyyoKUUwOWO-rAzFpn3T7jDPyflmS027I/edit#heading=h.bxfbkf5h34xd [12:06:54] (last mockups of the document) [12:09:37] (Colloquy crashed) [12:10:26] I'm not sure if it is preferred to support categories as illustrated in the recent doc, or make the changes once the assessment" tags [12:10:33] are in progress [12:56:02] I think I'll go with comma-separated for now, it's a decent compromise [13:43:17] (03PS6) 10Gilles: Add categories to the interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [13:43:45] (03CR) 10jenkins-bot: [V: 04-1] Add categories to the interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [13:46:14] (03PS7) 10Gilles: Add categories to the interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [13:47:58] (03CR) 10Gilles: "This needs review, as I had to modify Mark's original changeset significantly to make it work + changed the layout following the discussio" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur) [13:49:25] #41: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/41 [13:49:26] #41: (GD) O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/41 [13:52:05] (03CR) 10Gilles: "See Pau's email and the updated mingle card for actual colors, etc." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [15:12:26] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [18:01:19] 1 on 1 with rob going over a bit, I'll be there in a sec [18:01:31] gi11es: ok [18:28:18] (03CR) 10Aarcos: Fixes bug where next/prev would exit fullscreen mode (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109682 (owner: 10Gilles) [18:34:00] (03CR) 10Gergő Tisza: [C: 031] Test metadata visibility in fullscreen mode [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109866 (owner: 10Gilles) [18:34:11] am I missing a google hangout link somewhere? can't find any on the calendar [18:34:41] Yes. I have 2 calendar invites, but not hangout link on them [18:35:12] https://plus.google.com/hangouts/_/calendar/ZmZsb3JpbkB3aWtpbWVkaWEub3Jn.jd2fk9pjcia056grilm0f3l9oc [19:35:26] #146: (GT) S:IA|R:#MQ|I:#J2-S3|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/146 [20:03:25] (03CR) 10Aarcos: [C: 031] "This LGTM, just one style comment, merge at your convenience." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109866 (owner: 10Gilles) [20:51:46] (03CR) 10Aarcos: Chevron/metadata UI behavior improvements (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109023 (owner: 10Gilles) [21:03:15] (03CR) 10Aarcos: [C: 031] "Looks better now, I can understand it, ;-). Just some suggestions about comments, otherwise looks good on my side." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109023 (owner: 10Gilles) [21:49:25] #79: (F) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/79 [23:12:26] (03CR) 10Nemo bis: Fix the i18n source string for the chunked preference (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [23:33:38] (03CR) 10Aarcos: [C: 04-1] Add categories to the interface (038 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109031 (owner: 10MarkTraceur)