[00:54:30] (03PS7) 10Gergő Tisza: WIP Trying to install PIL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [00:56:10] (03PS8) 10Gergő Tisza: WIP Trying to install PIL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:05:10] (03PS9) 10Gergő Tisza: WIP Trying to install PIL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:09:51] (03CR) 10Gergő Tisza: "Tested on cloudbees, the current version works." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:14:40] (03CR) 10Gergő Tisza: "Note that the subdir is called 'tests' now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:23:13] (03CR) 10Aarcos: [C: 031] "Thanx for testing Gergo !" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:25:20] (03PS10) 10Gergő Tisza: WIP Trying to install PIL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:25:45] (03CR) 10Gergő Tisza: [C: 032] "Merging based on Aarcos' +1." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:25:52] (03Merged) 10jenkins-bot: Change requirements.txt so that PIL actually installs on Cloudbees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:31:14] (03PS2) 10Inchikutty: Adding Leaflet scripts to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [01:45:23] (03PS1) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [01:45:53] (03PS1) 10Aarcos: Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 [01:45:56] (03CR) 10jenkins-bot: [V: 04-1] Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 (owner: 10Aarcos) [01:47:27] (03PS2) 10Gergő Tisza: Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 (owner: 10Aarcos) [02:01:47] (03CR) 10Gergő Tisza: [C: 032] Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 (owner: 10Aarcos) [02:02:24] (03Merged) 10jenkins-bot: Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 (owner: 10Aarcos) [02:09:26] (03PS1) 10Aarcos: Fix to streching image b/60173. It seems the problem was iOS specific. In retina displays the devicePixelRatio turns out to be 2. This was making the images twice as wide. This was introduced as a way to fix the resolution problem with some Apple device [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109268 [02:12:25] #102: (AA) Please review patch: https://gerrit.wikimedia.o... S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/102 [02:30:07] (03PS19) 10Gergő Tisza: Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [02:30:09] (03CR) 10jenkins-bot: [V: 04-1] Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [02:35:11] (03CR) 10Gergő Tisza: [C: 032] "Can't test the Mac-specific error, but works on Ubuntu and looks reasonable." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109268 (owner: 10Aarcos) [02:35:39] (03Merged) 10jenkins-bot: Fix to streching image b/60173. It seems the problem was iOS specific. In retina displays the devicePixelRatio turns out to be 2. This was making the images twice as wide. This was introduced as a way to fix the resolution problem with some Apple device [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109268 (owner: 10Aarcos) [02:38:05] (03PS20) 10Gergő Tisza: Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [02:41:44] (03PS3) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [02:43:25] #135: (AA) S:IA|I:#B|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/135 [02:44:25] #135: (AA) R:(s|I:(s|T:B -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/135 [02:45:25] #135: (AA) R:#MQ|I:#J2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/135 [02:45:25] #135: (AA) I:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/135 [02:45:25] #135: (AA) I:#J2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/135 [02:49:43] (03PS2) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [02:51:34] (03PS4) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [02:52:15] (03PS3) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [03:02:50] (03PS4) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [03:26:52] (03PS5) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [06:34:57] (03PS6) 10Inchikutty: Embedding static and leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [13:40:37] (03PS12) 10Theopolisme: Enable fullscreening with jquery.fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 [15:35:30] (03PS1) 10MarkTraceur: Moving things around for module renames [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109298 [15:35:32] (03PS1) 10MarkTraceur: Move models to their own modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109299 [15:35:34] (03PS1) 10MarkTraceur: Make Model base class, give it get and set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109300 [15:35:36] (03CR) 10jenkins-bot: [V: 04-1] Moving things around for module renames [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109298 (owner: 10MarkTraceur) [15:35:38] (03CR) 10jenkins-bot: [V: 04-1] Move models to their own modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109299 (owner: 10MarkTraceur) [15:35:40] (03CR) 10jenkins-bot: [V: 04-1] Make Model base class, give it get and set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109300 (owner: 10MarkTraceur) [18:13:35] (03CR) 10Hashar: "Congratulations guys in figuring out a solution there! You are the bests." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [18:48:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [18:58:00] (03CR) 1001tonythomas: "Should something more be done here ?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108317 (owner: 1001tonythomas) [19:25:04] (03PS2) 10MarkTraceur: Move models to their own modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109299 [19:25:06] (03PS2) 10MarkTraceur: Moving things around for module renames [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109298 [19:25:08] * marktraceur uploads all the things [19:25:08] (03PS2) 10MarkTraceur: Make Model base class, give it get and set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109300 [19:25:10] (03PS1) 10MarkTraceur: Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 [19:25:39] (03CR) 10jenkins-bot: [V: 04-1] Move models to their own modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109299 (owner: 10MarkTraceur) [19:25:57] FFS. [19:26:43] I'll maybe work on the jshint failures during the next session. [19:26:43] (03CR) 10jenkins-bot: [V: 04-1] Make Model base class, give it get and set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109300 (owner: 10MarkTraceur) [19:27:12] (03CR) 10jenkins-bot: [V: 04-1] Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 (owner: 10MarkTraceur) [19:32:10] marktraceur: do the jasmine tests in UW run automatically? [19:32:24] Uh, no, they don't run at all [19:32:25] i want to relocate them and get rid of the test directory [19:32:37] Basically an rm -rf tests/jasmine would be awesome [19:32:50] i'll do that then [19:32:51] But confirm with Chris or Zeljkof or something [19:32:57] ok [19:33:03] I think I have asked them before but failed to be certain [19:33:11] Anyway, back to no-ethernet land [19:48:55] (03PS1) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 [19:49:25] (03CR) 10jenkins-bot: [V: 04-1] Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos) [19:50:07] (03CR) 10Legoktm: [C: 04-1] Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos) [19:56:22] (03CR) 10Gergő Tisza: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos) [19:58:47] (03CR) 10Gergő Tisza: [C: 032] Moving things around for module renames [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109298 (owner: 10MarkTraceur) [19:59:21] (03Merged) 10jenkins-bot: Moving things around for module renames [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109298 (owner: 10MarkTraceur) [20:04:46] (03PS2) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 [20:04:57] (03CR) 10jenkins-bot: [V: 04-1] Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos) [20:09:42] (03PS3) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 [20:09:45] (03CR) 10jenkins-bot: [V: 04-1] Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos) [20:10:49] (03CR) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos) [20:31:38] (03CR) 10Gergő Tisza: "I'm not sure I see the value in this. Putting field names into string constants means placing them outside static analysis. A good IDE or " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109300 (owner: 10MarkTraceur) [20:32:24] (03PS4) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 [20:45:41] (03PS3) 10MarkTraceur: Move models to their own modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109299 [20:45:43] (03PS3) 10MarkTraceur: Make Model base class, give it get and set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109300 [20:45:46] (03PS2) 10MarkTraceur: Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 [20:45:49] Trying again! [20:46:48] (03CR) 10jenkins-bot: [V: 04-1] Make Model base class, give it get and set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109300 (owner: 10MarkTraceur) [20:46:58] Ah, christ [20:47:16] (03CR) 10jenkins-bot: [V: 04-1] Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 (owner: 10MarkTraceur) [20:47:38] FFS [20:49:30] (03PS4) 10MarkTraceur: Make Model base class, give it get and set [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109300 [20:49:32] (03PS3) 10MarkTraceur: Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 [20:50:31] (03CR) 10jenkins-bot: [V: 04-1] Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 (owner: 10MarkTraceur) [20:54:05] (03PS4) 10MarkTraceur: Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 [20:54:41] (03CR) 10jenkins-bot: [V: 04-1] Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 (owner: 10MarkTraceur) [20:55:01] Gahhh [20:55:37] (03PS5) 10MarkTraceur: Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 [20:56:58] #wikimedia-multimedia, alternatively entitled #mark-swears-at-jenkins [21:45:47] * marktraceur realizes that he still hasn't done the lazy-loading init thing for MMV, feels guilty about listening to a talk about it instead of working on it [21:47:45] make a mingle card for it [21:48:16] I think I'm "just" going to do it [21:48:47] it needs to be tracked, it's not a tiny task, it will skew our velocity measurement if we do that sort of stuff untracked [21:48:59] *shrug* 'kay [21:49:14] It's not that big of a task, basically just tearing init things out of mmv.js [21:49:39] it's still going to go through review, etc. [22:05:51] (03CR) 10Gergő Tisza: [C: 04-1] "(forgot to score, see comments above)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109300 (owner: 10MarkTraceur) [22:14:25] #102: (AA) S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/102 [22:16:25] #75: (AA) I:#J2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/75 [22:17:25] #136: (MH) S:IA|I:#B|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136 [22:18:25] #75: (AA) S:IT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/75 [22:19:26] #75: (AA) I:#J2-S1 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/75 [22:19:26] #75: (AA) S:A -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/75 [22:21:17] #136 is the one I'll be working on [22:21:25] #136: (MH) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136 [22:22:25] #136: (MH) R:#MQ|I:(s -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136 [22:22:25] #136: (MH) R:#MQ|I:#J2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/136 [22:27:27] (03CR) 10Gergő Tisza: [C: 031] Add Thumbnail model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109331 (owner: 10MarkTraceur) [22:28:14] (03CR) 10Gergő Tisza: [C: 032] "Tested on Cloudbees." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos) [22:28:24] (03Merged) 10jenkins-bot: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos) [22:29:25] #137: (AA) S:ID|O:AA|I:#B|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/137 [22:42:25] #137: (AA) R:#MQ|I:#J2-S2 -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/137 [22:44:25] #137: (AA) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/137 [22:46:25] #137: (AA) All the changes requested by the QA team have b... S:ACR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/137 [22:46:25] #137: (AA) DDE:2J2|S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/137 [22:57:43] (03PS21) 10Gergő Tisza: Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [23:00:50] Ugh [23:01:03] I think I'm now approaching a point where it's basically useless to have two separate codebases [23:01:11] And we should just have our system [23:01:31] Instead of trying to keep multilightbox separate [23:01:38] Otherwise I think I can't do the init patch. [23:01:47] Or it would be unnecessarily complex [23:01:56] are these generic lightbox classes used by other projects? [23:02:15] No, I was hoping it would be mature enough eventually to be useful, but it's just us now [23:21:41] (03CR) 10Gergő Tisza: "Switched to the new mmv naming convention." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [23:23:56] (03CR) 10Gergő Tisza: [C: 032] Move models to their own modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109299 (owner: 10MarkTraceur) [23:24:27] (03Merged) 10jenkins-bot: Move models to their own modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/109299 (owner: 10MarkTraceur) [23:33:46] (03PS22) 10Gergő Tisza: Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [23:45:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza)