[00:02:53] (03PS1) 10Brian Wolff: Fix js bug where error report was always for first link. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108172 [00:04:07] (03CR) 10Aarcos: Add caption to the interface in place of description (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [00:08:41] fabriceflorin: btw, not sure if you saw, on the rfc some people noted that the 38k videos uploaded figure is from 2 months ago, and we're now at 40k (40.5k to be precise) - Do you think the number on the rfc should be changed to reflect that, or is it fine as is (after all the difference is pretty small)? [00:09:32] bawolff: Sure, feel free to update the number, as long as the link provides back-up. [00:10:27] The page being linked to was manually updated, and no one has updated it since nov 24, Special:TimedMediaHandler should provide up to the moment (well hour) stats [00:12:45] Oh, looks like somebody already did that, and I didn't notice [00:12:47] While you're there, I would be grateful if you could slightly edit the top part of the 'Views against MP4' section, where someone added two paragraphs that do not belong there'. In my view, that section should begin with the introduction as originally written collectively ('Those who oppose adoption of the MP4 video file format ...') and move special details about Nokia and Google much further down, where it [00:12:47] makes more sense editorially. [00:15:02] I am fine with having a new paragraph to talk more about the license arrangement not being public ('secret'), but it should be toned down and be more factual. We now have a link to a public version of the agreement that should be included. I would also add a sentence or two pointing to Luis Villa's notes about commercial usage, as proposed below. [00:15:55] "Commercial use of MP4 videos uploaded through Wikimedia sites under CC-BY-SA should generally be authorized, as described below. [00:15:56] Our understanding of the MPEG-LA license agreement is that, under the royalty-free terms of its "Internet Broadcast" sublicense, users who use licensed tools in connection with our "Internet Broadcast" service would be able to make commercial use of software and hardware to decode and encode h264, including to other formats. For more detail on this, see the summary [link]. [00:15:57] Commercial usage of CC BY-SA content is already permitted, and Creative Commons has endorsed the use of H264 to deliver CC-licensed videos. For more detail on this, see the summary [link]." [00:16:42] You're welcome to take a stab at condensing this into a single paragraph -- or I can do this on my end when I get back home in a few hours. [00:18:12] hmm one of the sentences someone added "Nokia lost its patent claim in Germany, and Nokia was the only one not signing the agreement with Google [for vp8]." seems out of place [00:18:19] Or at least, not entirely coherent [00:19:02] I am not proposing that we rewrite the entire 'Views against', but at least make it coherent, with the original introduction and conclusion -- moving the editor's comment about Google and Nokia until after we've established the need to 'limiting our use to Ogg Theora and WebM standards' . [00:19:32] Lesson learned for next time: We should have really put the information on a separate page from the votes so that the history of the info section could be usable [00:20:20] On second thought, I am now vetting the proposed paragraph about 'commercial usage' with our legal team, so maybe it's best if I add this myself in the introduction. I think it sheds new light, and warrants being added, so people can make more informed decisions. [00:21:12] Yes, I don't find the Google / Nokia argument to be very well written, but if you think it's relevant, we should try to salvage it, so the editor who added it doesn't feel disrespected. [00:22:07] OK, gotta go now, but will be back in a couple hours to pick this up. Thanks for all that you have done for the movement, to insure a thoughtful and respectful discussion about these important issues! [00:22:33] (03CR) 10Aaron Schulz: [C: 031] Fix transcodes on files with long non-ascii names (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 (owner: 10Brian Wolff) [00:22:47] (03CR) 10Aaron Schulz: "Haven't tested" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 (owner: 10Brian Wolff) [00:23:08] ok, I'll try to re-arrange things (but won't talk about non-commerical issue), once you pick it up you can try to re-arrange them futher [00:30:56] (03PS8) 10Gergő Tisza: Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [00:31:13] marktraceur: ^^ unWIPped [00:31:22] Aw [00:34:51] (03PS7) 10MarkTraceur: Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 [00:34:53] (03CR) 10jenkins-bot: [V: 04-1] Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [00:35:49] (03PS8) 10MarkTraceur: Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 [00:36:53] (03CR) 10jenkins-bot: [V: 04-1] Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [00:37:07] Bah [00:38:03] (03PS9) 10MarkTraceur: Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 [00:38:09] * marktraceur hurts self because that was super dumb [00:46:46] All this rfc talk really makes me feel we should get VP9 working on our sites [00:47:11] all it requires is libav and ffmpeg2theora to be compiled against a newer version of libvpx [00:50:04] There's a bug, even, bawolff! [00:50:31] Indeed, I was reading it last night [00:51:09] I also tried uploading a dirac file last night (for kicks, someone mentioned the format on the mailing list) [00:51:29] Conclusion: Anyone who says ogg theora is hard to convert to has never tried to make an ogg dirac file [00:52:05] Hahaha. [00:54:28] (03CR) 10MarkTraceur: [C: 04-1] "Little issues" (0315 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 (owner: 10Gergő Tisza) [00:54:36] Mostly doc comments, tgr [01:04:37] (03CR) 10Aarcos: [C: 032] Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [01:04:57] (03CR) 10Aarcos: "All my comments addressed, thank you !" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [01:06:11] (03Merged) 10jenkins-bot: Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [01:08:09] (03PS5) 10MarkTraceur: Add location information to metadata div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 [01:08:11] (03CR) 10jenkins-bot: [V: 04-1] Add location information to metadata div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 (owner: 10MarkTraceur) [01:14:16] (03PS6) 10MarkTraceur: Add location information to metadata div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 [01:19:09] (03PS7) 10MarkTraceur: Add location information to metadata div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 [01:22:49] (03PS8) 10MarkTraceur: Add location information to metadata div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 [01:23:07] (03PS8) 10Gergő Tisza: Create model & providers for file usage information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 [01:28:54] (03CR) 10Aarcos: [C: 032] "All my concerns are addressed, thanx !" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 (owner: 10MarkTraceur) [01:29:52] (03Merged) 10jenkins-bot: Add location information to metadata div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 (owner: 10MarkTraceur) [01:51:25] (03PS9) 10Gergő Tisza: Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [01:51:27] (03CR) 10jenkins-bot: [V: 04-1] Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [01:54:25] #102: (AA) O:AA -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/102 [02:12:55] (03PS9) 10Gergő Tisza: Create model & providers for file usage information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 [02:12:57] (03PS10) 10Gergő Tisza: Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [02:24:42] (03CR) 10Aarcos: "Just browsed over, nothing deep but found some things already." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [02:25:02] (03CR) 10Aarcos: Add file usage data to MMV metadata panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [02:56:43] (03PS2) 10Brian Wolff: Fix transcodes on files with long non-ascii names [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 [02:57:00] (03CR) 10Brian Wolff: "PS2: Fix error in comment" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 (owner: 10Brian Wolff) [04:58:02] (03CR) 10Brian Wolff: "Does anyone have any objections to allowing this codec? I certainly can't think of any." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 (owner: 10Michał Łazowik) [05:13:05] (03CR) 10Brian Wolff: bug 55742: fix types in JSON videoinfo output (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/89846 (owner: 10Brion VIBBER) [05:16:28] (03CR) 10Brian Wolff: [C: 032] Don't pass arguments to methods that don't need them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106930 (owner: 10Siebrand) [05:16:31] (03Merged) 10jenkins-bot: Don't pass arguments to methods that don't need them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106930 (owner: 10Siebrand) [05:24:32] (03PS2) 10Brian Wolff: Clean up RL module definitions. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/92052 (owner: 10Spage) [05:31:57] (03CR) 10Brian Wolff: [C: 032] "I tested the patch, and nothing exploded." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/92052 (owner: 10Spage) [05:32:00] (03Merged) 10jenkins-bot: Clean up RL module definitions. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/92052 (owner: 10Spage) [05:43:19] (03PS2) 10Brian Wolff: Pull upstream fix for File_Ogg [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86262 (owner: 10J) [05:44:07] (03PS3) 10Brian Wolff: Pull upstream fix for File_Ogg [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86262 (owner: 10J) [05:47:04] (03CR) 10Brian Wolff: [C: 032] Pull upstream fix for File_Ogg [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86262 (owner: 10J) [05:47:07] (03Merged) 10jenkins-bot: Pull upstream fix for File_Ogg [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86262 (owner: 10J) [06:22:31] (03PS1) 1001tonythomas: Added timedmedia-wav message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 [06:34:17] (03CR) 10Brian Wolff: "Could you also update the comment in WebVideoTranscode::getPrimarySourceAttributes (The comment should also mention timedmedia-flac which " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [06:37:57] (03PS2) 1001tonythomas: Added timedmedia-wav message Updated comment in WebVideoTranscode::getPrimarySourceAttributes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 [06:38:38] (03CR) 1001tonythomas: "Bawolff: done" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [06:55:27] (03PS1) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [07:00:34] (03CR) 10Brian Wolff: "Deprecated is spelt wrong in the commit message (I'm pretty sure MediaWiki is the only reason I can spell that word, when I first started " (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [07:09:49] (03CR) 10Brian Wolff: [C: 04-1] "Sorry, totally missed a bunch of stuff (all minor though) the first time I looked at it. See inline" (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [07:28:37] (03PS2) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [07:29:38] (03PS3) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [07:29:41] (03CR) 10jenkins-bot: [V: 04-1] Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [07:31:34] (03PS4) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [07:32:14] (03CR) 10jenkins-bot: [V: 04-1] Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [07:48:41] (03PS5) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [07:59:59] (03PS3) 1001tonythomas: Added timedmedia-wav message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 [08:23:17] (03PS1) 10Brian Wolff: Output ogg metadata on image description page. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108203 [08:24:15] (03CR) 10Gilles: Try to fix resizing again (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107739 (owner: 10MarkTraceur) [08:25:38] (03PS1) 10Apsdehal: Go to original image link added, as well the zoom [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/108204 [08:26:22] (03PS3) 10Gilles: Try to fix resizing again [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107739 (owner: 10MarkTraceur) [08:32:25] #59: (GD) S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/59 [08:35:25] #42: (GD) S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/42 [08:35:25] #42: (GD) DTS:1J2|S:IT|O:GD -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/42 [08:39:40] (03CR) 10Gilles: [C: 031] "Doesn't seem like it would cause any harm, since we already support 16-bit PCM. A simple explanation of the difference between the two for" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 (owner: 10Michał Łazowik) [08:41:00] (03PS4) 10Brian Wolff: Added timedmedia-wav message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [08:41:52] (03CR) 10Brian Wolff: [C: 032] "PS4: tiny pedantic nitpick about a space in a comment." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [08:41:55] (03Merged) 10jenkins-bot: Added timedmedia-wav message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [08:44:44] gi11es: Thanks for commenting on the wav patch, I didn't want to unilaterally +2 it since its technically a new format, even though its essentially more of the same [08:45:37] well there's always the unknown of an open-source tool in our chain not behaving well with it, but that's the risk with any new format [08:45:56] and this one basically seems like the same, except storing floats rather than integers... very low risk [08:46:40] I'm pretty sure all the tools support it [08:46:54] wav is hardly the cutting edge of audio technology ;) [08:47:21] And as it stands, things don't explode too badly (I just uploaded a dirac video the other day, it didn't work, but nothing too bad happened) [08:47:33] *don't explode too badly when our tools don't support it [08:47:49] similarly people have uploaded opus and vp9 files which are tools don't support [09:04:54] (03CR) 10Brian Wolff: Changed Mp4Handler class call from wfMsgto wfMessage (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [09:15:36] (03CR) 10Brian Wolff: [C: 032] "Tested, it works. merging." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 (owner: 10Michał Łazowik) [09:15:36] (03Merged) 10jenkins-bot: Allow to upload WAV files with 32 bit float uncmopressed audio [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 (owner: 10Michał Łazowik) [09:22:08] (03CR) 10PleaseStand: [C: 04-1] Changed Mp4Handler class call from wfMsgto wfMessage (034 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [09:55:52] (03PS6) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [20:56:22] (03PS11) 10Jhall: Initial setup for Multimedia Viewer browser tests and first basic e2e test. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 [20:59:24] (03CR) 10Jhall: [C: 031] "I did a little clean-up to make these files adhere a little better to our Cucumber code conventions[1], and to add en environment tag to t" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 (owner: 10Jhall)