[00:01:20] marktraceur: Hey !, testing your fix for https://gerrit.wikimedia.org/r/#/c/107739. I don't think it works, now that the height is set the image becomes huge. I can show you if you want. [00:01:27] hrm. [00:01:33] aarcos: After I meet with Rob [00:01:55] just stop by whenever you have time. [00:02:02] Yup yup [00:03:33] (03CR) 10Aarcos: [C: 04-1] "I don't think it works, I tested it, very easy to repro. Now that the height is set the image becomes huge. I can show you if you want." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107739 (owner: 10MarkTraceur) [00:03:38] (03PS6) 10Gergő Tisza: Create model & providers for file usage information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 [00:04:16] (03CR) 10Gergő Tisza: "Propertified types, unduplicated documentation." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 (owner: 10Gergő Tisza) [00:08:58] (03CR) 10Gergő Tisza: Display the favicon of the foreign file repo when available (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [00:28:14] (03CR) 10Aarcos: [C: 04-1] Fix resize engine for fullscreen (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 (owner: 10MarkTraceur) [01:10:35] (03Abandoned) 10MarkTraceur: Also use promise syntax for repoInfo fetches [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106005 (owner: 10MarkTraceur) [01:17:16] (03CR) 10Aarcos: [C: 031] "This LGTM but I will let Gilles take another look and approve if his concerns are addressed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 (owner: 10Gergő Tisza) [01:33:34] (03PS3) 10MarkTraceur: Refactor animation, plus test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105993 [01:33:45] (03CR) 10MarkTraceur: "Rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105993 (owner: 10MarkTraceur) [01:36:08] (03CR) 10MarkTraceur: [C: 04-1] "prop/attr confusion" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 (owner: 10Apsdehal) [01:36:35] (03Abandoned) 10MarkTraceur: Do not re-request repoinfo [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106620 (owner: 10Gergő Tisza) [01:37:46] #115: (MH) S:ID|R:#MQ|I:#J2-S2|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/115 [01:39:26] (03PS4) 10MarkTraceur: Adding first pass at jsduck docs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106848 [01:41:42] (03PS5) 10MarkTraceur: Adding first pass at jsduck docs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106848 [01:42:46] #115: (MH) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/115 [01:43:50] (03PS4) 10MarkTraceur: Add main class to jsduck [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106849 [01:44:01] (03CR) 10MarkTraceur: "Rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106849 (owner: 10MarkTraceur) [01:44:29] (03CR) 10MarkTraceur: [C: 032] "Once more with feeling" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [01:44:34] Am I a bastard [01:44:42] It might fail again because rebase. [01:44:57] (03Merged) 10jenkins-bot: Use JSONP for gender query to avoid cross-domain issues [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107125 (owner: 10Gergő Tisza) [01:45:43] (03CR) 10MarkTraceur: [C: 032] "I don't particularly like the var statement inside an if block, but if jshint is cool I'm cool." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106889 (owner: 10Apsdehal) [01:46:11] (03Merged) 10jenkins-bot: Added test if Lightbox is attached [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106889 (owner: 10Apsdehal) [01:46:20] (03CR) 10MarkTraceur: "The bug doesn't exist anymore - it was an artifact of a bygone age. Sorry to waste your time :(" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107881 (owner: 10AalekhN) [01:46:30] (03Abandoned) 10MarkTraceur: multilightbox.css : Creates white border around the image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107881 (owner: 10AalekhN) [01:48:22] Right, I've cleaned up some of our dirty laundry [01:48:23] Not much of it [01:48:25] But some [01:49:20] (03PS5) 10MarkTraceur: Reduce font-size for description in lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105154 (owner: 10Apsdehal) [01:49:29] (03CR) 10MarkTraceur: [C: 032] "Simple enough!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105154 (owner: 10Apsdehal) [01:49:51] (03CR) 10MarkTraceur: "Good enough to merge?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 (owner: 10MarkTraceur) [01:49:59] Time to go home [01:50:13] (03Merged) 10jenkins-bot: Reduce font-size for description in lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105154 (owner: 10Apsdehal) [02:01:53] (03CR) 10Aarcos: "Send my replies now for real." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 (owner: 10Jhall) [02:16:40] (03PS8) 10Aarcos: Initial setup for Multimedia Viewer browser tests and first basic e2e test. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 (owner: 10Jhall) [02:43:52] (03PS1) 10Gergő Tisza: WIP Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [02:44:30] (03CR) 10jenkins-bot: [V: 04-1] WIP Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [02:44:40] (03PS2) 10Gergő Tisza: WIP Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [02:45:08] (03PS3) 10Gergő Tisza: WIP Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [02:45:45] (03CR) 10jenkins-bot: [V: 04-1] WIP Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 (owner: 10Gergő Tisza) [03:18:13] (03CR) 10Jhall: "Aaron, regarding your comments on patch set 6, I think the navigation to the Login page is not occurring because the URL module is incompl" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 (owner: 10Jhall) [04:03:32] (03PS9) 10Aarcos: Initial setup for Multimedia Viewer browser tests and first basic e2e test. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 (owner: 10Jhall) [04:05:21] (03CR) 10Aarcos: "Thanx for the tip and the late review Jeff, very much appreciated. Now things work as expected, let me know if anything else." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 (owner: 10Jhall) [05:48:58] (03PS10) 10Aarcos: Initial setup for Multimedia Viewer browser tests and first basic e2e test. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107517 (owner: 10Jhall) [08:52:07] (03PS10) 10Apsdehal: Title properties added to some buttons in lbinterface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 [09:31:58] (03CR) 10Gilles: [C: 031] Refactor animation, plus test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105993 (owner: 10MarkTraceur) [09:58:50] marktraceur: as per the latest comment on the core ticket for a scroll plugin (I think it may not be exactly the same one), seems like flow is the holdup (due to a conflict, I imagine) [09:59:09] I'm following it anyway, I'll switch to the core one once it's merged [10:32:46] #107: (GD) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/107 [13:30:32] (03PS5) 10Gilles: Display the favicon of the foreign file repo when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 [13:31:27] (03CR) 10Gilles: Display the favicon of the foreign file repo when available (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [13:33:46] #96: (GD) So, are we at a stalemate here? I don't feel li... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/96 [13:38:50] (03CR) 10Gilles: "Conclusion of the discussion on IRC: make the doc for the function clearer and this is good to go." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [13:46:14] I need to use slideshow feature of Extension:Multimediaviewer for development purpose but the one for mediawiki 1.22 does not support slideshow i tried to include latest development version in mediiawiki 1.22.1-0 but it doesn't seem to work can anyone please guide me how to make slideshow work in this version of mediawiki for debugging purpose. [14:27:22] (03CR) 10Gilles: "Aaron, what are the steps to reproduce? I've tried triggering it on the same pages on OS X + Chrome, to no avail." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107739 (owner: 10MarkTraceur) [14:43:47] (03CR) 10Mdale: [C: 032 V: 032] "Looks reasonable." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108000 (owner: 10Brian Wolff) [14:58:28] (03CR) 10Gilles: "I've found the issue that was causing the tiny image bug: a race condition in LIP.getImageElement. The callback could fire before the func" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107739 (owner: 10MarkTraceur) [15:17:50] (03PS2) 10Gilles: Try to fix resizing again [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107739 (owner: 10MarkTraceur) [16:18:34] Hm, semes like an exciting night [16:19:08] gi11es: I guess we should bother Fabrice about #96 (the chevron thing) [16:22:00] (03PS5) 10Gilles: Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [16:22:25] (03CR) 10Gilles: Add caption to the interface in place of description (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [16:23:08] (03CR) 10Gilles: "There's Aaron's concern on ext.multimediaViewer.js left to address" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [16:26:37] (03CR) 10MarkTraceur: [C: 04-1] Add caption to the interface in place of description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [16:26:47] I keep missing it because it's not -1'd, gah [16:27:04] OK, I think it's time [16:27:08] * marktraceur --> office [16:40:37] (03CR) 10Gergő Tisza: Display the favicon of the foreign file repo when available (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107594 (owner: 10Gilles) [16:43:57] (03PS4) 10Gergő Tisza: WIP Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [17:59:25] #102: (AA) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/102 [17:59:37] gi11es et al., are we doing Mumble/ [17:59:39] ? [17:59:46] I can't get EasyRTC to load strangely [18:00:14] I think it's going to be google hangout, since fabrice isn't here and we didn't discuss using something special today [18:00:20] Sigh [18:00:24] He has Mumble, though [18:01:01] I think he's sticking by his "we should use the same thing as everyone else" stance [18:01:17] fabriceflorin: Are we thinking of doing EasyRTC today? [18:01:20] so we're trying those for research purposes, for now [18:01:49] Hi guys. I'm trying to get Mumble to work, stay tuned. [18:01:58] alright, mumble it is [18:02:11] my laptop fan is happy about the news [18:02:12] Yup yup [18:02:14] Hah [18:03:22] Well this is nice [18:03:27] I don't have to listen to the office [18:03:34] I can listen to tgr's loud microphone :P [18:04:05] Hi guys, Mumble doesnt work for me, so lets do this via IRC. [18:04:17] fabriceflorin: What's the trouble with it? (can do after the meeting) [18:04:24] Anywho [18:04:26] I will start, because I have to leave in a few minutes for my medical procedure [18:04:32] I nominate gi11es to facilitate (after fabriceflorin) [18:04:40] OK, sounds good. [18:04:58] I've read the irc office hours log, was interesting and probably influenced by current opinion [18:05:01] Yesterday, I worked on the MP4 Video Rfc mostly. [18:05:12] then I watched the TDD workshop, learned the basics of cucumber [18:05:14] Today, I am taking 4 hours off for my colonoscopy. [18:05:34] This afternoon, I will address any pressing issues on the Video RfC. [18:05:42] gi11es: Sec, it's fabriceflorin's turn [18:05:51] sorry [18:05:58] Then I will prepare Mingle cards for next week's sprint. [18:06:06] Passing the talking stick to the next person. [18:06:27] gi11es: OK, go [18:06:28] marktraceur [18:06:29] (You don't want to know about my personal blockers :) [18:06:33] OK me go [18:06:35] SO [18:07:06] Yesterday: Standup, then code review, then RFC IRC office hour, then incubator meeting, then...more code review [18:07:12] There was some rebasing also [18:07:24] I cleared out a bunch of backlogged patches that weren't mine, mine are still pretty backlogged [18:07:40] So past-me is blocked on that, but other threads are still unblocked so it's OK [18:07:54] Today: More CR, more rebasing and improving patches [18:08:06] Hopefully we can close out some good portion of our cards this week! [18:08:09] Aaaand next. [18:08:19] tgr [18:08:37] worked on the file usage patch [18:08:53] still need to the CSS part and the unit tests [18:09:05] the gist of it is ready for review, i think [18:09:14] no blockers [18:09:54] that's it [18:10:00] aaron_arcos [18:10:25] #59: (MH) O:MH|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/59 [18:10:27] me: yesterday, it was code reviews for most of the day. I managed to address the small issues on the e2e tests and sent it back for review. [18:11:15] Today: I was going to take on the image stretch problem if no one is taking it? [18:11:52] aaron_arcos: I started on it, but my work was just guesswork 'cause I couldn't repro [18:12:00] I think gi11es said he had a lead [18:12:15] alright, since it's my turn for real... [18:12:27] I created a bug with repo steps: https://bugzilla.wikimedia.org/show_bug.cgi?id=60173 [18:12:58] go gi11les [18:13:04] after office hours reading and cucumber I reviewed a couple of patches, I tried to add fixes to the jquery fullscreen plugin that theo wanted so we can get that dependency out of the way [18:13:30] I wrote what is hopefully the final fixes to the favicon changesets, both frontend and backend [18:13:52] I tried to reproduce the stretching issue but I couldn't reproduce, instead I ran into a similar bug where the image was tiny [18:14:11] I fixed that and the fix *might* also fix the stretching issue, if not I think they're very similar in nature [18:14:45] on monday I plan on doing whatever I can to finish the cards that are still blocked by then [18:15:05] already today I intervened a bit on stuff that you guys had started, I'll basically keep doing the same [18:15:08] that's it [18:15:20] thanks! bye everyone! [18:15:25] 'kay - announcements, blockers, etc.? [18:15:26] Tampa went down this morning, which was fun, but doesn't appear to be affecting anything seriously on our end, but be aware of it [18:15:43] Monday is a holiday here, ;-). Also, can you share your fix to the stretch problem? [18:15:54] oh fuck I forgot that I'm flying, so ignore that [18:16:04] it's pushed already aaron_arcos [18:16:26] on marktraceur's height changeset [18:16:36] ok, tx ! [18:17:07] I definitely can't repro with your instructions, that's what I was trying [18:17:37] I suspect it's a race condition that depends on the computer's and the network's speed or something along those lines [18:17:59] the race condition I fixed was purely dependent on speed of execution [18:19:04] Oh !, I see, you used the same patch. I will take a look and since I can repro, can verify if this also fixes the stretch problem. Sounds like a plan? [18:19:14] sure does [18:19:39] Maybe it's a Mac OS X issue? Shrug [18:19:48] I tried on OS X + Chrome [18:19:56] same as fabrice's screenshots [18:20:03] Huh. [18:20:05] Funky. [18:20:22] I have an old-ish laptop, though, maybe a faster one is needed to hit the sweet spot [18:20:46] I will let you guys know my findings, A+, ;-)... [18:21:49] Arright, good luck [18:21:51] check out the patch if you haven't yet marktraceur, you probably know if there's any other code rigged the same way [18:21:56] Yeah sure [18:22:00] gi11es: See you on Tuesday! [18:22:30] yeap !, bon voyage !... [18:24:43] thanks :) [18:25:03] WB fabriceflorin [18:25:05] speaking of that code, is it intentional that the thumb is used at the image at first, almost immediately replaced by the one we really want to load? [18:25:30] *as the image [18:26:31] similarly if you close and reopen the lightbox there's code that replaces the correct image by the same image, which can causing a very short black flash [18:26:33] gi11es: "yes" - I built the library that way but probably we could shift it around a little and override some stuff in our superclass [18:26:48] We're driving to the hospital, and I have my IRC and email channels open for another 20 mins or so, in case of emergency. [18:27:07] Heh, 'kay [18:27:15] maybe the solution is just CSS? the first one could be hidden [18:27:40] gi11es: Yeah, but it's still an HTTP request [18:27:45] Well [18:27:47] No [18:28:07] gi11es: I would say we should hide the element in the interface, maybe just not attaching it, until the image is loading [18:28:20] Which happens after the metadata request is done [18:28:33] right [18:29:17] let's keep that in mind for future improvements, I think the plate is full today with the cards [18:29:58] Yeah [18:30:00] CR hell [18:30:02] Huzzah! [18:30:25] Or I should maybe fix up the caption patch first [18:31:46] is grrrit-wm dead? [18:32:00] Yeah, labs went down, IRC bots are suffering [18:43:25] #59: (MH) https://gerrit.wikimedia.org/r/100618 back and ... S:AFCR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/59 [18:44:19] tgr: https://gerrit.wikimedia.org/r/106176 [18:44:25] #42: (MH) O:MH|S:ID -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/42 [18:44:49] Rebased too [19:34:25] Disclaimer: I don't know how my new location patch will fare in the tests [19:34:31] Because my tests locall are buggy [19:36:36] WTF [19:36:40] This is fucking stupid [19:39:01] Oh, FFS [19:40:49] Apparently when one changes global state in a test, one should change it back after the test [19:40:56] Grmblgrmblgrmbl [19:40:58] do we plan switching to sass anytime soon? [19:41:14] or less, i always forget which is the mediawiki standard [19:41:16] tgr: Soon, maybe not [19:41:22] LESS is the standard now [19:41:39] I'm game to, but we haven't yet [19:41:41] it would make the MMV CSS a lot easier to scan [19:41:46] And there are bigger priorities [19:41:47] Well, yes [19:42:02] it should just work, right? [19:42:07] "should", yes [19:42:13] Then you can start migrating things I guess [19:42:27] Variables etc. [19:42:57] https://gerrit.wikimedia.org/r/107256 ready for review again whoooo [19:43:25] #42: (MH) https://gerrit.wikimedia.org/r/107256 all fixed... S:AFCR -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/42 [19:43:32] Will review the file usage thing after noms [20:06:56] marktraceur: LESS works like a charm [20:07:03] Heh, yes [20:07:06] any objections against starting to use it? [20:07:22] It's *too* easy [20:07:25] tgr: No go 'head [20:38:25] #81: (MH) Tested on MediaWiki.org, looks fine DTE:1J2|S:RfS -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/81 [20:39:21] Oh, lol [20:39:25] #80: (MH) Tested on Beta, looks OK S:RfS -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/80 [20:39:41] The betalabs sites are accessible but they can't make metadata requests to eqiad [20:39:53] Thaaaat's super fun [20:47:25] #100: (MH) I'm happy with it, but I think Jeff Hall needs ... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/100 [20:52:18] didn't take very long to hit the first less bug [21:35:25] #116: (MH) S:IA|I:#B|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/116 [21:45:10] I am bloody tired of rebasing things [22:08:25] #116: (MH) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/116 [22:16:46] tgr, aarcos, is CR progressing fairly well for you? Anything I can help with? I'm sorta at a point where I'm toying with the idea of starting on next sprint's cards. [22:16:57] Next task is reviewing the WIP file usage patch. [22:17:26] yes, that. [22:18:01] also, gi11es-away doesn't have +2 yet, do you want to merge the flickr blacklist patch? [22:18:24] in case you want to test it, it shouldn't require setting up an API key anymore [22:18:35] thx! [22:19:14] Sigh [22:19:20] tgr: Oh, did he test and OK it? [22:19:32] btw just updated the file usage patch, apart from the tests should be ready [22:19:44] yeah, he said he would +2 if he could [22:19:51] 'kay [22:20:11] Yay, promises [22:25:20] (03PS7) 10Gergő Tisza: Create model & providers for file usage information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107588 [22:25:22] (03PS7) 10Gergő Tisza: WIP Add file usage data to MMV metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107993 [22:25:50] it lives! [22:29:07] (03CR) 10MarkTraceur: [C: 032] "Seems basically like the best thing ever." (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [22:29:08] So it would seem [22:34:56] (03CR) 10Gergő Tisza: Refactor Flickr API calls (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [22:35:51] Oh, hm, that one depends on the other big one [22:35:58] And AFAIK gi11es-away didn't OK it? [22:36:15] Oh, I see [22:36:16] NVM [22:42:30] (03CR) 10Aarcos: [C: 04-1] "Almost there, few things left." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/107256 (owner: 10MarkTraceur) [22:43:15] Bah [22:43:25] and the third big one depends on it [22:44:09] (03CR) 10MarkTraceur: [C: 032] "Seems OK (but I reviewed them in the wrong order! crap!)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [22:44:38] (03CR) 10MarkTraceur: [C: 032] "I'LL SAVE YOU GILLES" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [22:44:42] More better. [22:44:51] (03Merged) 10jenkins-bot: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [22:44:54] (03Merged) 10jenkins-bot: Refactor Flickr API calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [22:45:00] Oh shit! Awesome! [22:45:00] (03Merged) 10jenkins-bot: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [22:45:10] Jenkins is so cool. [22:46:02] OK, moving card [22:46:11] thanks [22:46:19] we close bugs at merge time, right? [22:46:23] Yeah [22:46:25] #78: (MH) S:RfT -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/78 [22:49:24] I'm going to put this in the tech news FYI [23:04:58] marktraceur: you should also mentioned the URL handling rewrite done at the end of GCI, if no one did yet [23:05:20] URL handling rewrite? [23:05:29] flickr url, i mean [23:05:35] * marktraceur didn't see that, or didn't look too closely [23:05:42] tgr: Oh, adding the other types you mean? [23:05:45] it accepts basically anything now, favorites, collections [23:05:46] yes [23:05:58] marktraceur: It should go in https://meta.wikimedia.org/wiki/Tech/News/2014/05 as it won't even be pushed next week. [23:06:14] James_F: 'kay [23:06:21] James_F: I put it in "upcoming" [23:06:25] marktraceur: (and /05 isn't live yet.) [23:06:29] marktraceur: Eh. I guess. [23:06:41] marktraceur: I would have put it in "upcoming" next week, or even that thereafter. [23:07:02] Remember it won't go live on Commons until yesterday + 1 week + 1 other week + 5 days. [23:07:03] tgr: Is the support for all of those already on Commons? [23:07:27] James_F: Oh, right, no deploys next week at all [23:07:28] Bah [23:07:32] Fucking...summit [23:07:34] marktraceur: Yeah. :-( [23:08:10] i think so but let me check [23:09:59] marktraceur: yep, merged last Wednesday [23:10:21] 'kay [23:12:10] (03CR) 10Aarcos: [C: 031] "Just a question regarding some function definition, otherwise LGTM. I will let Gilles take another look and approve though." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 (owner: 10MarkTraceur) [23:14:11] (03CR) 10MarkTraceur: Fix resize engine for fullscreen (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105840 (owner: 10MarkTraceur) [23:14:55] marktraceur: can you also mention that the blacklist is available via the API now? might be useful for tool maintainers [23:17:00] tgr: That should likely go in release notes, or to the API discussion mailing list [23:17:17] I dunno if it's as useful for tech news, but that's a lot of Flickr UW news for one issue :) [23:17:52] ok, i'll write to those places [23:18:09] and the talk page of the blacklist, i guess [23:18:47] and the api docs on mw.org [23:18:51] anything else? [23:19:19] Hm, nope [23:19:50] The core patch still needs a-mergin' I think, for jquery.fullscreen [23:26:25] #78: (GT) Config change: https://gerrit.wikimedia.org/r/#... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/78 [23:26:25] (03CR) 10Aarcos: [C: 04-1] "Almost there, just one tiny thing, thanx !" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100618 (owner: 10MarkTraceur) [23:30:25] #78: (GT) TODO: update mw.org API documents once this is ... -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/78 [23:36:25] #102: (AA) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/102 [23:42:46] (03PS1) 10Brian Wolff: Fix transcodes on files with long non-ascii names [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170