[00:04:49] <marktraceur>	 Woot
[00:05:35] <grrrit-wm>	 (03PS1) 10MarkTraceur: Adding first pass at jsduck docs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106848 
[00:12:02] <grrrit-wm>	 (03PS1) 10MarkTraceur: Add main class to jsduck [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106849 
[00:12:37] <marktraceur>	 Having jsduck running on jenkins might be nice, it will force us to write documentation and keep it relatively up to date maybe
[00:18:39] <tgr>	 can we make it available at doc.wikimedia.org?
[00:19:41] <marktraceur>	 Probably!
[00:21:55] <tgr>	 that would be awesome
[00:58:26] <grrrit-wm>	 (03CR) 10Gergő Tisza: "I really like the direction this is going!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 (owner: 10MarkTraceur)
[00:59:29] <grrrit-wm>	 (03CR) 10Gergő Tisza: Refactor to a data model (036 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 (owner: 10MarkTraceur)
[01:42:31] <grrrit-wm>	 (03CR) 10MarkTraceur: "Hm, I was considering that. OK, I'll probably build out some more of this over the weekend, but failing that, definitely next week. :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 (owner: 10MarkTraceur)
[01:46:05] <grrrit-wm>	 (03CR) 10MarkTraceur: Refactor to a data model (036 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 (owner: 10MarkTraceur)
[14:16:08] <grrrit-wm>	 (03PS1) 10Apsdehal: Added test if Lightbox is attached [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106889 
[18:32:46] <apsdehal>	 Hi everyone..
[18:33:35] <apsdehal>	 On loading the lightbox and checking console I get this error: GET https://bits.wikimedia.org/static-1.23wmf10/extensions/MultimediaViewer/resources/img/close.svg 404 Not found
[18:34:35] <apsdehal>	 I think the url provided in the css property is wrong and must be fixed.
[18:36:37] <tgr>	 apsdehal: where are you testing?
[18:41:10] <apsdehal>	 i was just surfing through https://www.mediawiki.org/wiki/Multimedia/About_Media_Viewer#mediaviewer/File:Media Viewer Desktop - Large Image Opaque Info.png/0
[20:58:22] <grrrit-wm>	 (03PS1) 10Siebrand: Don't pass arguments to methods that don't need them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106930