[00:12:02] Hi folks, one question before I go to bed. I am getting this error when I go to /Main_Page of my dev env: Error: 1054 Unknown column 'page_links_updated' in 'field list' (localhost). It seems it is related to this change: https://gerrit.wikimedia.org/r/#/c/101170/. I came up with a hacky workaround but may you guys know how to properly fix it. Probably rebuild the database? Thanx ! [00:14:05] aarcos: cd mediawiki/core && php maintenance/update.php --quick [00:14:47] (03CR) 10Gergő Tisza: Use promises (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106004 (owner: 10MarkTraceur) [00:30:27] (03CR) 10Gergő Tisza: [C: 04-1] Improve the test coverage to also check prev/next scroll (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [00:40:10] tgr: Oh, you're right, duh, what am I doing [00:52:29] Still 4 fewer lines! Woo! [00:52:36] (03PS5) 10MarkTraceur: Use promises [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106004 [00:54:06] No caching of target sizes [00:54:08] That can be later [01:07:58] (03CR) 10Gergő Tisza: [C: 031] "Looks all good!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106004 (owner: 10MarkTraceur) [01:08:17] No +2? :) [01:09:03] tgr: I think it's fine to leave things for others if they initiated the need for the patchset or have unique insight, but we shouldn't tie up the review pipeline unnecessarily [01:10:32] gi11es-away did a bunch of coding-convention-setting review a few days ago, I figured I'll leave it open for that [01:10:42] also I was too lazy to test [01:10:48] but you are right [01:11:03] Heh [01:11:13] Too lazy to test is a better excuse :) [01:16:18] yay [01:16:33] no more crashing chrome by tapping the cursor keys [01:17:34] still possible to confuse the app that way, but takes a lot more effort than it used to [01:20:22] (03CR) 10Gergő Tisza: [C: 032] "Navigating without waiting for the last image to load seems a lot less error-prone now. Great job!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106004 (owner: 10MarkTraceur) [01:20:49] (03Merged) 10jenkins-bot: Use promises [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106004 (owner: 10MarkTraceur) [01:38:53] (03CR) 10Aarcos: [C: 04-1] Improve the test coverage to also check prev/next scroll (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [02:16:52] (03CR) 10Gergő Tisza: Add blacklisting feature for flickr in backend (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [03:26:09] marktraceur, for multimediaviewer, what file is the loading spinner graphic coming from? It looks very weird (or lo-fi, or as if it's having transparency problems, or something), but maybe it's meant to look like that? I'm not sure if I should file a bug+screenshot or not... [03:27:09] goodgod, it's 7:30pm. nvm Mark! I'll ask again tomorrow, during rational hours. [03:31:37] (03CR) 10Nischayn22: Add blacklisting feature for flickr in backend (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [06:36:29] (03PS10) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [06:36:31] (03CR) 10jenkins-bot: [V: 04-1] Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [09:18:25] (03CR) 10Gilles: Improve the test coverage to also check prev/next scroll (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [09:24:09] (03CR) 10Gilles: "In fact, regarding Aaron's comment on the redundant return, it's rather that I was returning the wrong value in the update case, as seen h" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [09:27:03] (03PS2) 10Gilles: Improve the test coverage to also check prev/next scroll [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 [10:10:04] (03CR) 10Gilles: "I've done some research to see what other large web properties do. The interesting ones:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97919 (owner: 10Gergő Tisza) [10:36:45] (03CR) 10Gilles: [V: 04-1] "Some of the tests fail for me: http://pastebin.com/txapD3fb" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [10:47:34] so, I'm a reviewer on this changeset: https://gerrit.wikimedia.org/r/#/c/104694/ [10:47:58] but it doesn't appear on my gerrit frontpage. why is that? because it's +1ed? [10:51:31] in fact even now that I watch the project, with all options ticked, it doesn't appear in my "Watched Changes" either [10:51:57] oh, it's merged, heh *facepalm* [10:52:04] since the conversation continued I lost track of that [10:52:38] my fault for doing necromancy and starting a dialogue on a merged changeset :) [11:23:38] (03CR) 10Aarcos: [C: 032] "LGTM, thanx for the tests !" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [11:24:12] (03Merged) 10jenkins-bot: Improve the test coverage to also check prev/next scroll [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [12:18:49] (03CR) 10Aarcos: [C: 032] Move the arrows and the close/fullscreen button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106224 (owner: 10Gilles) [12:19:17] (03Merged) 10jenkins-bot: Move the arrows and the close/fullscreen button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106224 (owner: 10Gilles) [13:29:10] (03CR) 10Aarcos: [C: 04-1] Solves visibility issue on the progress bar (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [14:45:05] (03CR) 10Gilles: Solves visibility issue on the progress bar (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [14:54:51] (03PS1) 10Gilles: Solves visibility issue on the progress bar [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106704 [14:58:28] (03PS3) 10Gilles: Solves visibility issue on the progress bar [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 [14:59:07] (03PS11) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [14:59:14] (03CR) 10jenkins-bot: [V: 04-1] Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [14:59:25] (03CR) 10Gilles: [C: 04-1 V: 04-1] "Ignore this changeset, it's a dupe created by mistake" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106704 (owner: 10Gilles) [15:05:32] (03PS12) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [15:05:39] (03CR) 10jenkins-bot: [V: 04-1] Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [15:06:28] tgr: are the tests successful for you locally? [15:06:40] yes, they work for me [15:06:48] do you use vagrant? [15:07:47] the tests create some wiki pages which are not deleted so in theory an earlier test run could bleed into the current one, although the page is rewritten at the beginning of every test [15:08:00] to run them? yes I vagrant ssh into the machine and then go to the core phpunit folder and run the extensions suite [15:08:37] shouldn't be much difference in our setup then [15:08:48] I'll try again with your latest changeset to see if I see the same failure as jenkins [15:09:12] nvm i'm being stupid [15:09:55] i have the blacklist page name set in my config [15:10:03] let me try without that [15:12:07] yeah, i get one of the errors now [15:12:25] i wonder why? i reset the page name before every test [15:37:27] (03PS1) 10Gilles: Fix the i18n source string for the chunked preference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 [15:51:32] (03CR) 10Aarcos: "I will let Mark comment on the correctness of this change since he introduced most of the code in" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [16:06:31] (03CR) 10Aarcos: "While restructuring and reducing the amount of code is always a good thing I don't see much progress on testability. My experience so far " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106004 (owner: 10MarkTraceur) [17:20:07] (03CR) 10Brian Wolff: "On the php side (in the preferences part) this should probably be run through formatNum, or perhaps be instead specified in bytes and run " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [17:25:21] (03CR) 10Gilles: "$wgLang->formatSize looks like the right one, I'll give it a try" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [17:33:57] (03PS2) 10Gilles: Fix the i18n source string for the chunked preference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 [17:41:31] Exciting, it looks like fabriceflorin got Mumble set up [17:41:37] Dunno if tgr will have any luck [17:46:09] gi11es: Hi [17:48:14] Hi there folks, I have to pack and run some errands, I fly back tomorrow morning. I will miss the standup, just sent an update. have to go now but seeya online... [17:48:36] gi11es: Just wanted to say welcome to Wikimedia :) [17:54:05] thank! [17:57:15] gi11es: Also for the chunked upload bug I noticed you assigned yourself on - in my experiance the most common issue with chunked upload is that either the "publish" job goes missing, or the "assemble" job fails to report its done or something along those lines (leaving the script running in a loop), often manually sending another api request for the file to be published fixes things [17:57:26] * bawolff should probably file a bug just about that [18:00:15] yes, I think it's 2+ bugs in one ticket [18:00:18] I want to sort that out [18:00:25] that's why I replied to the affected user [18:00:46] I'd like to treat them separately [18:11:07] Hmm, we should have a tracking bug for chunked upload /me goes creates one [18:31:35] (03CR) 10MarkTraceur: [C: 032] "Heh, and sadly the progress bar still seems to skip around a lot. Another day, another bugfix...this looks great to me though." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [18:31:40] (03Merged) 10jenkins-bot: Solves visibility issue on the progress bar [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [18:32:06] Does anyone have a bead on a critical bug, or can I start refactoring things? [19:04:28] Right, on to model design [19:04:29] Awayyy [19:13:54] Hm [19:14:06] I think I might pull a VE and rename our module to something shorter [19:14:09] Not module [19:14:54] Well, sort of. We'd still call it ext.multimediaViewer in ResourceLoader, but rename the directory to be "mmv" and then make a mw.mmv object where we can stick things [19:15:21] We can backpedal I think [19:17:08] (03CR) 10Gergő Tisza: Fix the i18n source string for the chunked preference (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [19:21:53] (03CR) 10Brian Wolff: Fix the i18n source string for the chunked preference (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [19:41:21] tgr: So I envision the dataModel file as having ImageData as a basic constructor, and then a static method to construct an ImageData out of an API response. Sound sane to you? I'll also have a RepoData system but that can get addressed later. [19:42:32] sounds good [20:22:57] I may not make the actual interface code much prettier, but the image data model is working nicely so far [20:23:11] Now to see if it works... [20:24:27] Woohoo [21:03:18] (03CR) 10Gilles: "Yes, I glanced at the progress display logic and it's all kinds of wrong. Do you know if there's already a bug filed for that?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [21:05:58] (03CR) 10MarkTraceur: "I doubt it, but you could look and you could file it if you wanted. Or you could just work on it. Up to you :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [21:07:36] (03CR) 10Gilles: Fix the i18n source string for the chunked preference (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [21:45:46] (03CR) 10Gergő Tisza: Fix the i18n source string for the chunked preference (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [22:09:04] tgr et al., I've filed https://bugzilla.wikimedia.org/59925 because we may not be able to have the user page link go accurately to the remote user page in all instances [22:09:18] (ignore the logo thing for now, but I don't have the server URL for shared DB repos right now) [22:10:31] I thought the canonical file namespace was always File [22:11:10] oh, right, used to be Image on older MediaWiki [22:11:24] *shrug* if it's File now then I can just use File [22:11:26] Can we assume the same for User? [22:11:45] (if so, crackerjack, the only thing I need is the article path) [22:11:51] i think we can [22:13:06] OTOH maybe the API could provide local namespace names, that would make links more elegant [22:13:54] but we already have APIs for this, the problem is we cannot access the API of a sharedDB repo [22:14:37] I guess technically it is not even safe to assume such an API exists [22:14:43] Yeah [22:15:04] Because a repo could totally just be a backend software that has publicly accessible files, and links to their descriptions [22:16:11] in which case there would be no such thing as an article path or a user namespace [22:16:28] And if that's the case, fine [22:16:47] But if I can get the article path, I need to in order to provide remote user page links [22:17:10] If there's some weird software providing the images and thumbnails, that's fine, but if it's MediaWiki then I want to link to the user pages [22:18:09] if I understand the question correctly: Yes, namespaces will always autoredirect if needed, based on the canonical names. Eg, [[User:Quiddity]] in the search box at de: will automagically take you to [[Benutzer:Quiddity]] [23:14:52] (03CR) 10Gergő Tisza: "Bunch of bugfixes and a few more tests. Gilles, can you check if the tests still fail for you?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [23:23:10] marktraceur, for multimediaviewer, what file is the loading spinner graphic coming from? It looks very weird (or lo-fi, or as if it's having transparency problems, or something), but maybe it's meant to look like that? I'm not sure if I should file a bug+screenshot or not... (ie. http://i.imgur.com/wirjMzH.png - same in Firefox and Chromium) [23:23:34] quiddity: It's a core library [23:23:44] But we removed the spinner in the latest version [23:23:47] See mw.org [23:23:51] ah! ok [23:24:11] We're considering a different graphic for later [23:24:15] But right now it's sort of like meh [23:26:07] All good then. (Also, I love that the browser-back-button works as the user imagines it will, now :) [23:26:32] Oh, good! [23:26:40] I didn't realize we'd changed things? [23:27:53] This was a problem a while ago. It used to open the lightbox, without actually changing the navigation history. So when I clicked "back" it would send me too far back! [23:28:08] Aw. [23:28:25] Oh man [23:28:37] tgr: Coincidental bonus of my refactor - caching of thumbnail URLs [23:28:57] Well, sort of coincidental [23:29:22] I think I will stop while I'm *way* ahead and continue with doing things with repoInfo later [23:29:38] (I have a RepoData class, and some subclasses, but they don't get used everywhere yet) [23:29:49] (03PS13) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [23:30:10] (03CR) 10Gergő Tisza: "Um. Changes actually uploaded now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [23:30:48] (03CR) 10jenkins-bot: [V: 04-1] Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [23:31:31] Ooh, I should write tests first! [23:31:34] Wait, no [23:31:37] Tests can come next [23:32:29] (03PS1) 10MarkTraceur: Refactor to a data model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 [23:32:37] 476 insertions wow [23:33:02] Mostly new files [23:33:06] Existing files went down a bit [23:33:17] Exciiiiting [23:38:03] (03CR) 10jenkins-bot: [V: 04-1] Refactor to a data model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 (owner: 10MarkTraceur) [23:42:13] Argh seriously? [23:50:41] drunk jenkins is drunk? [23:54:42] No, drunk refactorer is drunk [23:56:07] Though Jenkins is, frequently, very drunk. [23:56:19] (03PS2) 10MarkTraceur: Refactor to a data model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 [23:56:34] I don't need to test setting the file page link with object before because now we don't have to fuck around with that, wheee [23:56:53] (03CR) 10jenkins-bot: [V: 04-1] Refactor to a data model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 (owner: 10MarkTraceur) [23:57:09] ...wat [23:57:37] Oh, because missing file, of course [23:57:58] (03PS3) 10MarkTraceur: Refactor to a data model [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106846 [23:58:04] I love robots so much [23:58:17] I want them to do all of my work [23:58:43] Huzzah! [23:59:05] tgr: Want a huge, but mostly very simple, patchset to review? :D [23:59:12] I might try to tackle jsduck next [23:59:22] already looking at it [23:59:25] looks great!