[00:18:24] * marktraceur  facepalms

[00:18:31] <marktraceur>	 There was a bug in the EL code
[00:18:43] <marktraceur>	 We have zero load times for, well, everything
[00:18:54] <marktraceur>	 Which would be really impressive if it wasn't just a stupid bug
[00:19:01] <marktraceur>	 I blame testing
[00:22:35] <grrrit-wm>	 (03PS1) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 
[00:23:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 (owner: 10MarkTraceur)
[00:24:54] <grrrit-wm>	 (03PS2) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 
[00:25:00] <marktraceur>	 Cleverer than I give myself credit for
[00:27:04] <marktraceur>	 tgr: So ^^ that will fix our metrics
[00:27:06] <marktraceur>	 Too late, but still
[00:27:12] <marktraceur>	 I'll write that email
[00:34:53] <marktraceur>	 I guess I could try to backport it maybe, I don't think image bucketing will hit e.g. enwiki 'til Thursday
[00:35:00] <marktraceur>	 Wonder if greg-g would go for it 
[00:36:16] <marktraceur>	 Probably yes, it's not a complicated thing
[00:37:10] <tgr>	 worst case, it breaks logging even more, right?
[00:37:20] <marktraceur>	 Well, let's bolody hope not
[00:37:23] <marktraceur>	 bloody*
[00:37:23] <tgr>	 nothing users would be affected by
[00:37:56] <marktraceur>	 Correct
[00:38:22] <marktraceur>	 I mean, worst case it contains a fatal error we don't catch, but the tests are there for a reason
[00:38:58] <marktraceur>	 Also I've confirmed it works locally
[01:04:56] <grrrit-wm>	 (03PS3) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 
[01:05:02] <marktraceur>	 Now with tests
[01:05:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 (owner: 10MarkTraceur)
[01:05:29] <marktraceur>	 Failing tests woo
[01:06:10] <grrrit-wm>	 (03PS4) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 
[01:06:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 (owner: 10MarkTraceur)
[01:06:42] <grrrit-wm>	 (03PS5) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 
[01:06:56] <marktraceur>	 Hrm.
[01:07:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 (owner: 10MarkTraceur)
[01:07:29] <marktraceur>	 That's really strange
[01:07:38] <marktraceur>	 I'll tear this out and put it in a different patchset
[01:07:54] <grrrit-wm>	 (03PS6) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 
[01:08:29] <grrrit-wm>	 (03PS1) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[01:08:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 (owner: 10MarkTraceur)
[01:12:22] <grrrit-wm>	 (03PS2) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[01:14:10] <marktraceur>	 Seriously Jenkins?
[01:14:13] <marktraceur>	 Because if I try again
[01:14:17] <marktraceur>	 You're totally going to fail it
[01:14:30] <grrrit-wm>	 (03PS3) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[01:14:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add tests for EventLogging timing. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 (owner: 10MarkTraceur)
[01:17:11] <grrrit-wm>	 (03PS4) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[01:17:33] <marktraceur>	 I will be super angry if this doesn't pass consistently
[01:19:03] <grrrit-wm>	 (03PS5) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[01:19:52] <marktraceur>	 I am suuuuuper skeptical
[01:20:25] <grrrit-wm>	 (03PS6) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[01:23:38] <grrrit-wm>	 (03PS7) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[01:23:52] <marktraceur>	 Dumb bug #2 I guess
[01:24:45] <marktraceur>	 OK, that one seems better.
[01:26:10] <grrrit-wm>	 (03PS7) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 
[01:26:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 (owner: 10MarkTraceur)
[01:26:44] <grrrit-wm>	 (03PS8) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[01:27:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 (owner: 10MarkTraceur)
[01:27:33] <grrrit-wm>	 (03PS8) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 
[01:27:41] <grrrit-wm>	 (03PS9) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[01:27:54] * marktraceur  breathes

[01:35:16] <marktraceur>	 tgr: Sorry that patch got dumped on, I wanted to get the tests working and then needed to disentangle the tests, they should both be good now
[01:48:03] <marktraceur>	 I guess it doesn't matter, we can't deploy 'til tomorrow anyway
[01:48:29] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 (owner: 10MarkTraceur)
[01:49:26] <marktraceur>	 ?
[01:55:35] <tgr>	 ? what?
[01:55:39] <marktraceur>	 Only 1?
[01:56:05] <tgr>	 is it urgent?
[01:56:12] <marktraceur>	 I mean...not today-urgent
[01:56:16] <marktraceur>	 Tomorrow-urgent though
[01:58:06] <marktraceur>	 BRB, picking up dinner
[01:58:32] <tgr>	 i figured we should leave changesets open at least for a full night so aarcos and gi11es-away can comment
[01:59:10] <tgr>	 i have nothing against the patch, i can +2 if you want it sooner than that
[02:04:05] <marktraceur>	 'kay
[02:04:09] <marktraceur>	 Tonight is fine
[02:04:26] <marktraceur>	 As long as it can get pushed out tomorrow
[02:20:12] <grrrit-wm>	 (03CR) 10Gergő Tisza: Add tests for EventLogging timing (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 (owner: 10MarkTraceur)
[02:24:29] <grrrit-wm>	 (03PS10) 10MarkTraceur: Add tests for EventLogging timing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 
[02:24:30] <marktraceur>	 {{done}}
[02:53:39] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "Looks good. I would still prefer if the non-assertion-related logic (like starting the next profiling session) would be outside logEvent()" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106176 (owner: 10MarkTraceur)
[10:34:15] <grrrit-wm>	 (03PS1) 10Gilles: Move the arrows and the close/fullscreen button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106224 
[10:52:49] <grrrit-wm>	 (03PS2) 10Gilles: Solves visibility issue on the progress bar [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 
[13:42:58] <grrrit-wm>	 (03PS1) 10Pginer: Use chevron for panel opening affordance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106244 
[13:43:00] <grrrit-wm>	 (03CR) 10Theopolisme: [C: 04-1] "Thanks again! This is looking good." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 (owner: 10Apsdehal)
[13:47:49] <grrrit-wm>	 (03PS2) 10Theopolisme: Changed the font-size for decription in lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105154 (owner: 10Apsdehal)
[13:47:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Reduce font-size for description in lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105154 (owner: 10Apsdehal)
[13:48:21] <grrrit-wm>	 (03CR) 10Theopolisme: [C: 031] "Looks good, needs rebase though" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105154 (owner: 10Apsdehal)
[14:30:25] <grrrit-wm>	 (03PS3) 10Apsdehal: Reduce font-size for description in lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105154 
[14:42:53] <grrrit-wm>	 (03PS8) 10Apsdehal: Titles attribute added to fullscreen and close button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 
[15:15:35] <grrrit-wm>	 (03PS1) 10Gilles: Make the behavior of the lightbox more consistent with scroll [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106263 
[15:17:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make the behavior of the lightbox more consistent with scroll [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106263 (owner: 10Gilles)
[15:39:24] <marktraceur>	 aarcos, gi11es, tgr and I left https://gerrit.wikimedia.org/r/106166 open primarily so you could take a look, but I'd like to get it merged today if you have time :)
[15:52:34] <marktraceur>	 Agh, pginer isn't in
[15:52:40] <marktraceur>	 I'm so happy with how he made the SVG
[15:54:34] <marktraceur>	 Um, did we decide that SSH was totally not working for Gerrit?
[15:58:14] <gi11es>	 it's still required, afaik? without adding the ssh key to gerrit you can't connect
[15:58:26] <gi11es>	 at least that was my experience messing with it this week
[15:58:38] <marktraceur>	 Well, I have my key added
[15:58:55] <marktraceur>	 pginer: <3 I love the new drag affordance, especially the way it's built in the SVG file
[15:58:56] <gi11es>	 I had to redo mine today, not sure why
[15:59:12] <marktraceur>	 Hm, I'm getting "no route to host"
[15:59:14] <marktraceur>	 Which is crap
[15:59:25] <pginer>	 marktraceur: thanks
[16:03:11] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-2] "Hi!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104325 (owner: 10Apsdehal)
[16:14:48] <grrrit-wm>	 (03PS2) 10Gilles: Make the behavior of the lightbox more consistent with scroll [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106263 
[16:16:32] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Huzzah, arrows!" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106244 (owner: 10Pginer)
[16:16:44] <marktraceur>	 OK
[16:16:51] <marktraceur>	 I should stop WFHing and go to office
[16:16:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use chevron for panel opening affordance [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106244 (owner: 10Pginer)
[17:14:29] <gi11es>	 does anyone know on the top of their head where in the code chunked upload are being reassembled/processed?
[17:14:43] <marktraceur>	 Lol.
[17:14:57] <marktraceur>	 gi11es: includes/jobs/AssembleChunkedUploads.php off the top of my head
[17:15:04] <gi11es>	 thanks
[17:15:25] <marktraceur>	 Sorry
[17:15:34] <marktraceur>	 includes/job/jobs/AssembleChunkedUploads.php
[17:15:41] <marktraceur>	 Nope still wrong
[17:15:51] <grrrit-wm>	 (03PS4) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 
[17:15:51] <marktraceur>	 includes/job/jobs/AssembleUploadChunksJob.php
[17:15:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[17:16:25] <marktraceur>	 The job queue is a mysterious beast
[17:17:13] <grrrit-wm>	 (03CR) 10Aarcos: [C: 032] Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 (owner: 10MarkTraceur)
[17:18:03] <marktraceur>	 \o/
[17:18:07] <gi11es>	 is the job queue purely php?
[17:18:23] <marktraceur>	 Yeah, I believe so
[17:18:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix painful bug in eventlogging code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106166 (owner: 10MarkTraceur)
[17:21:26] <marktraceur>	 Oh, crap, if I were smart I would have put a different version number in
[17:21:30] <marktraceur>	 D'oh
[17:21:49] <marktraceur>	 Hopefully I can get it in today
[17:23:47] <grrrit-wm>	 (03PS1) 10MarkTraceur: Version our EL profiling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106282 
[17:23:54] <marktraceur>	 aarcos: Quick add-on ^^
[17:28:04] <grrrit-wm>	 (03CR) 10Aarcos: [C: 032] Version our EL profiling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106282 (owner: 10MarkTraceur)
[17:31:14] <marktraceur>	 THankee!
[17:32:39] <marktraceur>	 All right, we should be set to generate stats
[17:32:43] <marktraceur>	 Once I backport
[17:33:02] <marktraceur>	 We'll only get about...eh...a night of data from non-bucketing code? I think?
[17:34:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Version our EL profiling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106282 (owner: 10MarkTraceur)
[17:34:58] <marktraceur>	 ...wat
[17:35:18] <marktraceur>	 Oh, of course
[17:35:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Version our EL profiling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106282 (owner: 10MarkTraceur)
[17:35:40] <grrrit-wm>	 (03PS2) 10MarkTraceur: Version our EL profiling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106282 
[17:35:42] <marktraceur>	 I'm terrible
[17:36:21] <marktraceur>	 aarcos: Because testing ^^
[17:37:18] <aarcos>	 lol
[17:37:42] <grrrit-wm>	 (03CR) 10Aarcos: [C: 032] Version our EL profiling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106282 (owner: 10MarkTraceur)
[17:38:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Version our EL profiling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106282 (owner: 10MarkTraceur)
[17:39:14] <marktraceur>	 'kay, will make branches for us and everything
[17:48:58] <grrrit-wm>	 (03PS1) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106287 
[17:49:33] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Sometimes Gerrit just deserves a lot of love." [extensions/MultimediaViewer] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106287 (owner: 10MarkTraceur)
[17:49:48] <grrrit-wm>	 (03PS1) 10MarkTraceur: Fix painful bug in eventlogging code [extensions/MultimediaViewer] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106288 
[17:50:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix painful bug in eventlogging code [extensions/MultimediaViewer] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106287 (owner: 10MarkTraceur)
[17:50:12] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Muahahah." [extensions/MultimediaViewer] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106288 (owner: 10MarkTraceur)
[17:50:27] <grrrit-wm>	 (03PS1) 10MarkTraceur: Version our EL profiling [extensions/MultimediaViewer] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106290 
[17:50:41] <grrrit-wm>	 (03PS1) 10M4tx: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard into bug/42964 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106291 
[17:50:42] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Version our EL profiling [extensions/MultimediaViewer] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106290 (owner: 10MarkTraceur)
[17:50:51] <grrrit-wm>	 (03PS1) 10MarkTraceur: Version our EL profiling [extensions/MultimediaViewer] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106292 
[17:50:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix painful bug in eventlogging code [extensions/MultimediaViewer] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106288 (owner: 10MarkTraceur)
[17:51:13] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Version our EL profiling [extensions/MultimediaViewer] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106292 (owner: 10MarkTraceur)
[17:51:24] <marktraceur>	 Patchspam yayyyy
[17:51:49] <grrrit-wm>	 (03Abandoned) 10M4tx: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard into bug/42964 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106291 (owner: 10M4tx)
[17:52:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Version our EL profiling [extensions/MultimediaViewer] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106290 (owner: 10MarkTraceur)
[17:52:38] <marktraceur>	 Hm, I don't have a tgr yet, and the standup is soon
[17:52:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Version our EL profiling [extensions/MultimediaViewer] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106292 (owner: 10MarkTraceur)
[17:52:57] <marktraceur>	 Oh wait, even worse, the bug triage is soon
[17:55:28] <grrrit-wm>	 (03PS5) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 
[17:55:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[17:58:44] <gi11es>	 both entries in the calendar overlap, which video call should we join first? daily scrum?
[17:59:55] <marktraceur>	 I think triage
[18:00:50] <marktraceur>	 We have some A/V issues, predictably
[18:01:12] <grrrit-wm>	 (03PS6) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 
[18:04:02] <fabriceflorin>	 Hi marktraceur and tgr : Are you joining us on Google Hangouts?
[18:04:11] <tgr>	 trying to
[18:04:23] <tgr>	 we have some tech problems
[18:04:39] <aarcos>	 ok, we are waiting...
[18:05:17] <grrrit-wm>	 (03CR) 10M4tx: "Sorry for the mess. I had some problems with merging the patch. I fixed the problems that Gergő Tisza mentioned." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[18:14:02] <bd808>	 Which room are you guys in? Diderot?
[18:21:08] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[18:51:01] <tgr>	 as a side topic, do we do any client-side logging of JS errors? could be useful with bugs like this
[19:03:28] <marktraceur>	 tgr: Hm, I think there is some logging, but I'm forgetting how it works
[19:11:26] <marktraceur>	 fabriceflorin: OK, re: spinner
[19:11:39] <marktraceur>	 I think the situation is, with the progressive load patch, it's not shown anymore
[19:11:42] <marktraceur>	 But that patch needs fixing
[19:11:50] <marktraceur>	 So that should maybe be priority one for me
[19:14:38] <fabriceflorin>	 marktraceur: yes, it would be great if we could fix the spinner today for tomorrow's release, it makes us all look bad. Even if you can't implement progressive image load today, at least replace the spinner to use Pau's instead -- or a better version of yours that looks good. We're staring at this for up to 10 seconds, so it's perceived as our primary experience, hence the high priority.
[19:15:05] <marktraceur>	 Wait. Pau's spinner?
[19:15:11] <marktraceur>	 I don't remember that existing
[19:15:46] <fabriceflorin>	 Pau had recommended a spinner in an email he sent in December. Let's ask him now and/or dig up through email.
[19:16:05] <marktraceur>	 I'll look
[19:16:51] <tgr>	 this is just about fixing the problem in https://gerrit.wikimedia.org/r/#/c/100693/ right?
[19:17:12] <tgr>	 I can try if you don't mind, Mark, I'm a bit short on tasks today
[19:17:25] <marktraceur>	 Oh, sure
[19:17:31] <marktraceur>	 As long as we have a reviewer
[19:17:45] <marktraceur>	 I don't want to go to sleep uncertain of whether it will get merged
[19:19:17] <tgr>	 i'll take a shot at it and see if aarcos or gi11es is still up afterwards
[19:19:30] <marktraceur>	 'kay
[19:19:38] <tgr>	 re logging, I was thinking of logging client errors on server side
[19:19:45] <marktraceur>	 Oh, I see
[19:19:50] <tgr>	 catch exceptions at top level, send home in AJAX
[19:20:06] <tgr>	 do we have something like that?
[19:20:12] <marktraceur>	 There might be a way in the debug settings, but I don't know
[19:20:14] <marktraceur>	 ori-l might
[19:28:40] <marktraceur>	 Hey gi11es, I have some patches that are mostly refactoring that you could probably review quick:
[19:28:43] <marktraceur>	 :* https://gerrit.wikimedia.org/r/105993
[19:28:45] <marktraceur>	 :* https://gerrit.wikimedia.org/r/106004
[19:28:48] <marktraceur>	 :* https://gerrit.wikimedia.org/r/106005
[19:29:14] <marktraceur>	 fabriceflorin: FYI there are issues with theopolisme's core patch for fullscreen that may stop it from going out
[19:29:27] <marktraceur>	 But the next version can easily have it
[19:30:13] <fabriceflorin>	 marktraceur: Full screen can wait, but let's fix the spinner and the metadata panel that obscures the image for tomorrow's release.
[19:30:25] <marktraceur>	 OK
[19:30:35] <marktraceur>	 I'll review the metadata panel thing now
[19:30:45] <marktraceur>	 And back off intensity on the fullscreen things
[19:32:52] <marktraceur>	 * Test image bucketing code (in parallel with metrics) (who?)
[19:33:00] <marktraceur>	 fabriceflorin: Who was supposed to be doing this?
[19:35:50] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "I thought it might not work with document instead of document.body, but WFM. Thanks, gi11es!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106263 (owner: 10Gilles)
[19:36:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make the behavior of the lightbox more consistent with scroll [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106263 (owner: 10Gilles)
[19:36:33] <marktraceur>	 {{done}}, wonderful
[19:38:37] <mayankmadan>	 aarcos, i dont understand your comments on https://gerrit.wikimedia.org/r/103596 , i have fixed the code duplication by defining a new function
[19:42:02] <marktraceur>	 mayankmadan: Lines 69-78 look a lot like lines 80-85.
[19:42:53] <marktraceur>	 And 98-105
[19:43:17] <marktraceur>	 And 114-123
[19:44:06] <mayankmadan>	 marktraceur, but an apiRequest has to made for every test
[19:44:12] <marktraceur>	 Yes
[19:44:29] <marktraceur>	 And you can make that API request in a different function
[19:44:52] <marktraceur>	 I'm guessing about aarcos's intent, but I suspect they involved repeated code there
[19:45:00] <marktraceur>	 Also grumble, where did fabriceflorin get to
[19:46:22] <mayankmadan>	 marktraceur, okay
[20:06:38] <grrrit-wm>	 (03CR) 10Kaldari: "@M4tx: I wasn't complaining. It was a compliment!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[20:08:48] <grrrit-wm>	 (03CR) 10Kaldari: [C: 031] Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[20:18:35] <fabriceflorin>	 marktraceur: Sorry, I was away, due to power outage. Will be back on IRC for the rest of the day (though breaking for lunch shortly). Glad you're focusing on spinner and metadata panel obstruction for tomorrow's release, they are both key for us, full screen can wait.
[20:18:46] <marktraceur>	 'kay
[20:19:05] <marktraceur>	 fabriceflorin: What about the question about testing image bucketing?
[20:20:36] <fabriceflorin>	 marktraceur: I thought we discussed asking Aaron to work with you to test image bucketing, analyze results and report on findings. Perhaps we could start an email thread or ether pad for now to see what we can realistically do with limited resources to see how painful this is for users and how much our bucketing code is helping with that.
[20:20:50] <marktraceur>	 'kay
[20:20:57] <marktraceur>	 I just didn't have it written down in the pad
[20:21:27] <marktraceur>	 I can actually start analysing the data this week, I think
[20:21:41] <marktraceur>	 Like, on a dashboard
[20:21:44] <fabriceflorin>	 Cool. Thanks for all your good work this week, and sorry I haven't been more responsive, due to a variety of factors.
[20:21:53] <marktraceur>	 No problem
[20:22:56] <fabriceflorin>	 Moving on now to writing the monthly engineering report, planning community engagement with Keegan and posting the vision piece later today. Ping me if you need anything tested for tomorrow's Media Viewer release. Cheers ...
[20:23:31] <marktraceur>	 Sure sure
[20:25:01] <gi11es>	 marktraceur: is it ok if I review those 10 hours from now? I really need a bit of free time tonight. reviews are the first thing I do when I get up
[20:25:43] <gi11es>	 I'll do
[20:25:50] <grrrit-wm>	 (03PS2) 10Gergő Tisza: Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[20:25:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[20:26:16] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Just adding some jsdoc." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[20:54:28] <grrrit-wm>	 (03PS11) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 
[20:54:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[20:55:22] <mayankmadan>	 marktraceur, how is the latest patchset looking?
[20:56:14] <marktraceur>	 Basically the same?
[20:56:43] <marktraceur>	 Ah, you're almost there
[20:56:48] <marktraceur>	 Just call that function a few more times
[20:57:07] <marktraceur>	 tgr: Are you signing up to do GSoC this year? I think I'm a bit disillusioned about it
[20:57:16] <marktraceur>	 (there's a post on the list)
[20:58:12] <tgr>	 will see how OPW goes
[20:58:26] <tgr>	 so far i havent done a great job, i guess
[20:58:40] <mayankmadan>	 marktraceur, was the "Just call that function a few more times" for me?
[20:59:57] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[21:00:07] <marktraceur>	 Yeah
[21:00:13] <marktraceur>	 mayankmadan: Yes, it was
[21:00:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[21:00:30] <mayankmadan>	 marktraceur, a few more times meaning in other tests too?
[21:00:45] <marktraceur>	 Ideally, or your refactor might not make much sense
[21:00:49] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Rebased. I think the problem is related to race conditions in the API calls, and the recent work with promises makes it a lot easier to de" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[21:02:02] <tgr>	 aw crap, those are not merged yet
[21:02:11] <marktraceur>	 Nooope
[21:02:15] * marktraceur  looks at gi11es 

[21:03:47] <gi11es>	 http://24.media.tumblr.com/tumblr_mco3mh94gd1qgc2meo1_400.jpg
[21:04:31] <gi11es>	 I promise that you won't have to wait more than 24 hours for reviews from me in the future, it's just that start week comes with a lot of extra overhead
[21:04:42] <gi11es>	 and I really need to research strollers tonight
[21:05:09] <marktraceur>	 Heh
[21:05:10] <tgr>	 hm, jshint does not like some of the closure documentation style
[21:05:47] <marktraceur>	 tgr: I think just basic jsduck is probably better :/
[21:06:07] <tgr>	 the issue is with
[21:06:16] <tgr>	  /** .... */
[21:06:28] <tgr>	 Foo.bar;
[21:06:31] <marktraceur>	 Really?
[21:06:46] <tgr>	 which is not an assignment or a function call
[21:06:57] <marktraceur>	 ...huh
[21:07:01] <tgr>	 but a nice way to document members in a prototype
[21:07:21] <tgr>	 could just doo Foo.bar = undefined; i guess
[21:07:58] <marktraceur>	 Wait.
[21:08:01] <marktraceur>	 What?
[21:08:22] <marktraceur>	 Oh
[21:08:35] <tgr>	 i added a block like
[21:08:37] <tgr>	 	/**
[21:08:37] <tgr>	 	 * @type {LightboxImage}
[21:08:37] <tgr>	 	 * @protected
[21:08:37] <tgr>	 	 */
[21:08:39] <tgr>	 	LIP.currentImage;
[21:08:52] <tgr>	 just to get type annotation on currentImage
[21:08:54] <marktraceur>	 You can do that in the constructor
[21:09:58] <tgr>	 yes, but when someone wants to read through what the constructor actually does, he wouldn't thank me
[21:11:06] <marktraceur>	 True.
[21:11:13] <marktraceur>	 OK, so undefined or null would also work
[21:11:27] <tgr>	 yeah, I'll do that
[21:12:11] <grrrit-wm>	 (03PS4) 10Gergő Tisza: Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[21:16:34] <gi11es>	 the discussion happened before I was here, but yes, spinners for images are bad
[21:16:55] <gi11es>	 we studied the effect at deviantart and real image load beats speed impression of spinner hands down
[21:17:20] <gi11es>	 even better if you can blow up any lower res image already cached and load the higher res on top
[21:21:10] <gi11es>	 and while it's generally better to have an entire UI appear at once when everything is ready, instead of people seeing the DOM move around as it loads/gets constructed, images are a notable exception in that it's better if people see them appear
[21:21:36] <gi11es>	 basically you don't want stuff to jump around, but it's better to have images load the naturel top-to-bottom way
[21:21:39] <grrrit-wm>	 (03PS12) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 
[21:22:22] <mayankmadan>	 marktraceur, now it should be good to go
[21:22:35] <gi11es>	 I've run into situations where the choice about what to wait for/what to display right away had really counter-intuitive results in what felt faster
[21:34:10] <marktraceur>	 2014-01-08 - 13:17:20  <gi11es> even better if you can blow up any lower res image already cached and load the higher res on top
[21:34:17] <marktraceur>	 gi11es: What do you mean exactly, there?
[21:35:02] <gi11es>	 if the thumb on the page is big enough, you can but it as the lightbox's background right behind the loading image
[21:35:22] <gi11es>	 it only works if the thumb is reasonably big to begin with, but we did that a bunch on dA
[21:35:35] <gi11es>	 *put it
[21:37:19] <marktraceur>	 Well, the thumbnail would be of varying size
[21:37:32] <marktraceur>	 There can be thumbnails that are 2 pixels and thumbnails that are 2000 pixels
[21:37:37] <marktraceur>	 We don't discriminate
[21:37:52] <gi11es>	 we could set a maximum blowup factor
[21:38:05] <marktraceur>	 Hm, maybe
[21:38:13] <gi11es>	 i.e. only do this if you try to display the thumb at most 6 times its original size or something like that
[21:38:16] <marktraceur>	 But then it's inconsistent and seeing no image may be shocking
[21:38:23] <gi11es>	 true
[21:38:43] <gi11es>	 I think it's worth experimenting with, in practice most thumbs are at least 140px, right?
[21:38:50] <marktraceur>	 Usually, yes
[21:39:31] <gi11es>	 I honestly can't remember the size of the ones we were using on dA, 140px might look utterly crappy, but I'd like to see it to be sure
[21:39:41] <marktraceur>	 Heh
[21:39:52] <marktraceur>	 We can work on that after the image resize thing goes in maybe
[21:40:03] <marktraceur>	 Right now I think I'll focus on getting the analytics scripts to run every day
[21:50:54] <grrrit-wm>	 (03CR) 10Theopolisme: [C: 04-1] Titles attribute added to fullscreen and close button (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 (owner: 10Apsdehal)
[21:52:03] <grrrit-wm>	 (03CR) 10Theopolisme: Reduce font-size for description in lightbox (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105154 (owner: 10Apsdehal)
[21:57:06] <marktraceur>	 Maybe even some sort of useful dashboard!
[21:57:08] <marktraceur>	 Exciting times
[21:57:14] <marktraceur>	 I have two hours before the LD
[21:58:13] <quiddity>	 marktraceur, gi11es default thumb size is 220px, since late 2009. bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=21117  Enwiki thread: https://en.wikipedia.org/wiki/Wikipedia_talk:Image_use_policy/Archive_12#Proposal_to_increase_the_default_thumbnail_dimensions
[21:58:28] <gi11es>	 neat, thanks for the info
[22:44:30] <grrrit-wm>	 (03PS5) 10Gergő Tisza: Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[22:45:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[22:56:06] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Fixed some places in the code where data was not passed correctly. This fixed a lot of resize bugs, but the image loading is not increment" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[22:59:28] <fabriceflorin>	 marktraceur: Do you think anything tested before the LD?
[22:59:55] <marktraceur>	 The LD shouldn't be anything complicated, I have the patches set up in the wmf8/9 branches and it should be quick and uneventful
[23:04:31] <fabriceflorin>	 Okay, sounds good. Were you able to fix the spinner and the media panel obstruction?
[23:09:50] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Incremental display still does not work even if I undo all my changes. Must have been caused by the rebase." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[23:13:56] <marktraceur>	 fabriceflorin: tgr is working on it
[23:15:02] <fabriceflorin>	 super. thanks for the update.
[23:16:36] <marktraceur>	 tgr: The incremental loading may not work obviously, because localhost may be too fast to notice it
[23:16:46] <marktraceur>	 You should probably go for a *really* big image to test.
[23:17:26] <tgr>	 i'm thinking of that too, since it seems to work every once in a while
[23:17:43] <tgr>	 is it possible that the image is not displayed before the metadata is in?
[23:18:05] <marktraceur>	 It's definitely not.
[23:18:14] <tgr>	 because it works very sluggishly for me on localhost, which makes sense for PHP but not for images
[23:18:15] <marktraceur>	 Because the metadata fetch also includes the URL to the thumbnail
[23:18:38] <tgr>	 ah, yes, of course
[23:19:06] <tgr>	 still, it feels like something is blocking display of the image when it is loading already
[23:19:54] <marktraceur>	 Hm. There *shouldn't* be, but I dunno
[23:20:12] <tgr>	 nevermind
[23:20:32] <tgr>	 i played around with cache settings in chrome, and now incremental loading works fine
[23:20:44] <marktraceur>	 Woot
[23:20:55] <tgr>	 so i guess the patch is ready for review
[23:21:06] <marktraceur>	 'kay
[23:21:14] <marktraceur>	 I'm the only one left, gah
[23:21:19] <marktraceur>	 I'll review it anyway
[23:21:31] <marktraceur>	 If you can +1 that the bits I wrote make sense
[23:23:20] <tgr>	 i think i fixed some bugs that you already fixed in the resize engine patches, so there might be a conflict when those are merged
[23:23:31] <marktraceur>	 Heh, fun
[23:23:37] <marktraceur>	 I'll deal with that after tomorrow anyway
[23:23:53] <tgr>	 I thought at some point that a resize callback is missed, but it was a different issue after all
[23:24:37] <marktraceur>	 Did you review the parent commits?
[23:24:52] <tgr>	 parent of what?
[23:24:53] <marktraceur>	 It looks like there's an older version actually
[23:25:04] <marktraceur>	 Oh, never mind
[23:26:07] <grrrit-wm>	 (03PS6) 10Gergő Tisza: Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[23:26:18] <tgr>	 I forgot a console.log there
[23:26:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[23:27:01] <marktraceur>	 tgr: Won't the image.width = targetWidth need to go before the image.src = line now?
[23:27:16] <marktraceur>	 Or immediately after
[23:28:43] <tgr>	 not sure when an image gets a width
[23:28:59] <marktraceur>	 I recall looking for an event to listen for and failing.
[23:29:13] <marktraceur>	 Maybe just set a timeout that looks for the width?
[23:29:28] <marktraceur>	 If it's undefined set another timeout etc.
[23:29:58] <tgr>	 probably you are right and immediately after would work
[23:30:02] <tgr>	 lets see
[23:30:27] <marktraceur>	 The trick is, before I wasn't looking at the width to see if it was bigger.
[23:30:33] <marktraceur>	 So now that we have that...hm.
[23:31:49] <marktraceur>	 tgr: Aha - check the "thumbwidth" value from the API response, it will tell you the size of the URL
[23:31:56] <marktraceur>	 s/URL/image/ wow
[23:32:09] <marktraceur>	 If that's bigger, then replace the width before even loading the image.
[23:33:55] <marktraceur>	 Should be innerInfo.thumbwidth
[23:36:22] <tgr>	 seems to work
[23:36:31] <tgr>	 or at least there is no visible difference
[23:37:04] <grrrit-wm>	 (03PS7) 10Gergő Tisza: Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[23:37:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[23:43:38] <grrrit-wm>	 (03PS8) 10Gergő Tisza: Load images normally [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100693 (owner: 10MarkTraceur)
[23:43:52] <tgr>	 got rid of some assertions, I don't think they make sense anymore
[23:43:57] <marktraceur>	 'kay
[23:44:12] <tgr>	 and hopefully this makes jenkins happy
[23:44:47] <marktraceur>	 We can only hope
[23:45:44] <tgr>	 ok, +1 on my side
[23:53:53] <marktraceur>	 tgr: How do you make Chrome not be dumb?
[23:54:15] <tgr>	 you mean caching?
[23:54:19] <marktraceur>	 Yeah
[23:54:24] <marktraceur>	 I want to verify it's working
[23:54:40] <tgr>	 i think opening the web dev toolbar and enabling the no cache option helped
[23:54:56] <tgr>	 you have to keep the toolbar open for it to work
[23:55:15] <marktraceur>	 Hm
[23:55:25] <marktraceur>	 I think I may need to also have a big file locally
[23:57:07] <marktraceur>	 Still not seeing it, weird.
[23:58:05] <marktraceur>	 I'll do the deploy and try again after