[10:52:32] (03CR) 10Gilles: Fixed positioning for the image (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104689 (owner: 10MarkTraceur) [11:04:07] (03CR) 10Aarcos: "LGTM" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105734 (owner: 10MarkTraceur) [11:05:30] (03CR) 10Gilles: "What's the process for raising a UI spec issue? This animation is way too obnoxious. It's fine for someone who's never opened the lightbox" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104696 (owner: 10MarkTraceur) [11:26:37] (03CR) 10Aarcos: Animate the metadata div to show the user it's there (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104696 (owner: 10MarkTraceur) [11:28:53] (03PS6) 10Apsdehal: Titles attribute added to fullscreen and close button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 [11:29:06] (03CR) 10jenkins-bot: [V: 04-1] Titles attribute added to fullscreen and close button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 (owner: 10Apsdehal) [11:31:26] (03PS7) 10Apsdehal: Titles attribute added to fullscreen and close button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105459 [13:29:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105005 (owner: 10Apsdehal) [14:47:19] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105954 [14:48:07] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105954 (owner: 10Hashar) [15:08:25] (03PS1) 10Pginer: Styling fixes for media panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105960 [15:08:26] (03CR) 10jenkins-bot: [V: 04-1] Styling fixes for media panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105960 (owner: 10Pginer) [15:14:45] (03PS2) 10Pginer: Styling fixes for media panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105960 [15:51:50] (03CR) 10Aarcos: "This looks reasonable to me but I don't think I have the domain knowledge to actually have a vote on this review." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [15:52:45] (03CR) 10MarkTraceur: "I'm intrigued by the thought, gilles - I think the minimum browser support we're aiming for might put us *just* below what we need for cal" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104694 (owner: 10MarkTraceur) [15:54:13] (03CR) 10Gilles: "Where can I find the browser minimum we currently support?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104694 (owner: 10MarkTraceur) [15:54:56] (03CR) 10MarkTraceur: "I think we actually could do that - it would mean sticking the div "under" the image (i.e. placing it before the image in the DOM), and pr" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104768 (owner: 10MarkTraceur) [15:57:05] (03CR) 10MarkTraceur: "I'll look into doing promise things today! Exciting." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105742 (owner: 10MarkTraceur) [15:59:55] (03CR) 10MarkTraceur: [C: 032] "Woohoo! Thanks so much, tonythomas." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105005 (owner: 10Apsdehal) [16:00:23] (03Merged) 10jenkins-bot: Added No description message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105005 (owner: 10Apsdehal) [16:00:55] (03CR) 10MarkTraceur: "My current default is to tug at a product manager's coattails until they tell me. I'd ask Krinkle or RoanKattouw for something super-techn" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104694 (owner: 10MarkTraceur) [16:01:54] Man, full plate today [16:01:59] Refactor all the things [16:02:09] heh [16:02:26] well my day is almost over and all I've done is read and comment, haven't had a chance to open my editor [16:02:45] I guess it compensates that you're going to have to code all day? :) [16:05:54] (03CR) 10Gilles: "OK, I'll talk to Fabrice, then. We should have an official list written somewhere and guidelines about what to do when browsers are below " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104694 (owner: 10MarkTraceur) [16:10:03] does gerrit support multiple commits in a single changeset? if for example you want to separate reactoring from bugfix, but still bundle both in the same review? [16:10:31] I'm thinking about large commits, it's not really useful on small ones [16:11:41] gi11es: Hah, no [16:11:57] A big complaint from people new to Gerrit from the GitHub world :) [16:14:10] my main complaint is the horrid UI, but the list is long [16:14:28] multi-commmit isn't a big deal, the workaround is obvious [16:16:02] how do I run the tests locally? jslint, lint, qunit, etc. [16:25:46] gi11es: They're all different - jslint is a command, you can use "npm install jslint" for such things [16:25:54] gi11es: Lint, I don't know [16:26:12] gi11es: qunit is at Special:JavaScriptTest on your wiki [16:54:01] thanks [17:11:32] No problem [17:22:08] How are we going to run this standup thing? Hangouts? Mumble? [17:22:16] Agh, none of the relevant players are here [17:25:20] I will join the hangout, ;-). [17:31:19] Agh [17:31:37] What with the chatter on Mumble yesterday I held up hope that we'd change [17:51:10] marktraceur: Hi Mark !, if no more issues left with https://gerrit.wikimedia.org/r/#/c/103624, can you merge it? Tx ! [17:54:11] (03CR) 10MarkTraceur: "It looks fine to me - there's a few issues with var statement order, but whatever." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 (owner: 10Aarcos) [17:54:20] (03CR) 10MarkTraceur: [C: 032] Add basic UI tests to LicenseInput class. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 (owner: 10Aarcos) [17:54:26] (03Merged) 10jenkins-bot: Add basic UI tests to LicenseInput class. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 (owner: 10Aarcos) [17:54:34] aarcos: Done! [17:54:45] I'll do the Jenkins/Zuul thing later [17:54:55] For now, I need to figure out a standup...oh, wait, I have a standup desk [17:55:19] marktraceur: tx !, seeya in a bit, ;-)... [17:55:24] we can do mumble if you guys want to, the server is still up [17:55:24] Yarp- [17:55:41] I don't mind either way [17:56:00] gi11es: I think we have no way of quickly signalling to fabrice that we'd be doing Mumble [17:56:09] Let's discuss it during the standup, novel plan [17:56:23] ah, right, let's postpone figuring this out until fabrice is back to being healthy [17:56:45] it's probably more than enough for him right now to just keep up on regular work [18:12:54] (03Abandoned) 10MarkTraceur: Styling adjustments on the bottom panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100362 (owner: 10Pginer) [18:14:13] (03CR) 10MarkTraceur: [C: 04-1] "Remove the change to multilightbox, I think. It's unnecessary." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105960 (owner: 10Pginer) [18:55:20] marktraceur: The border in the .mlb-cntrols rule affects the final display. I changed it to red in Chrome DevTools as an example: http://i.imgur.com/kfzSySf.png [18:55:38] Oh, whoa [18:56:10] pginer: In that case you can still change it in the ext.multimediaViewer module, they're called cascading style sheets for a reason :) [18:56:42] That also explains why that div is 97px tall [18:56:46] I was always curious about that [18:57:45] What is not clear to me is which is the criteria to add rules in one or the other file [18:58:24] Since the rule existed, I modified wherever it was [18:59:34] pginer: It should always be a modification in ext.multimediaViewer, unless you're consciously changing the way the library behaves [18:59:50] I think we hardly ever change the CSS anymore, I haven't opened the standalone multilightbox test in a long time [19:00:07] So basically I *shouldn't* let people modify the library code [19:01:18] ok. I didn't knew multilightbox was a library [19:02:00] It's supposed to be :) [19:02:11] I'll update the patch set to leave multilightbox.css intact [19:03:03] Thanks :) [19:05:31] (03PS3) 10Pginer: Styling fixes for media panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105960 [19:06:17] Done [19:06:44] Yay! [19:36:42] Oh interesting [19:36:53] The arrow keys work before the arrow buttons are loaded [19:37:17] (03CR) 10MarkTraceur: [C: 032] "Je l'aime!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105960 (owner: 10Pginer) [19:37:29] Maybe we should load the arrow buttons sooner [19:37:33] Agh, first refactoring [19:37:45] (03Merged) 10jenkins-bot: Styling fixes for media panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105960 (owner: 10Pginer) [19:58:40] (03PS1) 10MarkTraceur: Refactor animation, plus test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105993 [19:58:48] I'm sure you could say something about this being a UI test [19:59:11] I'm mostly OK with that [19:59:24] Hm, no I'm not, I'll replace $.fn.animate instead [20:05:10] (03PS2) 10MarkTraceur: Refactor animation, plus test [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105993 [20:05:17] More better [20:07:53] Next: Promises [20:19:45] (03PS1) 10MarkTraceur: Use promises [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106004 [20:26:51] (03PS1) 10MarkTraceur: Also use promise syntax for repoInfo fetches [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106005 [20:27:05] I promise [20:27:09] * marktraceur goes for noms [21:38:52] Announce: I am bad at thinking about data [21:38:58] But it's OK [21:39:08] The analytics team is currently hitting me with a very large cluebat [22:05:32] (03CR) 10Gergő Tisza: "A function returning a promise and then neither resolving nor rejecting it will eventually cause trouble. All the branches where the fetch" (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106004 (owner: 10MarkTraceur) [22:08:04] (03CR) 10Gergő Tisza: Also use promise syntax for repoInfo fetches (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106005 (owner: 10MarkTraceur) [22:08:11] Yes yes [22:17:49] (03PS1) 10Reedy: Hack to fix bug 59780 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106134 [22:18:58] marktraceur: could you review or unblock https://gerrit.wikimedia.org/r/#/c/42770/ ? apparently -2 sticks to new patchsets, so your block for the old version is still there [22:20:16] (03CR) 10MarkTraceur: "Trusting tgr on this" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [22:20:44] thx! [22:23:18] (03PS1) 10Reedy: Hack to fix bug 59780 [extensions/TimedMediaHandler] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106135 [22:23:47] (03CR) 10Reedy: [C: 032] Hack to fix bug 59780 [extensions/TimedMediaHandler] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106135 (owner: 10Reedy) [22:23:49] (03Merged) 10jenkins-bot: Hack to fix bug 59780 [extensions/TimedMediaHandler] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106135 (owner: 10Reedy) [23:48:52] marktraceur: do the bugs that you want to give me from fabrice's list need to be filed? or are they already in bugzilla? [23:49:27] They aren't filed, but you don't *need* to file them [23:49:33] You could also look at the list [23:49:40] They might be filed but I don't know about it [23:52:04] alright, I'm fine with doing whatever you see fit form the list. I'm going to bed I'll start working on them in 7-8 hours [23:52:44] 'kay! [23:52:56] I doubt I'll hit anything, I'm still involved in the metrics business