[00:02:55] quiddity: I think the bug you pointed me at seems fixed, actually, on mw.org [00:03:01] So the refactor must have fixed it [00:03:05] Yay me! [00:04:43] marktraceur, if I click the image on the main page, and then the "Learn more on Wikimedia Commons" link, i get taken to [00:04:45] https://commons.wikimedia.org/wiki/File:File:Peter_Paul_Rubens_%281577-1640%29,_Portrait_of_a_commander,_Christie%27s_Images.jpg [00:10:34] On en.wp? [00:11:27] yup [00:11:50] That's because en.wp doesn't have the latest [00:11:58] quiddity: Is it important enough to backport? [00:12:05] CC fabriceflorin, robla? [00:12:21] * robla is in a meeting [00:12:25] No problem [00:12:27] Not urgent [00:14:35] Not sure. For editors who work with files a lot, they'll definitely have to turn off the BetaFeature for a week. Perhaps that's ok? Perhaps a message at the talkpage, to let everyone know it will be fixed in a week, would be enough? [00:15:06] Hm, I don't like that idea overmuch [00:15:12] But I'm basically out of time to backport it [00:15:31] Maybe editors who work with files a lot aren't using the betafeature yet anyway? [00:15:38] Maybe [00:15:45] I bow to fabriceflorin on that determination [00:16:09] marktraceur quiddity : Thanks for the heads-up. We should definitely fix this, but I don't believe we need to backport at this time. This is a beta feature, and people can turn it off if it's a serious issue for them. [00:16:15] 'kay [00:16:16] Yeah, there are probably bigger fish to fry. I'd recommend leaving a very brief note on https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer explaining it though. [00:16:40] Dibs [00:17:01] :) /me goes back to writing long emails. [00:17:13] Yes, it's a good idea to let people know about this. Would you mind dropping a quick note there? Or would you like me to? [00:18:01] I did [00:19:47] marktraceur: Thank you! I'm in the middle of sorting out the alphabet soup of MP4, MPEG4 PRT 14 VS. PAERT 10, H.264, AVC, and trying to keep my sanity ... [00:20:08] Ooh, fun times [00:20:16] * marktraceur prefers Alpha-Bits [00:20:52] Hehe. I can't believe the industry has allowed this level of rampant complexity to creep in this day and age ... [00:21:16] fabriceflorin: This industry is built on complexity, it's how people make their money nowadays [00:22:38] fabriceflorin, this is the canonical explanation: http://xkcd.com/927/ [00:22:53] Could well be. It's simply insane. It seems only technology experts and lawyers can make sense of this .... I long for the analog days, when there were just a few formats to keep track of :) [00:23:39] quiddity: Indeed, this illustrates very well the mess we're in. [00:24:28] I don't know what you mean, there were all sorts of formats for music in the analog days [00:24:40] Guitars, violins, pianos [00:24:47] And they were these giant bloody things, too, not very compact [00:25:24] Oh, yeah, where's vinyl in all this? That was a sweet technology. [00:26:09] is* [00:26:11] my local indie music store is mostly vinyl. The hipsters are totally bringing it back. [00:26:24] My dad got a portable record player for Christmas, which is awesome [00:27:56] I like my 500 album collection (cds) which is able to fit in my pocket (previously ogg, but now mp3, because the reality of trying to introduce/loan music to non-geek friends...) [00:28:17] I'll re-rip it all in .flac eventually... [00:28:32] Cool. Our son has reintroduced us to vinyl, gave us a turntable last yar. There's something so much more human about these analog technologies .. we lost some of that feeling in the move to digital. I don't want to knock digital, but would be great if it could incorporate some of these real-life elements. [00:29:48] quiddity: That's why I'm usually technology-agnostic. The technologies come and go, but the people and their feelings remain, and that's what really matters most to me :) [00:30:57] marktraceur: is your dad's portable record player a modern or ancient device? [00:31:08] I believe modern [00:31:28] My friend neil has about 2000 cds, but got back into vinyl last year, and is now up to about 200 albums. Half of which he owned on vinyl in the 80s... It definitely makes music more interactive, having to flip the record every 30 minutes, rather than having 5 cds in a carousel... Which is sometimes good, and sometimes bad. [00:32:28] 'kay. That's what Adam got us too. I was hoping my mom would have had an old phonograph in her things, but she didn't would have been a cool way to play my dad's old records. As long as we can still hear the scratches, we'll be fine :) [00:33:24] quiddity: good point. never thought of flipping records as interactive, but you're absolutely right that it is. [00:34:58] OK, better get back to the RfC, so I can wrap it up today. Though it's fun chatting with you guys, glad you rang my bell ... [00:35:00] In contrast, I just load my music player in the morning, and hit "Play", and it cycles randomly through my... 6834 songs. [00:35:16] ditto! Actually lunch. :) [00:58:08] (03PS1) 10Theopolisme: Enable fullscreening with jquery.fullscreen [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 [00:59:23] (03CR) 10Theopolisme: "This does *not* fix the occasional weird rendering/redrawing issues." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105124 (owner: 10Theopolisme) [01:02:38] I knew a guy once could instantly tell the difference between vinyl or tape and CD, he said vinyl was like a waterfall, but digital was like a spray of individual ice crystals. Analog playback is a true curve, while digital approximates a curve with very small square waves [03:25:15] so.... the answer is to rip vinyl to flac? [03:25:25] >.< [07:35:06] marktraceur, around? [07:36:11] mayankmadan_: Uhh...not really [07:36:14] About to sleep [07:36:17] then its fine [08:48:45] (03PS2) 10Apsdehal: Added No description message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105005 [09:16:17] (03PS1) 10Apsdehal: Changed the font-size for decription in lightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/105154 [17:15:41] gi11es: Switchin' the nick up, eh? [17:16:00] yes, that old dusty nickname needs to be put to rest [17:16:09] Fun times [17:16:27] it's equally unpronounceable in english anyway, might as well not force people to memorize two [17:16:42] Hm [17:20:50] I see that wiktionary doesn't have a sound file for it, let's remedy that :) [17:21:10] hi marktraceur [17:21:19] Salut, mayankmadan! [17:25:27] marktraceur, https://gerrit.wikimedia.org/r/#/c/105111/ [17:26:39] is there a plan to use the web audio api to let people record speech directly? just wondering [17:27:07] mayankmadan: You have a review that you should fix, from anomie [17:27:33] gi11es: https://www.mediawiki.org/wiki/Extension:PronunciationRecording [17:27:49] neat [17:28:28] I thought so! [17:28:44] It also meant he got to refactor a bunch of UW things into separate modules, which made me super happy [17:29:40] gi11es: Is your old nick French-based? I'm not even sure I know how to pronounce it if so [17:30:15] yes it is, it comes from this old skit: http://www.youtube.com/watch?v=XkOYGrZQqmU [17:31:04] Hah [17:31:23] I'm glad one of the possible pronunciations were correct [17:37:25] marktraceur, how do i test the code? [17:39:23] mayankmadan: Try making an API request to your local wiki [17:39:34] Oh, it's an upload API call. Less easy. [17:39:44] mayankmadan: Maybe try uploading with UploadWizard - it uses the API [17:42:18] marktraceur, it gives an unknown error [17:42:19] i got it [17:43:06] mayankmadan: You can check the webserver logs to see the error in better detail [17:44:17] marktraceur, how do i check those? [17:45:12] mayankmadan: less /var/log/apache2/error.log usually [18:30:43] marktraceur, how about now? [18:30:59] Did you upload a new patch? [18:31:13] marktraceur, yeah [18:32:42] Hm, I swear I've seen this code before [18:33:28] mayankmadan_: Aren't you doing the same thing here as in https://gerrit.wikimedia.org/r/104012, basically? [18:35:38] marktraceur, that patch was mine too [18:35:49] but bryan said that the check was to be done in the frontend [18:37:15] Yes [18:37:28] marktraceur, isnt that what i am doing? [18:37:35] mayankmadan_: You're doing it in the frontend now, sort of, but you're still calling verifyUpload in a warning-oriented function [18:37:43] Call it before the warning function is even called [18:38:47] marktraceur, what does lost mean here? [18:38:53] https://gerrit.wikimedia.org/r/#/c/105111/ [18:38:55] Actually, the verifyUpload function is already called! [18:39:30] mayankmadan_: I don't see "lost" on that page [18:39:42] marktraceur, the last comment by jenkins-bot [18:41:08] Oh, Jenkins is drunk or something [18:41:13] Probably zuul got restarted [18:41:16] Ignore it for now [18:50:21] * chrismcmahon has a mental image of Jenkins the butler staggering around a server room somewhere marktraceur [19:05:24] Antoine keeps punching poor Jenkins in the face [19:13:24] marktraceur, what should i aim for? [19:20:28] marktraceur, chrismcmahon bd808|LUNCH, I made a thing for you. http://i.imgur.com/wk8af7T.png [19:25:19] or with the traditional font http://memedad.com/memes/85748.jpg [19:26:19] marktraceur, around [20:11:02] mayankmadan_: Sure [20:11:27] marktraceur, what should i aim for? [20:12:30] mayankmadan_: Didn't I explain? [20:14:32] mayankmadan_: If something I said was unclear, you should ask a question about that thing [20:15:14] quiddity: Demonstrating once again why you're very nearly my favourite [20:18:16] marktraceur, you commented in the review request to call verifyUpload() before checkWarnings() in getContextResult method [20:18:33] but what if the *getApiWarnings [20:18:46] *getApiWarnings [20:18:59] What about it? [20:19:11] but what if the getApiWarnings() is called by some other class directly? [20:19:43] mayankmadan_: Then grep for it. [20:19:54] In general I think the API classes are pretty self-contained [20:22:21] marktraceur, its not called anywhere else [20:22:28] so im gonna just check it there [20:24:38] marktraceur, shall i call the verifyUpload() method again? [20:25:15] mayankmadan_: You shouldn't need to, I think, but if you think it's necessary then sure [20:25:31] I think it's stupid to call the same function twice, I think it won't have any more helpful effect [20:27:48] okay [20:37:56] marktraceur, it needs to be called again because it is not returning anything but it has a call to checkVerification() which is important [20:40:56] mayankmadan_: Important to run twice? Why? [20:42:18] marktraceur, because verifyUpload returns nothing and there is nothing [20:42:39] mayankmadan_: The way you checked it in your patch doesn't look for a return value [20:42:58] oh yeah [21:01:07] marktraceur, so can i use $this->mUpload->verifyUpload() again?(its being used in $this->verifyUpload() [21:01:09] ) [21:01:39] Sure [21:05:24] marktraceur, can you have a look now? [21:05:43] marktraceur, am i going the right way? [21:10:15] mayankmadan_: Getting there [21:15:42] marktraceur, why dont i just make the getContextResult return null instead of using dieUsage method? [21:16:49] Hm [21:16:54] I suspect that will cause trouble [21:16:59] But you can try it [21:17:54] then ill just use dieUsage [21:18:24] how about "There were some errors while uploading the file" for the message [21:20:29] mayankmadan_: I think you should figure out what failed verification means and be more specific if possible [21:20:54] marktraceur, than ill just call the checkVerification method [21:21:24] marktraceur, anomie just commented [21:38:03] marktraceur, what is the module that is being talked about? [21:38:49] marktraceur, uploaded a new patchset [21:39:34] marktraceur, is the approach correct? [21:42:34] Hold on. [21:42:47] mayankmadan_: I'm sorry, I wasn't paying attention, why are you calling verifyUpload again? [21:43:28] marktraceur, i didnt find any other way around it [21:46:12] Why not just call $this->verifyUpload() unconditionally? [21:46:18] It does the same thing [21:46:38] More importantly, why isn't verifyUpload being called elsewhere? [21:47:05] why isnt? [21:47:13] Yeah [21:47:29] It's getting called in execute, but apparently not in all circumstances? Why is that. [21:52:36] marktraceur, i think its not called in all the circumstances because there are much more simpler verification tests for those circumstances [21:52:53] no [21:52:55] no idea [21:53:32] mayankmadan_: So look at line 99 and tell me what's wrong there [21:53:37] Because I don't see it [21:54:11] whats wrong? that is just verifying the uploaded file [21:54:15] marktraceur, ^ [21:54:38] Yeah [21:54:41] Why doesn't that fire? [21:54:58] Alternatively, why are we still firing it there if we're going to later on anyway? [21:55:48] true [22:01:39] marktraceur, lets start fresh, lets have a look at the bug report https://bugzilla.wikimedia.org/show_bug.cgi?id=38222 [22:04:06] mayankmadan_: Why start fresh? I want to hear the answer to the question [22:04:17] marktraceur, ive got no idea [22:04:53] Well [22:05:09] mayankmadan_: Maybe we should delete one or the other calls to verifyUpload [22:07:35] marktraceur, we cant remove the call on line 99 [22:07:45] Why not? [22:08:12] marktraceur, actually we can [22:08:43] because getContextResult is always called [22:08:54] and hence getApiWarnings too [22:09:07] Right. [22:09:19] so before getting the warnings we add a call for verifyUpload to verify the file [22:09:34] True [22:11:02] marktraceur, uploaded the patchset [22:17:16] marktraceur, what is blacklisted extension here https://bugzilla.wikimedia.org/show_bug.cgi?id=38222 ? [22:18:26] mayankmadan_: Like if someone were trying to upload an EXE file to Commons [22:20:42] (03PS1) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 [22:24:26] (03CR) 10Mayankmadan: [C: 04-1] "There are some whitespace errors" (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [22:26:41] (03PS2) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 [22:31:15] (03CR) 10Kaldari: "Haven't had a chance to test, but this looks like a heroic effort. It looks like this should cover just about any URL that anyone could po" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [22:36:21] (03CR) 10M4tx: "Hm... is it bad? I think that was the point of the bug report..." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [22:48:34] (03PS3) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393