[15:34:00] <marktraceur>	 Gooooood morning y'all
[15:34:43] <marktraceur>	 I think it's still just us, tgr
[15:34:57] <marktraceur>	 robla: Are you joining us for the weekly meeting?
[15:49:08] <marktraceur>	 Oh, I lied, fflorin is joining us remotely
[16:28:47] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "Tested, works." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal)
[16:31:18] <tgr>	 morning
[16:31:37] <marktraceur>	 Morning!
[16:35:06] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "I don't see the 'x' anymore. (Chrome 31 / Ubuntu)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104131 (owner: 10MarkTraceur)
[16:35:41] <marktraceur>	 Waaaaat
[16:35:51] <marktraceur>	 tgr: Even when you hover over the image/
[16:35:52] <marktraceur>	 ?
[16:36:08] <tgr>	 i think so, but let me re-check
[16:37:43] <tgr>	 no, not even then
[16:37:47] <marktraceur>	 Huh.
[16:37:49] <marktraceur>	 I'll retest.
[16:39:15] <marktraceur>	 I should really take some of these images off my main page
[16:46:39] <marktraceur>	 OK, touche tgr
[16:46:42] <marktraceur>	 I don't see it
[16:47:23] <marktraceur>	 Oh, wonderful, it fucking works in debug mode
[16:47:28] * marktraceur  swears at MediaWiki

[16:47:59] <marktraceur>	 tgr: Can you try emptying your cache and refreshing?
[16:48:37] <tgr>	 tried with Ctrl-F5, in theory that should but be enough
[16:48:40] <tgr>	 ...or not?
[16:49:06] <tgr>	 anyway, doesn't ResourceLoader take care of cache invalidation?
[16:49:50] <marktraceur>	 No, Chrome is stupid about Ctrl-F5
[16:50:05] <marktraceur>	 As for RL, I dunno. Try going through a debug=true load first?
[16:51:57] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "Tested, works. It will conflict with I2c6cef2cb21f88159dc56ca7c94c4be21e553db9 though." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102859 (owner: 10MarkTraceur)
[16:53:01] <grrrit-wm>	 (03CR) 10MarkTraceur: "Merge that first, I'll rebase." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102859 (owner: 10MarkTraceur)
[16:56:48] <tgr>	 doesn't work in debug mode either
[16:57:05] <tgr>	 nor with cache disabled via dev console
[16:57:05] <marktraceur>	 Huh.
[16:57:07] <marktraceur>	 Weird.
[16:57:27] <marktraceur>	 It works fine for me in debug=true
[17:00:18] <tgr>	 if i close the tab and reopen with ctrl-shift-t, i see the X
[17:02:12] <marktraceur>	 ...weird
[17:02:20] <marktraceur>	 But refreshing again, you don't?
[17:03:22] <tgr>	 i do
[17:03:28] <marktraceur>	 Hm.
[17:03:36] <marktraceur>	 I assume that means "cache issue"
[17:03:55] <tgr>	 it seems to work when the page is loaded with a magic url to show an image immediately, but not otherwise
[17:04:01] <marktraceur>	 Oh!
[17:04:15] <marktraceur>	 That explains things
[17:04:19] <marktraceur>	 I'll try to fix it, thanks
[17:19:10] <grrrit-wm>	 (03Abandoned) 10Mayankmadan: Adding support for more types of flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103967 (owner: 10Mayankmadan)
[17:25:02] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "Tested, works. Sometimes there is an 1px gap between the metadata bar and the image, but it is not annoying (actually might even look bett" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur)
[17:26:07] <robla>	 marktraceur: I'll be at the meeting, but maybe a little late
[17:26:29] <marktraceur>	 Kay
[17:26:32] * marktraceur  joins

[17:28:35] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal)
[17:30:33] <robla>	 (yup, I'll be late)
[18:06:06] <tgr>	 marktraceur: https://gerrit.wikimedia.org/r/#/c/99021/ seems to be done but there is nothing to test
[18:06:09] <tgr>	 maybe Theopolisme	
[18:06:34] <tgr>	 ... would like to work on restoring fullscreen, using the new core support?
[18:06:47] <marktraceur>	 Ooh, maybe.
[18:17:28] <tgr>	 marktraceur: re +2, not sure what the norm should be now that we are a team of 4
[18:17:44] <tgr>	 should we wait until everyone gives +1?
[18:17:56] <marktraceur>	 tgr: Naw, +2 should mean the same thing
[18:18:17] <marktraceur>	 Unless there's something that one person will want to weigh in on
[18:18:54] <tgr>	 ok
[18:19:15] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur)
[18:19:30] <marktraceur>	 ...oh
[18:19:35] <marktraceur>	 Hm
[18:19:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur)
[18:19:50] <marktraceur>	 I'm a fan!
[18:19:53] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Added 'Learn more' message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal)
[18:19:55] <mayankmadan_>	 marktraceur, some more help on this
[18:19:58] <mayankmadan_>	 https://gerrit.wikimedia.org/r/#/c/104012/
[18:20:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added 'Learn more' message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal)
[18:21:22] <marktraceur>	 mayankmadan_: He's saying that the verify/warning/upload path should be called by some other function, and that you should check that the previous function(s) have been called at each step internally
[18:21:59] <marktraceur>	 I think it may start to be a slightly more complicated patchset, though
[18:55:57] <marktraceur>	 OK, need to go pick up a friend at the airport, back later
[20:36:58] <grrrit-wm>	 (03PS3) 10MarkTraceur: Move 'x' button, shift arrows away from screen edges [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104131 
[20:37:04] <marktraceur>	 tgr: This seems to fix the issue
[20:57:55] <marktraceur>	 tgr: Do you have a vested interest in having Theopolisme do the fullscreen thing?
[20:58:05] <marktraceur>	 It's one of the design priorities for our release next week
[20:59:12] <tgr>	 not as such
[20:59:20] <tgr>	 but he seemed very capable so far
[21:00:04] <tgr>	 he is a GCI student, I think?
[21:01:50] <marktraceur>	 Yeah, sounds right
[21:01:54] <marktraceur>	 I can confirm with qgil
[21:18:34] * marktraceur  looks for fabriceflorin

[21:18:45] <marktraceur>	 Grumble grumble grumble
[21:53:07] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Add tests for the link construction code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102859 (owner: 10MarkTraceur)
[21:54:00] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Rebased." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102859 (owner: 10MarkTraceur)
[21:54:05] <marktraceur>	 Yay
[21:54:17] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Add tests for the link construction code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102859 (owner: 10MarkTraceur)
[21:56:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add tests for the link construction code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102859 (owner: 10MarkTraceur)
[21:56:21] <marktraceur>	 \o/
[21:57:59] <tgr>	 the X is visible now, but the activation area is way bigger than the image
[21:59:20] <tgr>	 I like it better this way, but there is not much point in hiding it at all if the area where it is hidden is about 5% of the screen
[22:01:08] <marktraceur>	 Heh, yeah maybe
[22:01:22] <marktraceur>	 tgr: I wasn't out to crusade against that just yet, though
[22:01:30] <marktraceur>	 Focusing on things the pdm has actually asked me for first
[22:03:18] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Move 'x' button, shift arrows away from screen edges [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104131 (owner: 10MarkTraceur)
[22:03:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move 'x' button, shift arrows away from screen edges [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104131 (owner: 10MarkTraceur)
[23:35:54] <grrrit-wm>	 (03PS1) 10MarkTraceur: Fixed positioning for the image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104689 
[23:35:56] <marktraceur>	 Phew.
[23:35:59] <marktraceur>	 That was a weird patch.