[12:26:50] (03CR) 10Aarcos: [C: 04-1] Functionality to create a new image in upload-wizard_tests.py (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [13:52:38] (03CR) 10Gergő Tisza: Functionality to create a new image in upload-wizard_tests.py (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [14:47:44] (03CR) 10Anomie: [C: 031] "Code looks ok, haven't tested. But I think you might have forgotten to use one of your URL options." (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [17:13:50] tgr: I have "yes" responses on Calendar from aarcos and fabriceflorin, but I assume they won't be joining us [17:14:15] In any case, I seem to be in a stable enough place [17:28:52] (03CR) 10MarkTraceur: "I think clicking on the image is an action we want to reserve for fullscreen..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/103902 (owner: 1001tonythomas) [17:29:32] (03CR) 10MarkTraceur: [C: 04-1] "Yeah, put the click handler on the overlay instead." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/103902 (owner: 1001tonythomas) [17:30:22] (03CR) 10MarkTraceur: "Oh, and stick the click handler initialisation in the ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js file instead - that c" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/103902 (owner: 1001tonythomas) [17:31:06] (03Abandoned) 10MarkTraceur: Added a local only message to the i18n.php file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99366 (owner: 10Durga94) [17:43:41] (03CR) 10MarkTraceur: "One note about i18n (shame on siebrand for not catching it)" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal) [17:43:43] (03PS3) 10MarkTraceur: Added 'Learn More' message [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal) [17:44:00] (03CR) 10MarkTraceur: [C: 04-1] "Oh, huh. Interesting. Still -1 for lack of qqq." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal) [17:44:22] Oh, right, I haven't merged the refactor for the interface yet [17:47:17] (03CR) 10Siebrand: [C: 04-1] "Per Mark." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/102631 (owner: 10Apsdehal) [17:49:50] (03CR) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [17:50:36] (03CR) 10MarkTraceur: [C: 031] "A few comments about the surrounding code, but otherwise it looks fine to me." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103967 (owner: 10Mayankmadan) [17:53:16] (03PS4) 10MarkTraceur: Styling adjustments on the bottom panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100362 (owner: 10Pginer) [17:58:02] (03CR) 10MarkTraceur: [C: 04-1] "I could have sworn there was another place where we had a hardcoded pixel height for the bottom panel, but I guess not." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/100362 (owner: 10Pginer) [18:00:00] Standup or something! [18:00:04] * marktraceur looks at tgr [18:00:05] yay [18:00:23] * tgr pulls stick [18:00:46] worked on flickr-related uploadwizard bugs [18:01:03] the one about blacklisting user nsids, currently [18:01:19] i'll continue with that [18:01:32] then the UW license i18n bug [18:01:50] I tried to add tests to UW, a review would be appreciated [18:01:56] in Zuul, i mean [18:01:59] Oooh. Interedasting. [18:02:01] I'll look. [18:02:31] no blockers [18:02:47] well, the usual with CMD, but can wait until next year [18:02:52] Ah [18:02:54] * tgr passes stick to marktraceur  [18:03:01] I was gonna look at the patch I had half-reviewed [18:03:04] Anyway [18:03:09] Since Last Time: Worked really hard at not working, failed pretty hardcore, but at least wasn't working on WMF stuff. [18:03:17] Was working on Wikipedia a little [18:03:24] But that's not the same! I swear! [18:03:43] holidays are hard [18:03:44] Today: Code review and more code review, plus probably some bug triage from bugs that have been filed recently. [18:04:05] Ideally I'll have some time to work on moving the controls around [18:04:20] i.e. the arrows away from the sides a little, the 'x' in the top right corner [18:05:36] Uh [18:05:42] No blockers, I don't think [18:05:48] I'd like review on older MMV patches, though [18:06:19] * marktraceur tosses stick to bd808's dog [18:06:25] i think i revied everything that wasn't wip, but will doublecheck [18:07:00] Hm [18:07:01] if i already +1-d something and you need a +2, just poke me [18:07:11] I think the "load image normally" one is good to go [18:07:12] marktraceur: Ebony took the stick and ran into the living room to bury it in the couch [18:07:17] So is the caption one [18:07:32] bd808: Wonderful, we'll know where it is next time we need it [18:08:06] tgr: The tests for the link construction are proooobably ready? I guess I might let aarcos have The Final Say on that one. [18:08:28] The scroll-up affordance patch is definitely ready though [18:09:07] oh, yeah, forgot about the test, will check [18:09:30] what's the id for the other one? [18:09:53] There were three others! :) [18:10:08] https://gerrit.wikimedia.org/r/100618 https://gerrit.wikimedia.org/r/100693 https://gerrit.wikimedia.org/r/100713 [18:10:19] The size bucketing one needs work still though [18:10:26] And I've -1'd all the rest [18:12:37] ah, ok, those didn't show up on the gerrit dashboard [18:13:05] there is some way to be auto-added on all commits to a project, right? [18:13:16] i recall jenkinsbot adding reviewers sometimes [18:13:27] Hm [18:13:31] There's a reviewerbot [18:13:34] I think MZ runs it [18:13:47] Or maybe Bartosz? Ugh, too many people. [18:13:58] mzmcbride? [18:14:10] tgr: Those are for changes to one file or another, though. For per-project...yeah, I can add you. Sec. [18:14:53] tgr: In general you can look at https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/MultimediaViewer,dashboards/default:review [18:15:14] Or our CR dashboard, which is in the topic [18:15:22] (under "gerrit") [18:46:25] (03CR) 10MarkTraceur: "Lots of thoughts, I don't think I have any opinion that would block this going forward though. Responses would be great, but I could also " (0311 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [18:47:04] (03CR) 10MarkTraceur: "For the record I'm +0 on the current patchset, but will re-review after responses to my comments." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [18:47:38] As promised! [18:47:50] I suspect I'll be happy to +2 it after testing. [18:51:27] (03CR) 10Gergő Tisza: Functionality to create a new image in upload-wizard_tests.py (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [18:56:32] (03CR) 10MarkTraceur: [C: 032] "Ooh, sexy solution. Cheers." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100181 (owner: 10Gergő Tisza) [18:56:56] (03PS2) 10MarkTraceur: Add Attribution field to CommonsMetadata output [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96493 (owner: 10Gergő Tisza) [18:57:08] Oh, hm. Not merged yet. [19:01:22] Whatever [19:01:41] (03CR) 10MarkTraceur: [V: 04-1] "Rebase conflict!" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96493 (owner: 10Gergő Tisza) [19:02:34] (03PS3) 10MarkTraceur: Add Attribution field to CommonsMetadata output [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96493 (owner: 10Gergő Tisza) [19:02:39] Real git understood [19:03:52] (03CR) 10MarkTraceur: [C: 031] "I'd like tests :D" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96493 (owner: 10Gergő Tisza) [19:30:25] (03CR) 10Anomie: Rewrite template parsing with DOMDocument (032 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [19:32:28] (03CR) 10MarkTraceur: Rewrite template parsing with DOMDocument (032 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/100569 (owner: 10Gergő Tisza) [19:33:04] * marktraceur shakes his fist at the sky [19:38:12] tgr: Ooh, could we start using CommonsMetadata to parse license prose in UploadWizard? [19:38:24] We'd need to create another API module maybe, but it might be worthit [19:42:31] hey tgr are you okay with +2'ing https://gerrit.wikimedia.org/r/#/c/103561/ ? [19:43:35] (03CR) 10MarkTraceur: [C: 04-1] "Few issues, deferreds are a little more tricky than we may have thought." (036 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [20:03:29] hey bd808, are you okay with +2'ing https://gerrit.wikimedia.org/r/#/c/103561/ ? :) [20:04:31] dan-nl: I'll take a look [20:09:03] thanks bd808! [20:09:17] Np [20:23:02] (03PS1) 10MarkTraceur: Move 'x' button, shift arrows away from screen edges [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104131 [20:31:48] Urgh, resizing isn't working and I have no clue why [20:36:55] Oh my god this is the dumbest thing [20:51:57] (03PS1) 10MarkTraceur: Fix resize engine (a little) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104133 [20:55:21] (03PS2) 10MarkTraceur: Move 'x' button, shift arrows away from screen edges [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104131 [21:01:28] Why can't I edit the mingle anymore [21:01:30] WTF guys [21:04:22] Oh, hurr, because it moved [21:18:44] (03PS7) 10MarkTraceur: Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 [21:18:45] (03CR) 10jenkins-bot: [V: 04-1] Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur) [21:20:13] (03PS8) 10MarkTraceur: Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 [21:20:27] (03CR) 10jenkins-bot: [V: 04-1] Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur) [21:20:31] ...uh huh. [21:27:00] (03PS9) 10MarkTraceur: Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 [21:27:04] I have no idea how this will go [21:27:30] Oh, hm, pretty well [21:27:33] Cool beans [21:28:06] (03CR) 10jenkins-bot: [V: 04-1] Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur) [21:29:22] ...agh [21:39:37] (03PS10) 10MarkTraceur: Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 [21:39:40] More better I hope [23:22:42] * marktraceur swears loudly at past-mark for using globals [23:29:48] marktraceur: WHAT WERE YOU THINKING?!?!!?? [23:30:00] chrismcmahon: Clearly terrible, awful things. [23:30:32] chrismcmahon: But it's OK! I've learned now to use circular references instead. -.- [23:31:31] marktraceur: make sure you use plenty of nested conditionals inside the circular references [23:31:49] Oh, of course [23:37:58] Hrm, it's still not working. [23:51:00] 'kay, I'm gonna push the failing version, because I still don't see what is wrong [23:51:22] (03PS2) 10MarkTraceur: Fix resize engine (a little) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104133 [23:51:53] (03CR) 10jenkins-bot: [V: 04-1] Fix resize engine (a little) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104133 (owner: 10MarkTraceur) [23:53:43] (03CR) 10MarkTraceur: "I can't get the bloody resize event to fire. No errors in the log (that are relevant), no problems anywhere else that I can see, and I've " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/104133 (owner: 10MarkTraceur) [23:59:00] I'm going to call it a day for now, I'm still feeling the effects of caffeine withdrawal, but I'll be in and out all night [23:59:04] Because urgh family