[00:12:53] Gah, now my OCD reflex keeps firing because I'm thinking about how terrible UploadWizard is [00:14:31] (03PS3) 10MarkTraceur: Fix listerner leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96689 (owner: 10Aarcos) [00:14:45] (03CR) 10jenkins-bot: [V: 04-1] Fix listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96689 (owner: 10Aarcos) [00:15:14] aarcos: Jenkins is unhappy with that patch [00:15:23] If you could rebase it that would rock, but no rush [00:15:40] It may be that it's no longer necessary? [00:16:40] I think the leak is still there, I will rebase and resend, tx ! [00:17:20] 'kay [00:17:37] (03CR) 10MarkTraceur: [C: 04-1] Fix listener leak problem. (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96689 (owner: 10Aarcos) [00:19:04] (03PS2) 10MarkTraceur: Make importml.sh less Linux-centric, more UNIX-agnostic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97171 (owner: 10Dereckson) [00:19:16] (03CR) 10MarkTraceur: [C: 032] Make importml.sh less Linux-centric, more UNIX-agnostic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97171 (owner: 10Dereckson) [00:20:06] (03Merged) 10jenkins-bot: Make importml.sh less Linux-centric, more UNIX-agnostic [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97171 (owner: 10Dereckson) [00:20:57] marktraceur: btw, thanx for jumping into the unit test wagon !, will review your bucketing change shortly, ;-) [00:21:03] (03CR) 10MarkTraceur: [C: 04-1] "Less than useful documentation should be taken out, but otherwise good." (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97172 (owner: 10Dereckson) [00:21:11] Thanks! [00:21:29] Oh, hm, you have a later patch about listener leaks [00:22:41] (03CR) 10MarkTraceur: [V: 04-1] "Can't rebase this automatically, so I'm going to -1 it" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 (owner: 10Aarcos) [00:23:01] (03PS2) 10MarkTraceur: Remove lightbox entries from history when closing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97919 (owner: 10Gergő Tisza) [00:23:16] (03CR) 10MarkTraceur: "WIP it, WIP it good." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97919 (owner: 10Gergő Tisza) [00:23:29] (03CR) 10jenkins-bot: [V: 04-1] WIP Remove lightbox entries from history when closing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97919 (owner: 10Gergő Tisza) [00:23:30] (03Abandoned) 10MarkTraceur: Merge "Previous and next functionality!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97938 (owner: 10Vldandrew) [00:23:58] yeap !, c/96689, this is not valid anymore. [00:24:03] (03Abandoned) 10MarkTraceur: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98118 (owner: 10Vldandrew) [00:24:07] c/96819 is the good one ! [00:24:12] aarcos: K [00:24:35] (03Abandoned) 10MarkTraceur: Fix listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96689 (owner: 10Aarcos) [00:25:01] marktraceur: c/96819 is the one that I will fix. [00:25:09] (03CR) 10MarkTraceur: [V: 04-1] "Cannot rebase, fails." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96682 (owner: 10Aarcos) [00:25:11] Yup [00:26:29] (03PS7) 10MarkTraceur: File usage dialog: Only reselect on focus, not on every click [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98128 (owner: 10Bartosz Dziewoński) [00:26:42] (03CR) 10MarkTraceur: [C: 032] "Always a pleasure, MatmaRex" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98128 (owner: 10Bartosz Dziewoński) [00:27:27] (03Merged) 10jenkins-bot: File usage dialog: Only reselect on focus, not on every click [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98128 (owner: 10Bartosz Dziewoński) [00:34:20] Woo, the MMV CR backlog looks not super terrible now [00:35:10] (03CR) 10MarkTraceur: [C: 04-1] "Also, if you tested locally you would be seeing this stuff before you push." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew) [00:40:14] fabriceflorin: Notably, Daniel and I managed to connect re: his gadget, and we determined a much better method for him [00:40:32] (03PS1) 10Aarcos: Smoke tests for LightboxInterface class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 [00:41:01] (03CR) 10jenkins-bot: [V: 04-1] Smoke tests for LightboxInterface class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 (owner: 10Aarcos) [00:42:17] marktraceur: So glad to hear that you were able to help Daniel with his gadget. Let's definitely plan to offer these hooks in the new year, so others may continue to make Media Viewer better without requiring our time. [00:43:29] Cool beans [00:43:51] I mean, really the time was minimal, it was just being able to offer a separate set of eyes to look at the problem [00:44:05] (03CR) 10MarkTraceur: "Coupla notes" (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 (owner: 10Aarcos) [00:44:35] (03PS2) 10Aarcos: Smoke tests for LightboxInterface class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 [00:44:56] Muahaha, OCD bots, FLYYYYY [00:45:10] Oh [00:46:22] (03CR) 10MarkTraceur: [C: 04-1] "ps2.inlineComments = $.map( ps1.inlineComments, function ( comment ) { return comment.replace( /assert\.equal/g, 'assert.strictEqual' ); }" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 (owner: 10Aarcos) [01:13:44] (03PS3) 10Aarcos: Smoke tests for LightboxInterface class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 [01:14:13] (03CR) 10jenkins-bot: [V: 04-1] Smoke tests for LightboxInterface class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 (owner: 10Aarcos) [01:16:09] (03PS4) 10Aarcos: Smoke tests for LightboxInterface class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 [01:16:50] (03CR) 10Aarcos: "ptal (please take another look)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 (owner: 10Aarcos) [01:17:56] (03CR) 10MarkTraceur: [C: 032] "Mumble grumble spacing, but whatever. :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 (owner: 10Aarcos) [01:18:25] (03Merged) 10jenkins-bot: Smoke tests for LightboxInterface class. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99284 (owner: 10Aarcos) [01:40:13] (03CR) 10Aarcos: Introduce image size bucketing (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur) [01:54:00] (03CR) 10Dereckson: Improving functions documentation (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97172 (owner: 10Dereckson) [01:56:06] (03PS1) 10MarkTraceur: Remove oojs hack [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99301 [01:56:49] (03CR) 10jenkins-bot: [V: 04-1] Remove oojs hack [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99301 (owner: 10MarkTraceur) [02:46:11] (03CR) 10Catrope: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99301 (owner: 10MarkTraceur) [02:47:10] (03PS2) 10Catrope: Remove oojs hack [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99301 (owner: 10MarkTraceur) [02:53:32] (03CR) 10Jforrester: [C: 032] Remove oojs hack [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99301 (owner: 10MarkTraceur) [02:54:00] (03Merged) 10jenkins-bot: Remove oojs hack [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99301 (owner: 10MarkTraceur) [02:59:55] (03PS1) 10Catrope: Remove oojs hack [extensions/MultimediaViewer] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99313 [03:00:23] (03CR) 10jenkins-bot: [V: 04-1] Remove oojs hack [extensions/MultimediaViewer] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99313 (owner: 10Catrope) [11:46:24] (03PS1) 10Durga94: Added a local only message to the MultimediaViewer.i18n.php file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99359 [11:48:15] (03CR) 10jenkins-bot: [V: 04-1] Added a local only message to the MultimediaViewer.i18n.php file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99359 (owner: 10Durga94) [12:08:35] (03PS1) 10Durga94: Added a local only message to the i18n.php file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99366 [12:08:38] (03CR) 10jenkins-bot: [V: 04-1] Added a local only message to the i18n.php file [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99366 (owner: 10Durga94) [12:21:33] (03CR) 10Siebrand: [C: 04-2] "No logic is allowed in i18n.php files." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99366 (owner: 10Durga94) [12:22:17] (03CR) 10Siebrand: [C: 04-2] "No logic is allowed in i18n files." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99359 (owner: 10Durga94) [12:41:08] (03CR) 10Gergő Tisza: "Well, do you still intend to review it? :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97919 (owner: 10Gergő Tisza) [13:34:31] (03CR) 10Vldandrew: "I could not make it work locally, there were no errors but the lightbox wouldn't show up. I asked on irc and someone said that I need a w" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew) [14:57:15] (03CR) 10Gergő Tisza: "See https://www.mediawiki.org/wiki/Download_from_Git on getting the newest version of MediaWiki." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew) [17:21:03] (03CR) 10Catrope: [C: 032 V: 032] Remove oojs hack [extensions/MultimediaViewer] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99313 (owner: 10Catrope) [18:00:00] Stand-up! [18:00:00] Order: bd808 -> fabriceflorin -> tgr -> marktraceur [18:00:27] Oh my goodness [18:00:37] my internet connection is acting up today [18:00:39] Oh, ffs, fabrice rescheduled [18:00:48] I could have had FIFTEEN MORE MINUTES OF SLEEP [18:01:04] i probably won't make it to hangout [18:21:22] Womp womp [18:21:29] tgr: 'kay, see you around [18:21:42] I guess if bd808 is the only remote person we may or may not need to hangout! [18:22:00] As much as we love you, bd808. [18:22:05] * bd808 will stay sitting down [18:22:25] Heh [18:28:04] tgr: Can you make it? [18:28:29] let's see [19:58:49] (03PS14) 10Vldandrew: Corrected page link and problems if the link is to a remote server [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 [19:58:51] (03CR) 10jenkins-bot: [V: 04-1] Corrected page link and problems if the link is to a remote server [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew) [20:02:56] (03CR) 10Gergő Tisza: Introduce image size bucketing (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur) [20:06:44] (03PS15) 10Vldandrew: Corrected page link and problems if the link is to a remote server [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 [20:49:17] Anyone want to review my interface change for translated svgs? https://gerrit.wikimedia.org/r/#/c/95746/ [20:50:21] The patch is sitting all lonely, pending review, and wants to go play with the other patches which are merged into master [20:50:47] Let's face it bawolff [20:50:51] Some patches are just different [20:51:08] They'll just be forever alone? [20:51:20] Maybe that's what the patch gods have planned for it [20:52:46] I still have hope for this patch. I've resigned myself to feeling that 42279 will be forever alone [20:52:57] but I don't care about that patch as much [20:53:06] (03CR) 10MarkTraceur: [C: 032] "Something about spacing, but it seems to work so I'm going to stop my whining." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew) [20:53:32] bawolff: Every committer has favourites [20:53:36] Don't feel guilty about it [20:53:38] (03Merged) 10jenkins-bot: Corrected page link and problems if the link is to a remote server [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew) [21:06:50] Oh man this is fantastic [21:06:51] https://www.mediawiki.org/wiki/Category:Files_with_unknown_copyright_status# [21:06:58] Browsing big ol' pages [21:07:12] lol [21:07:25] Hm, I should really make it possible to pick up further category members also [21:20:35] (03PS5) 10Yamelnychuk: "Use this file" does not contain license information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 [21:26:30] (03CR) 10jenkins-bot: [V: 04-1] "Use this file" does not contain license information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 (owner: 10Yamelnychuk) [21:50:44] (03Abandoned) 10Yamelnychuk: "Use this file" does not contain license information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99003 (owner: 10Yamelnychuk) [21:54:38] (03PS1) 10Yamelnychuk: "Use this file" does not contain license information [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/99533 [22:31:31] (03PS3) 10Aarcos: Fix listener leak problem. Second try, merged latest changes. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 [22:38:07] (03PS4) 10Aarcos: Fix resize listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 [22:41:26] (03CR) 10jenkins-bot: [V: 04-1] Fix resize listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 (owner: 10Aarcos) [22:44:45] (03CR) 10jenkins-bot: [V: 04-1] Fix resize listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 (owner: 10Aarcos) [22:53:46] (03PS5) 10Aarcos: Fix resize listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 [22:55:19] chrismcmahon: We still on? [22:55:29] marktraceur: yep [22:55:31] Cool [22:56:31] (03CR) 10jenkins-bot: [V: 04-1] Fix resize listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 (owner: 10Aarcos) [23:02:56] chrismcmahon: We're dealing with A/V but meh [23:03:42] marktraceur: I'm just hangin' out... [23:05:14] (03CR) 10Gergő Tisza: [C: 031] "Not directly related to this patch, but resizing should not automatically trigger an API query anymore, as the image size does not necessa" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur) [23:51:15] aarcos: I think I may WFH tomorrow and join the standup via Hangout, as irritating as the concept is - I have plans that will be easier to execute if I'm at home when I'm done with work [23:51:48] I say because you're the one organizing the daily "no matter what we're meeting" thing [23:51:59] zOMG, marktraceur is going to use hangout! [23:52:29] bawolff: Kill me now [23:53:13] marktraceur: We don't have to do it, only if you think is useful? It has proven to be useful in my previous lives but I am not a fundamentalist, ;-). [23:55:30] aarcos: The meeting isn't the irritating thing, the use of Hangouts is [23:59:33] (03PS6) 10Aarcos: Fix resize listener leak problem. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819