[00:00:11] <chrismcmahon>	 marktraceur: aarcos I'm looking to add a MMV clause to the end of the existing UploadWizard browser test, like probably tomorrow. 
[00:00:28] <marktraceur>	 Yeah
[00:01:04] <marktraceur>	 aarcos: The hard bits are done, though, stuff like writing zuul config patches, remembering to deploy Jenkins jobs before trying to run them, having creds to deploy CI changes...
[00:01:57] <aarcos>	 Kool !, I think we should sync up at some time tomorrow regarding the UploadWizard tests, see how I will be able to help.
[00:02:07] <marktraceur>	 Now we can just merge MMV patches to the test system and it will all be like butter.
[00:02:21] <marktraceur>	 aarcos: Sounds like fun
[00:02:25] <chrismcmahon>	 marktraceur: I'm still looking for reasonable suggestions for monitoring UW availability in production though.   I don't think Selenium is a good choice for that. 
[00:02:30] <marktraceur>	 chrismcmahon: Do you think it belongs in the UW tests?
[00:02:36] <marktraceur>	 Oh, interesting.
[00:03:09] <marktraceur>	 chrismcmahon: We do need to make sure (at least) that the interface loads sanely on major browsers. Maybe testswarm or so?
[00:03:31] <chrismcmahon>	 marktraceur: the UW test conveniently provides a fresh new image at the end of every run, I think it makes sense to have MMV grab that image and put it in a lightbox or summat.  haven't looked closely. 
[00:04:36] <marktraceur>	 Maybe
[00:04:57] <chrismcmahon>	 marktraceur: the situation that prompted the production monitoring concern was misconfigured Apaches.  what I want to avoid is "yo, test failed" "yep" "how come?" "timed out" "why'd it time out?" "dunno"
[00:05:49] <marktraceur>	 chrismcmahon: It would be easyish to create a test page with a few different sorts of ways to include the image (like [[$testimage|thumb]], [[$testimage|link=]], <gallery>$testimage|captiony caption</gallery>) and make sure MMV loads on them
[00:05:59] <marktraceur>	 Heh, yeah
[00:09:46] <chrismcmahon>	 marktraceur: Selenium is a tool for cross-browser UI testing, navigating through the frothy upper layer of a software stack.  it's not so good for monitoring availability of the full production software stack.  (Which is something we could use a whole lot more of, not just for UW)
[00:10:15] <marktraceur>	 chrismcmahon: Maybe I'm misunderstanding you, but I'm pretty sure UW is basically all frothy upper layer
[00:10:29] <marktraceur>	 The only stuff that's not frontend UI stuff is campaigns API stuff
[00:10:44] <marktraceur>	 And you're talking to the wrong guy for testing that, YuviPanda has been maintaining it recently
[00:11:12] <marktraceur>	 There's also the stash upload API, but that's a core-test sort of thing methinks
[00:12:18] <chrismcmahon>	 marktraceur: I could also be misunderstanding.  Could the stash upload API be monitored independently of a particular browser?  I think that is a point of failure. 
[00:12:47] <marktraceur>	 Oh, totally. It's just an API call.
[00:13:02] <chrismcmahon>	 marktraceur: and I think that might have been what failed the last time UW tanked, not entirely sure. 
[00:13:05] <marktraceur>	 How it acts with different browsers might be interesting, but that's testing UW's frontend upload code
[00:13:10] <marktraceur>	 Transport code in particular
[00:13:35] <marktraceur>	 Anyway, that could be a *unit* test. In core. Pretty sure.
[00:14:22] <marktraceur>	 I guess it's sort of tested now?
[00:14:44] <marktraceur>	 Did the upload stash tests not fail when you were seeing issues?
[00:15:54] <chrismcmahon>	 marktraceur: I'm guessing the upload stash tests don't run against the production servers?  someone once said something like "sufficiently advanced testing is indistinguishable from monitoring".  I think it is time to start monitoring some of the API endpoints in production.  
[00:16:14] <marktraceur>	 'kay, that could work.
[00:16:59] <chrismcmahon>	 marktraceur: not with Firefox, running on a Jenkins hosted by Cloudbees, driving a browser hosted on Sauce Labs.  that way lies madness I think. 
[00:17:09] <marktraceur>	 Absolutely
[00:17:18] <marktraceur>	 But that will be necessary to make sure e.g. UW loads properly
[00:17:51] <marktraceur>	 chrismcmahon: At this point -dev may be the place to talk about this - checking API endpoints is a topic for us, but also for yurik and YuviPanda, among others
[00:18:45] <marktraceur>	 I wonder if there's a way we could AUTOMATICALLY test *all* the endpoints
[00:19:01] <marktraceur>	 Oh man, I broke my own suggestion out of excitement but we should switch
[00:19:29] <chrismcmahon>	 marktraceur:  it's a topic for a lot of people right now, Antoine and Greg and management also.  I think it is steam-engine time.  
[02:07:47] <grrrit-wm>	 (03PS1) 10Aarcos: Add test to verify that in case of a resize event no image replacement takes place when api data is empty/undefined. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98746 
[03:59:01] <grrrit-wm>	 (03CR) 10Aarcos: "Can you add a regression test so next time you move code around we can catch issues like this? I have some ideas if you don't know where t" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 (owner: 10MarkTraceur)
[17:07:41] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "-1 because of indentation issues and naming problems, and at least one jslint failure." (034 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew)
[17:08:13] <grrrit-wm>	 (03PS11) 10MarkTraceur: Corrected page link and problems if the link is to a remote server [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew)
[17:10:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Corrected page link and problems if the link is to a remote server [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 (owner: 10Vldandrew)
[17:11:38] <marktraceur>	 Muahaha, I have ROBOTS to do my nitpicking now
[17:12:02] <grrrit-wm>	 (03PS2) 10MarkTraceur: Fix fileLink initialisation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 
[17:50:35] <grrrit-wm>	 (03PS3) 10MarkTraceur: Fix fileLink initialisation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 
[17:51:00] * marktraceur  thinks the tests will fail.

[17:51:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix fileLink initialisation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 (owner: 10MarkTraceur)
[17:51:15] <marktraceur>	 Go figure
[17:51:47] <marktraceur>	 I'm pretty sure the mw.MultimediaViewer constructor doesn't get called, and I'm not really sure why
[17:58:13] <chrismcmahon>	 marktraceur automates all the things
[17:59:52] <grrrit-wm>	 (03PS4) 10MarkTraceur: Fix fileLink initialisation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 
[17:59:53] <marktraceur>	 That one's better!
[18:00:00] <wmfmedia-standup>	 Stand-up!
[18:00:00] <wmfmedia-standup>	 Order: tgr -> marktraceur -> bd808 -> fabriceflorin
[18:00:10] <marktraceur>	 chrismcmahon: Actually aarcos gets credit for pushing our test business into the 21st century
[18:00:49] <marktraceur>	 wmfmedia-standup: Ssshhhhhh
[18:00:49] <grrrit-wm>	 (03PS12) 10Vldandrew: Corrected page link and problems if the link is to a remote server [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 
[18:02:56] <chrismcmahon>	 go aarcos go!  yesterday marktraceur and I were talking about doing some testing and monitoring of APIs required by MMV/UploadWizard
[18:03:23] <marktraceur>	 Yeah, he's going to maybe help with the UW testing also
[18:03:40] <marktraceur>	 chrismcmahon: Notably *I* was talking about testing and monitoring _all_ the APIs. :)
[18:04:12] <marktraceur>	 And honestly I'm thinking of doing this as a side project anyway because it sounds fun as all hell
[18:05:23] <aarcos>	 Testing rocks, debugging sucks !, I love testing because it saves so much time, you end up with better products and that's what good engineers do, ;-). I will be happy to help !
[18:05:32] <marktraceur>	 aarcos: In other news, 98593 should be better now
[18:05:40] <chrismcmahon>	 marktraceur: If you're up for schooling me on API use along the way, I'd like to know a lot more than I do right now. 
[18:05:48] <marktraceur>	 Coolio, sure
[18:05:59] <grrrit-wm>	 (03PS13) 10Vldandrew: Corrected page link and problems if the link is to a remote server [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98180 
[18:06:13] <aarcos>	 marktraceur: looking...
[18:06:27] <marktraceur>	 chrismcmahon: I may need to put you in line for reading the RESTful Web Apps book that ori-l gave me and that I'll likely wind up passing on many times
[18:06:49] <marktraceur>	 I'm also getting the newer book by leonardr on the same topic
[18:08:02] <chrismcmahon>	 marktraceur:  It's not completely unfamiliar :-)  https://www.socialtext.net/open/very_simple_rest_in_ruby_part_3_post_to_create_a_new_workspace
[18:08:31] <marktraceur>	 *nod* Ruby folk tend to like the buzzword
[18:08:47] <marktraceur>	 I'm not sure how well they do with it, but leonardr's explanations are the bestest IMO
[18:10:04] <chrismcmahon>	 marktraceur: the architecture of the Socialtext wiki was very cool, literally every action was accomplished by a REST call, and the UI was just a thin layer on scads of REST endpoints.  I had a nice little suite of REST tests for it at one point. 
[18:11:25] <tgr>	 did anyone use the browsertests vagrant role recently?
[18:12:13] <marktraceur>	 chrismcmahon: cf. https://bugzilla.wikimedia.org/show_bug.cgi?id=41837
[18:12:31] <marktraceur>	 And also plus https://bugzilla.wikimedia.org/show_bug.cgi?id=14123
[18:15:25] <chrismcmahon>	 marktraceur: I'll re-read the RESTful one, I added myself there
[18:16:34] <marktraceur>	 *nod*
[18:16:48] <marktraceur>	 It's been a while since I read through, but looks like no movement anyway
[19:49:45] <grrrit-wm>	 (03CR) 10Aarcos: Fix fileLink initialisation (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 (owner: 10MarkTraceur)
[19:51:39] <grrrit-wm>	 (03CR) 10MarkTraceur: "Some thoughts but it looks generally good." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98746 (owner: 10Aarcos)
[19:51:56] <marktraceur>	 Duelin' comments
[19:53:28] <grrrit-wm>	 (03CR) 10MarkTraceur: "Will fix the issue with the callbacks." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 (owner: 10MarkTraceur)
[21:33:35] <grrrit-wm>	 (03PS2) 10MarkTraceur: Trim HTML-based metadata values [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/97743 (owner: 10Gergő Tisza)
[21:37:00] <marktraceur>	 tgr: For some reason our phpunit tests for CMD never got enabled. {{fixed}}
[21:43:35] <tgr>	 marktraceur: cool, thx
[21:44:17] <tgr>	 is the zuul-config commit all it takes?
[22:02:18] <grrrit-wm>	 (03PS5) 10MarkTraceur: Fix fileLink initialisation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 
[22:02:43] <marktraceur>	 tgr: In that instance yes
[22:02:59] <marktraceur>	 tgr: Because the jobs were already built by JJB, we had just never enabled them for some reason
[22:21:45] <grrrit-wm>	 (03CR) 10Aarcos: Fix fileLink initialisation (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 (owner: 10MarkTraceur)
[22:23:53] <grrrit-wm>	 (03CR) 10MarkTraceur: Fix fileLink initialisation (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 (owner: 10MarkTraceur)
[22:25:30] <marktraceur>	 aarcos: Until we have jsduck running on MMV, there's nothing reading those comments :)
[22:25:40] <marktraceur>	 But I'm happy to add them, I like them anyway
[22:39:27] <grrrit-wm>	 (03PS6) 10MarkTraceur: Fix fileLink initialisation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 
[22:59:20] <grrrit-wm>	 (03CR) 10Aarcos: [C: 031] Fix fileLink initialisation (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98593 (owner: 10MarkTraceur)
[23:03:20] <marktraceur>	 aarcos: Can you not merge it? :/
[23:03:29] <marktraceur>	 Too much to hope for I guess
[23:04:48] <aarcos>	 marktraceur: Not sure what you mean? 
[23:05:22] <aarcos>	 marktraceur: You can always stop by if you are around, ;-)
[23:09:27] <bd808>	 aarcos: He's fishing for a +2 instead of just a +1
[23:09:56] <aarcos>	 ah !
[23:13:05] <grrrit-wm>	 (03CR) 10Aarcos: "I saw this problem in the debugger while testing some code. I figure if this is happening to me it may happen in production so better be s" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98746 (owner: 10Aarcos)
[23:20:55] <grrrit-wm>	 (03PS2) 10MarkTraceur: Add test to verify that in case of a resize event no image replacement takes place when api data is empty/undefined. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98746 (owner: 10Aarcos)
[23:21:01] <grrrit-wm>	 (03CR) 10MarkTraceur: "Shorter commit summary, very important" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98746 (owner: 10Aarcos)
[23:23:15] <marktraceur>	 aarcos: If you can't merge it I either need to wait (admittedly probably not very long) for tgr to, or selfmerge, or find someone else...meh
[23:28:50] <aarcos>	 marktraceur: How do I do that? ;-)
[23:29:42] <tgr>	 marktraceur: i'll pass, i'm too sleepy now to comprehend patches longer than five lines
[23:29:50] <marktraceur>	 aarcos: If you don't see a +2 option in the review dialog, then probably you don't have merge rights on MMV yet
[23:29:56] <marktraceur>	 I can submit the request though
[23:29:58] <tgr>	 also, haven't managed to set up browser tests yet
[23:31:00] <marktraceur>	 tgr: It's not terribly hard, plus Jenkins runs them for you
[23:31:29] <aarcos>	 Nope, I don't see a +2, so I am still a mortal, ;-).
[23:31:42] <marktraceur>	 Anyway, I have dentist things in an hour, so I will be winding down earlier than usual
[23:38:12] <marktraceur>	 aarcos: Do you have an account on mediawiki.org?
[23:44:40] <marktraceur>	 Actually, maybe I can do this unilaterally.
[23:45:56] <marktraceur>	 Nooope.
[23:47:18] <marktraceur>	 aarcos: So yeah, a username for you on mediawiki.org would be good
[23:50:30] <aarcos>	 marktraceur: username in mediawiki.org is 'aaron_arcos'
[23:53:16] <marktraceur>	 aarcos: You should maybe create your user page
[23:53:59] <marktraceur>	 Weird.
[23:55:37] <marktraceur>	 https://www.mediawiki.org/wiki/Gerrit/Project_ownership#aarcos_.2B2_for_MultimediaViewer submitted request
[23:55:43] <marktraceur>	 And now I should maybe go to the dentist
[23:56:33] <aarcos>	 wow !, kool !, tx !, feel with new great powers now, ;-). Good luck with the dentist !, later...
[23:57:32] <aarcos>	 well, not yet, but thanx for proposing me !...
[23:58:32] <bawolff>	 aarcos: I gave you a support :)
[23:59:00] <aarcos>	 tx !