[00:57:12] (03PS4) 10MarkTraceur: Add a tests to MultimediaViewer. Based on https://gerrit.wikimedia.org/r/#/c/96152/1 These are just smoke tests. I will add more in coming versions of this change. Consolidated various cases in one tests. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98009 (owner: 10Aarcos) [00:57:22] (03CR) 10MarkTraceur: "Stripped down and reformatted the commit message" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98009 (owner: 10Aarcos) [00:58:12] (03PS5) 10MarkTraceur: Add tests to MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98009 (owner: 10Aarcos) [00:58:43] (03CR) 10MarkTraceur: "Sorry, took out important information because I thought it was "based on" my commit as in git terminology." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98009 (owner: 10Aarcos) [00:58:59] Let's all spam aarcos [00:59:26] No worries, ;-). [01:00:43] Whoo, you're even jsducking it up [01:00:45] * marktraceur is a fan [01:00:49] I should probably be better about that [01:08:26] With the extra doc types the compiler helps you find lots of defects, ;-). [01:09:35] Yup! [01:10:00] I should probably fix the way we do dependency injection to make that easier [01:12:31] dependency injection helps with testability. [01:12:45] I can do that sometime over the long weekend [01:13:09] For now I think I'll go spend time with my brother, but I'll be on and off tonight [01:14:44] No rush, enjoy the holiday, I will continue writing a few more tests so we have the foundations to write tests on each change, ;-). Nice evening ! [02:10:51] (03PS6) 10Aarcos: Add a tests to MultimediaViewer. Based on https://gerrit.wikimedia.org/r/#/c/96152/1 These are just smoke tests. I will add more in coming versions of this change. Consolidated various cases in one tests. Added more test.s [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98009 [02:11:18] (03PS7) 10Aarcos: Add a tests to MultimediaViewer. Based on https://gerrit.wikimedia.org/r/#/c/96152/1 These are just smoke tests. I will add more in coming versions of this change. Consolidated various cases in one tests. Added more test.s [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98009 [02:11:37] (03PS8) 10Aarcos: Add a tests to MultimediaViewer. Based on https://gerrit.wikimedia.org/r/#/c/96152/1 These are just smoke tests. I will add more in coming versions of this change. Consolidated various cases in one tests. Added more tests. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98009 [05:44:41] (03PS1) 10Theopolisme: Prevent multiple "Use this file" windows [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98066 [06:33:30] (03PS2) 10Theopolisme: Prevent multiple "Use this file" windows [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98066 [06:33:56] (03CR) 10Theopolisme: Prevent multiple "Use this file" windows (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98066 (owner: 10Theopolisme) [08:33:51] (03CR) 10MarkTraceur: Prevent multiple "Use this file" windows (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98066 (owner: 10Theopolisme) [17:02:04] (03CR) 10Theopolisme: Prevent multiple "Use this file" windows (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98066 (owner: 10Theopolisme) [17:27:44] (03PS1) 10Yamelnychuk: Auto-ellipsis for filename field Bug:56113 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98108 [17:45:19] (03CR) 10Qgil: [C: 04-1] "I haven't looked at the code, but at least there is a problem with the commit description, not referencing correctly the related bug repor" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98108 (owner: 10Yamelnychuk) [18:00:00] Stand-up! [18:00:00] Order: tgr -> bd808 -> marktraceur -> fabriceflorin [18:06:21] wmfmedia-standup: Go eat turkey [18:25:22] (03PS1) 10Vldandrew: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98118 [19:05:48] (03PS3) 10Vldandrew: Fixes the UI refactor [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98020 [20:57:14] (03PS1) 10Bartosz Dziewoński: Replace weird .select reimplementation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98127 [20:57:15] (03PS1) 10Bartosz Dziewoński: File usage dialog: Only reselect on focus, not on every click [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98128 [21:04:56] (03CR) 10Poke: [C: 031] "+1. Wow, that was really some weird stuff. I’m quite sure that `select` has better browser support than `setSelectionRange` too." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98127 (owner: 10Bartosz Dziewoński) [21:07:43] (03PS1) 10Bartosz Dziewoński: Kill !Boolean( variable ) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98129 [21:10:58] (03CR) 10MarkTraceur: [C: 032] "We strive for excellence around here" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98129 (owner: 10Bartosz Dziewoński) [21:11:03] (03Merged) 10jenkins-bot: Kill !Boolean( variable ) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98129 (owner: 10Bartosz Dziewoński) [21:18:02] (03PS2) 10Bartosz Dziewoński: File usage dialog: Only reselect on focus, not on every click [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98128 [21:22:13] (03PS1) 10Bartosz Dziewoński: File usage dialog: Only allow one copy to be open at a time [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98130 [21:24:22] (03Abandoned) 10Bartosz Dziewoński: File usage dialog: Only allow one copy to be open at a time [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98130 (owner: 10Bartosz Dziewoński) [21:27:00] (03PS4) 10MarkTraceur: Fixes the UI refactor [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98020 (owner: 10Vldandrew) [21:29:41] (03PS2) 10Bartosz Dziewoński: Replace weird .select reimplementation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98127 [21:30:23] (03CR) 10MarkTraceur: [C: 032] "This is still broken (the lightbox gets closed when the dialog opens) but it's an improvement over the status quo." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98020 (owner: 10Vldandrew) [21:30:27] (03Merged) 10jenkins-bot: Fixes the UI refactor [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98020 (owner: 10Vldandrew) [21:30:39] This is the MOST PRODUCTIVE THANKSGIVING [21:31:06] (03PS3) 10MarkTraceur: Replace weird .select() reimplementation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98127 (owner: 10Bartosz Dziewoński) [21:34:25] (03CR) 10MarkTraceur: [C: 032] "Thanks as always, MatmaRex!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98127 (owner: 10Bartosz Dziewoński) [21:34:29] (03Merged) 10jenkins-bot: Replace weird .select() reimplementation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98127 (owner: 10Bartosz Dziewoński) [21:34:55] (03PS3) 10MarkTraceur: File usage dialog: Only reselect on focus, not on every click [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98128 (owner: 10Bartosz Dziewoński) [21:36:18] (03CR) 10MarkTraceur: [C: 04-1] "Works super with the labels, but clicking in the inputs themselves causes them to get deselected, and I have to manually select the entire" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98128 (owner: 10Bartosz Dziewoński) [21:39:29] (03CR) 10MarkTraceur: Prevent multiple "Use this file" windows (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/98066 (owner: 10Theopolisme)