[00:07:28] 'kay, now the hash navigation is working and you can link to an image in the viewer...but back button still doesn't work because I need to listen to popState events [00:07:31] Soon! [00:43:38] Hrm [00:43:43] popstate events seem...buggy. [00:44:03] I'm gonna push this anyway, it's probably just a matter of the browser being unhappy with me [00:44:20] (03PS1) 10MarkTraceur: Push history state to support links to media viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97657 [00:44:32] It also pushes a bunch of UI code into ext.multimediaViewer.lightboxinterface.js [00:45:06] * marktraceur gets a snack before trying to do next/previous [01:05:20] (03CR) 10MarkTraceur: [C: 032] Fix images and related CSS for RTL wikis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/94269 (owner: 10Amire80) [01:05:23] (03Merged) 10jenkins-bot: Fix images and related CSS for RTL wikis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/94269 (owner: 10Amire80) [01:07:54] I wonder if that will have any consequences [01:08:05] (03PS2) 10MarkTraceur: Push history state to support links to media viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97657 [01:08:08] Oh, sweet. [01:20:01] "Navigation" is a bad word to start being dyslexic on [01:20:31] * marktraceur typed "Va" and was like NOPE THIS IS WRONG [01:36:08] Hm, I don't think navigating between images will actually be all that hard. [03:50:41] (03PS1) 10MarkTraceur: Previous and next functionality! [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97673 [03:50:55] Fuuuunnnn [03:52:53] Both of those are on alpha now [03:52:56] Try e.g. http://multimedia-alpha.wmflabs.org/wiki/Lightbox_demo#mediaviewer/File:Pentacle 3.svg/3 [14:36:09] (03CR) 10Gergő Tisza: [C: 04-1] "This results in a loop: when the hash is just #, and the user clicks back, it will call closeInterface, which will re-push #." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97657 (owner: 10MarkTraceur) [15:20:07] (03CR) 10Gergő Tisza: [C: 04-1] "Works very nicely!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97673 (owner: 10MarkTraceur) [15:33:04] Woo hoo, more eyeballs. [15:47:39] (03PS1) 10Gergő Tisza: Trim HTML-based metadata values [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/97743 [17:26:06] * marktraceur will be back in 20, taking the dog out, should be in time for the standup [18:04:25] marktraceur: Do you wish to join us on Google Hangouts? [18:04:32] Sure! [18:04:41] "wish" is a strong term but I'm game [18:14:58] Hi Mark, thanks for joining today's hangout. I know it's not your favorite communication channel, and your presence today means that much more to me. I appreciate it very much :) [18:15:28] *nod* [18:22:40] pginer: FWIW I see some interesting-looking free prototyping systems, I'd be interested to hear your thoughts on them [18:39:35] (03CR) 10MarkTraceur: "There's not really any way to take things *out* of the history, sadly. I'll at least make sure it doesn't add more than one entry per even" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97657 (owner: 10MarkTraceur) [19:07:18] (03CR) 10MarkTraceur: "> two API queries (imageinfo + gender [1]) are made on every prev/next, even when we have that information already. For a huge page with l" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97673 (owner: 10MarkTraceur) [20:21:19] tgr: Will you be attending one of our Roundtables on Google Hangouts? If so, do you prefer tomorrow's (Nov. 27) or next week's? (Dec. 4) [20:21:57] it's pretty much the same for me, do you have any preference? [20:23:01] Let's try next week, since we're short on video feeds tomorrow and Mark will be in the same session next week. Should we use your wikimedia email or your personal Gmail for the Hangouts invitation? [20:24:51] the wikimedia one, with the other one i usually end up in google account switching hell [20:27:04] tgr: I guess you'll already be there with all the volunteers joining :/ [20:34:49] hey fabriceflorin, how are you? did you have a good break? [20:36:43] fabriceflorin, do you know if we are we still on target for deployment of gwtoolset to commons in december? [20:41:43] (03CR) 10Gergő Tisza: [C: 031] "Sorry, I misunderstood what's happening, completely different issue: bug 57620" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97673 (owner: 10MarkTraceur) [20:42:19] (03CR) 10Gergő Tisza: "The broken image thing, I mean." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97673 (owner: 10MarkTraceur) [20:43:01] Ah, cool. [20:50:59] tgr: Is that +2able then? [20:51:16] yes, should i go ahead? [20:51:35] I don't see a reason why not...oh, wait, it depends on the other patch [20:51:39] So I'll have to rebase anyway [21:10:05] (03PS3) 10MarkTraceur: Push history state to support links to media viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97657 [21:10:10] Supports more than one back event now, yay [21:10:18] (03PS2) 10MarkTraceur: Previous and next functionality! [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97673 [21:10:25] 'kay, tgr, you should be good to go now [21:13:40] I hate how I did the comingFromPopstate bits, but I think any other method would have been equally nasty [21:15:10] hi dan-nl : Sorry for not responding sooner, I was out for lunch. Are you still awake? [21:16:13] tgr: Good we will schedule you for Dec. 4, then -- and use your wikimedia account. To be continued ... [21:31:03] hi fabriceflorin i'm still here just relaxing a bit with the evening ... [21:32:48] marktraceur: can't you just use the state for that? [21:33:41] set {mmv:1} on pushstate, then if history.state.mmv is defined on close, you are using the X button, otherwise it is a pop [21:34:26] but anyway, the current method works fine [21:34:46] (03CR) 10Gergő Tisza: [C: 032] Push history state to support links to media viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97657 (owner: 10MarkTraceur) [21:35:06] tgr: Ahhh...I guess so [21:35:22] (03Merged) 10jenkins-bot: Push history state to support links to media viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97657 (owner: 10MarkTraceur) [21:35:56] i still don't like the way you have navigate through all the images when you want to leave the page [21:36:32] i think it is possible to get around that with history.go, i'll set up a fiddle and try to figure out how [21:36:41] Hm [21:37:59] dan-nl: We discussed the GW Toolset in our last team meeting. Though you have made some great progress in recent weeks, we are not sure that the code can realistically be released in December. I am afraid that it may have to be in January, to allow time for completing the security review and fixing a few more issues. [21:38:50] dan-nl: Would that be feasible from your end? What is your current funding situation? [21:39:09] dan-nl: If you like, we could discuss this in a private channel. [21:39:20] fabriceflorin: okay [21:40:43] funding ends in december … it would be good for you to discuss this further with david [21:40:52] i'll mention it to him tomorrow [21:47:53] tgr: The next/prev patch was a clean rebase FYI [21:59:22] ah, sorry, i got distracted [22:00:03] 's arright [22:46:06] (03CR) 10Gergő Tisza: [C: 032] Previous and next functionality! [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97673 (owner: 10MarkTraceur) [22:46:19] (03Merged) 10jenkins-bot: Previous and next functionality! [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97673 (owner: 10MarkTraceur) [22:46:42] Woooooo [22:46:53] * marktraceur looks at betalabs [23:12:20] hi mark, I'm the person akshata is trying to schedule a hangout for [23:12:30] Oh hey! [23:12:49] I think she hasn't quite understood that next week I'm at a corporate offsite/hackathon and my availability is subject to surprises [23:12:58] Ah dear. [23:13:00] I *could* do the scheduled time in theory [23:13:15] but I'm likely to be a no-show if morning activities run late, and they usually do [23:13:36] is there any chance you could do the hangout any time between now and sunday? [23:13:45] There is non-zero chance of that! [23:14:10] Like, tomorrow basically any time that isn't 14:30-15:00 PST would work [23:14:19] 22:30-23:00 UTC [23:15:17] how about 15:00 or 15:30 PST? [23:15:54] 15:30 is probably safer [23:16:20] alright, I'll be on here anyway, I have two other hangouts before yours, with fabrice and tim [23:16:22] I just heard someone I know will be on the tele at 14:40, else I'd have no constraints :) [23:16:37] I'll reply to akshata and tell here that we agreed on 15:30 [23:16:40] *her [23:16:51] Oh, and a 1:1 with robla I guess. I'm terrible about those. [23:17:04] In my defence it's one day earlier this week [23:18:33] thanks for the flexibility, spending next week in close contact with all my coworkers and bosses doesn't make stealth interviewing very practical :) [23:23:25] Heh [23:24:16] I wouldn't call talking about an interview in a public, logged channel "stealth", but whatever :P [23:58:25] kouiskas: Did you say Thursday? [23:58:38] yeah there's a bit confusion on the calendar right now [23:58:45] timezone misunderstanding [23:58:49] Heh [23:58:54] we're on the same page, I've just emailed akshata about it [23:59:53] it's my bad, I looked at the calendar when I emailed her earlier and said 28th was tomorrow, but it's not (it is where I am, which is why I got it wrong)