[00:14:55] <dan-nl>	 hey bd808, just finished addressing all of aaron's comments. let me know if you buys need anything else from me
[00:15:27] <bd808>	 dan-nl: Will do.
[00:17:40] <marktraceur>	 tgr, if you have time, the UI redesign is done ish
[00:33:00] <grrrit-wm>	 (03PS2) 10MarkTraceur: Bump version number [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96411 
[01:14:17] <grrrit-wm>	 (03PS1) 10Aarcos: Load image only if data was returned, otherwise do nothing. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96682 
[01:16:11] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "Good start!" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96682 (owner: 10Aarcos)
[01:16:20] <marktraceur>	 Small patches are easy to review
[01:17:57] <marktraceur>	 fabriceflorin: Why am I on the "ee" list? I was never part of that team...
[01:18:27] <fabriceflorin>	 marktraceur: I just Bccd you, so you know what I spent my afternoon on :)
[01:18:42] <marktraceur>	 Aahhhh.
[01:18:52] <marktraceur>	 BCC explains why I got the email without any indication of how
[01:19:04] <fabriceflorin>	 I have one quick meeting upstairs, then I can start looking at your new code on alpha.
[01:19:09] <marktraceur>	 Cool beans
[01:19:11] <marktraceur>	 Good luck
[01:20:04] <fabriceflorin>	 Yeah, I use Bcc to let people know about important developments, even if they are not on the primary list. Saves me time not having to send multiple emails. Though I can if you think it would be better ... 
[01:20:08] <grrrit-wm>	 (03PS2) 10Aarcos: Load image only if data was returned, otherwise do nothing. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96682 
[01:20:35] <marktraceur>	 *shrug* not multiple emails, just...maybe CC the multimedia team instead of BCC
[01:20:46] <marktraceur>	 Having a team list might help
[01:20:53] <marktraceur>	 *Might*
[01:21:29] <marktraceur>	 Anyway, I think I'm gonna try to get home and get something done
[01:22:01] <marktraceur>	 But I shall be tuned into feedback
[01:22:48] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "Pristine code convention adherence :P" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96682 (owner: 10Aarcos)
[01:25:57] <grrrit-wm>	 (03CR) 10MarkTraceur: "I'm not able to see any issue in HEAD^, can you include reproduction instructions in the commit message maybe?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96682 (owner: 10Aarcos)
[01:34:17] <grrrit-wm>	 (03PS3) 10Aarcos: Load image only if data was returned, otherwise do nothing. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96682 
[01:44:53] <grrrit-wm>	 (03PS4) 10Aarcos: Load image only if data was returned, otherwise do nothing. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96682 
[01:46:55] <grrrit-wm>	 (03CR) 10Aarcos: "Updated commit message with repro steps." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96682 (owner: 10Aarcos)
[04:15:26] <grrrit-wm>	 (03PS1) 10Aarcos: Merge "Preserve space for the description even if it is not present" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96689 
[04:18:33] <grrrit-wm>	 (03PS2) 10Aarcos: Merge "Preserve space for the description even if it is not present" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96689 
[04:24:34] <marktraceur>	 aarcos: Merge commits aren't really part of our workflow
[16:38:58] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Lookes very nice!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur)
[16:42:50] * marktraceur  will ask for clarification on that when he gets in, tgr

[17:37:21] <marktraceur>	 Arright
[17:37:44] <marktraceur>	 tgr: How do you mean, the information scrolldown doesn't work?
[17:38:04] <tgr>	 i just can't scroll down
[17:38:08] <marktraceur>	 Hrm
[17:38:09] <tgr>	 or hover or anything
[17:38:32] <marktraceur>	 tgr: Was that on a previous version? I think I pushed a version that had a weird problem with scrolling.
[17:39:06] <tgr>	 i checked it out a few hours ago
[17:39:21] <tgr>	 i think it happens when you quit from fullscreen mode
[17:39:40] <tgr>	 in general, fullscreen does some strange things
[17:39:49] <marktraceur>	 Hrm.
[17:39:51] <marktraceur>	 I'll look
[17:39:59] <tgr>	 a few times it loaded the image with a huge size
[17:40:06] <tgr>	 or even the previous image
[17:40:19] <tgr>	 but it will be rewritten anyway, right?
[17:40:34] <tgr>	 seems kind of pointless in its current form
[17:40:42] <marktraceur>	 The fullscreen? I guess so.
[17:40:49] <tgr>	 now that the default size is almost full
[17:41:32] <marktraceur>	 Yeah, the fullscreen is weird
[17:41:36] <tgr>	 i would hide the metadata, fit the image by its smaller size and make it scrollable
[17:41:46] <marktraceur>	 tgr: Consider someone who browses at half screen-width and wants to fullscreen, I guess
[17:42:14] <marktraceur>	 I don't think it's supposed to have hardly any metadata in fullscreen, yeah
[17:42:19] <marktraceur>	 But...hm
[17:42:24] <tgr>	 he can just use the fullscreen button of his browser then, almost the same behavior
[17:42:46] <marktraceur>	 I'm not sure if I want to release it this way, or hide the fullscreen, or try to fix it in an hour
[17:42:54] <tgr>	 anyway it does a few weird things
[17:43:00] <marktraceur>	 Yeah, I see it
[17:43:38] <tgr>	 sometimes when entering/exiting fullsize, it starts switching between two very close sizes, and does that a dozen times or so in quick succession
[17:45:21] <marktraceur>	 tgr: I guess that will stop once the image bucketing works
[17:45:26] <tgr>	 i think disabling fullscreen is the best, it has several issues which do not seem related, and the default look already gives very good usage of space, fullscrize just doesn't add that much benefit since the UI rewrite
[17:45:45] <marktraceur>	 tgr: Let me confirm with fabriceflorin before we merge
[17:46:13] <tgr>	 alternatively, maybe just enter browser fullscreen mode and not do anything special, let the resize handler deal with it?
[17:46:58] <marktraceur>	 Maybe
[17:47:03] <marktraceur>	 But that could be done later
[17:47:30] <grrrit-wm>	 (03PS13) 10MarkTraceur: Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 
[17:47:45] <marktraceur>	 tgr: If you want to review and +1, that's cool, I'll +1 when fabriceflorin gives me the go-ahead
[17:48:03] <marktraceur>	 Agh, I just saw the extra-big issue.
[17:48:29] <marktraceur>	 But I feel like I saw that in the old version too
[17:48:37] <marktraceur>	 That sounds like a problem for the image bucketing patch to fix
[17:50:06] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur)
[17:50:51] <marktraceur>	 Thanks
[18:00:00] <wmfmedia-standup>	 Stand-up!
[18:00:00] <wmfmedia-standup>	 Order: fabriceflorin -> bd808 -> marktraceur -> tgr
[18:03:43] * bd808  waves to those who are standing up

[18:05:42] <marktraceur>	 Oh right
[18:05:51] <marktraceur>	 We were standing up and talking about git! :D
[18:06:05] <marktraceur>	 Where's fabrice
[18:12:44] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 031] "Fabrice is cool" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur)
[18:12:48] <marktraceur>	 tgr: Bam
[18:13:15] <tgr>	 should I +2?
[18:13:26] <tgr>	 or are we waiting for brion or someone?
[18:13:47] <marktraceur>	 +2 sounds OK to me, we get to see it happening in prod
[18:14:31] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur)
[18:14:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur)
[18:27:50] <marktraceur>	 Right, anything we need to do in the last half hour before the deploy?
[19:29:32] <marktraceur>	 fabriceflorin: http://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo now has the version going to mw.o today
[20:05:19] <grrrit-wm>	 (03PS1) 10Aarcos: Fix listener leak problem. Second try, merged latest changes. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96819 
[21:20:29] <marktraceur>	 fabriceflorin: https://en.wikibooks.org/w/index.php?title=Special:Preferences#mw-prefsection-betafeatures technically deployed but the CSS isn't going for some reason, we're working on it
[21:31:37] <marktraceur>	 CSS fixed thanks to Reedy the file-touching robot
[21:49:08] <marktraceur>	 Briefly deployed to all wikis, but we had to revert
[21:49:26] <marktraceur>	 Because it's not what we *meant* to do. :P
[22:18:39] <marktraceur>	 aarcos: https://gerrit.wikimedia.org/r/96152
[23:03:50] <robla>	 hi fabriceflorin: I'm just going to go straight to R35 from here
[23:11:58] <marktraceur>	 fabriceflorin: https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures and https://en.wikipedia.org/wiki/Wikimedia_Foundation has both geodata and a nice thumbnail for a demo
[23:12:39] <marktraceur>	 robla: Now that we're out I can go at 15:30 or whenever you're ready
[23:14:51] <fabriceflorin>	 Wonderful! I will test enwiki and frwiki -- as well as let all our world partners know.
[23:32:01] <tgr>	 is there any description of where exactly the nearby button should be?
[23:32:07] <tgr>	 or what triggers it?
[23:32:18] <marktraceur>	 tgr: It's on pages with geoloc data
[23:32:29] <marktraceur>	 Try [[Wikimedia Foundation]] and look at the top right hand corner
[23:32:34] <tgr>	 that's pretty vague
[23:33:34] <marktraceur>	 Yeah.
[23:37:26] <marktraceur>	 tgr: https://bugzilla.wikimedia.org/show_bug.cgi?id=57383 maybe a CMD bug, but I don't want to assume
[23:37:28] <tgr>	 doesn't seem to be working on hu.wikipedia
[23:37:47] <tgr>	 and formula editing doesn't work for me anywhere, i get various JS errors
[23:37:54] <marktraceur>	 I could blacklist the HTML aarcos found but I'd rather have more generic support for metadata
[23:39:22] <marktraceur>	 fabriceflorin: Your "about beta features" link in the email is actually https://bugzilla.wikimedia.org/show_bug.cgi?id=57383
[23:39:25] <marktraceur>	 Er
[23:39:27] <marktraceur>	 About Media Viewer
[23:42:26] <tgr>	 marktraceur: filtering information template fields is hard
[23:42:33] <marktraceur>	 Yeah
[23:42:40] <tgr>	 i would do that in mediaviewer, because i am lazy
[23:42:43] <fabriceflorin>	 Darn, thanks for catching that.
[23:42:44] <marktraceur>	 If you'd prefer I can do it
[23:42:54] <tgr>	 and it is more fun to filter html in jquery than in php
[23:42:56] <marktraceur>	 tgr: Or we can both be lazy and wait for Wikidata. :3
[23:42:59] <marktraceur>	 "fun"
[23:43:00] <marktraceur>	 'kay
[23:43:24] <tgr>	 but yes, that properly should be a CMD bug
[23:44:02] <fabriceflorin>	 marktraceur: Do you think it's worth it for me to post a followup email with the correct Beta Features link on Wikitech, 
[23:44:06] <tgr>	 i think throwing away tables is a good first start, on commons they hav lots of additional data in tables
[23:44:21] <fabriceflorin>	 wikimedia-l, ee-l, mm-l, etc. ?
[23:44:26] <marktraceur>	 fabriceflorin: Probably not, people there are smart, they can find it. But if you want.
[23:44:32] <marktraceur>	 Wikimedia, maybe more pressing. Commons too.
[23:44:44] <fabriceflorin>	 Or maybe I can just let them figure it out, since the first link on the Media Viewer page points to the Beta Features page.
[23:45:20] <marktraceur>	 fabriceflorin: So it begins... https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Beta
[23:45:32] <tgr>	 marktraceur: on second thought i will just add phpquery to CMD
[23:45:43] * marktraceur  blinks

[23:45:49] <marktraceur>	 I mean, yes. But also...hrm
[23:46:03] <tgr>	 Daniel Kinzler did say that wikidata fields should never contain html
[23:46:16] <tgr>	 so probably this should be fixed on the api side
[23:46:26] <tgr>	 of we are serious about using it for import
[23:46:56] <marktraceur>	 Cool beans