[01:15:38] Everyone ready for BUGSPAAAAAAAAAM???? [01:15:43] Too bad you're getting it anyway [01:25:28] (03PS1) 10MarkTraceur: Bump version number [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96411 [07:51:44] yay bugspam! :D [08:29:09] (03CR) 10Gergő Tisza: [V: 032] Bump version number [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96411 (owner: 10MarkTraceur) [11:10:35] (03PS1) 10Gergő Tisza: Preserve space for the description even if it is not present [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96465 [15:12:27] (03PS1) 10Gergő Tisza: Add Attribution field to CommonsMetadata output [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96493 [17:46:30] aarcos: https://gerrit.wikimedia.org/r/96152 [17:49:04] (03PS1) 10Gergő Tisza: Make sure local URLs in image description are always absolute [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96528 [17:56:45] The hangout link has disappeared from the bug triage invite [17:57:51] (03PS2) 10Gergő Tisza: Make sure local URLs in image description are always absolute [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96528 [18:00:00] Stand-up! [18:00:00] Order: bd808 -> fabriceflorin -> marktraceur -> tgr [18:00:45] * bd808 stands up and tells wmfmedia-standup to sit down [18:01:16] bd808++ [18:04:16] marktraceur: When fab shows up tell him about the disappearing hangout link [18:04:37] And don't have him post the link here in the public channel :) [18:04:37] Uh [18:04:42] Kay [18:04:50] I don't see him as yet [18:04:52] [10:56] < bd808> The hangout link has disappeared from the bug triage invite [18:05:00] Email said "late bus" [18:05:05] Ah, right [18:06:20] * bd808 goes back to more gorram code reviews [18:07:32] bd808: Try again? [18:07:59] Yup. Thanks [18:08:12] tgr: Joining us? [18:26:10] got disconnected [19:10:43] fabr argh [19:12:40] marktraceur: will you have time for some code review today? [19:12:57] Yeeeesssmaybe [19:13:01] tgr: Whatcha need reviewed? [19:13:20] ideally, everything :) [19:13:35] Fun times [19:13:37] I'll get on that [19:13:57] but mostly 94931 and 96288 [19:14:11] not particularly urgent, mind you [19:14:59] i just want to reshuffle stuff in CMD and write more tests, and want to avoid rebase hell [19:16:29] 'kay [19:16:31] Will do [19:16:45] (03CR) 10MarkTraceur: [C: 032 V: 032] "I like it." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96465 (owner: 10Gergő Tisza) [19:16:57] ...V2 was a mistake, but Jenkins will merge [19:16:59] (03Merged) 10jenkins-bot: Preserve space for the description even if it is not present [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96465 (owner: 10Gergő Tisza) [19:24:46] thanks [19:46:43] (03CR) 10MarkTraceur: [C: 04-1] "Still not sure cc0 will be handled properly" (033 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94931 (owner: 10Gergő Tisza) [19:59:04] (03CR) 10MarkTraceur: [C: 04-1] "-1 for line 82" (033 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96288 (owner: 10Gergő Tisza) [20:21:04] (03CR) 10Gergő Tisza: "It won't. How should it be handled? Do we want to display the CC logo for such images? CC0 is basically just a fancy way of saying somethi" (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94931 (owner: 10Gergő Tisza) [20:21:14] (03PS4) 10Gergő Tisza: Add generic CC license parsing [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94931 [20:21:44] (03CR) 10Gergő Tisza: "Added missing docs." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94931 (owner: 10Gergő Tisza) [20:26:11] tgr: Can't exactly leave out CC0 in a patch that says "Generic CC license handling" :P [20:26:23] I don't see any reason not to show the CC logo for that [20:27:05] Hrm [20:27:18] Did you get my last messages? [20:27:33] probably not [20:28:01] contact problems with the power plug + linux failing to alert when battery is low -> not a good combination [20:28:31] Ah. [20:28:35] tgr: Can't exactly leave out CC0 in a patch that says "Generic CC license handling" :P [20:28:39] I don't see any reason not to show the CC logo for that [20:29:32] fair enough [20:29:50] Luckily it's easy to fix :) [20:30:27] also, there was another PD CC license [20:30:42] the CC public domain certification or something like that? [20:31:36] Waiver probably [20:31:44] CC-PD or something equally silly [20:31:49] yes [20:31:53] I wouldn't mind supporting that but it's less critical [20:32:12] less critical than CC0? :) [20:32:18] Yes [20:32:24] CC0 has some adoption on Commons [20:32:28] AFAIK CC-PD doesn't [20:32:37] Maybe I'm remembering that wrong? [20:33:14] 400k vs 600 [20:33:17] no, it seems to be used on a fair number of images [20:33:27] https://commons.wikimedia.org/wiki/Category:CC-PD [20:33:51] never understood the point of it [20:34:07] Heh [20:34:22] I suspect that's why CC retired it from use :) [20:34:35] Maybe I'll ask Kat [20:34:53] its basically saying, this image is in the public domain, except for jurisdictions where that is not legal, in which case it is in the public domain [20:35:17] Yeah [20:35:21] anyway [20:35:28] Copyright is complicated :) [20:36:01] i'll just send a 'cc0' string [20:36:06] for both of those [20:36:10] Works for me [20:55:35] (03PS5) 10Gergő Tisza: Add generic CC license parsing [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94931 [20:56:06] (03CR) 10Gergő Tisza: "Added CC0 handling. Also fixed a nasty bug in the process." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94931 (owner: 10Gergő Tisza) [20:56:35] Cool [20:56:39] tgr: Runs? Tested? [20:57:05] I should add a jenkins job for running the unit tests... [20:58:09] seems to work, and test are green [20:58:19] Saweet. [20:58:26] (03CR) 10MarkTraceur: [C: 032] "Huzzah" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94931 (owner: 10Gergő Tisza) [20:58:26] i'll write some more generic tests soon [20:58:31] Coolio [20:58:43] (03Merged) 10jenkins-bot: Add generic CC license parsing [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94931 (owner: 10Gergő Tisza) [21:09:38] marktraceur tgr speaking of which, at some point I assume you'll want some browser tests for multimedia beyond our one UploadWizard test? [21:10:04] chrismcmahon: That sounds like A Good Idea [21:11:35] (03CR) 10Gergő Tisza: Use data provided by remote CMD only when appropriate (032 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96288 (owner: 10Gergő Tisza) [21:11:45] marktraceur: one thing I'd like to do sooner is to put the UploadWizard browser test into the UploadWizard repo: https://gerrit.wikimedia.org/r/#/c/92875/ . Beyond that I'm a bit unclear about what would be useful to test at the UI level. [21:11:53] (03PS2) 10Gergő Tisza: Use data provided by remote CMD only when appropriate [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96288 [21:11:54] (03CR) 10jenkins-bot: [V: 04-1] Use data provided by remote CMD only when appropriate [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96288 (owner: 10Gergő Tisza) [21:12:07] Oh, I thought you guys had merged that already [21:12:30] I'll take a look at it during our UploadWizard Tech Debt Extravaganza [21:14:45] marktraceur: feel free to send me an invite to the Extravaganza [21:15:31] I don't think it's an actual thing [21:15:56] I'm just joking about the fact that we're organizing a blocked-out time to deal with UW tech debtn [21:15:59] debt* [21:16:02] cannot keyboard [21:16:56] marktraceur: I was thinking lack of UI tests was techdebtular [21:17:52] A little bit [21:18:06] I just don't really have a place to put tech-debt things apart from bugzilla [21:18:10] So...file bugs? :D [21:19:45] (03PS3) 10Gergő Tisza: Use data provided by remote CMD only when appropriate [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96288 [21:21:31] (03CR) 10Gergő Tisza: "Rebased + fixed medadata." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96288 (owner: 10Gergő Tisza) [21:32:14] marktraceur: bugs under Wikimedia/Quality Assurance are welcome [21:32:34] 'kay [21:33:05] (03CR) 10MarkTraceur: [C: 032] "I'll go with it. :)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96288 (owner: 10Gergő Tisza) [21:33:50] tgr: Are the other two patches basically-fine for now? [21:34:06] I'd like to sort out the UI redesign if I can, maybe we can get it to mediawiki.org tomorrow (HAH) [21:34:12] I mean totally. [21:36:54] (03Merged) 10jenkins-bot: Use data provided by remote CMD only when appropriate [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/96288 (owner: 10Gergő Tisza) [21:40:13] attribution is super-minor, so easy to rebase, and the other one is really nasty, not sure if i want to actually go along with that [21:40:27] so yes, those can wait [21:40:29] a lot [21:41:02] Cool [23:06:11] OK I am getting _really_ weird results with the new controls code [23:06:14] But it's coming along [23:06:46] (03PS9) 10MarkTraceur: Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 [23:07:05] (03CR) 10jenkins-bot: [V: 04-1] Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur) [23:07:40] (03CR) 10MarkTraceur: "Argh. *sobs*" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur) [23:39:54] (03PS10) 10MarkTraceur: Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 [23:39:54] (03CR) 10jenkins-bot: [V: 04-1] Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur) [23:40:00] Sliiiightly better now [23:40:07] No mobile solution yet I guess [23:40:15] I feel a little dirty using click to trigger this [23:43:47] (03PS11) 10MarkTraceur: Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 [23:43:49] Ah well [23:43:50] (03CR) 10jenkins-bot: [V: 04-1] Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur) [23:43:50] * marktraceur rebases [23:44:47] (03PS12) 10MarkTraceur: Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 [23:44:49] Woo, looks better [23:48:07] fabriceflorin: Latest lightbox UI redesign patch is on alpha [23:48:20] I'm suuuuper unhappy about bits of the design, but at least it's working now