[17:15:36] tgr: Hey, any chance I could get some MMV reviews today? :) [17:16:08] I'll handle Amire's patch and re-review the moment.js one [17:19:11] marktraceur: sure [17:24:54] (03CR) 10MarkTraceur: "This seems, at least partly, like a pretty silly patch, but OK, let's go with some of it anyway." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/94269 (owner: 10Amire80) [17:25:00] (03CR) 10MarkTraceur: [C: 04-1] Fix images and related CSS for RTL wikis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/94269 (owner: 10Amire80) [18:04:33] wmfmedia-standup: You're late [18:04:43] Oh, it's Monday, bots don't know about my standup [18:04:47] STAND-UP! [18:04:55] !shuffle tgr marktraceur bd808 [18:04:55] marktraceur bd808 tgr [18:04:58] Shit! [18:05:47] * bd808 stands up [18:05:56] Yesterday^WFriday: Worked on code review, hacked on grrrit-wm, but was a little sleep deprived! Bettar now. [18:06:37] Today: MMV work, more CR, hopefully looking at bugs and mingle cards and prioritizing accurately. [18:07:09] I'm acutely aware that we have to decide whether to "go" on Thursday by tomorrow, so we should probably get the UI reorganisation dealt with before Wednesday. [18:07:22] (tgr, I'm looking at you for CR) [18:07:33] * marktraceur hands bd808 a stick [18:08:03] On Friday I interviewed another candidate for the "lead" position [18:08:15] I liked him, but who knows [18:08:36] TOday I'm mostly heads down on the scholarship project [18:08:55] But I have another candidate to interview late this afternoon [18:09:12] I've also been doing some code reviews for Dan [18:09:19] * bd808 hands stick to tgr  [18:10:15] didn't work today, i migrated my dev environment to the wmf laptop, which proved way more complicated than imagined [18:10:26] * tgr is not used to linux desktops [18:11:06] aaron still needs to review the category patch, i asked him a few times, but no effect so far [18:11:50] Cool [18:11:53] tgr: Is that patch a blocker for this week's release? [18:11:55] that's the only blocker, otherwise CMD is ready as far as i am aware [18:12:07] Oh, and we have our mate Aaron Arcos in the office today, I think [18:12:11] well, technically not [18:12:31] but without it the metadata part of MV is mostly useless [18:13:13] the lightbox functionality still works, so depends on how much do we care about making a good first impression [18:13:34] ok, mostly useless is an exaggeration [18:13:38] Yeah [18:13:52] licenses wouldn't work, assessments wouldn't work [18:14:00] categories, obviously [18:14:04] the rest is not affected [18:14:14] marktraceur: Can you use your "I'm staring at you in real life" powers to nudge Aaron towards a review today? [18:14:18] fabrice seemed to worry a lot about categories [18:14:27] I haven't implemented assessments or categories in the UI [18:14:31] Is that a bad thing [18:14:41] bd808: I'm ON THE CASE! [18:14:46] * marktraceur bounds away heroically [18:15:28] personally i wouldn't see it as a big problem if always just wrote "see image page" for the license [18:15:42] but iirc fabrice considered it a blocker at some point [18:16:36] He's had some trouble coming to grips with choosing either a time or a feature set but not both [18:17:49] * marktraceur poked Aaron [18:17:56] thanks [18:18:00] actually [18:18:02] \o/ [18:18:11] tgr: He suggests maybe putting it in the extension, so you might brace yourself for that [18:18:33] the earlier version used html data for licenses, i could just revert to that if nothing else works [18:18:52] so not a blocker at all [18:19:05] i can move it to the extension very easily [18:19:20] it just seems very generic functionality which belongs to core [18:19:23] anyway [18:19:32] next up, code review [18:20:36] * tgr gives stick back to wmfmedia-standup  [18:21:45] Cool [18:21:47] Thanks tgr [18:22:40] Ooh, cool, CirrusSearch is using BetaFeatures soon [18:28:59] Do we know when new-Aaron is supposed to be here? [18:29:44] * bd808 doesn't [18:30:03] robla? [18:31:49] 11am [18:31:55] Cool beans [18:31:57] Thanks [18:34:24] (03CR) 10MarkTraceur: [C: 032] "I'm a fan" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92298 (owner: 10Gergő Tisza) [18:34:32] moment.js merged [18:45:49] (03Merged) 10jenkins-bot: Use moment.js for date formatting [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92298 (owner: 10Gergő Tisza) [20:51:15] howdy, aarcos! [20:51:21] bd808 tgr marktraceur robla: Hi! [20:51:50] aarcos: You made it! :) [20:55:02] OK so [20:55:18] First up, staff channel [20:55:35] Step 1) cloak [20:55:40] you tell me what to do... [20:56:01] cloak [20:56:05] sorry [20:56:07] robla: Sorry, I should confirm, we have agreements/contracts signed with aarcos, right? [20:56:21] yeap ! [20:56:29] as of 90 min ago :) [20:56:39] Cool [20:56:47] aarcos: /join #wikimedia-staff [20:56:47] https://office.wikimedia.org/wiki/IRC#Cloaking [21:00:06] It tells me I need to login? How can I get an account? [21:00:14] Oh, huh [21:00:19] You should be logged in already [21:00:32] Yeah, you are [21:00:40] Oh, you mean for officewiki [21:00:50] That's OIT's job [21:01:22] aarcos: https://meta.wikimedia.org/wiki/IRC/Cloaks is better [21:01:59] /join #wikimedia-staff [21:02:21] You put a space in front of it, there [21:03:46] yeap ! for officewiki, the browser thells me: Login required. You must log in to view other pages. [21:03:55] Yeah, that's expected [21:03:59] We haven't gotten you an account yet [21:05:20] I am sure we can fix that, ;-). Who should I talk to? [21:05:31] Probably cndiv. Sec. [21:05:47] But that's not really terribly pressing right now [21:06:51] aarcos: Send an email to techsupport@wikimedia.org requesting officewiki and foundationwiki accounts, as well as a Mingle account and access to the Multimedia Mingle project [21:06:59] They'll probably do at least one of those things [21:07:10] Maybe an email address too, if you haven't started that process [21:07:47] ok, doing that right now... [21:07:51] Awesmoe [21:07:54] Awesome* [21:08:01] Did you try joining the staff channel, too? [21:09:31] Just did !, who is there? [21:11:01] aarcos: So, on to thinking about Multimedia, let's get you some links to projects and setup your environment [21:11:23] aarcos: The first thing you'll want is to set up Vagrant - https://www.mediawiki.org/wiki/Vagrant [21:13:33] ok, let me take a look... [21:13:54] It's basically just a prefab'd virtual machine for getting MediaWiki up and running on your computer [21:15:37] Neat !, will install and set up, let you know if any questions, tx ! [21:16:05] Cool [21:31:12] marktraceur: the new UI doesn't have a close button yet? [21:32:52] No, that's (I think) the only pending thing before I bug someone to merge it [21:36:06] i'll leave the UI patch alone for now, then [21:38:22] 'kay [21:38:28] And I'll fix it up [21:39:02] (03CR) 10Gergő Tisza: [C: 032] Use oojs to extend multilightbox objects [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95295 (owner: 10MarkTraceur) [21:39:04] (03CR) 10jenkins-bot: [V: 04-1] Use oojs to extend multilightbox objects [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95295 (owner: 10MarkTraceur) [21:41:51] Hrm [21:42:37] (03CR) 10Gergő Tisza: [C: 032] "Works for me, but might depend on the API lag and browser type; we'll have to look at the logs once it is deployed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [21:42:38] (03CR) 10jenkins-bot: [V: 04-1] Measure sitename clicks too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [21:43:35] I'll do oojs first [21:43:50] ...after I finish adding unit tests (as it were) [21:47:44] (03PS1) 10MarkTraceur: WIP: Add unit tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/96152 [21:50:08] (03PS3) 10MarkTraceur: Use oojs to extend multilightbox objects [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95295 [21:50:11] tgr: Rebase ^^ [21:56:38] Hi aarcos, are you on the wikitech-l and multimedia mailing lists yet? [21:56:59] nope ! [21:57:37] how do I suscribe? Also, do I need a wiki.org email or I can use my personal email? [21:57:50] your personal email should work just fine. [21:58:17] Actually, I will probably create a new email account for this gig, ;-). [21:58:35] (03PS5) 10MarkTraceur: Measure sitename clicks too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 [21:58:37] Rebase also [21:58:38] Just tell me how to subscribe and will do, tx ! [21:59:17] (03CR) 10Gergő Tisza: [C: 032] Use oojs to extend multilightbox objects [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95295 (owner: 10MarkTraceur) [21:59:21] (03Merged) 10jenkins-bot: Use oojs to extend multilightbox objects [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95295 (owner: 10MarkTraceur) [21:59:39] * marktraceur hopes the other rebase is trivial ish [22:02:54] aarcos: http://lists.wikimedia.org/ has all the lists [22:03:12] You'll want https://lists.wikimedia.org/mailman/listinfo/wikitech-l and https://lists.wikimedia.org/mailman/listinfo/multimedia in particular [22:03:35] Both fairly low-ish traffic...depending on the day [22:05:29] robla: tx !, will do. [22:07:42] register Ata100100 aarcos.wiki@gmail.com [22:07:58] dah ! [22:08:14] now you guys now my password, ;-) [22:17:38] aarcos: You should change it! [22:19:43] (03CR) 10Gergő Tisza: [C: 032] Measure sitename clicks too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [22:19:50] (03Merged) 10jenkins-bot: Measure sitename clicks too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [22:21:29] Huzzah [22:57:53] marktraceur: is there anything else i should look at today? [23:00:18] Not yet, nope [23:00:26] Nothing pressing :) [23:00:42] by the way, now that the core patch has landed, could you merge https://gerrit.wikimedia.org/r/#/c/95173/ ? [23:01:15] (03CR) 10MarkTraceur: [C: 032] Handle remote categories in a ForeignDBRepo setup [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/95173 (owner: 10Gergő Tisza) [23:01:16] (03CR) 10jenkins-bot: [V: 04-1] Handle remote categories in a ForeignDBRepo setup [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/95173 (owner: 10Gergő Tisza) [23:01:21] Said I would, so...oh. [23:01:24] tgr: Apparently no [23:13:44] Huh, weird [23:13:58] That 4px gap you were seeing is on both sides on my screen [23:14:07] And it doesn't appear to be measured by...anything [23:21:09] It's because I'm using the table method of centering. Crap. [23:21:16] * marktraceur works it out [23:24:23] (03PS4) 10MarkTraceur: Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 [23:24:32] Better. Much better. [23:24:38] aarcos: How's it going? [23:31:26] (03PS5) 10MarkTraceur: Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 [23:35:44] marktraceur: hey !, good that you ask, I think I have a virtual server (http://127.0.0.1:8080/wiki/Main_Page) up and running, ;-). [23:36:34] Cool! [23:36:59] aarcos: Do you already have git installed on your local machine also? [23:37:05] (03PS3) 10Gergő Tisza: Handle remote categories in a ForeignDBRepo setup [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/95173 [23:37:51] marktraceur: yeap !, git installed ! [23:38:25] aarcos: OK, next up is introducing you to MediaWiki development in general [23:39:00] marktraceur: all ears... [23:39:41] marktraceur: rebased 95173 [23:39:43] aarcos: https://www.mediawiki.org/wiki/Gerrit/Getting_started should get you there - you already have a git clone of mediawiki in your vagrant instance (it should be at mediawiki in the vagrant dir), so you don't need to do that, but you may need to set up a gerrit remote [23:39:48] tgr: On it [23:40:50] marktraceur: All right, let me do that... [23:41:01] Fun times! [23:42:11] welcome aarcos! [23:43:32] ragesoss: Thanx !, honored to be here !, ;-). [23:44:18] He's even in -staff, ragesoss :) [23:44:26] I announced _way_ faster than robla did [23:46:29] marktraceur: ? [23:46:57] robla: I said "Hey here's aarcos" in -staff a few hours ago. [23:47:03] Faster, but also less creative and informative. :) [23:47:46] ah...you had me worried that you had scooped me on wmfall or something :-) [23:47:55] Heh [23:48:28] Naw, I didn't, I'm too scared to watch an email thread I started devolve into improper threading [23:48:38] Though maybe we'll get lucky this time [23:49:51] It's tough coming to grips with the fact that your coworkers are email heathens, eh marktraceur? [23:50:15] ragesoss: You have _no_ _idea_ what I have to deal with. [23:50:57] you know they make free-as-in-freedom graphical clients for email, right? [23:51:06] I do know that [23:51:11] :) [23:51:13] I use mutt because it means I only need one client open [23:51:33] And I can SSH to the computer running that client [23:51:40] ah, saving precious computer resources. [23:51:44] Not really [23:51:47] ;) [23:51:55] I'm probably a small ecological disaster when it comes to power usage [23:53:22] I'm probably not the most consistent about power usage across my life, but I do take a small amount of pride in running my IRC server on tiny TV stick that draws less power than my desktop does while suspended. [23:53:44] Nice