[00:57:46] <grrrit-wm>	 (03PS2) 10MarkTraceur: Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 
[00:57:51] <marktraceur>	 Fixed the algo to use width only
[00:57:55] <marktraceur>	 Er
[00:59:01] <marktraceur>	 Ignore me a sec
[01:03:49] <marktraceur>	 Urgh, something's wrong.
[01:04:21] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "Needs work, but that last PS was supposed to switch it over to using only width *and* abstract out the width/height calculations." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 (owner: 10MarkTraceur)
[16:09:13] <grrrit-wm>	 (03PS2) 10Gergő Tisza: Handle remote categories in a ForeignDBRepo setup [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/95173 
[17:16:46] <marktraceur>	 tgr: Did inch<tab> address my thoughts in the latest patchset?
[17:19:28] <tgr>	 some of them
[17:20:50] <marktraceur>	 Should I review again?
[17:21:13] <marktraceur>	 Or are we waiting on her to fix the rest
[17:22:17] <tgr>	 i think you should just -1 if you still have concerns with it
[17:23:03] <marktraceur>	 It seems unlikely.
[17:23:06] <tgr>	 i think she didn't quite understand what you wanted from her wrt var formatting
[17:23:37] <marktraceur>	 Argh
[17:23:38] <marktraceur>	 'kay
[17:24:29] <tgr>	 the link vs. button issue should be a different changeset IMO
[17:24:35] <marktraceur>	 Agreed
[17:24:53] <tgr>	 if her application is accepted, it will be replaced by some more complex control anyway
[17:25:13] <marktraceur>	 Heh, awesome.
[17:46:08] <grrrit-wm>	 (03CR) 10Gergő Tisza: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95295 (owner: 10MarkTraceur)
[17:48:09] <marktraceur>	 tgr: No, multilightbox isn't in core :) I'm calling the extension file a dependency because it replaces a class that multilightbox uses
[17:48:40] <marktraceur>	 Dependency injection, I guess, is the word.
[17:48:43] <tgr>	 i know, thats why i said core-ish
[17:49:10] <tgr>	 still, it is a lower level component, isn't it?
[17:49:20] <marktraceur>	 A little bit
[17:49:39] <marktraceur>	 Using MLB with the original LightboxInterface class wouldn't be a problem
[17:49:50] <marktraceur>	 But we want to later add functionality through this new class
[17:50:47] <grrrit-wm>	 (03CR) 10MarkTraceur: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95295 (owner: 10MarkTraceur)
[17:54:07] <tgr>	 then maybe MLB could use this.interface everywhere
[17:54:39] <tgr>	 and in the main extension module you can just say MLB.interface = ExtensionSpecificInterface
[17:55:04] <tgr>	 thats closer to how dependency injection is usually done
[17:55:42] <marktraceur>	 interface is actually a reserved word :)
[17:55:48] <marktraceur>	 Gotta love JS.
[17:56:01] <marktraceur>	 But yeah, I guess so
[17:56:15] <marktraceur>	 I'll look into doing that instead
[17:59:56] <marktraceur>	 Brace for impaaaact
[18:00:00] <wmfmedia-standup>	 Stand-up!
[18:00:00] <wmfmedia-standup>	 Order: bd808 -> marktraceur -> fabriceflorin -> tgr
[18:01:18] * bd808  grabs stick

[18:01:41] <bd808>	 Yesterday I did a phone interview with a candidate
[18:01:52] <bd808>	 I also looked at Dan's patches
[18:02:11] <bd808>	 Today I looked at some folloup changesets from Dan
[18:02:25] <bd808>	 And I will be focusing on non-mulitmedia work
[18:02:30] <marktraceur>	 Woot
[18:02:34] <bd808>	 multimedia even
[18:02:40] <marktraceur>	 Mulletmedia
[18:02:43] * bd808  drops stick

[18:02:52] * marktraceur  picks it up, dusts it off

[18:03:07] <marktraceur>	 Yesterday I was working on improving MultimediaViewer some more
[18:03:19] <marktraceur>	 Though it's slowing down a bit because I'm getting into a commit chain trap
[18:03:31] <marktraceur>	 Consequently, today I'm going to work on all the code review
[18:03:58] <marktraceur>	 And hope that tgr or brion can at some point review the patches I have in - they pretty significantly change the code structure, so it would be hard to move forward without them
[18:04:21] <marktraceur>	 I'm also deploying VectorBeta to mw.org today, which should be amusing
[18:04:35] <marktraceur>	 Watch on channel 7 right after How I Met Your Mothr
[18:04:54] * marktraceur  hands fabr<tab> the stick

[18:04:56] <marktraceur>	 Oh right
[18:05:09] * marktraceur  takes the stick back from fabrice, gives to tgr

[18:05:53] <tgr>	 i reworked the category patch, because people said File is not the right place for dealing with categories
[18:06:03] <tgr>	 hopefully the new version fares better
[18:06:16] * marktraceur  crosses fingers

[18:06:21] <tgr>	 i reviewed the gwtoolset changes
[18:06:36] <brion>	 ooh patches to look at
[18:06:41] * brion  adds to list

[18:06:52] <tgr>	 and started reviewing the pending mediaviewer changes, i'll continue doing that
[18:07:42] <tgr>	 no blockers, although i couldn't figure out how to properly test the core patch
[18:07:56] <marktraceur>	 I'll add you, brion
[18:08:05] <brion>	 tx
[18:08:29] <tgr>	 since it depende on File subclasses, and those depend on DB load balancer and whatnot
[18:08:50] <tgr>	 guess it will have to be tested on the beta cluster
[18:09:00] <marktraceur>	 Fun times
[18:09:04] * tgr  drops stick

[18:09:19] <marktraceur>	 tgr: FWIW testing on beta wouldn't be so bad
[18:09:36] <marktraceur>	 Worst case, we fix it 6-12 minutes later with a revert commit
[18:10:10] <tgr>	 i tested with local files, and it inwokes the same lines of code, so it shouldn't be completely broken
[18:10:22] <tgr>	 but maybe gets the categories from the wrong page
[18:10:29] <tgr>	 unlikely, but should be checked
[18:11:16] <marktraceur>	 'kay
[18:11:27] <marktraceur>	 tgr: Do you need review on that, or is Aaron on it?
[18:12:31] <tgr>	 he gave feedback pretty quickly yesterday, i'll wait until he is happy with the general approach, then invite you for review
[18:13:09] <marktraceur>	 'kay
[18:23:00] <grrrit-wm>	 (03PS3) 10MarkTraceur: WIP Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 
[18:45:32] <marktraceur>	 tgr: The momentjs patch needs a rebase, do you have time or should I do it?
[18:45:43] <tgr>	 i'll do it
[18:45:46] <marktraceur>	 Sweet
[18:46:11] <tgr>	 should i wait for the UI rewrite etc to be merged?
[18:46:30] <marktraceur>	 Naw, it should be fine
[18:46:32] <marktraceur>	 I can rebase that
[18:53:59] <dan-nl>	 hey bd808 thanks for the rebase
[19:01:47] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "Tested, works." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93867 (owner: 10MarkTraceur)
[19:15:10] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "Tested, works." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93909 (owner: 10MarkTraceur)
[19:21:50] <marktraceur>	 Huzzah
[19:22:37] <tgr>	 marktraceur: should i +2 these or wait for brion?
[19:23:10] <brion>	 if you're confident in them go ahead
[19:23:15] <brion>	 but i'll take a peek after this meeting
[19:23:16] <marktraceur>	 Go nuts man
[19:41:57] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Rewrite of UI initialization [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93909 (owner: 10MarkTraceur)
[19:42:21] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] ResourceLoader consistency file moves [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93867 (owner: 10MarkTraceur)
[19:55:06] <marktraceur>	 Looks like I need to rebase too
[19:55:09] <marktraceur>	 Crap
[20:59:44] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Looks very nice! Two small things (not sure if they should belong to this changeset or not):" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur)
[21:23:03] <grrrit-wm>	 (03CR) 10MarkTraceur: "I haven't really thought about what the background should be, yet. I'd say that could be a separate patchset." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 (owner: 10MarkTraceur)
[21:38:47] <grrrit-wm>	 (03PS3) 10MarkTraceur: ResourceLoader consistency file moves [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93867 
[21:38:53] <grrrit-wm>	 (03PS2) 10MarkTraceur: Rewrite of UI initialization [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93909 
[21:38:57] <grrrit-wm>	 (03PS3) 10MarkTraceur: Reorganize UI to be...way sexier. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95081 
[21:39:00] <grrrit-wm>	 (03PS4) 10MarkTraceur: WIP Introduce image size bucketing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95282 
[21:39:11] <grrrit-wm>	 (03PS2) 10MarkTraceur: Use oojs to extend multilightbox objects [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/95295 
[21:39:17] <marktraceur>	 Rebase all the things
[21:40:48] <grrrit-wm>	 (03PS2) 10MarkTraceur: Fix images and related CSS for RTL wikis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/94269 (owner: 10Amire80)
[21:54:57] <grrrit-wm>	 (03PS2) 10Gergő Tisza: Use moment.js for date formatting [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92298 
[22:16:06] <quiddity>	 all your rebase (rebase), are belong to marktraceur 
[23:13:32] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] ResourceLoader consistency file moves [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93867 (owner: 10MarkTraceur)
[23:14:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: ResourceLoader consistency file moves [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93867 (owner: 10MarkTraceur)
[23:22:23] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Rewrite of UI initialization [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93909 (owner: 10MarkTraceur)
[23:23:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rewrite of UI initialization [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93909 (owner: 10MarkTraceur)
[23:31:16] <marktraceur>	 Woo
[23:56:09] <grrrit-wm>	 (03CR) 10MarkTraceur: "(3 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92298 (owner: 10Gergő Tisza)
[23:57:34] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "(2 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92298 (owner: 10Gergő Tisza)