[15:07:14] <nataliaharateh>	 reets android standup? :D
[16:41:59] <amrox>	 android hackers: is there a customary way to push a WIP branch or gerrit review?
[16:46:41] <mdholloway>	 amrox: not really.  we just preface the commit message with WIP: or similar and submit via the usual flow
[16:46:59] <mdholloway>	 i guess technically there's a way to mark a patch set as a draft, but i've never used it
[16:48:46] <amrox>	 mdholloway: ok. Is there a way to update a patch?
[16:49:41] <mdholloway>	 amrox: yep, just amend the commit and resubmit
[16:50:03] <mdholloway>	 are you using the instructions from our wiki?
[16:50:23] <amrox>	 I glanced at them :)
[16:50:34] <amrox>	 I'm just so used to the github-style pull request workflow
[16:52:14] <mdholloway>	 haha ok :)  yeah, i follow what's described there, niedzielski-afk just submits with plain git pushes rather than using git-review but i don't know his exact workflow offhand (and he's out for the rest of the week)
[16:57:10] <amrox>	 so is a "patch" in gerrit always a single commit?
[16:57:53] <mdholloway>	 amrox: yep, no consolidating into anything like a Github-style PR, every commit is separate
[17:00:18] <amrox>	 mdholloway: gotcha, that makes sense now
[17:57:08] <dbrant>	 mdholloway: we may also need to roll back the Support library update.
[17:57:55] <mdholloway>	 dbrant: dang, where is it (possibly) breaking the app?
[17:58:04] <dbrant>	 mdholloway:  try the following:  go to read an article, and try invoking a link preview or two.  do you notice anything unusual?
[17:59:11] <mdholloway>	 dbrant: right off the bat i see a bit of a jitter on load...
[17:59:26] <dbrant>	 yep!
[17:59:49] <dbrant>	 it's definitely happening only after the update.
[18:27:39] <amrox>	 first android patch submitted 🙃
[18:30:11] <mdholloway>	 amrox: nice
[18:31:47] <mdholloway>	 amrox: did you just set up a gerrit account?  your account doesn't seem to be whitelisted for changes to automatically kick off CI tests even though it should be as a staff member
[18:32:09] <mdholloway>	 not a big deal but something to note
[18:32:33] <amrox>	 yes, I did, I should be 'AMroczkowski'
[18:32:34] <mdholloway>	 never mind
[18:32:38] <mdholloway>	 they ran
[18:53:35] <mdholloway>	 dbrant: the jitter goes away if i comment out this line: https://github.com/wikimedia/apps-android-wikipedia/blob/master/app/src/main/java/org/wikipedia/page/ExtendedBottomSheetDialogFragment.java#L45
[18:55:34] <mdholloway>	 dbrant: separately, i've seen the app ANR on launch a couple of times in the past 15 minutes or so...
[19:36:43] <dbrant>	 mdholloway: good find! worth investigating a bit further.
[19:37:09] <dbrant>	 mdholloway: i'm guessing the ANR is not reproducible?
[19:38:48] <mdholloway>	 dbrant: (was in 1:1 for a bit since i messaged last) yeah, not sure about reproducing the ANR, but i believe on both instances it was when launching from AS, which may or may not mean anything
[19:38:56] <mdholloway>	 i'll keep digging on the preview jitter
[19:39:14] <mdholloway>	 restarted my phone and a third launch from AS went fine
[19:39:40] <mdholloway>	 nothing too interesting in logcat unfortunately
[19:50:49] <dbrant>	 mdholloway: i think i might have it.
[19:51:46] <mdholloway>	 dbrant: jitter or ANR?
[19:51:51] <dbrant>	 jitter.
[20:50:56] <mdholloway>	 dbrant: ICYMI, reading list service RFC meeting is coming up in 10 minutes
[20:51:44] <dbrant>	 mdholloway: thx, i'll join
[20:52:05] <mdholloway>	 cool. i'll be there as well