[15:03:23] session's expiring in gerrit pretty frequently these days :[ [16:02:46] nataliaharateh: standup ;) [16:42:38] niedzielski: i'll try running the screenshot tests on master again in a minute [16:43:02] i had a run going when standup started but it errored out because of unrelated failures [16:43:22] mdholloway: cool, i'll give them a go on my machine as well. there's a script in the scripts folder that i normally use when i want to run the same thing ci does [16:43:58] i don't know if anyone else experiences this but the full test suite is awfully flaky when i run it locally (especially those editing abuse filter tests) [16:44:00] scripts/apps-android-wikipedia-periodic-test [16:44:12] oh, nice, i'll check that out [16:44:21] the editing tests fail for me all the time :/ [16:56:12] bearND: which was the service patch you were hoping to merge ASAP? was it https://gerrit.wikimedia.org/r/#/c/327224/? [17:01:54] mdholloway: https://gerrit.wikimedia.org/r/#/c/327023/ [17:02:59] bearND: oh, ok! i'll just verify on my machine and merge shortly [17:05:55] mdholloway: oops, master passes on my machine fwiw [17:48:59] bearND: dbrant good to go now: https://gerrit.wikimedia.org/r/327224 [17:49:24] bearND: had to make an iOS specific parameter name change to cover for a bug on iOS native side [17:58:09] niedzielski: do you need anything else from me here? https://gerrit.wikimedia.org/r/#/c/323087/2 [17:58:41] coreyfloyd: no, i just need to follow up on it. thanks [17:58:55] niedzielski: ok sounds good… let me know [20:01:40] mdholloway: are you able to run the tests successfully (just master is fine) as part of deployment prep in your VM? [20:02:09] i mean MCS [20:02:11] bearND: yes, in a VM, just not native docker for mac [20:02:34] mdholloway: have you run it today? [20:03:16] bearND: not in the VM [20:05:14] mdholloway: I'm getting some mysterious 500 errors there, not even 504s as I used to get [20:06:07] bearND: i'll try now [20:13:23] bearND: passing here [20:16:12] mdholloway: thanks. Something in my setup is really horked. I'm downloading a new Ubuntu iso and will create a new VM image. But I won't get this done in time before the next deployment window. Would you do another deployment prep a bit later? Going through some more code review. [20:16:34] bearND: sure, just let me know when everything that should be included is merged! [20:21:17] thanks. will do [20:41:54] jdlrobson: Did you want to watch the deployment prep for MCS today? [20:47:27] mdholloway: I think we've got what we need for today's MCS deploy. [20:48:53] bearND: cool. i'll wait a bit in case jdlrobson wants to hop on a hangout [20:49:26] bearND: hangout? [20:49:39] sure but i dont have an invite [20:50:30] jdlrobson: one sec, gotta plug in and grab headphones, i'll pm you a link [20:51:07] bearND: batcave if you want to join [20:51:20] jdlrobson: I just added you to our regular deployment window meeting invite, just for this session [20:52:21] bearND: jdlrobson: oh, i'll hop on that one [20:52:25] jdlrobson: mdholloway : that way I can join as well