[05:10:56] Hello everyone. I like to contribute something to the android app project and I saw some task marked with "Easy" tags in Phabricator and thought of solving them. But when I see the code base, I am totally lost as to where to start and about which part of the code does what. That's because this is the first time I'm seeing code of an open source project. I seem to be missing something big. Can anyone point me to some good resources about this or [05:22:25] * bearND was about to respond but he quit [15:23:25] kaartic: o/ hello! have you checked out our getting starting guide? https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Wikipedia_Android_app_hacking [17:01:44] phuedx: "standup" [17:30:24] ^ nice air quotes [18:50:11] niedzielski: mdholloway|biab: question about the Retrofit tasks that are getting merged... [18:50:31] shouldn't we be checking for body() == null everywhere now? [18:50:41] only places that use @Require [18:51:54] @Require percolates up the composition until it's optional. that optional is null. if it's never optional, the highest level composed object is null [18:52:12] right now only Feed models used @Require AFAIK [18:52:14] dbrant: niedzielski in other words, not at all for these patches, which shouldn't contain @Require [18:52:36] cool, i see! [18:52:38] right, we did talk about it in the patches though [18:53:02] we're good AFAIK. thanks for checking [19:25:23] Hi. I am going to send a mail to mobile-l@lists.wikimedia.org but thought I'd let the team know about it here first. I want to discuss about https://phabricator.wikimedia.org/T147504. Please have a look and let me know your thoughts. [19:45:15] niedzielski: hello, thanks for the new alpha, the add description feature is really cool, but it doesn't work for me [19:45:47] matanya: glad you like it! dbrant just added it but it's not done yet (only ui is there) [19:46:01] I see [19:46:14] it should be featured out on the beta and prod builds [19:46:26] (pitfalls of using the Alpha app!) [19:46:34] niedzielski: I also saw you posted my volunteer work for a contractor ;) [19:47:01] dbrant: glad to help out as a pitfall early adapter [19:50:43] matanya: sorry, i think i'm a bit tired today and my memory is failing me. i didn't quite catch that, could you reword your phrasing a bit differently? are you referring to T144858 by any chance? [19:50:43] T144858: Remove dotted overflow from explore feed and add a long-pressing sub menu instead - https://phabricator.wikimedia.org/T144858 [19:52:29] niedzielski: https://boards.greenhouse.io/wikimedia/jobs/487209?gh_src=w3ekxu1 [19:54:13] matanya: ah, now i follow you :] yes, the apps have a large domain of functionality and countless bugs. there's now a job req to help supplement all the volunteer work you put in :] [19:54:28] heh :D [19:58:59] matanya: we also work with a group called The Specialist Guild to help test our beta releases before they go out. we've been trying to write more tests to automate some of this work at the unit level but it takes time. thanks again for your reports [19:59:03] ! [22:49:22] It's time for the percolator. [23:45:22] bearND: question: I've finally set up the android emulator locally so I wouldn't need to ask you to test the app when deploying any more [23:45:36] But, I see there's some automated tests [23:45:58] is that possible to point the tests to a RESTBase instance running on my localhost? [23:47:55] so that I'd be able to run the app tests when I'm developing something locally in RESTBase.. [23:51:23] Pchelolo: check out our example configs here: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Wikipedia_Android_app_hacking#Working_with_Vagrant_and_the_Content_Service [23:52:30] Pchelolo: we're trying to move more tests to use saved network responses. it's probably sufficient to just visit a page or two unless there's something specific you want to check [23:55:20] niedzielski: hm.. Where does this config live? [23:56:15] Pchelolo: this is just in the app's dev settings. if you're running the dev version of the app (green icon), just go to settings and tap "dev settings" in the upper right [23:56:35] otherwise you have to enable it by tapping seven times on the wikipedia logo on the about screen under settings [23:58:00] i think a manual test is most appropriate here because if an automated test could be made that was checking the service output, it should probably actually live in the service. for rendering issues, we do have some screenshot tests against a fully rendered webpage but they're very flaky [23:58:27] Aha, ok, cool, thank you. [23:59:20] np, i'll be on and off so ping my name if you need anything