[08:50:02] morning [08:50:07] netsplits everywhere [09:16:30] yo [09:16:32] hey joakino [09:16:39] it works! [09:17:24] joakino: https://twitter.com/IRCCloud/status/693906266247303174 [09:17:28] boo [09:17:42] yerp [09:17:57] seems to be working now [09:22:15] this album is currently featured on arctic drones [09:22:17] https://14nightsatsea.bandcamp.com/album/minor-light [09:22:22] and oh me oh my [09:40:01] intense ^ [14:03:55] man, sprint 64 would look so beautiful if it wern't for that damn core patch :D [14:05:36] jhobs: is that isElementInViewport to be moved from MobileFrontend to MediaWiki ? [14:05:43] yes [14:05:48] it is good to see you "upstreaming" [14:06:00] yeah, we're trying to be better about it in MF [14:06:19] maybe one day we will shoot MF entirely [14:06:27] and MediaWiki will support mobile out of the box [14:06:45] anyway progress! [14:06:45] * jhobs holds his breath and then realizes that's probably a bad idea [14:06:46] ;) [14:07:00] but yes, progress! [16:21:36] yo [16:25:31] o/ [17:01:28] joakino/bd808 PING ONG [17:01:31] ONG? [17:01:32] PONG! [17:01:46] nod [17:01:52] in a run over meeting [17:02:00] ping? http://vignette1.wikia.nocookie.net/disney/images/3/39/Mulan-disneyscreencaps.com-3154.jpg/revision/latest?cb=20141111135355 [17:02:10] not [17:02:12] clicking [17:02:13] that [17:02:14] link [18:16:22] bearND: standup time! [18:16:36] bearND: coming to standup? [18:17:00] mbinder: yes, still need to tackle h-o issues [18:22:40] phuedx: jesus this album is bleak [18:27:02] * mdholloway goes to listen [18:30:19] mdholloway: did you ever find a chance to try running that final fantasy game (I can't remember if it's 2 or 4, and the naming scheme across regions is so weird anyways :D)? [18:31:07] jhobs: not yet! still on my list for a free weekend. [18:31:29] bmansurov: you there? have you got a failing browser test for RelatedArticles issues? [18:31:44] yeah i'm here [18:31:48] mdholloway: well be sure to let me know how you end up doing! [18:32:00] jdlrobson: come again? [18:32:16] jhobs: i will! [18:32:19] coreyfloyd: standup? [18:32:23] bmansurov: https://phabricator.wikimedia.org/T120715#1930208 [18:32:27] where are you seeing that? ^ [18:32:51] jdlrobson: when i run the test locally [18:33:14] visit(SpecialPreferencesPage).enable_read_more < i'm not sure that line is correct [18:33:48] what is it trying to achive? [18:34:03] I would write two lines: [18:34:04] visit(SpecialPreferencesPage) [18:34:29] jdlrobson: that is enabling the beta perferences [18:34:48] jdlrobson: it was written differently before but someone from the testing team change it to that [18:34:57] oh i see it's a function [18:35:12] *d [18:35:23] bmansurov: usually when this happens [18:35:27] mobile web error on https://en.m.wikipedia.org/wiki/Main_Page but all other pages seem fine. [18:35:29] it's because JS is loading slow or something [18:35:58] it might be worth adding a step mw.loader.getState("/whateverpreferencesjsmodulenameis/") === "ready"; [18:36:31] a cheap way to test if it is indeed due to the test assertion runing before the js is run is to add a sleep just before the check :) [18:36:37] but dont submit a patch with sleep [18:36:54] jdlrobson: cool thanks [18:36:58] (Re: my comment, _joe_ solved it in -operations) [18:37:05] quiddity: wht was the issue? [18:37:23] <_joe_> quiddity: https://en.m.wikipedia.org/w/index.php?title=Main_Page&nocache=y&action=purge solved it, FYI [18:37:24] <_joe_> the trick is to add a bogus part in the query string (nocache=y does nothing) [18:38:26] quiddity: but what was the js error [18:38:34] i'm worried it might be something impacting other pages [18:40:14] it didn't show a specific error. It showed the "experiencing technical difficulties [...]" message/page, but instead of showing just the English version, with a technical explanation underneath, it showed the error messages in all languages underneath each other [18:40:28] (sorry, I reloaded the page, so can't screenshot :< ) [18:43:28] http://i.imgur.com/S78F93U.png [18:43:40] another report in -operations https://www.wikidata.org/wiki/Wikidata:Main_Page?action=purge [18:44:35] jdlrobson, ^ [18:45:25] oh ok [18:45:27] so not js :) [18:45:35] jhobs: i have more examples of bleak [18:45:41] i have a catalog of bleak ;D [18:45:57] quiddity: next time that happens can you halt a purge [18:46:00] so i can see what's going on? [18:46:35] jhobs: cult of luna - dark city dead man, for example [18:46:43] coreyfloyd would like that ^ [18:47:22] phuedx: I'm not much for bleak. The bleakest I go is stuff like Pearl Jam's "Black", which of course isn't very bleak at all, just grunge. [18:47:36] jdlrobson, see https://commons.m.wikimedia.org/wiki/Main_Page [18:47:40] i hate vodafone [18:47:44] ^ lol [18:47:45] Incidentally, one of, if not my favorite Pearl Jam song [18:48:09] (I'll let you fix that, and diagnose further, I need to concentrate on a meeting.. :) [18:48:17] joakino: vodafone hates you right back [18:48:34] mobile companies are force multipliers of hatred [18:49:30] quiddity: not seeing the js issue :/ [18:49:46] niedzielski: on which device/api are you seeing 8 events per read-more? o_O [18:49:49] but yay nudity ;-) [18:50:12] dbrant: nexus 6p [18:51:56] phuedx: indeed [18:52:22] jdlrobson, sorry, I didn't mean to imply a js issue. Just that the error is only seen for mobile subdomains. IIUC (based on skimming -operations whilst also paying attention to a meeting) it is a varnish problem, and thus not your problem. :) [18:52:42] okay let me know if there is anything we can help with [18:52:50] s/is only/was only/ [18:52:51] nod. [18:54:42] phuedx: oh no [18:55:25] phuedx: I think we need some drastic intervention - I'm buying you a Taylor Swift CD [18:57:04] dbrant: are you not able to repro? [18:57:24] niedzielski: not at all... on either my physical api 23 device, or emulator. [18:57:26] coreyfloyd: https://www.youtube.com/watch?v=BtJST96WBm8 [18:58:21] dbrant: hm, let me retry [19:01:16] dbrant: maybe i'm reading this wrong but here's what i get for scrolling down on one article: https://phabricator.wikimedia.org/P2551 [19:01:55] niedzielski: well that's darn peculiar... [19:02:55] dbrant: that's just from running tail -f /srv/log/eventlogging/all-events.log |grep --line-buffered MobileWikiAppArticleSuggestions [19:06:25] niedzielski: oh i see! i'm just now looking at the server-side EL data. It looks like all events are being octupled, not just these ones. [19:07:12] niedzielski: the app is definitely sending only a single packet. [19:07:28] dbrant: ok hm. i guess i'll check the database and make sure we're not counting 8 [19:07:42] phabricator is going to expand until it has every functionality on the internet https://phabricator.wikimedia.org/applications/ [19:07:49] kind of like mediawiki if you think about it haha [19:12:38] phuedx: lol [19:13:09] mdholloway: bearND: just a reminder, we're skipping today's deployment window for MCS and moving it to tomorrow to be able to coordinate with the config change [19:14:17] mobrovac: ok, thank you [19:15:05] mobrovac: yep! thanks for confirming. [19:15:22] joakino: lol [19:16:12] joakino: ahahaha [19:16:45] mobrovac: is it at the same time as usual? [19:17:42] btw there is a polls app, jdlrobson bmansurov jhobs phuedx, for future votes (no more etherpad voting?) https://phabricator.wikimedia.org/vote/ [19:17:56] mobrovac: never mind, just looked it up. lol [19:18:03] bearND: it will happen during the PuppetSWAT window - https://wikitech.wikimedia.org/wiki/Deployments#Tuesday.2C.C2.A0February.C2.A002 [19:18:04] kk [19:18:05] :) [19:18:56] mobrovac: oh wait, now that did confuse me then. the puppet SWAT is an hour earlier than the services [19:19:32] bearND: yes, because we need to roll out the config and the code at the same time [19:20:21] mobrovac: so we need to be ready for the puppet SWAT then but wait until we get the signal from you? [19:20:33] joakino: then even our sprint naming can be publically attached to the sprint! [19:20:55] jhobs: you can select the viewers I think [19:22:03] bearND: yup, exactly [19:22:21] mobrovac: ok, i see now. One patch needs to go in as part of the puppet SWAT. Sorry, still catching up with things. [19:22:56] bearND: yup, and we need ops for that, so we need a slight deviation from the schedule this week [19:23:13] bearND: no worries, i sympathise :) [19:26:58] jhobs_latelunch: yeap you can restrict viewers [19:27:59] :) [21:12:17] dbrant: i explored mostly watchlist and collection read apis the other day. is there a mw api to _read_ userjs preferences? i just see write [21:13:04] dbrant: and i don't see any unit tests around reading api functionality either in mediawiki/tests/phpunit/includes/api/ApiOptionsTest.php [21:14:43] niedzielski: to read options, it's action=query&meta=userinfo&uiprop=options [21:16:05] dbrant: thanks! i see the option i wrote :) [21:16:22] niedzielski: nice!