[00:01:54] hmm jdlrobson why do we even move the location of the settings icon if there is a description ? I feel like it should just stay in one place regardless of a description [00:02:20] re: CollectionEditOverlay [00:02:25] rmoen: mm ? sorry i'm super multi-tasking today i'll need more context [00:02:42] sryi realized i'm being vague [00:07:39] rmoen|afk: looking at https://phabricator.wikimedia.org/T101202 patch looks good. [00:08:43] unit tests would be useful in a follow up because of https://phabricator.wikimedia.org/T103578 (i'm getting really cautious about merging anything right now.) I'm a bit burnt out now so I'll take a look at the code tomorrow and give it a good test. [00:08:50] i'm not convinced i'll do a good job right now [00:15:08] jdlrobson: ok, same. I was trying to figure out what tests needed to be added as I just shifted some things around [00:15:16] jdlrobson: no new features really [00:15:43] jdlrobson: i'm going to come back and try to address feedback on the onboarding patch tonight [00:15:58] but i'm gonna be afk for a bit, time for me to watch the kid for a while [08:05:57] morning! [09:01:38] yo [10:17:57] phuedx: acted on https://phabricator.wikimedia.org/T103496 [10:18:21] verified still broken, updated description and commented, and moved back to todo [10:18:21] joakino: thanks [10:18:29] nice description of the issue and context [10:18:51] 👍 [10:31:28] joakino: just to clarify, gather is straight up enabled on beta labs, right? [10:31:43] sorry, beta cluster [10:31:55] phuedx: ? [10:32:12] phuedx: yes http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/all/recent [10:32:14] why? [10:32:18] good [10:32:25] just making sure as i sign things off :) [10:32:41] that was a confusing question hehe [10:34:23] i'm seeing the collections link added to the mobile menu regardless of mode on special pages [10:35:26] but not on articles [10:38:24] ah, i see the bug [10:41:27] phuedx: good job on clearing out the ready for signoff column [10:41:36] bmansurov: meh [10:41:38] not yes [10:41:39] *t [10:41:49] half done at least [10:45:02] it's kind of you to say bmansurov, but i need to be more on top of this [10:45:20] it'll get a little easier once we're past the end of quarter [10:47:04] because you wont signoff most of things? haha [10:47:49] half of them [10:47:57] but also hopefully we'll have a bit more bandwidth?! [10:48:09] i'm also responsible for letting you know when things are ready, right? [10:48:47] phuedx: i hope to stay on top of that column without needing pinging, if it's there, needs verification on staging/bc [10:49:06] phuedx: frak the collections menu item is on 1.26wmf11 going to enwiki today [10:49:16] YOBABYYYYY [10:49:41] https://lesleyedith.files.wordpress.com/2014/01/sf_yobaby_4oz_lid_vanilla-low.jpg [10:59:33] joakino: non-work related question, but i'm curious. How do you find animated gifs for a certain situation? Do you remember all gifs you've seen and just share some of them? Or is there a place you can search them by keywords? [11:01:52] bmansurov: haha, really important questino for remotes. I use giphy.com and search for the mood i'm looking for [11:02:09] for example http://giphy.com/search/wtf [11:02:17] https://media1.giphy.com/media/dnsEO6TxzZXWw/200.gif [11:02:35] this one is better https://media4.giphy.com/media/XEPsPKtqSwfPa/200.gif [11:03:00] lol [11:03:09] haha [11:18:44] http://devopsreactions.tumblr.com has some good ones [11:21:06] breaking for lunch [12:12:34] back [12:13:05] i'm heading out for lunch [12:13:24] phuedx: i've sent the performance meeting notes to reading, give it a pass in case I've said something wrong [12:13:34] (when you can) [12:13:36] joakino: suresies [12:13:44] gonna get the sign off column in order [12:13:56] and then give bmansurov some review on his search patch [12:14:03] which i've failed to do for the last two days [12:14:13] hehe me too [12:14:16] (those are my immediate priorities) [12:14:29] phuedx: sounds good! [13:26:46] any iOS developer here? :) (Or someone with an iPhone and the installed Wikipedia app?) [14:17:57] gonna take a short break to sweep out the back patio [14:17:57] i'll be back in about 15 minutes [14:30:26] back [14:57:28] dbrant: hello! would you mind reviewing this guy when you get a chance? https://gerrit.wikimedia.org/r/#/c/219239/ [14:57:56] niedzielski: sure! [14:58:08] dbrant: thanks :) [15:00:03] bearND: for the test errors you're seeing in https://gerrit.wikimedia.org/r/#/c/220326/, i think your robolectric.properties is not being read for some reason. i can help debug in the batcave most anytime today if you like [15:05:00] joakino: yt? [15:05:29] yo phuedx [15:05:31] niedzielski: thank you. I'll ping you a bit later when I'm ready to do so [15:05:46] bearND: sounds good [15:05:51] i think the pagination link for /all/recent is broken. [15:06:01] i'm just testing https://gerrit.wikimedia.org/r/#/c/220749/ [15:06:13] and i think that /all/recent has an /all/public pagination link [15:07:21] just verifying now [15:07:24] then i'll write up a task [15:07:29] just wanted to give you a heads up [15:07:53] wait [15:07:55] it's not a bug [15:07:58] it's by design [15:08:01] maybe [15:21:02] phuedx: that sounds like a case we haven't covered, yes [15:21:13] JS disabled pagination on collections list is broken [15:37:09] joakino: i'm fairly certain i just tested it locally when signing off a bug from wayne's world [15:39:44] wait [15:39:51] sorry -- we've already raised that bug [15:39:52] ok [15:39:57] just behind myself that's all [15:48:20] great [15:50:39] hola [15:50:44] hey rmoen|afk [15:52:15] mdholloway: hey michael! i'm looking through your email on the LanguagePreference dialog. is the issue that you're trying to launch the dialog from an activity's oncreate? [15:53:22] niedzielski: hmm... worth playing around with. [15:54:41] mdholloway: is there a reason to wrap the dialog in an activity? [15:58:12] niedzielski: I don't recall whether I tried it without wrapping in an activity; will try again. I was preemptively trying to avoid the NullPointerException that was the basis for this question: https://stackoverflow.com/questions/16883811/cannot-launch-dialogpreference-programmatically-null-pointer-exception-thrown [16:01:24] joakino: phuedx would you please drag the "Push max-width..." card on https://phabricator.wikimedia.org/tag/roadmap/ to the correct column? [16:01:50] done -- i just saw the question [16:01:59] lower priority work that gather at the moment [16:03:39] niedzielski: hmm, so, interestingly (or not), when i just launch the dialog directly in onClick( ), I get the same InflateException, not a NullPointerException. [16:03:41] phuedx: thanks [16:07:17] mdholloway: hm, another option might be to modify LangLinksActivity [16:08:15] niedzielski: which, if i understand correctly, indicates a problem on line 3 (in this case) of some XML file [16:09:00] niedzielski: yeah. to me a dialog feels better (in theory) but if it isn't working out then that would probably be a good way to go. [16:10:33] jdlrobson: yt? [16:10:35] mdholloway: I would still encourage you to refactor LanguagePreference to inherit from AppCompatDialog. This would also enable the dialog to use our styles (which it currently doesn't!) [16:10:43] want me to fix up https://gerrit.wikimedia.org/r/#/c/217757/? [16:11:07] just a very minor update to fix the build [16:11:42] dbrant: cool, yeah, i'll give that a whirl [16:11:47] dbrant mdholloway: would we still be able to use the preferences XML file to drive AppCompatDialog? [16:12:32] niedzielski: mdholloway: I was just thinking we'd have a "blank" preference that launches the dialog programmatically when clicked... [16:14:01] dbrant mdholloway: so SettingsFragment would remain largely unchanged? [16:14:39] niedzielski: i would think... [16:15:18] dbrant mdholloway: ok that makes sense. as a subsequent refactor, it'd be neat if LangLinksActivity could be rolled into the new dialog [16:23:15] phuedx: yup [16:25:16] * jdlrobson catches up on broken pagination [16:26:32] mhurd: hey monte! if you get a chance to take another look at this patch, https://gerrit.wikimedia.org/r/#/c/219421/, i'd appreciate it. [16:47:52] jdlrobson: sorry to break your catchup on pagination but is https://phabricator.wikimedia.org/T103047 a thing? [16:47:52] the border-box kerfuffle was reverted and i haven't seen any issues [16:47:52] niedzielski: will do! sorry about the delay! [16:47:52] mhurd: thanks! no worries [16:50:05] phuedx: basically preparing for https://gerrit.wikimedia.org/r/#/c/219874/2/includes/views/Collection.php [16:50:16] (So we reverted the change but we need to reapply it) [16:50:54] ah [16:51:01] so no it shouldn't be broken on current master any more and when you reapply https://gerrit.wikimedia.org/r/220008 it will still not be broken [16:51:15] should i try and fix the border box kerfuffle? [16:51:25] i wasn't sure whether i should mess with the sprint or leave it till next [16:53:11] jdlrobson: leave it for now [16:53:16] sprint items are more important [16:53:21] thanks for the update [16:53:27] roger that. Can you leave a note in comments and put it in next sprint or whatever [16:53:36] i want to communicate out to the editing team to avoid confusion [16:54:09] jdlrobson: there's a meeting being scheduled at some point to clarify editing foo [16:54:29] but yes, understood that you want to be explicit [17:07:46] yo jdlrobson phuedx sorry but gotta go pack and go car-trip to my parents city before a meeting with jon katz [17:07:53] i'll connect back later for a bit [17:07:56] bb [17:08:03] joakino: bbhf [17:08:36] jdlrobson: fyi https://phabricator.wikimedia.org/T103627 tracks setting up the meeting between reading and editing [17:09:39] phuedx: awesome. [17:09:44] joakino: ok [17:10:44] kaldari, jdlrobson i thought we disabled centralnotice banners in mobile frontend? :/ [17:14:27] jdlrobson: comment inline here that i'd like to discuss with you: https://gerrit.wikimedia.org/r/#/c/217757/7/resources/ext.gather.collection.contentOverlay/CollectionsContentOverlay.js when you're free (and i'm free, it's almost the end of my day) [17:15:29] biab i gotta go deal with something but yeh phuedx we can talk about a better approach for the icons. Essentially what we want is a view/widget within a view/widget which we need to work out anyway... [17:15:39] (for oojs ui) [17:15:43] agree [17:16:07] i'm not convinced it's -1 worthy because this is the first time we've encountered it, but it's worth having a discussion about [17:35:25] etonkovidova: let me know when you have a second and i can give you a quick briefing on iOS [17:35:49] didn't see you at standup, but would be really great to have some time fromm you today to do more testing on iOS [17:48:02] bgerstle: I have time now :) [17:50:36] gonna get the boys to bed [17:50:38] back in a bit [17:53:52] etonkovidova: sorry was jsut grabbing a snack [17:53:53] still have time? [17:54:15] bgerstle: yes :) [17:57:06] etonkovidova: i have a couple minutes before retro. tried to call you [17:57:09] call me on hangout? [17:57:41] bgerstle: a sec... getting headphones [17:57:47] k [18:14:37] mdholloway: shoot, i'll look at that task in a bit.. [18:14:50] dbrant: cool [18:15:15] niedzielski: mdholloway: let's fix the channel builds before building the beta apk... [18:15:29] dbrant: i'll have a patch in shortly [18:17:37] bearND|afk: retro? [18:17:43] nvm [18:17:59] dbrant: by the way, I got the refactored LanguagePreference class to launch from the search bar; now, to wire it back up to the preferences... [18:18:18] mdholloway: cool! [18:19:19] dbrant mdholloway: this patch is for one error, https://gerrit.wikimedia.org/r/#/c/220843/. the python script does not like missing default locales [18:21:28] yo [18:21:41] mdholloway dbrant: other fix https://gerrit.wikimedia.org/r/220844 [18:22:53] niedzielski: dbrant thanks! any idea what's up with the Gerrit delay adding reviewers/sending notification emails lately? [18:28:22] i'm actually going to go bouldering for the first time in forever -- i'll be around later for a little while [18:28:55] bmansurov: i still need to test your patch with some actual descriptions, but it lgtm [18:31:02] FlorianSW: no.. central notice banners do run on mobile. I think we turned off site notices though [18:31:57] jdlrobson: ok, but hoo said, that it's a site notice (and he's right, i haven't checked it, sorry). For you interest, can you open https://de.m.wikipedia.org/wiki/Android just for fun? ;) [18:32:27] FlorianSW: haajaj [18:32:32] phuedx|AFK: need help setting it up? [18:32:36] at least it does clos [18:32:39] jdlrobson: cool, right? :D [18:33:09] bmansurov: just packing my bag -- i've still got my notes from wikigrok so i think i'm good [18:33:26] phuedx|AFK: oh i saw your earlier comment, have fun [18:34:05] marxarelli|away: let me know when you are not away [18:35:08] right [18:35:10] *gone* [18:59:10] rmoen: did you see my comments on https://gerrit.wikimedia.org/r/#/c/220013/ ? [18:59:13] what do you think? [19:04:51] mdholloway: nope :) [19:07:53] rmoen: also i've suggested a follow up for https://gerrit.wikimedia.org/r/#/c/220288/ it's a bit minor but worth investigating [19:10:54] jdlrobson: thanks. on my end the vertical positioning of the icon is better than before.. I will look into it [19:12:00] jdlrobson: will check https://gerrit.wikimedia.org/r/#/c/220013/, right now i'm wrapping up https://gerrit.wikimedia.org/r/#/c/219506/ [19:12:10] i see that good old barry has found an issue with my patch ;) [19:17:15] bmansurov: rmoen we seem to be causing a patchset pile up in the last 2 columns. I don't think we should be starting work on any other patches till we get the issues with those patches fixed up [19:17:16] thoughts? [19:17:29] (bmansurov: i see you started the references story) [19:17:36] jdlrobson: i'm not starting anything else [19:17:42] wrapping up things [19:18:18] but good idea to communicate the pile up ;) [19:18:30] yeh i think we should make it our priority to unblock all this stuff [19:18:53] bmansurov: i'm looking at the wikidata description patch again now there has been some conversation [19:19:07] rmoen: you want to take care of that browser test? I think that patch is the closest of yours to being mergeable [19:19:49] bmansurov: you forgot to move my patch to the -1 column so had no idea you were waiting for a follow up :) [19:20:10] jdlrobson: yeah, i need something to work on [19:20:15] jdlrobson: i just pushed in the onboarding and addressed all feedback [19:20:16] did code review too [19:20:26] bmansurov: well maybe we could take on each other's patches [19:20:26] now lets see if it works with the search icon [19:20:36] it makes no sense doing new work when higher priority work is still waiting to get completed [19:20:46] my 2 cents :) [19:20:47] jdlrobson: any suggestions? [19:21:02] i'm fine picking up somebody else's patch [19:21:22] the other alternative is to pair with each other and get stuff merged [19:21:33] jdlrobson: now i'm working on fixing the browser test issue [19:22:17] bmansurov: feel free to poke at my pointer patch fix https://gerrit.wikimedia.org/r/#/c/220013/ [19:22:29] if you like. there is feedback from jdlrobson [19:22:40] dbrant|food bearND|afk mdholloway: do you guys have the full partner list? i can replicate what was last distributed in the google drive but do we have an official list? [19:22:41] https://gerrit.wikimedia.org/r/#/c/217757/ of mine needs some review [19:22:41] jdlrobson: as for the patch, I think @NiharikaKohli is working on it [19:22:50] jdlrobson: it shouldn't be on the -1 column [19:23:01] bmansurov: hm which patch? [19:23:02] rmoen: ok thanks [19:23:08] jdlrobson: https://phabricator.wikimedia.org/T103496 [19:23:51] jdlrobson: sorry, i'll get better about the browser tests, thanks for catching that [19:24:03] i need to get acquainted with barry [19:24:15] bmansurov: looks like she fixed the patchset after my review [19:24:18] would be great to look at that then [19:24:23] i'm looking at your search patch [19:24:26] have to use vagrant to test [19:24:29] ok [19:24:29] s will take a while [19:25:01] jdlrobson: i'll review it [19:26:51] jdlrobson: i'm not sure how to fix the browser tests.. Care to help me understand this stuff? [19:27:06] rmoen: so Barry is telling you which test is failed and on which line [19:27:10] yeah [19:27:19] i assume that it's just a case of changing some selectors [19:27:22] edit_collection.feature:17:28 [19:27:32] not sure what 17:28 means [19:27:38] could be line 17 or 28 ? [19:27:40] lol [19:27:46] so add @broken above Scenario: Changing description [19:27:51] then run locally the browser tests [19:27:55] cd tests/browser [19:28:03] bundle exec cucumber features/ --tags @broken [19:28:09] and you'll get a clearer idea what's going on [19:28:43] hmm ok. . does the 28 mean that Blank My description is broken also [19:28:48] ? [19:29:09] gonna try to run them locally [19:30:31] yup [19:30:36] i imagine it's the same issue [19:30:43] i bet you it is "I click to edit name and description" [19:30:43] niedzielski: sorry, i don't, but there's a good chance dbrant|food will know more. [19:30:51] ok, installing stuff [19:31:24] bmansurov: Object {query: Object} [19:31:26] in console [19:31:45] i'll remove it shortly [19:33:06] jdlrobson: so these browser tests don't run for me. They are opening browser to 127.0.0.1:8080 ... I don't have a webserver running there [19:33:20] want to google hangout? [19:33:24] same thing happens when i try to run the qunit tests [19:33:26] ok [19:34:26] bmansurov: https://phabricator.wikimedia.org/T103048 should be easy to fix up if you run out of things to do and should feel free :) [19:34:34] k [19:49:52] niedzielski: I'm going to create the partner list or a simple script on the GDrive [19:51:29] bearND: thanks! i know that the channel identifier changes but i think we also support app name and app package id changes and i don't know which need which [19:52:22] niedzielski: we don't really need the app id changes. No one uses it, which is good, since those would not get automatic updates from the Play Store [19:52:46] bearND: right, totally agree that app id changes are really bad [19:53:26] niedzielski: I've been thinking we could remove the support for it [19:54:06] bearND: i can phab it if you're officially in favor of it :) [19:54:40] niedzielski: go for it [19:54:49] bearND: ok will do! [19:56:52] niedzielski: are you able to reproduce the build failure with the --channel foo option? [19:57:20] bearND: yeah, there's one more patch that needs some upvotes [19:57:35] bearND: https://gerrit.wikimedia.org/r/#/c/220843/ [19:58:01] bearND: this one has already been merged https://gerrit.wikimedia.org/r/#/c/220844/ [19:58:13] https://gerrit.wikimedia.org/r/#/c/220627/3/resources/skins.minerva.tablet.beta.styles/common.less < bmansurov comment for you there [19:58:17] if you want to talk through it [19:58:27] niedzielski: ah, cool. Very nice! [19:58:48] pre-content post-content could be moved to the parent element [19:58:59] you might also want to move the refactorings into a separate patchset [19:59:16] but i dont mind either way [19:59:37] jdlrobson: ok, let me finish up what i'm working on, i'll take a look at it soon [20:09:19] have i ever told anyone how much i hate the alpha menu and the additional work it creates for us ? :) [20:10:26] "You shouldn't do this. The close icon in talk overlay is not aligned with the content for example." would be great to understand this baha.. i'm not seeing this problem [20:10:50] jdlrobson: i'll upload a screenshot [20:10:52] niedzielski: sent email about a script which builds all the apks. [20:11:06] thanks [20:12:25] jdlrobson: tests are running now locally. ;) yay [20:12:33] whats strange is the test that we tagged as @broken is passing [20:13:08] rmoen: oh really? on your patch? [20:13:14] try running all of those tests [20:13:19] ya [20:13:20] ok [20:13:21] e.g. ... features/edit_collection.feature [20:13:27] ok [20:13:55] bearND: sorry, but i'm not seeing the script. are you sure it's in the partners folder? [20:14:33] jdlrobson: http://imgur.com/dnVcnlI the icon and the content are not aligned [20:14:45] niedzielski: oh, shoot I need to sync my GDrive folder first [20:15:49] niedzielski: it should be available now. Try again [20:17:13] bearND: got 'em! [20:17:28] bearND: ok to make a patch later to put these in the repo? [20:17:41] jdlrobson: 4 scenarios ( 4 passed ) 37 steps ( 37 passed) 3m22.947s [20:17:48] could barry be wrong ? [20:18:13] Come to think of it he should be because i didn't change anything with the normal edit workflow except the delete button [20:18:22] no selectors changed [20:18:22] rmoen: maybe something slipped through the net [20:18:25] let me try locally [20:18:53] jdlrobson: wait.. [20:19:03] wrong patch [20:19:05] sorry [20:19:46] they pass with onboarding at least :) [20:19:51] bmansurov: they look aligned to me... what am i missing? the icon is center aligned [20:19:58] and it matches the text [20:20:00] so that's good [20:20:22] what does it look like on master? [20:20:35] rmoen: phew :) [20:20:47] jdlrobson: the content below the icon looks like it has a negative margin-left [20:21:04] jdlrobson: the content left should go as far as the icon [20:21:05] bmansurov: i'm really not seeing what you are seeing. A before and after screenshot would be helpful [20:21:25] what do you mean by content bmansurov [20:21:30] text or the left border? [20:21:34] both [20:21:38] that makes no sense [20:22:02] ahah, found it :) [20:22:19] jdlrobson: http://imgur.com/90zzOzW is master [20:22:29] jdlrobson: do you see the difference? [20:22:56] bearND: i don't suppose you'd mind +2ing this guy? https://gerrit.wikimedia.org/r/#/c/220843/ [20:23:13] not at all.. kaity which of these http://imgur.com/90zzOzW i and http://imgur.com/dnVcnlI is how the talk overlay should look? [20:23:31] (and can you notice any difference) [20:23:42] niedzielski: yes, will do in a bit [20:23:48] bearND: thanks! [20:24:16] * jdlrobson picks up https://phabricator.wikimedia.org/T103048 [20:24:30] yo [20:24:45] jdlrobson: thanks for reviewing bmansurov's patch [20:24:49] barry says it's green [20:25:04] if you've tested it locally (0, many, more, right?) then cool :) [20:25:14] niedzielski: let me also check if I can get TWN sync to work again. Having some issues with ssh / git permissions [20:25:15] (i'm still going to finish up setting up a new vagrant box) [20:25:36] jdlrobson: http://imgur.com/JTosYWD everything on the left of the line is the regression [20:25:55] bearND: sounds good. getting a last language update before release would be great! [20:27:12] bmansurov: i think this is being overly fussy to be honest (unless Kaity tells me otherwise). [20:27:29] i'm not seeing any glaring visual issues in either of the patches [20:27:44] phuedx: merged [20:27:49] jdlrobson: you're basically pushing content outside the container [20:27:51] also pm phuedx [20:28:12] everything should be contained in the container [20:28:13] jdlrobson: noted, ta [20:28:41] also phuedx how best to handle the search and discovery patch in future - it would have been good to have had a heads up about it in kick off [20:29:18] i think in this case it's just a link in search so pushing straight to stable is not the end of the world but it's not traditionally how we've rolled [20:29:51] ^ that and ^^ that [20:30:00] email on the 23rd followed by patch on 25th… [20:30:34] there was an email? :) i missed that [20:30:44] but in general what if there was a patch to overhaul search completely [20:30:54] would we require it to go through beta first? [20:31:06] yes, and a fair amount of discussion [20:31:20] jdlrobson: commented https://gerrit.wikimedia.org/r/#/c/220627/ [20:31:42] what would the overhaul be for, i.e. what is it supposed to enable and why wasn't that enabled in the first place etc etc [20:31:48] granted all of that could be done on a task [20:31:48] vibha: bearND - "Extract exact license info for share a fact cards" - https://phabricator.wikimedia.org/T101436 -- Share fact license info does not match to what is displayed in iOS Share fact :( [20:31:55] but i'd rather it not be a 10% project [20:32:22] vibha: bearND - pls, take a look at my comment on the ticket [20:32:29] jdlrobson: dr0ptp4kt forwarded an email from Deskana|Away from 23rd to the mailing list [20:32:34] etonkovidova: already commented on that ticket [20:32:44] oh forwarded mails... they're the worse :-/ [20:33:08] etonkovidova: you were tsalking about the license icons, right? [20:33:08] i usually ignore those since i figure they weren't originally meant to me. [20:33:23] jdlrobson: ok i believe to have wrapped both of my larger patches, both pass browser tests. Going for lunch [20:33:27] phuedx: so theoretical example - the search and discovery team wants to load full screen previews inside the search overlay when you click on an item [20:33:33] both are in code review column [20:33:53] thanks rmoen|lunch [20:33:55] enjoy! [20:34:02] traditionally we would do that sort of thing in beta, allow time for tweaking/testing/sign off and then push it to stable [20:34:04] jdlrobson: also thanks for schooling me on getting cucumber running [20:34:07] in this new world it's unclear [20:34:12] rmoen|lunch: np enjoy lunch! [20:34:12] phuedx: np [20:34:21] bearND: yes - thx! I wanted to make sure that it's known :) [20:34:27] jdlrobson: it's a brave new world [20:34:38] we'll figure it out [20:34:46] we've committed to process stuff next quarter [20:34:53] but there's nothing like a concrete example in code [20:34:54] it's not clear to me if there is an expectation that we will always use mobile beta / beta features for new developments or not. So it might be a good time to school product owners on expectations [20:35:00] agreed [20:35:26] but tbh i think rather than email we need this sort of stuff bubbled up in kick off meetings [20:35:33] there's no excuse then for being surprised :) [20:36:04] etonkovidova: the iOS guys have their onw story for this: https://phabricator.wikimedia.org/T101534 [20:36:41] rmoen|lunch: am taking a look at https://phabricator.wikimedia.org/T103213 [20:36:42] jdlrobson: agreed [20:37:10] but i'm fairly certain the email came /after/ the meeting [20:38:46] okie poke -- all caught up for tomorrow [20:38:54] i get time to code review and triage tomorrow! [20:38:55] woo! [20:39:09] but for now i'm done [20:39:13] gn y'all [20:39:26] night phuedx [20:39:30] jdlrobson: i'm going to run tests against https://gerrit.wikimedia.org/r/#/c/220816/2 first thing, then we're good [20:39:56] browser and qa-ish [20:55:24] if i search for "Lasagna" in the app, the #1 hit is Spaghetti code :) [20:57:37] * jdlrobson going to grab coffee. @rmoen|lunch will look at your patches first thing when i get back [21:03:26] kaldari: do you know who is the best person at WMF to ask about the font dimension aspect of the typography refresh debate? [21:03:55] which fonts have the same apparent size? [21:07:21] bearND dbrant: oof, it looks like there's a prod-only issue in the overflow menu. tapping it crashes the app :/ [21:07:43]