[00:37:45] (03PS1) 10Deskana: Add script to find undocumented translations. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185786 [00:38:37] aharoni: You might like this ^ [00:38:40] :-) [00:49:49] (03PS1) 10Deskana: Fix broken qq message. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185787 [01:07:05] (03PS1) 10Deskana: Add documentation for undocumented messages, and remove unused messages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185789 [01:08:01] (03CR) 10Deskana: [C: 032] "Trivial documentation fix" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185787 (owner: 10Deskana) [01:08:18] (03PS2) 10Deskana: Add script to find undocumented translations. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185786 [01:08:34] (03PS2) 10Deskana: Add documentation for undocumented messages, and remove unused messages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185789 [02:44:02] 3Mobile-Web: Closing mobile media viewer always scrolls to top on FF, IE - https://phabricator.wikimedia.org/T87156#985150 (10tstarling) [02:54:09] (03CR) 10Legoktm: Add script to find undocumented translations. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185786 (owner: 10Deskana) [08:01:03] 3Wikipedia-App-Android-App: Add an easier and faster way to change the SEARCH language - https://phabricator.wikimedia.org/T87154#985202 (10AlexLippert) [08:37:15] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/i-5XvQ [08:37:15] 13WikipediaMobile/06master 143ae3ef1 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [13:13:34] yo phuedx [13:14:02] (03PS1) 10Jhernandez: WIP: Add inline editing to Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 [13:14:11] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add inline editing to Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 (owner: 10Jhernandez) [13:17:58] (03PS3) 10Jhernandez: Improve wikidata infobox style and template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 [13:35:59] (03CR) 10Florianschmidtwelzow: WIP: Add inline editing to Infobox editing (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 (owner: 10Jhernandez) [13:39:37] (03CR) 10Jhernandez: WIP: Add inline editing to Infobox editing (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 (owner: 10Jhernandez) [13:46:00] (03PS2) 10Jhernandez: WIP: Add inline editing to Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 [13:47:28] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add inline editing to Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 (owner: 10Jhernandez) [13:52:08] (03CR) 10Florianschmidtwelzow: WIP: Add inline editing to Infobox editing (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185823 (owner: 10Jhernandez) [16:57:29] (03CR) 10Bmansurov: [C: 031] Replace zwnj in the footer with a nicer CSS solution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185659 (https://phabricator.wikimedia.org/T86281) (owner: 10Amire80) [17:00:33] (03CR) 10Bmansurov: [C: 032] Hygiene: add @see tag to jsduck [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184405 (owner: 10Florianschmidtwelzow) [17:02:32] (03Merged) 10jenkins-bot: Hygiene: add @see tag to jsduck [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184405 (owner: 10Florianschmidtwelzow) [17:15:19] (03CR) 10Bmansurov: [C: 032] Surface mobile special pages on desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185489 (https://phabricator.wikimedia.org/T66986) (owner: 10Jdlrobson) [17:17:54] (03Merged) 10jenkins-bot: Surface mobile special pages on desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185489 (https://phabricator.wikimedia.org/T66986) (owner: 10Jdlrobson) [17:38:51] (03PS21) 10Jdlrobson: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [17:43:52] (03CR) 10Jdlrobson: Recruit volunteers via the JavaScript console (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 (owner: 10Jdlrobson) [17:45:21] (03PS4) 10Jdlrobson: Recruit volunteers via the JavaScript console [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 [17:45:46] 3: Improve mobile uploads (tracking) - https://phabricator.wikimedia.org/T70376#985647 (10Jdlrobson) [17:45:47] 3Mobile-Web: "Desktop" in page footer of Special:Uploads returns Page unavailable - https://phabricator.wikimedia.org/T66986#985646 (10Jdlrobson) 5Open>3Resolved [17:56:11] (03CR) 10Bmansurov: [C: 031 V: 031] Recruit volunteers via the JavaScript console [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 (owner: 10Jdlrobson) [18:01:01] (03CR) 10Bmansurov: [C: 04-1] "dependency outdated" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185581 (owner: 10Jdlrobson) [18:06:55] (03CR) 10Bmansurov: [C: 032 V: 032] Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185561 (owner: 10Jdlrobson) [18:08:54] (03Merged) 10jenkins-bot: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185561 (owner: 10Jdlrobson) [18:09:40] (03PS2) 10Jdlrobson: Hygiene: Removing @inheritdoc, no parent function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari) [18:10:19] (03CR) 10Jdlrobson: Hygiene: Removing @inheritdoc, no parent function (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari) [18:11:06] (03CR) 10Jdlrobson: [C: 032] Replace zwnj in the footer with a nicer CSS solution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185659 (https://phabricator.wikimedia.org/T86281) (owner: 10Amire80) [18:11:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Removing @inheritdoc, no parent function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari) [18:13:40] (03Merged) 10jenkins-bot: Replace zwnj in the footer with a nicer CSS solution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185659 (https://phabricator.wikimedia.org/T86281) (owner: 10Amire80) [18:14:07] (03CR) 10Bmansurov: Promoting new table styles from beta to stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 (owner: 10Kaldari) [18:19:28] (03CR) 10Jdlrobson: [C: 04-1] Group categories to content based and administrational ones (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [18:28:59] (03CR) 10Florianschmidtwelzow: Infobox item editing using oojs-ui (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [18:30:35] (03CR) 10Jdlrobson: [C: 04-1] Promoting new table styles from beta to stable (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185564 (owner: 10Kaldari) [18:31:28] (03CR) 10Florianschmidtwelzow: "Otherwise looks good :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 (owner: 10Jdlrobson) [18:33:48] (03CR) 10Jdlrobson: Recruit volunteers via the JavaScript console (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 (owner: 10Jdlrobson) [18:34:45] (03CR) 10Jdlrobson: [C: 04-1] "you will need to document the parameters now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185590 (owner: 10Kaldari) [18:35:34] (03CR) 10Florianschmidtwelzow: [C: 031] Recruit volunteers via the JavaScript console (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185578 (owner: 10Jdlrobson) [18:39:09] hallo! [18:39:51] (03PS7) 10Bmansurov: Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) [18:44:21] 3MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), Mobile-Web, MediaWiki-User-login-and-signup: Captcha positioning is inconsistent between JavaScript and non-JavaScript users - https://phabricator.wikimedia.org/T85192#985674 (10Florian) [18:44:57] (03CR) 10Jdlrobson: [C: 04-1] "Selecting a category from the widget seems to add two categories for me..." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [18:47:22] (03CR) 10Jdlrobson: "In console: Uncaught TypeError: Cannot read property 'prop' of undefined" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [18:48:55] jdlrobson: bmansurov: hi guys [18:49:16] joakino: what up, dude? [18:49:38] bmansurov: here checking into the flight, suppershuttling, etc [18:49:42] how's the day [18:50:24] good, quiet [18:50:30] joakino: when will you arrive? [18:50:50] bmansurov: tomorrow at 4:35 to SFO [18:50:58] with sam [18:50:58] (03CR) 10Jdlrobson: [C: 04-1] "apart from that good to go" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [18:50:58] ooo, am? [18:51:00] and you? [18:51:11] bmansurov: pm [18:51:24] joakino: 2:10pm [18:51:29] also tomorrow [18:52:03] awesome [18:52:17] good flight joakino and phuedx :) [18:52:29] and bmansurov ;) [18:53:21] FlorianSW: when are you arriving? [18:54:04] 25. Jan 13:25, iirc [18:54:08] bmansurov: ^ [18:54:26] can't wait until 5 Jan :D [18:54:46] not much left [18:55:09] FlorianSW: awesome [18:55:31] 6 days :D [18:55:33] (03PS8) 10Bmansurov: Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) [18:57:28] FlorianSW: I'm also looking for that day. Arsenal are playing that day :P [18:57:39] *ward to [18:58:05] lol :P [19:03:38] (03CR) 10Florianschmidtwelzow: Group categories to content based and administrational ones (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [19:07:19] (03PS20) 10Florianschmidtwelzow: Add Possibility to add categories to a page using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [19:07:21] (03PS4) 10Florianschmidtwelzow: Group categories to content based and administrational ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) [19:08:28] (03PS8) 10Jdlrobson: Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 [19:09:14] (03CR) 10Jdlrobson: [C: 032] Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [19:09:53] bmansurov: you are an arsenal fan? [19:09:54] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Oops, there seems to be a problem, checking it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [19:10:08] * jdlrobson belatedly waves at joakino [19:10:24] jdlrobson: sup! [19:10:36] (03Merged) 10jenkins-bot: Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [19:10:47] you're at the airport? [19:12:40] 3Mobile-Web: modes.js should be moved into a Context.js to be consistent with PHP - https://phabricator.wikimedia.org/T85572#985679 (10Jdlrobson) 5Open>3Resolved [19:13:32] 3Mobile-Web, MediaWiki-extensions-Thanks, Continuous-Integration: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#985680 (10Jdlrobson) @MattFlaschen or @Kaldari can you merge that qunit patch? I'm keen to start having coverage for this asap. [19:13:51] jdlrobson: yep [19:14:39] 3Mobile-Web: Upload page-action button sometimes visible, sometimes not - https://phabricator.wikimedia.org/T87075#985683 (10Jdlrobson) Are you sure about this? Looks fine to me. Remember the uploads icon doesn't show on all pages, only pages which do not have a lead image. It is also dependent on the rights of... [19:15:15] (03PS21) 10Florianschmidtwelzow: Add Possibility to add categories to a page using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [19:15:33] 3Mobile-Web: Wikidata Infobox should properly format dates - https://phabricator.wikimedia.org/T85960#985685 (10Jdlrobson) 5Open>3Resolved [19:16:15] bmansurov: as a nottingham forest fan i somewhat understand the pain of your team. but good result at weekend :) [19:17:05] jdlrobson: yeah, i'm going to enjoy the result for a whole week ;) [19:18:03] 3Mobile-Web: Closing mobile media viewer always scrolls to top on FF, IE - https://phabricator.wikimedia.org/T87156#985687 (10Jdlrobson) This might be a generic problem with overlay scrolling. The same happens for the talk overlay. Can someone investigate and verify locally? We've done a bunch of refactoring so... [19:19:04] (03PS9) 10Jdlrobson: Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 [19:23:32] (03PS22) 10Florianschmidtwelzow: Add Possibility to add categories to a page using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [19:24:59] 3Mobile-Web: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#985690 (10bmansurov) I am not able to get visual editor working locally. I keep getting "Unknown dependency: jquery.uls.data" in the console. I have re-opened the existing bug on the VisualEditor project [1]. F... [19:25:08] 3Mobile-Web: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#985691 (10bmansurov) a:5bmansurov>3None [19:25:40] jdlrobson: can you check this and recommend? Should i go tube or go for the express? there is only 15 minutes difference https://www.google.co.uk/maps/dir/51.6515127,-0.2718883/Heathrow+Airport,+London+Borough+of+Hillingdon/@51.5603399,-0.4346748,11z/data=!4m13!4m12!1m1!4e1!1m5!1m1!1s0x48767234cdc56de9:0x8fe7535543f64167!2m2!1d-0.454296!2d51.470022!2m1!4e2!3e3!5i1 [19:25:50] * jdlrobson looks [19:26:11] sooo when i go to heathrow depends on how quickly i want to get there [19:26:45] wow Borehamwood [19:27:16] so yeh basically you can either get into london and take the piccadilly line all the way (will take a while) [19:27:40] or heathrow express it from paddington [19:28:02] (latter option prob also more $$$) [19:28:22] 15 mins now on the express? wow [19:28:28] jdlrobson: also express means 2 tube changes [19:28:38] picadilly is just train + tube [19:28:46] the piccadily line is super slow though [19:28:49] 15 minutes difference... i think i'm going tube [19:28:57] joakino: also more chance of delays [19:29:00] dangit [19:29:04] not helping xD [19:30:07] :-) [19:30:15] if i was in your situation i'd get to paddington [19:30:18] then relax [19:31:03] since work will pay for it i'm guessing? [19:31:12] airport transfer expense [19:31:54] jdlrobson: i think so [19:32:10] jdlrobson: so should i book the express in advance? [19:32:45] you seem to have convinced yourself :-) [19:33:06] joakino: up to you. you might arrive earlier than expected [19:33:23] i think you have to buy a ticket for exact train you get [19:33:28] to get cheap prices [19:33:50] the tube changes are minor and journeys are short from West Hampstead Thameslink, [19:34:04] it's just asked for the day [19:34:05] (03PS1) 10Bmansurov: Add border bottom to the last menu item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185847 (https://phabricator.wikimedia.org/T1160) [19:34:22] joakino: oh in that case go for it in advance [19:34:38] thx jdlrobson [19:35:39] 3Wikipedia-App-Android-App: Scroll position for image description is preserved while moving through images, hiding some of them - https://phabricator.wikimedia.org/T87191#985698 (10Pginer-WMF) 3NEW [19:36:03] (03CR) 10Jdlrobson: [C: 032] Add Possibility to add categories to a page using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [19:36:15] (03PS5) 10Jdlrobson: Group categories to content based and administrational ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [19:38:26] (03Merged) 10jenkins-bot: Add Possibility to add categories to a page using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [19:41:07] 3Mobile-Web: Overlay and Drawer should use events property for its event bindings - https://phabricator.wikimedia.org/T87192#985705 (10Jdlrobson) 3NEW [19:42:34] 3Mobile-Web: EditorOverlays should use events property for their event bindings - https://phabricator.wikimedia.org/T87193#985713 (10Jdlrobson) 3NEW [19:43:01] 3Mobile-Web: Wikigrok and infobox dialogs should use events property to define their events - https://phabricator.wikimedia.org/T87194#985721 (10Jdlrobson) 3NEW [19:47:05] (03CR) 10Jdlrobson: [C: 04-1] "rendering issues http://imgur.com/83FxrcH" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [19:52:41] 3Wikipedia-App-Android-App: Scroll position for image description is preserved while moving through images, hiding some of them - https://phabricator.wikimedia.org/T87191#985738 (10Deskana) This may be related to T86577. [19:52:53] (03CR) 10BearND: "Thanks for the links, Legoktm!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185786 (owner: 10Deskana) [19:53:31] (03PS3) 10BearND: Add script to find undocumented translations. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185786 (owner: 10Deskana) [19:55:32] (03CR) 10Deskana: [C: 031] "I tested the script and verified that it can be run from any location now. Sweet!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185786 (owner: 10Deskana) [20:07:18] (03PS1) 10Jdlrobson: Hygiene: UploadTutorial should use events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185849 [20:07:20] (03PS1) 10Jdlrobson: WIP: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 [20:07:51] (03CR) 10Jdlrobson: [C: 032] Add border bottom to the last menu item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185847 (https://phabricator.wikimedia.org/T1160) (owner: 10Bmansurov) [20:08:41] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix UploadTutorial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185850 (owner: 10Jdlrobson) [20:08:47] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: UploadTutorial should use events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185849 (owner: 10Jdlrobson) [20:09:50] (03CR) 10Florianschmidtwelzow: Group categories to content based and administrational ones (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [20:09:55] (03PS4) 10Jdlrobson: Hygiene: Kill obsolete profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 (owner: 10MaxSem) [20:10:04] (03PS4) 10BearND: Add script to find undocumented translations. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185786 (owner: 10Deskana) [20:10:13] (03CR) 10Jdlrobson: [C: 032] "^ that wasn't hard hmm?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 (owner: 10MaxSem) [20:10:15] (03CR) 10BearND: [C: 032] Add script to find undocumented translations. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185786 (owner: 10Deskana) [20:10:39] (03PS4) 10Jdlrobson: Improve wikidata infobox style and template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185164 (owner: 10Jhernandez) [20:11:29] (03Merged) 10jenkins-bot: Add border bottom to the last menu item [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185847 (https://phabricator.wikimedia.org/T1160) (owner: 10Bmansurov) [20:11:51] (03Merged) 10jenkins-bot: Add script to find undocumented translations. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185786 (owner: 10Deskana) [20:11:54] (03Merged) 10jenkins-bot: Hygiene: Kill obsolete profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 (owner: 10MaxSem) [20:12:14] 3Mobile-Web: In mobile sidebar, last item border styling is inconsistent - https://phabricator.wikimedia.org/T1160#985767 (10Jdlrobson) 5Open>3Resolved [20:18:19] 3Mobile-Web: Some galleries still not rendering correctly - https://phabricator.wikimedia.org/T87198#985771 (10Jdlrobson) 3NEW [20:18:45] 3Mobile-Web: Some galleries still not rendering correctly on mobile - https://phabricator.wikimedia.org/T87198#985779 (10Jdlrobson) [20:23:57] (03CR) 10Jdlrobson: Group categories to content based and administrational ones (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [20:24:53] (03CR) 10BearND: [C: 04-1] "See inline comments." (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185789 (owner: 10Deskana) [20:25:19] Heading for lunch! [20:28:24] (03PS1) 10BearND: Fix tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185851 [20:33:11] 3MediaWiki-extensions-PageImages, Wikipedia-App-Android-App: an irrelevant image is shown as the header for Hebrew Wikipedia articles about cities in Israel - https://phabricator.wikimedia.org/T87153#985799 (10eranroz) Added the file to https://he.wikipedia.org/wiki/MediaWiki:Pageimages-blacklist (need to wait f... [21:06:31] (03PS1) 10Bmansurov: Enable strict mode in javascript files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185908 (https://phabricator.wikimedia.org/T86231) [21:06:57] 3Mobile-Web: Use strict mode in javascript files - https://phabricator.wikimedia.org/T86231#985834 (10bmansurov) a:3bmansurov [21:07:46] (03CR) 10Jdlrobson: [C: 04-1] "it would be better to force this via a ResourceLoaderModule that way we don't have to repeat ourselves all the time...might be a good feat" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185908 (https://phabricator.wikimedia.org/T86231) (owner: 10Bmansurov) [21:08:05] (03CR) 10jenkins-bot: [V: 04-1] Enable strict mode in javascript files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185908 (https://phabricator.wikimedia.org/T86231) (owner: 10Bmansurov) [21:08:19] (03CR) 10Jdlrobson: "(or if we do it this way we should update jshint)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185908 (https://phabricator.wikimedia.org/T86231) (owner: 10Bmansurov) [21:08:51] (03CR) 10Bmansurov: "jshint already picks up strict mode" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185908 (https://phabricator.wikimedia.org/T86231) (owner: 10Bmansurov) [21:09:10] (03PS3) 10Jdlrobson: Allow other token types with foreign api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185581 [21:10:06] (03CR) 10Jdlrobson: "@Bmansurov tip - hit rebase to update dependencies automatically. Only hit -1 if this cannot happen (-1s are sticky so put people off from" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185581 (owner: 10Jdlrobson) [21:11:40] (03CR) 10Florianschmidtwelzow: Group categories to content based and administrational ones (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [21:12:22] (03PS6) 10Florianschmidtwelzow: Group categories to content based and administrational ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) [21:12:28] (03CR) 10jenkins-bot: [V: 04-1] Group categories to content based and administrational ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [21:15:33] (03PS7) 10Florianschmidtwelzow: Group categories to content based and administrational ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) [21:36:25] (03PS3) 10Deskana: Add documentation for undocumented messages, and remove unused messages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/185789 [21:51:39] 3Mobile-Web: Log common JavaScript exceptions - https://phabricator.wikimedia.org/T77931#985874 (10bmansurov) Assuming an exception renders the page unusable, it may be a good idea to who the user an overlay form with the exception message and encourage the user to submit the error. [21:53:17] 3Mobile-Web: mw.mobileFrontend should have a minimal amount of methods - https://phabricator.wikimedia.org/T86245#985875 (10bmansurov) [22:04:32] 3Mobile-Web: Move overlayManager and router as defined modules using M.define - https://phabricator.wikimedia.org/T86246#985884 (10bmansurov) a:3bmansurov [22:05:49] 3Mobile-Web: mw.mobileFrontend should have a minimal amount of methods - https://phabricator.wikimedia.org/T86245#985888 (10Jdlrobson) [22:07:18] 3Mobile-Web: mw.mobileFrontend should have a minimal amount of methods - https://phabricator.wikimedia.org/T86245#964395 (10Jdlrobson) [22:08:13] (03Abandoned) 10Jdlrobson: WIP: Refactor: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 (owner: 10Jdlrobson) [22:09:03] (03PS1) 10Jdlrobson: Hygiene: Address LanguageOverlay FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185919 [22:09:05] (03PS1) 10Jdlrobson: Alpha: Read in another project overlay button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185920 [22:09:14] (03PS2) 10Jdlrobson: Hygiene: Address LanguageOverlay FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185919 [22:09:23] (03PS2) 10Jdlrobson: Alpha: Read in another project overlay button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185920 [22:09:42] bmansurov: can you remove your -1 on https://gerrit.wikimedia.org/r/#/c/185581/ ? [22:09:46] see my comment [22:10:01] (03CR) 10Bmansurov: Allow other token types with foreign api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185581 (owner: 10Jdlrobson) [22:10:08] thanks. [22:10:10] np [22:12:08] (03PS2) 10Jdlrobson: Hygiene: UploadTutorial should use events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185849 [22:13:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: UploadTutorial should use events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185849 (owner: 10Jdlrobson) [22:17:55] (03PS3) 10Jdlrobson: Hygiene: UploadTutorial should use events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185849 [22:19:48] (03PS1) 10Bmansurov: Define router and overlayManager outside M [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185922 (https://phabricator.wikimedia.org/T86246) [22:21:34] (03CR) 10jenkins-bot: [V: 04-1] Define router and overlayManager outside M [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185922 (https://phabricator.wikimedia.org/T86246) (owner: 10Bmansurov) [22:22:55] (03CR) 10Bmansurov: [C: 032] Hygiene: Address LanguageOverlay FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185919 (owner: 10Jdlrobson) [22:23:50] (03CR) 10Jdlrobson: [C: 04-1] Define router and overlayManager outside M (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185922 (https://phabricator.wikimedia.org/T86246) (owner: 10Bmansurov) [22:24:13] (03Merged) 10jenkins-bot: Hygiene: Address LanguageOverlay FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185919 (owner: 10Jdlrobson) [22:27:50] (03CR) 10Bmansurov: Hygiene: UploadTutorial should use events map (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185849 (owner: 10Jdlrobson) [22:30:52] (03PS2) 10Bmansurov: Define router and overlayManager outside M [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185922 (https://phabricator.wikimedia.org/T86246) [22:32:56] (03CR) 10Jdlrobson: [C: 032] Group categories to content based and administrational ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [22:33:08] 3Mobile-Web: Category overlay should separate content categories from adminstration categories - https://phabricator.wikimedia.org/T86496#985924 (10Jdlrobson) 5Open>3Resolved [22:34:18] (03Merged) 10jenkins-bot: Group categories to content based and administrational ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185229 (https://phabricator.wikimedia.org/T86496) (owner: 10Florianschmidtwelzow) [22:36:19] (03CR) 10Bmansurov: [C: 032] Allow other token types with foreign api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185581 (owner: 10Jdlrobson) [22:38:58] 3Wikipedia-App-Android-App: Disable autocorrect on the username entry field - https://phabricator.wikimedia.org/T87208#985940 (10ori) 3NEW [22:41:31] 3Mobile-Web: EditorOverlays should use events property for their event bindings - https://phabricator.wikimedia.org/T87193#985954 (10bmansurov) a:3bmansurov [22:45:45] (03CR) 10Jdlrobson: "Rob I think you forgot to post the new version?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (https://phabricator.wikimedia.org/T87050) (owner: 10Robmoen) [22:49:12] 3Wikipedia-App-Android-App: Disable autocorrect on the username entry field - https://phabricator.wikimedia.org/T87208#985960 (10Deskana) Looking at the XML that defines the username field, it's correctly set to not provide suggestions (i.e. android:inputType="textNoSuggestions"). I'm unable to reproduce this is... [22:49:42] (03CR) 10Jdlrobson: [C: 032] Define router and overlayManager outside M [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185922 (https://phabricator.wikimedia.org/T86246) (owner: 10Bmansurov) [22:52:56] (03Merged) 10jenkins-bot: Define router and overlayManager outside M [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185922 (https://phabricator.wikimedia.org/T86246) (owner: 10Bmansurov) [23:10:31] (03PS1) 10Bmansurov: Use events map in overlay files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/185929 (https://phabricator.wikimedia.org/T87193) [23:11:35] 3Mobile-Web: Move overlayManager and router as defined modules using M.define - https://phabricator.wikimedia.org/T86246#985975 (10Jdlrobson) 5Open>3Resolved [23:11:36] 3Mobile-Web: mw.mobileFrontend should have a minimal amount of methods - https://phabricator.wikimedia.org/T86245#985976 (10Jdlrobson)