[07:19:17] morning! [07:33:11] (03CR) 10Jhernandez: [C: 031] "What do you mean bmansurov?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez) [07:43:52] (03CR) 10Jhernandez: [C: 032] Move M.isIos to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 (owner: 10Jdlrobson) [07:45:37] (03Merged) 10jenkins-bot: Move M.isIos to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 (owner: 10Jdlrobson) [08:30:56] (03CR) 10Jhernandez: "Created a task for tracking this issue and discuss a bit more:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 (owner: 10Jhernandez) [09:33:07] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove redundant returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181099 (owner: 10Jdlrobson) [09:33:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove redundant returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181099 (owner: 10Jdlrobson) [09:48:45] (03PS2) 10Jhernandez: Hygiene: Remove redundant returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181099 (owner: 10Jdlrobson) [09:49:17] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove redundant returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181099 (owner: 10Jdlrobson) [09:52:06] (03Merged) 10jenkins-bot: Hygiene: Remove redundant returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181099 (owner: 10Jdlrobson) [11:01:13] (03PS1) 10Jhernandez: Memoize results of the browser.js methods. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 [11:01:19] (03CR) 10jenkins-bot: [V: 04-1] Memoize results of the browser.js methods. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 (owner: 10Jhernandez) [11:05:37] (03PS7) 10Jhernandez: Hygiene: Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 [11:05:39] (03PS2) 10Jhernandez: Memoize results of the browser.js methods. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 [13:24:24] 3MobileFrontend-alpha, Mobile-Web: Return of the icon alpha chaos - https://phabricator.wikimedia.org/T85044#939666 (10Florian) Hmm, i can't replicate it in Chrome and firefox alpha :/ [13:30:19] (03PS2) 10Esanders: Redo VE toolbar styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 [13:30:21] (03PS2) 10Esanders: Minor updates to VE integration code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181376 [13:32:11] (03CR) 10Esanders: "I've done a cleanup of the CSS hacks in Ifa646fe3 based on the new MW theme. If you merge that first you can abandon this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181215 (owner: 10Bartosz Dziewoński) [13:46:17] (03CR) 10Florianschmidtwelzow: [C: 031] Ensure file page mobile views have the proper title in context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181178 (owner: 10MaxSem) [13:49:54] (03CR) 10Florianschmidtwelzow: [C: 031] Remove old b/c code not needed since late summer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181212 (owner: 10MaxSem) [13:51:03] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: phpdoc comments, unused variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181213 (owner: 10MaxSem) [14:06:32] (03PS1) 10Florianschmidtwelzow: Don't add VisualEditor related modules if VE isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181403 [14:15:08] (03PS3) 10Esanders: Redo VE toolbar styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 [14:15:10] (03PS3) 10Esanders: Minor updates to VE integration code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181376 [16:57:01] (03CR) 10Bmansurov: "Isn't browser.js loaded on every page load? If so, then adding code that's not used everywhere to it is not reasonable. We should maybe cr" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez) [17:07:12] (03CR) 10Bmansurov: Memoize results of the browser.js methods. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 (owner: 10Jhernandez) [17:09:52] (03CR) 10Bmansurov: [C: 031] Don't add VisualEditor related modules if VE isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181403 (owner: 10Florianschmidtwelzow) [17:15:26] (03CR) 10Bmansurov: [C: 031] Remove images from infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181197 (owner: 10Jdlrobson) [18:02:31] Maryana, where's everyone? [18:04:12] phuedx: standup? [18:04:31] phuedx: https://plus.google.com/hangouts/_/calendar/d2lraW1lZGlhLm9yZ19yMWNvaHVib3JmYjlqcWMydHA0bmwxcXMxZ0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t.abvfhue9msa07tgt4d9v4s0u1g?authuser=0 [18:16:36] (03CR) 10Kaldari: [C: 032] Include the campaign property's Wikidata label [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 (owner: 10Phuedx) [18:17:17] (03Merged) 10jenkins-bot: Include the campaign property's Wikidata label [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 (owner: 10Phuedx) [18:17:53] MaxSem: Submitted this minor patch a while back, but I don't think anyone's looked at it: https://gerrit.wikimedia.org/r/#/c/179985/ [18:18:24] looking [18:24:25] (03CR) 10Jdlrobson: [C: 04-1] Don't add VisualEditor related modules if VE isn't installed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181403 (owner: 10Florianschmidtwelzow) [18:24:58] (03CR) 10Jdlrobson: [C: 032] Remove old b/c code not needed since late summer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181212 (owner: 10MaxSem) [18:26:28] (03Merged) 10jenkins-bot: Remove old b/c code not needed since late summer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181212 (owner: 10MaxSem) [18:27:04] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: phpdoc comments, unused variables (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181213 (owner: 10MaxSem) [18:27:16] (03CR) 10MaxSem: [C: 032] Make sure campaign data isn't set to false [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/179985 (owner: 10Kaldari) [18:27:45] (03Merged) 10jenkins-bot: Make sure campaign data isn't set to false [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/179985 (owner: 10Kaldari) [18:28:41] Maryana: do we want to create a new trello board for unstructured sprint [18:28:46] or do we not care about what happens to our velocity? [18:29:07] nah, we know velocity will be all screwy [18:29:17] but if it helps you keep your work in order, go for it :) [18:30:15] (03CR) 10Florianschmidtwelzow: Don't add VisualEditor related modules if VE isn't installed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181403 (owner: 10Florianschmidtwelzow) [18:31:04] (03CR) 10Jdlrobson: [C: 031] Redo VE toolbar styling (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders) [18:31:52] (03CR) 10Jdlrobson: [C: 031] "untested. Anyone should feel free to merge once verified." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181376 (owner: 10Esanders) [18:33:03] (03CR) 10Kaldari: [C: 032] Remove images from infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181197 (owner: 10Jdlrobson) [18:35:25] (03PS4) 10Brion VIBBER: Merging MWKArticle and MWKArticleStore into one object [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 [18:37:00] (03CR) 10Kaldari: [C: 032] i18n/Hygiene: Use Wikibase for infobox labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181196 (owner: 10Jdlrobson) [18:40:24] (03Merged) 10jenkins-bot: i18n/Hygiene: Use Wikibase for infobox labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181196 (owner: 10Jdlrobson) [18:40:30] (03Merged) 10jenkins-bot: Remove images from infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181197 (owner: 10Jdlrobson) [18:43:15] (03CR) 10Jdlrobson: [C: 032] Ensure file page mobile views have the proper title in context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181178 (owner: 10MaxSem) [18:44:35] (03Merged) 10jenkins-bot: Ensure file page mobile views have the proper title in context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181178 (owner: 10MaxSem) [18:45:11] (03PS5) 10Brion VIBBER: Merging MWKArticle and MWKArticleStore into one object [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 [18:45:58] 3Mobile-Web, Wikipedia-App-Android-App, MediaWiki-API: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#940234 (10Deskana) 5Open>3Resolved a:3Deskana Resolved. Just have to wait for this to go live now. [18:54:31] (03PS6) 10Brion VIBBER: Merging MWKArticle and MWKArticleStore into one object [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 [18:57:14] kaldari: 'grok responses shared w/you :) [18:57:23] Maryana: thanks [19:03:00] (03CR) 10Jdlrobson: [C: 032] "Baha. I agree on principle, especially given that uploads is currently disabled on all pages but since we don't have a deployment till Jan" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez) [19:05:04] (03Merged) 10jenkins-bot: Hygiene: Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez) [19:05:43] (03CR) 10Jdlrobson: [C: 04-1] Memoize results of the browser.js methods. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 (owner: 10Jhernandez) [19:07:41] (03PS1) 10Deskana: Don't transmit search results events in TitleSearchFragment funnel. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181429 [19:14:02] Maryana: If it isn't clear if a WikiGrok response is correct or not, should I just put a '?'? [19:14:10] sure [19:14:14] (03CR) 10Bmansurov: "I suggest creating a browser module, not just a file, but a folder with the main file that loads on all pages and separate files with diff" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez) [19:14:32] kaldari: some of them are pretty tricky [19:16:33] kaldari: wait, i'm confused -- for event_response, some are null and some are o [19:16:43] what does that mean? [19:17:00] some are o? [19:17:04] err, zero [19:17:06] kaldari, jdlrobson so I'm working on a script that detects anomalies and sends emails when it does so. What email account can I use for sending emails? Any suggestions? [19:17:41] Maryana: 0 means false, 1 mean true, and null is ambiguous (so we don't need to score those) [19:17:50] ah, ok [19:18:12] should i just cut them from the dataset, kaldari ? [19:18:18] Maryana: You might even want to remove them from the dataset [19:18:22] jinx [19:18:23] :) [19:18:24] :) [19:18:25] k, i'll do that [19:20:06] (03PS1) 10Kaldari: Fixes to neglected Mobile upload interface (for 3rd parties) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181430 [19:24:39] (03CR) 10Jdlrobson: [C: 04-1] "A few concerns:" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [19:31:18] jdlrobson: You keep +2ing right before me! [19:31:19] :) [19:31:30] what did i +2? [19:31:54] bmansurov: use your own one for time being. We can also try mobile-tech in future [19:32:17] bmansurov: can you manually add multiple recipients for time being e.g. kaldari, myself and you [19:32:28] jdlrobson: ok [19:37:45] kaldari: i'm going to guess that all these wolf city responses are from you and not some other secret krautrock enthusiast ;) [19:37:57] 3Mobile-Web, MobileFrontend-alpha: Return of the icon alpha chaos - https://phabricator.wikimedia.org/T85044#940316 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson I was running an old version of core. My bad! Sorry. [19:37:58] Maryana: guilty [19:43:40] 3Mobile-Web, MobileFrontend-alpha: Return of the icon alpha chaos - https://phabricator.wikimedia.org/T85044#940320 (10Florian) > My bad! Sorry The main thing is, that it isn't a bug :) Better to open one bug report more as one to few :) [19:44:20] bmansurov: I set $wgMFEnableWikiGrokInSidebar = true, but still don't see anything in the sidebar. Is there something else I need to do? [19:45:16] kaldari: that and all the requirements for wikigrok, such as being logged in, etc. [19:45:37] oh, only alpha [19:46:23] kaldari: https://gerrit.wikimedia.org/r/#/c/179367/22/includes/skins/SkinMinervaAlpha.php [19:47:47] bmansurov: Ah! :) [19:48:14] bmansurov: I should have thought of that :) [19:52:44] 3MobileFrontend-Uploads: Improve mobile uploads (tracking) - https://phabricator.wikimedia.org/T70376#940358 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Doesn't seem like a useful tracking bug any more now the feature is disabled. (Does anyone disagree?) [19:53:22] (03PS2) 10Jdlrobson: Fixes to neglected Mobile upload interface (for 3rd parties) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181430 (owner: 10Kaldari) [19:53:43] (03CR) 10Jdlrobson: [C: 032] Fixes to neglected Mobile upload interface (for 3rd parties) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181430 (owner: 10Kaldari) [19:56:12] (03PS2) 10Jdlrobson: Hygiene: check types are valid in jsdocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181101 [19:56:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: check types are valid in jsdocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181101 (owner: 10Jdlrobson) [19:56:34] (03PS2) 10Jdlrobson: Hygiene: check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181100 [19:57:44] (03Merged) 10jenkins-bot: Fixes to neglected Mobile upload interface (for 3rd parties) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181430 (owner: 10Kaldari) [19:57:51] (03PS3) 10Jdlrobson: Hygiene: check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181100 [19:58:09] 3MobileFrontend-Uploads: Special:Uploads button not centered - https://phabricator.wikimedia.org/T74972#940368 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [19:59:01] (03CR) 10Jdlrobson: [C: 032] "Max says this is okay :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 (owner: 10Florianschmidtwelzow) [19:59:07] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move anonymousEditing config to EditorOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 (owner: 10Florianschmidtwelzow) [19:59:54] (03CR) 10Jdlrobson: Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [20:05:24] (03PS3) 10Florianschmidtwelzow: Hygiene: Move anonymousEditing config to EditorOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 [20:09:59] (03CR) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [20:14:05] (03PS7) 10Brion VIBBER: Merging MWKArticle and MWKArticleStore into one object [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 [20:19:20] (03PS8) 10Brion VIBBER: Merging MWKArticle and MWKArticleStore into one object [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 [20:21:49] (03PS9) 10Brion VIBBER: Merging MWKArticle and MWKArticleStore into one object [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 [20:27:05] (03PS1) 10Deskana: Some tweaks to image sharing functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181440 [21:03:41] (03CR) 10Mhurd: [C: 032 V: 032] "Yup. Good stuff." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 (owner: 10Brion VIBBER) [21:08:00] Deskana: i think we’re just gonna stay on 3rd floor [21:09:23] mhurd: Okay! [21:12:59] mhurd: Let me know if you need anything and I'll get it for you. :) [21:13:06] brion: ^ [21:13:09] Deskana: will do! thanks! [21:13:49] a bowl of only green m&ms, a juicer, and a parrot. [21:13:52] kaldari: let me know when you have few min. I'd like to run few things with you. [21:14:17] * Deskana sighs. [21:14:33] so i’ve got it saving scroll position across back/forward but it resets to 0 on restart. wtf [21:14:40] http://www.amazon.com/Green-Chocolate-Ms-Candy-Pound/dp/B004XRJ5R0/ref=sr_1_2?ie=UTF8&qid=1419282868&sr=8-2&keywords=green+m%26m [21:14:53] http://www.amazon.com/Black-Decker-JE2200B-Vegetable-Extractor/dp/B003ZDNKSS/ref=sr_1_1?s=kitchen&ie=UTF8&qid=1419282887&sr=1-1&keywords=juicer [21:15:09] wow that’s almost as cool as bulk-ordering certain legos [21:15:34] Amazon doesn't sell parrots, but there is a toy one on Erik's desk. [21:16:05] when we had Richard Stallman speak at Wikimania Frankfurt in ’05 he apparently had a list of demands [21:16:08] including a parrot [21:16:21] i’m not certain about the parrot [21:16:36] like was it for companionship or dinner? :-O [21:16:51] :O [21:17:06] are… are they tasty? [21:18:13] * brion assumes rms eats baby parrots FOR OUR FREEDOM [21:30:10] His demands are legendary. [21:30:36] he does brion [21:30:41] seen live [21:30:56] (03CR) 10Jdlrobson: [C: 032] Hygiene: Move anonymousEditing config to EditorOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 (owner: 10Florianschmidtwelzow) [21:32:54] (03PS1) 10Brion VIBBER: Fix for market build not remembering scroll position. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181444 [21:32:56] (03PS1) 10Brion VIBBER: Fix for new build not remembering scroll position! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181445 [21:33:30] (03CR) 10Brion VIBBER: "cherry-picked from https://github.com/montehurd/apps-ios-wikipedia/commit/9f93b26d9e13a0bf65ff13e71477ff69c2cd5eb6" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181444 (owner: 10Brion VIBBER) [21:33:44] (03Merged) 10jenkins-bot: Hygiene: Move anonymousEditing config to EditorOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 (owner: 10Florianschmidtwelzow) [21:33:48] (03CR) 10Brion VIBBER: "Adjusted to make sure save is correct, and added back delay on scroll cause something's out of sync" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181445 (owner: 10Brion VIBBER) [21:34:11] (03PS2) 10Brion VIBBER: Add X-WMF-UUID to Wikipedia for iOS requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/180846 (owner: 10Dr0ptp4kt) [21:34:15] 3Mobile-Web, MobileFrontend-stable: Text does not appear in the place of icons when images are disabled - https://phabricator.wikimedia.org/T69726#940576 (10Jdlrobson) Actually this is also the case in stable since they use the Icon class. Is there anything more we want to do here? e.g. detect when images are d... [21:35:57] (03CR) 10Jdlrobson: [C: 04-1] "So I tested this and there is a slight visual regression with the cite menu:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders) [21:36:30] (03CR) 10Brion VIBBER: [C: 032] "looks sane enough?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/180846 (owner: 10Dr0ptp4kt) [21:38:16] (03CR) 10Jdlrobson: [C: 032] VisualEditorOverlay: Update for Idc299e23 in OOUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181215 (owner: 10Bartosz Dziewoński) [21:39:12] (03PS4) 10Jdlrobson: Minor updates to VE integration code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181376 (owner: 10Esanders) [21:40:04] (03CR) 10Jdlrobson: [C: 032] Minor updates to VE integration code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181376 (owner: 10Esanders) [21:40:58] (03Merged) 10jenkins-bot: VisualEditorOverlay: Update for Idc299e23 in OOUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181215 (owner: 10Bartosz Dziewoński) [21:41:43] (03Merged) 10jenkins-bot: Minor updates to VE integration code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181376 (owner: 10Esanders) [21:49:15] MaxSem: Do you know of any reason why MediaWiki doesn't provide an option to vewi SVGs as SVGs? [21:49:23] vewi = view [21:49:48] internet crapsplorer? [21:50:10] ugh one finger typing [21:50:56] Well, all the IEs after IE8 support SVG rendering, so it seems like it should at least be a preference or a detected fallback at this point. [21:51:40] MaxSem: I'll send an email to wikitech-l unless you know some obvious reason it wouldn't be a good idea. [21:51:50] for svgs in page text you would need to vary parser cache [21:52:09] mhurd: let me know if you would like to move todays 1:1 so that you and brion can have the whole afternoon un-interrupted [21:52:14] also, some svgs are huge but are used as tiny thumbs [21:52:22] kaldari, ^^^ [21:52:57] you don't want to download a 500k mexican flag for a 20px flagicon [21:53:18] MaxSem: oh yeah. Fuckin flagicons!!! [21:53:22] :( [21:54:17] MaxSem: We could always set a size threshold for those [21:59:51] kaldari: yeah lots of svgs in use for maps and flags and such are overdetailed and they’re pretty huge [21:59:57] some can be slow to render in browser too [22:00:07] prerendering them to PNG speeds them up and reduces bandwidth [22:00:08] tfinc: oh, yes, that would be helpful :) [22:00:29] also browsers have slight differences in rendering and it complicates the text/font support story [22:00:51] it’s not impossible to resolve it’ll just take some detection, fallback logic, and a lot of q&a [22:00:59] and maybe filtering down giant files to smaller ones :P [22:01:10] brion: would there be any downside to having an option in the [[File:]] syntax to not rasterize an SVG, for example if it was an animation or interactive? [22:01:32] well, interactive stuff usually doesn’t work in reliably iirc [22:01:39] so i’m not sure if that’d need additional work [22:01:46] another problem is standard conformance that's not perfect among browser park [22:01:49] but that’s something to consider yeah [22:02:22] i want to find some time later to work on more interactive stuff that’s probably going to need more live JS, that’ll be more complicated than dropping SVG into an [22:02:34] (03PS2) 10Mhurd: Fix for market build not remembering scroll position. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181444 (owner: 10Brion VIBBER) [22:02:44] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181444 (owner: 10Brion VIBBER) [22:02:57] (03PS2) 10Mhurd: Fix for new build not remembering scroll position! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181445 (owner: 10Brion VIBBER) [22:03:00] whee [22:03:07] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181445 (owner: 10Brion VIBBER) [22:06:58] (03CR) 10Nuria: "Analytics team respectfully requests that if user has opted out of sending data this header is not sent." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/180846 (owner: 10Dr0ptp4kt) [22:08:37] MaxSem: maybe it's something you could think about while your arm is healing :) [22:10:05] (03CR) 10Nuria: "Analytics team respectfully requests that if the user has opted out from sending data this header is not sent" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180868 (owner: 10Dr0ptp4kt) [22:13:49] (03PS1) 10Mhurd: Made article fetch manager use default serializer. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181518 [22:14:06] brion: ^ [22:15:11] whee [22:17:25] brion: that patch didn’t do any of the “savethumbnailfetcher” re-organizing we talked about - doing that as separate commit [22:17:49] ok [22:55:35] (03CR) 10Kaldari: [C: 04-1] Alpha: WikiGrok in sidebar (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [23:02:59] (03CR) 10Kaldari: "When I submit an answer, I see the thanks screen for a split second before it goes to the next page. We should probably suppress the Thank" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [23:03:49] (03PS2) 10Jdlrobson: WIP Untested Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 [23:04:35] (03PS3) 10Jdlrobson: Hygiene: check types are valid in jsdocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181101 [23:05:30] (03CR) 10jenkins-bot: [V: 04-1] WIP Untested Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson) [23:05:43] jdlrobson: posted a question for you in the comments at https://gerrit.wikimedia.org/r/#/c/179367/ [23:09:16] (03CR) 10Kaldari: "Talked to Jon. He wasn't suggesting using the OverlayManager so the back/forward behavior wouldn't be an issue. The advantage would just b" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [23:40:44] 3Wikipedia-App-Android-App: IllegalStateException: Can not perform this action after onSaveInstanceState - https://phabricator.wikimedia.org/T75237#940918 (10Krenair) New one (2.0-beta-2014-12-19): https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8037455 [23:41:57] chromium bug? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8037134 [23:42:26] (03PS1) 10Brion VIBBER: Move old CoreData stuff to separate project library [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181525 [23:44:42] (03CR) 10Brion VIBBER: [C: 032] "looks ok" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181518 (owner: 10Mhurd) [23:45:29] (03CR) 10Brion VIBBER: "Migration to come in next few days. May need to slightly tweak the subproject but this starts it off." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181525 (owner: 10Brion VIBBER) [23:47:19] (03PS1) 10Jdlrobson: Prevent asynchronous event logging events in qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181526 [23:47:29] ^ kaldari that might solve our jenkins woes [23:47:49] oh goody! [23:49:32] testing it now [23:51:12] (03CR) 10Kaldari: [C: 032] Prevent asynchronous event logging events in qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181526 (owner: 10Jdlrobson) [23:52:32] (03Merged) 10jenkins-bot: Prevent asynchronous event logging events in qunit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181526 (owner: 10Jdlrobson) [23:55:09] Maryana: So for the 'correct' column I assume we're entering whether or not the user's response is correct, not whether or not the claim should be correct, right? [23:55:27] right :) [23:55:45] just wanted to double-check :) [23:55:45] y'all are slow. i've done ~200 of these already :D [23:56:03] looking like around 70% accuracy rate [23:57:43] (03PS2) 10Brion VIBBER: Move old CoreData stuff to separate project library [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181525