[00:00:40] (03CR) 10Jdlrobson: [C: 04-1] Update mediaviewer, mobile redirect, and nearby documentation (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 (owner: 10Bmansurov) [00:03:13] (03CR) 10Jdlrobson: [C: 04-1] Update search, talk, and TOC documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [00:04:26] (03PS16) 10Kaldari: Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [00:04:31] (03PS3) 10Bmansurov: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 [00:06:05] (03PS3) 10Bmansurov: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 [00:17:42] (03CR) 10Kaldari: [C: 04-1] "editor init seems to be broken" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [00:19:45] (03PS21) 10Jdlrobson: Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 [00:19:47] (03PS1) 10Jdlrobson: Serve description even if the wiki data item has no instance of claims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180683 [00:22:52] (03CR) 10jenkins-bot: [V: 04-1] Serve description even if the wiki data item has no instance of claims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180683 (owner: 10Jdlrobson) [00:22:56] (03CR) 10jenkins-bot: [V: 04-1] Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [00:26:38] (03PS2) 10Jdlrobson: Update lastEdited documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180663 (owner: 10Bmansurov) [00:26:44] (03CR) 10Jdlrobson: [C: 032] Update lastEdited documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180663 (owner: 10Bmansurov) [00:26:52] (03PS3) 10Jdlrobson: Hygiene: Update lastEdited documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180663 (owner: 10Bmansurov) [00:27:02] (03CR) 10Jdlrobson: [C: 031] Hygiene: Update lastEdited documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180663 (owner: 10Bmansurov) [00:27:10] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update lastEdited documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180663 (owner: 10Bmansurov) [00:33:59] (03PS2) 10Jdlrobson: Serve description even if the wiki data item has no instance of claims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180683 [00:37:23] (03CR) 10jenkins-bot: [V: 04-1] Serve description even if the wiki data item has no instance of claims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180683 (owner: 10Jdlrobson) [00:38:55] (03PS22) 10Jdlrobson: Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 [00:41:05] (03PS2) 10Jdlrobson: Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [00:41:55] (03PS3) 10Jdlrobson: Hygiene: Update uploads and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 (owner: 10Bmansurov) [00:42:01] (03PS4) 10Jdlrobson: Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [00:42:05] (03PS2) 10Jdlrobson: Hygiene: Update notifications, preferred languages, and references documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180667 (owner: 10Bmansurov) [00:42:14] (03PS4) 10Jdlrobson: Hygiene: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 (owner: 10Bmansurov) [00:42:21] (03PS2) 10Jdlrobson: Hygiene: Update editor documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 (owner: 10Bmansurov) [00:42:43] (03CR) 10Jdlrobson: [C: 031] Hygiene: Update lastEdited documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180663 (owner: 10Bmansurov) [00:42:50] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update lastEdited documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180663 (owner: 10Bmansurov) [00:45:55] bmansurov: i'm getting very confused with 'FIXME: don't use a private method or make it public ' [00:45:59] (03CR) 10jenkins-bot: [V: 04-1] Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [00:46:01] (03Merged) 10jenkins-bot: Hygiene: Update lastEdited documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180663 (owner: 10Bmansurov) [00:46:36] can you explain why you are so against them? [00:49:17] jdlrobson: i think it's about consistency. why prepend a _ to private method names? since javascript doesn't throw an error, we should make sure not to call those methods outside their classes. [00:50:18] why? a public method can call a private method. [00:50:46] jdlrobson: yes, if the private method also belongs to the same class [00:50:51] jdlrobson: also, they can change without a notice to outside classes [00:51:35] I see it wasn't clear from the comment that these methods lived outside the class [00:52:03] jdlrobson: my bad, i should have done a better job. i'll make updates [00:52:42] also bmansurov i keep finding lots of small issues with your documentation. Can you take a little bit more care to check them before sending for review? [00:52:57] jdlrobson: sure i [00:52:58] it's really draining for me to keep reading the entire commit again [00:53:02] ll doble check [00:53:08] sorry about that [00:55:22] (03PS5) 10Jdlrobson: Hygiene: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 (owner: 10Bmansurov) [00:55:24] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [00:55:29] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 (owner: 10Bmansurov) [00:56:28] (03PS1) 10Kaldari: Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 [00:56:48] (03PS2) 10Kaldari: Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 [00:57:33] (03CR) 10Kaldari: [C: 032] Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [00:57:35] (03CR) 10jenkins-bot: [V: 04-1] Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [00:58:13] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Update editor documentation (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 (owner: 10Bmansurov) [00:58:46] (03PS3) 10Jdlrobson: Hygiene: Update notifications, preferred languages, and references documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180667 (owner: 10Bmansurov) [00:58:51] (03PS5) 10Jdlrobson: Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [00:58:59] (03PS4) 10Jdlrobson: Hygiene: Update uploads and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 (owner: 10Bmansurov) [00:59:08] (03PS4) 10Jdlrobson: Hygiene: Update notifications, preferred languages, and references documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180667 (owner: 10Bmansurov) [01:00:17] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:01:18] (03CR) 10Kaldari: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:02:09] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update notifications, preferred languages, and references documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180667 (owner: 10Bmansurov) [01:04:34] (03CR) 10Kaldari: Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:04:44] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:05:28] (03CR) 10jenkins-bot: [V: 04-1] Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:08:30] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:09:13] (03CR) 10jenkins-bot: [V: 04-1] Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:14:22] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 (owner: 10Bmansurov) [01:16:08] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:17:28] (03PS3) 10Bmansurov: Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 [01:17:45] (03CR) 10Kaldari: [C: 032] Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:18:30] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [01:19:49] bmansurov: Do you know which Trello card this change is related to: https://gerrit.wikimedia.org/r/#/c/180315/ (Phabricator is down) [01:20:29] kaldari|2: I found it through https://trello.com/c/m1GWdHXg/38-placeholder-phabricator-bugs [01:21:03] ah [01:22:19] bmansurov: unfortunately, I had to revert it, but can't update the bug right now. Oh well. [01:22:35] kaldari|2: what was the problem? [01:22:48] bmansurov: In some cases the pencil icon remains completely hidden [01:23:27] kaldari|2: specific urls or randomly? [01:23:40] (03PS1) 10Alex Monk: Followup Ia6bf604c, I431a9025: Update way VE target is constructed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180692 [01:23:42] bmansurov: Seems to be just 2 specific cases: https://gerrit.wikimedia.org/r/#/c/180688/ [01:24:41] kaldari|2: i see [01:24:41] bmansurov: feel free to take another pass at it when you have a chance [01:24:48] ok [01:26:41] (03CR) 10Kaldari: "Problem was caused by a different commit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [01:28:44] (03PS23) 10Jdlrobson: Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 [01:30:08] (03CR) 10jenkins-bot: [V: 04-1] Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [01:31:11] (03CR) 10Jdlrobson: [C: 032] Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:33:17] (03Merged) 10jenkins-bot: Revert "Load correct page actions images" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180688 (owner: 10Kaldari) [01:35:05] (03PS3) 10Bmansurov: Update editor documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 [01:36:08] (03PS1) 10Kaldari: Revert "Load correct page actions images" [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180696 [01:37:23] (03PS4) 10Bmansurov: Hygiene: Update editor documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 [01:44:16] (03PS5) 10Bmansurov: Hygiene: Update notifications, preferred languages, and references documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180667 [01:47:08] (03CR) 10Jdlrobson: [C: 032] "I'm no longer getting the error" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180692 (owner: 10Alex Monk) [01:47:12] (03PS1) 10Jforrester: Followup Ia6bf604c, I431a9025: Update way VE target is constructed [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180701 [01:47:22] (03CR) 10Jforrester: [C: 032] Followup Ia6bf604c, I431a9025: Update way VE target is constructed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180692 (owner: 10Alex Monk) [01:50:04] (03PS6) 10Jdlrobson: Hygiene: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 (owner: 10Bmansurov) [01:50:38] (03Merged) 10jenkins-bot: Followup Ia6bf604c, I431a9025: Update way VE target is constructed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180692 (owner: 10Alex Monk) [01:51:22] bmansurov: Should the changes from https://trello.com/c/4icRYufi/26-5-eventlogging-update-all-click-tracking-graphs be live now? [01:51:35] (03CR) 10Jdlrobson: [C: 032] Polish: Fade in and out the search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180373 (owner: 10Bmansurov) [01:51:49] (03PS5) 10Bmansurov: Hygiene: Update uploads and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 [01:52:36] kaldari|2: are you asking if you want to make the changes live? [01:52:59] bmansurov: No, trying to sign off on the card, but don't see the changes [01:53:51] kaldari|2: I'm not sure when they push changes to the prod server. ;( [01:54:02] but the changes have been merged [01:54:10] bmansurov: I think you have to ask the analytics folks to deploy it [01:54:18] kaldari|2: ok [01:54:38] bmansurov: It's not an automatic deployment process like MediaWiki is [01:55:23] bmansurov: You can usually find someone on #wikimedia-analytics to do it [01:55:36] kaldari|2: thanks, good to know [01:57:47] kaldari|2: the work day is ending and they may have left already. I'll ping them tomorrow again. [01:58:17] bmansurov: that's fine [01:58:39] (03CR) 10Kaldari: [C: 04-1] WIP: Style wikigrok for tablets (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180447 (owner: 10Jhernandez) [01:59:42] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [01:59:53] (03Merged) 10jenkins-bot: Polish: Fade in and out the search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180373 (owner: 10Bmansurov) [02:01:47] (03CR) 10Alex Monk: "Jon: Did you apply the VE change I mentioned in the commit message? It wasn't merge at the time you wrote this. I think it's a local issue" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180692 (owner: 10Alex Monk) [03:31:46] (03PS3) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 [03:33:20] (03CR) 10jenkins-bot: [V: 04-1] Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [05:24:49] (03PS1) 10BearND: Update Gradle plugin to 1.0.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180722 [05:24:51] (03PS1) 10BearND: Update README for Android Studio 1.0.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180723 [05:30:42] (03PS2) 10BearND: Update Gradle plugin to build-tools [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180722 [05:30:44] (03PS2) 10BearND: Update README for Android Studio 1.0.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180723 [06:59:28] 3MobileFrontend-alpha, Mobile-Web: Alpha shows always a "page issues" link - https://phabricator.wikimedia.org/T78800#931640 (10Florian) 5Open>3Resolved [07:19:32] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Update documentation (0313 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [07:22:35] (03CR) 10Florianschmidtwelzow: Hygiene: Update editor documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 (owner: 10Bmansurov) [09:19:30] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [09:19:35] (03CR) 10Hashar: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [09:22:34] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [09:34:14] The module 'ext.echo.base' required by 'mobile.notifications.overlay' must exist :-(((( [09:39:12] any mobilefrontend guru around? [09:39:25] the resource loader entries complains when running phpunit.php --testsuite structure [09:39:31] The module 'mobile.stable' must not have target 'desktop' because its dependency 'mobile.site' does not have it [09:39:31] Failed asserting that an array contains 'desktop'. [09:39:32] :( [09:39:45] morning! [09:39:56] oh yeah good morning [09:45:35] ah [09:45:36] $wgMFResourceFileModuleBoilerplate = $wgMFResourceBoilerplate + array( [09:45:36] 'targets' => array( 'mobile', 'desktop' ), [09:45:36] ); [10:02:20] morning [10:02:46] hashar: one sec [10:04:43] hashar: does it complain about mobile.usermodule too? [10:04:52] phuedx: it fails before [10:04:58] … [10:05:06] it fails that hard? [10:05:13] that is a single tests doing a foreach( module ) { assertEquals( some module ) }  [10:05:23] so the first module failing the assertion abort the test [10:05:29] user module would probably fail as well [10:06:07] looking at MF code, the 'mobile.site' use a specific class which has : protected $targets = array( 'mobile' ); [10:08:13] if they ran as individual test cases then you'd report all failures ;) [10:08:20] and yeah, that's why i asked [10:08:22] one moment [10:09:57] (03PS1) 10Hashar: Add autoload entry for ZeroPortal\\ConfigMerger [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180747 [10:10:26] (03CR) 10jenkins-bot: [V: 04-1] Add autoload entry for ZeroPortal\\ConfigMerger [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180747 (owner: 10Hashar) [10:10:37] phuedx: the resource loader test is in mw/core tests/phpunit/structure/ResourcesTest.php [10:10:46] it is very lame since it does not instantiate the module class [10:12:21] (03PS1) 10Phuedx: Fix structure suite [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180748 [10:12:43] joakino: ^ eyeballs plz [10:13:13] k [10:14:30] phuedx: what is the structure test suite? [10:14:41] (03CR) 10jenkins-bot: [V: 04-1] Fix structure suite [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180748 (owner: 10Phuedx) [10:14:55] makes assertions about the structure of the resource load modules [10:16:01] phuedx: any link to read about how to run it? [10:16:38] (03CR) 10Jhernandez: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180748 (owner: 10Phuedx) [10:17:12] 9:39:24 AM the resource loader entries complains when running phpunit.php --testsuite structure [10:17:14] joakino: ^ [10:17:24] k [10:17:37] the qunit failure is unrelated [10:17:48] yup [10:17:54] that is a known race condition that has been introduced fairly frequently [10:17:54] hashar: what /is/ that qunit failure? [10:17:58] recently [10:17:58] ah [10:18:14] some apache request is still being processed while Jenkins is busy archiving the debug log files [10:18:28] thus tar raise an exception because a file it attempts to archive is still being written to :( [10:18:49] oh [10:18:59] so our test seems to be smart enough to load the classes [10:19:24] it must request the structure from RL which knows about the protected $target var [10:19:25] \O/ [10:20:09] then I have no idea why they are explicitly set to 'mobile' [10:20:56] (03CR) 10Hashar: "So that fix the structure test. I have no idea about the impact for the mobile sites though, there might have been a good reason to have " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180748 (owner: 10Phuedx) [10:21:41] hashar: i'd rather fix the structure tests and write a card about auditing the structure of our rl modules [10:21:49] which have changed dramatically recently [10:23:13] phuedx: do you want to create such task and I +2 it then? [10:23:25] sounds like a plan [10:24:36] (03CR) 10Jhernandez: [C: 032] Fix structure suite [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180748 (owner: 10Phuedx) [10:24:48] you guys are awesome [10:26:27] (03Merged) 10jenkins-bot: Fix structure suite [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180748 (owner: 10Phuedx) [10:26:54] to the trello cave! [10:27:36] one more step toward testing all mobile related extensions together [10:33:54] phuedx: joakino thank you very much. You have no idea how helpful it is :] [10:34:02] :) [10:34:08] glad we could help [10:35:36] 👍 [10:45:32] hashar, joakino: https://trello.com/c/47nS4Be4/55-audit-rl-module-structure [10:46:08] ah [10:46:11] cool [10:46:16] it is pleasant to interact with smart / well organized people [10:47:10] hashar: we'll pick that up in stand up tomo [10:47:16] might even be answered immediately [10:47:21] but it's worth reviewing anyway [10:52:53] phuedx: from what I'm seeing infoboxes have arbitrary widths, right? [10:53:01] joakino: looks like [10:53:05] not convinced they should [10:53:06] specified in inline style attr [10:53:26] grr, then the wikigrok styling for tablets its going to be quite a nightmare [10:54:38] (03CR) 10Jhernandez: WIP: Style wikigrok for tablets (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180447 (owner: 10Jhernandez) [10:58:36] (03CR) 10Hashar: "recheck" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180747 (owner: 10Hashar) [10:59:31] phuedx: joakino: I have one more class missing in ZeroPortal autoloader https://gerrit.wikimedia.org/r/#/c/180747/ :D [10:59:33] tests pass! [11:04:44] hashar: don't know who can help you with zeroportal [11:06:06] yurik I guess [11:06:18] or be bold :] [11:06:56] lol from one day to the next the certain infoboxes that didn't work work now... [11:07:32] so non deterministic... 😩 [11:09:42] self merge for the win [11:09:42] (03CR) 10Hashar: [C: 032] "Triple verified and tests via Jenkins." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180747 (owner: 10Hashar) [11:10:14] (03Merged) 10jenkins-bot: Add autoload entry for ZeroPortal\\ConfigMerger [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180747 (owner: 10Hashar) [11:10:39] pew pew pew [11:10:41] joakino: ? [11:10:54] yep phuedx [11:11:12] (03PS2) 10Jhernandez: WIP: Style wikigrok for tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180447 [11:11:19] (03CR) 10jenkins-bot: [V: 04-1] WIP: Style wikigrok for tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180447 (owner: 10Jhernandez) [11:16:08] (03PS2) 10Jhernandez: WIP: Enable wikigrok on all devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180446 [11:16:10] (03PS3) 10Jhernandez: WIP: Style wikigrok for tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180447 [11:18:47] (03CR) 10Jhernandez: [C: 032] "Well thought." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180329 (owner: 10Jdlrobson) [11:23:58] (03Merged) 10jenkins-bot: Hygiene: Move lockViewport to Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180329 (owner: 10Jdlrobson) [11:24:14] (03CR) 10Jhernandez: [C: 032] Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 (owner: 10Jdlrobson) [11:27:04] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 (owner: 10Jdlrobson) [11:27:43] (03PS3) 10Phuedx: Use ResourceLoaderImage module in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179005 (owner: 10Jdlrobson) [11:27:58] (03CR) 10Phuedx: "PS3 is a rebase." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179005 (owner: 10Jdlrobson) [11:29:52] (03CR) 10Jhernandez: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 (owner: 10Jdlrobson) [11:36:40] (03PS8) 10Jhernandez: Move M.isIos to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 (owner: 10Jdlrobson) [11:37:07] (03CR) 10Jhernandez: Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 (owner: 10Jdlrobson) [11:37:18] (03CR) 10Jhernandez: [C: 032] Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 (owner: 10Jdlrobson) [11:37:51] (03CR) 10Jhernandez: "Fixed tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 (owner: 10Jdlrobson) [11:40:27] (03Merged) 10jenkins-bot: Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 (owner: 10Jdlrobson) [11:51:29] (03CR) 10Phuedx: [C: 031] Use ResourceLoaderImage module in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179005 (owner: 10Jdlrobson) [11:52:18] (03CR) 10Phuedx: "This LGTM (and is super-cool) but I'd like someone else to take a look too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179005 (owner: 10Jdlrobson) [12:24:11] (03PS1) 10Esanders: Give editor an empty label to prevent rendering bug [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180772 [12:33:28] (03PS1) 10Esanders: Remove border-box rule from reset.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 [13:23:07] (03PS1) 10Yurik: Fixed $wgAutoloadClasses for ConfigMerger [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180784 [13:25:24] (03PS2) 10Yurik: Fixed $wgAutoloadClasses for ConfigMerger [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180784 [13:25:50] (03CR) 10Yurik: [C: 032] Fixed $wgAutoloadClasses for ConfigMerger [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180784 (owner: 10Yurik) [13:26:18] (03Merged) 10jenkins-bot: Fixed $wgAutoloadClasses for ConfigMerger [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180784 (owner: 10Yurik) [13:34:04] (03PS2) 10Esanders: Remove border-box rule from reset.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 [14:26:58] (03CR) 10Hashar: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [14:29:49] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [14:52:45] (03CR) 10Hashar: Fixed $wgAutoloadClasses for ConfigMerger (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180784 (owner: 10Yurik) [15:28:43] (03CR) 10Dbrant: [C: 032] Material design icon for share action [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180570 (owner: 10BearND) [15:34:01] (03CR) 10Dbrant: [C: 032] Avoid StackOverflowError when initializing channel preference [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180652 (owner: 10BearND) [15:34:15] had to go have a lie down – i felt really, really tired [15:34:15] :/ [15:38:15] (03CR) 10Dbrant: [C: 032] Update Gradle plugin to build-tools [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180722 (owner: 10BearND) [15:41:20] (03CR) 10Dbrant: [C: 032] "excellent" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180723 (owner: 10BearND) [15:54:25] 3Wikipedia-App-Android-App: Crash on zero-width image in LeadImageHandler - https://phabricator.wikimedia.org/T84881#932758 (10Dbrant) 3NEW a:3Dbrant [15:55:46] (03PS1) 10Dbrant: Fix crash when lead image is abnormally small. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180797 [16:07:28] (03PS4) 10Bmansurov: Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 [16:07:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [16:09:12] (03PS1) 10Dr0ptp4kt: Show noscript HTTPS to HTTP tap if HTTPS charged [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 [16:13:42] (03PS2) 10Dr0ptp4kt: Show noscript HTTPS to HTTP tap if HTTPS charged [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 [16:14:50] (03PS5) 10Bmansurov: WIP: Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 [16:14:54] (03PS3) 10Dr0ptp4kt: Show noscript HTTPS to HTTP tap if HTTPS charged [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 [16:14:56] (03CR) 10jenkins-bot: [V: 04-1] WIP: Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [16:15:10] (03PS5) 10Bmansurov: WIP: Hygiene: Update editor documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 [16:15:30] (03PS7) 10Bmansurov: WIP: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 [16:15:42] (03PS6) 10Bmansurov: WIP: Hygiene: Update notifications, preferred languages, and references documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180667 [16:15:55] (03PS2) 10Dbrant: Fix crash when lead image is abnormally small. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180797 [16:15:57] (03PS6) 10Bmansurov: WIP: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 [16:16:02] (03CR) 10jenkins-bot: [V: 04-1] WIP: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [16:16:07] (03PS6) 10Bmansurov: WIP: Hygiene: Update uploads and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 [16:34:15] 3Wikipedia-App-Android-App: Unable to start activity ComponentInfo{org.wikipedia/org.wikipedia.page.PageActivity}: android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#932892 (10Dbrant) 5Open>3stalled All three of these are pretty murky... It is possible that bug(s) in t... [16:40:33] (03PS6) 10Bmansurov: Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 [16:43:26] (03PS1) 10Phuedx: Include the campaign property's Wikidata label [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 [16:43:31] (03CR) 10jenkins-bot: [V: 04-1] Include the campaign property's Wikidata label [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 (owner: 10Phuedx) [16:44:40] (03PS2) 10Phuedx: Include the campaign property's Wikidata label [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 [16:45:06] 3Wikipedia-App-Android-App: top bar flickers when scrolling up past end of page (android) - https://phabricator.wikimedia.org/T76985#932965 (10Dbrant) @Deskana @bearND Can anyone with a real 5.0 device reproduce this? [16:47:34] 3Wikipedia-App-Android-App: IllegalStateException: Can not perform this action after onSaveInstanceState - https://phabricator.wikimedia.org/T75237#932991 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:13:14] (03PS1) 10Dbrant: Fix possible crash when user goes to Settings from Nearby screen. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180819 [17:17:17] 3Wikipedia-App-Android-App: NPE when updating ProgressBar - https://phabricator.wikimedia.org/T74817#933119 (10Dbrant) 5Open>3Resolved a:3Dbrant Resolved since we started using a Toolbar instead of ActionBar with built-in ProgressBar. [17:17:56] (03CR) 10Florianschmidtwelzow: Hygiene: Update documentation (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [17:18:13] good evening @all :) [17:18:15] 3Wikipedia-App-Android-App: Android app dismisses and re-opens tool bar after TOC navigation - https://phabricator.wikimedia.org/T75577#933132 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:19:01] 3Wikipedia-App-Android-App: Regression: Decreased search target area in Alpha - https://phabricator.wikimedia.org/T75576#933141 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:19:40] 3Wikipedia-App-Android-App: Add option to turn off images - https://phabricator.wikimedia.org/T74031#933146 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:21:03] 3Wikipedia-App-Android-App: allow user to configure if he wants cover images in the app - https://phabricator.wikimedia.org/T75315#933155 (10Dbrant) 5Open>3Resolved a:3Dbrant Covered by our new option to disable loading images (in the More menu). [17:21:19] (03CR) 10Bmansurov: Hygiene: Update documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [17:21:30] (03PS7) 10Bmansurov: Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 [17:21:31] dbrant, bearND, Deskana: I'm liking the concept for collapsing infoboxen. I don't like how the collapse box label is laid out, though. The index of topics can stretch to two lines, with the the second line nearly empty and ending with "..." [17:22:12] and when the box has been opened to show the whole infobox, that elliptical header seems gratiuitous. [17:23:15] (03CR) 10BearND: [C: 04-1] "Good. It doesn't crash anymore. But could you make it so that it wouldn't show the default lead image in that case, too?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180797 (owner: 10Dbrant) [17:23:34] ragesoss: We do that to have the boxes be consistent sizes. Maybe we could include a bit more info to make the box a bit fuller. [17:24:06] Deskana: yeah, including as much as possible to fill the final line would be an improvement, I think. [17:24:08] ragesoss: What do you think of the lead images? :) [17:24:20] ragesoss: Deskana: there will always be cases where the text overflows just enough to make the ellipsis on its own line... [17:24:39] (or whatever the last word is) [17:25:04] lead images are nice. I've been enjoying them in the alpha for a little while. [17:25:18] (03PS1) 10Jhernandez: Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 [17:26:18] Deskana: want to answer here? https://www.mediawiki.org/w/index.php?title=Project:Support_desk&offset=20141218141540#Windows_Phone_51943 [17:26:40] (03CR) 10BearND: [C: 032] Fix possible crash when user goes to Settings from Nearby screen. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180819 (owner: 10Dbrant) [17:26:49] FlorianSW: Will do! Thanks. [17:26:59] Deskana: thanks :) [17:27:05] (03Merged) 10jenkins-bot: Fix possible crash when user goes to Settings from Nearby screen. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180819 (owner: 10Dbrant) [17:27:50] Deskana: what does it do now, just include the first two items? Or the minimum number to wrap to a second line? [17:28:09] dbrant ^ [17:28:34] that's a lot of tickets closed :) [17:28:41] (well, phab ones at least...) [17:29:01] I was wondering about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7569800 - we don't have such a limit, do we? [17:29:14] first two, it looks like, because in landscape mode I can get them down to one line. [17:29:25] ragesoss: just the first two headers from the table. The contents of the headers may fill much more than two lines, though [17:29:36] Krenair: sorry for the torrent! I'm not done yet, either [17:29:46] (03CR) 10Florianschmidtwelzow: Move file upload support detection to browser.js (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez) [17:29:46] I don't mind, stuff i [17:29:50] is getting resolved. [17:30:05] although it would be better if these were resolved when the patches were merged :) [17:30:25] but I can handle that but just paying closer attention to gerritadmin [17:30:30] by just* [17:30:49] Krenair: there is definitely no limit on saved pages [17:31:13] Maybe there was back in May? [17:31:22] Deskana, dbrant: have you done any user testing on whether those headers are useful? I would rather have a clean "quick facts" box with no headers at all, but maybe that's just because I'm a power user who knows the concept of 'infobox'. [17:32:09] ragesoss: we felt that including the headers provides a very useful quick context of what the table is about [17:32:47] is it just infoboxes that get this treatment, or other tables as well? [17:32:57] ragesoss: Yeah, it does help contextualise it a bit in my opinion. [17:33:13] ragesoss: yep, it's actually any table that has at least one header. [17:33:41] but always labeled "Quick facts"? [17:34:04] ragesoss: no, "quick facts" means infobox. Other tables is "more information" [17:34:06] ragesoss: No, that's just the infobox that's called that. [17:34:22] ah. cool. [17:34:36] We considered labelling it "infobox" but we're trying to avoid Wikipedia jargon. [17:34:55] I just dealt with like 4 of the page 1 android app feedback emails. nothing left from april or may now! [17:35:23] the headers make sense to me for other tables, they just seem like clutter for the infoboxes in particular. (I like 'quick facts' as the label, though.) [17:35:36] Krenair: Fantastic! Thank you so much. [17:35:56] ragesoss: It is true that there is a bit more of a clear model of what's underneath the "quick facts" box in particular. [17:36:04] the oldest email is now one in a language I don't believe we can handle [17:36:23] ragesoss: We can consider that. I may ask our Design Research Team to test that for us. [17:37:12] Deskana, how do you suggest I handle these? google translate? [17:37:56] Krenair: You can try that. If you think you can make sense of it from that, I'd suggest telling the person that you used machine translation and apologise if you misunderstood as a result. [17:37:59] the Material Design implementation is really nice, btw. the app looks wonderful these days. [17:38:18] yeah. ok [17:38:56] ragesoss: Thanks! I'm really pleased too. [17:39:11] It really involves a lot of us telling ourselves that there will be edge cases and that that's okay. [17:39:22] That's just the nature of developing an app for something as crowdsourced as Wikipedia. [17:41:03] * Deskana sighs at himself for using the word "crowdsourced" in a serious sentence [17:41:37] * ragesoss feels dirty every time the word 'agile' escapes his lips. [17:41:59] (03CR) 10Dbrant: "@bearND: I don't think that would be feasible... If the image URL is non-null, the placeholder image is shown to the user while the real i" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180797 (owner: 10Dbrant) [17:42:02] (03CR) 10Jdlrobson: [C: 04-1] "It was a choice we made a while back to make our lives easier." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [17:42:39] +100000000 to border-box [17:42:52] jdlrobson: ^ [17:43:15] joakino: i'd appreciate you weighing in with your views but i'm very strongly against moving away from it [17:43:59] ragesoss: thx! [17:44:42] joakino: how was your birthday celebration? [17:44:54] we all drank in SF to celebrate at the xmas party [17:44:54] jdlrobson: removing it and going back to border-box can be troublesome with all the css weve got right? [17:45:18] joakino: border-box is already our default everywhere [17:45:24] jdlrobson: haha cool! we went to a posh-y sushi restaurant, it was fun [17:45:29] so we'd basically have to tweak everything which has padding [17:45:34] jdlrobson: sorry i meant content-box [17:46:17] gonna be a few headaches in the 10am meeting i think ;-) [17:46:42] ooh is editor broken on mobile? [17:47:03] 3Wikipedia-App-Android-App: Issues with Google Plus interaction - java.lang.SecurityException: Permission Denial: starting Intent { act=android.intent.action.VIEW - https://phabricator.wikimedia.org/T73301#933288 (10Dbrant) 5Open>3Resolved a:3Dbrant I'll go out on a limb and presume that the Google Plus ap... [17:47:30] is it? [17:48:49] (03PS1) 10Jhernandez: Fix incorrect documentation in PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180832 [17:48:51] (03PS1) 10Jhernandez: Remove redundant include in uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180833 [17:48:53] (03PS1) 10Jhernandez: WIP: Implement a view that features an event map for declarative event definitions. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 [17:48:55] (03PS1) 10Jhernandez: WIP: Refactor Watchstar view to use EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 [17:48:57] (03PS1) 10Jhernandez: WIP: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 [17:48:59] (03PS1) 10Jhernandez: WIP: PhotoUploaderButton uses EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 [17:49:08] KABOOM [17:50:54] :D :D [17:50:56] woo! [17:51:07] 3Wikipedia-App-Android-App: Refactor PageActivity.onWikipediaZeroInterstitialEvent - https://phabricator.wikimedia.org/T68081#933301 (10Dbrant) 5Open>3Resolved a:3Dbrant Done, as part of this patch: https://gerrit.wikimedia.org/r/178532 [17:51:35] (03CR) 10Jdlrobson: [C: 04-1] "Label is plain text not html so you'll either have to update the template (maybe have the nbsp after the {{label}})" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180772 (owner: 10Esanders) [17:52:19] (03PS2) 10Jdlrobson: Hygiene: Fix incorrect documentation in PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180832 (owner: 10Jhernandez) [17:52:27] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix incorrect documentation in PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180832 (owner: 10Jhernandez) [17:52:28] 3Wikipedia-App-Android-App: suboptimal scrollbar in image description on Android - https://phabricator.wikimedia.org/T78347#933305 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:52:50] (03PS2) 10Jdlrobson: Remove redundant include in uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180833 (owner: 10Jhernandez) [17:53:00] (03PS3) 10Jdlrobson: Hygiene: Remove redundant include in uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180833 (owner: 10Jhernandez) [17:53:06] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove redundant include in uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180833 (owner: 10Jhernandez) [17:53:22] (03CR) 10Jhernandez: [C: 04-1] "I agree with jdlrobson, this is going to cause a lot of headaches with styling all through the code." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [17:53:43] 3Wikipedia-App-Android-App: StackOverflowError while getting channel info - https://phabricator.wikimedia.org/T78833#933307 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:54:32] 3Wikipedia-App-Android-App: overlapping lines under the globe logo in the Android login screen - https://phabricator.wikimedia.org/T78350#933310 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:54:42] (03PS3) 10BearND: Fix crash when lead image is abnormally small. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180797 (owner: 10Dbrant) [17:54:57] (03CR) 10BearND: [C: 032] "OK, fair enough." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180797 (owner: 10Dbrant) [17:55:09] oops I forgot the Hygiene prefix [17:56:06] (03Merged) 10jenkins-bot: Fix crash when lead image is abnormally small. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180797 (owner: 10Dbrant) [17:56:43] (03CR) 10Jdlrobson: [C: 04-1] Move file upload support detection to browser.js (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez) [17:57:02] jenkins is being super slow these days [17:57:05] 3Wikipedia-App-Android-App: Crash on zero-width image in LeadImageHandler - https://phabricator.wikimedia.org/T84881#933318 (10Dbrant) 5Open>3Resolved [17:58:31] so joakino https://gerrit.wikimedia.org/r/#/c/180834/1/javascripts/EventsView.js I wonder if we could use https://github.com/wikimedia/oojs/blob/master/src/EventEmitter.js (which we load anyway) to do a lot of this [17:58:46] particularly the connect function [18:00:11] var EventEmitter = mw.mobileFrontend.require( 'eventemitter' ); EventEmitter.prototype.connect [18:00:19] jdlrobson: let me have a look, but this events code is about dom events, it builds on jquerys $el.on(event, selector) form [18:00:45] nothing to do with view events (event emmitter) [18:01:10] 3Wikipedia-App-Android-App: IllegalArgumentException: View not attached to window manager causing crashes - https://phabricator.wikimedia.org/T69947#933327 (10Dbrant) 5Open>3Resolved a:3Dbrant Closing, since these tickets are from many versions ago, and don't seem to have recurred. [18:02:54] (03PS6) 10Bmansurov: Hygiene: Update editor documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 [18:02:59] (03Merged) 10jenkins-bot: Hygiene: Fix incorrect documentation in PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180832 (owner: 10Jhernandez) [18:03:27] (03PS8) 10Bmansurov: Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 [18:03:28] we are setting up hangout in r37 as we speak [18:03:30] be back in a bit :) [18:03:35] hey dudes I can't get on hangouts for some reason but I'm around if you need anything for story review! [18:03:50] bmansurov are in hangout [18:03:54] and i [18:04:55] 3Wikipedia-App-Android-App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - https://phabricator.wikimedia.org/T69807#933338 (10Dbrant) 5Open>3Resolved a:3Dbrant Closing, since these tickets are from many versions ago, and don't seem to have recurred. [18:05:00] joakino: phuedx [18:05:06] y [18:05:19] hangout :) [18:05:33] oh dangit [18:05:36] 3Wikipedia-App-Android-App: IllegalArgumentException: View not attached to window manager causing crashes - https://phabricator.wikimedia.org/T69947#933343 (10bearND) Agreed. Just for informational purposes: I have seen exceptions like "View not attached to window manager" when I used the wrong Context object,... [18:06:39] ping phuedx [18:06:44] ping: cannot resolve phuedx: Unknown host [18:08:22] 3Wikipedia-App-Android-App: Crash caused by pressing Retry button on connection issue error - https://phabricator.wikimedia.org/T72834#933349 (10Dbrant) 5Open>3Resolved a:3Dbrant Should be fixed by https://gerrit.wikimedia.org/r/174976 [18:09:30] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [18:09:46] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [18:10:01] (03CR) 10Bmansurov: Hygiene: Update documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [18:10:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove redundant include in uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180833 (owner: 10Jhernandez) [18:10:18] 3Wikipedia-App-Android-App: Add option to reload an article - https://phabricator.wikimedia.org/T70627#933367 (10Dbrant) 5Open>3Resolved a:3Dbrant This is now available by swiping down when scrolled to the top of the page. [18:15:23] (03PS8) 10Bmansurov: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 [18:15:25] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update editor documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 (owner: 10Bmansurov) [18:15:31] 3Wikipedia-App-Android-App, Mobile-Apps, Wikipedia-App-iOS-App: "Your app’s back button doesn’t send users back to search results" - https://phabricator.wikimedia.org/T75918#933382 (10Dbrant) 5Open>3Resolved a:3Dbrant [18:15:41] (03CR) 10Bartosz Dziewoński: [C: 031] "I recall raising this issue in the past on some occasion. You shouldn't be applying styles like this to content you do not fully control, " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [18:15:46] (03CR) 10Esanders: "Rightly or wrongly content-box is the default model in user agents. That means for the most part people develop against this model so when" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [18:15:55] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 (owner: 10Bmansurov) [18:16:59] (03CR) 10Krinkle: "Seems a bit like an equivalent of global variables and functions. This border-box rule is conveniently available everywhere and MobileFron" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [18:17:02] (03CR) 10Catrope: [C: 031] "At the very least, border-box should be scoped to user-generated content, not to the entire body. If this exists to make inline styles beh" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [18:22:48] (03PS1) 10Dr0ptp4kt: Add X-WMF-UUID to Wikipedia for iOS requests [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/180846 [18:23:30] phuedx: joakino bmansurov my fave list - https://en.m.wikipedia.org/wiki/List_of_lists_of_lists [18:23:50] lol [18:24:47] (03PS1) 10BearND: Go to first suggestion on search submit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180848 [18:26:32] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [18:26:35] (03CR) 10Esanders: "@Catrope wouldn't scoping it to user generated content be bad as well? If there is any content on WMF wikis with padding and width it was " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [18:28:51] (03CR) 10Dr0ptp4kt: "@mhurd, feel free to run with it. Lemme know if you want to pair up on this over video." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/180846 (owner: 10Dr0ptp4kt) [18:30:06] (03CR) 10Krinkle: "I imagine it is exactly inline styles that are least compatible with this, because those are written in isolation with no access to styles" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [18:32:08] 3Wikipedia-App-Android-App: top bar flickers when scrolling up past end of page (android) - https://phabricator.wikimedia.org/T76985#933425 (10jeremyb) 5Open>3Resolved a:3jeremyb I can no longer repro on Android App 2.0-beta-2014-12-17. Same device as first noticed on. I saw some visible changes in betwee... [18:33:15] 3Wikipedia-App-Android-App: top bar flickers when scrolling up past end of page (android) - https://phabricator.wikimedia.org/T76985#933438 (10jeremyb) a:5jeremyb>3None [18:33:33] jdlrobson: we made these literally at the same time: https://phabricator.wikimedia.org/T84898 [18:34:32] (03CR) 10Jdlrobson: [C: 04-2] "Please provide a concrete motivation for this. Until then this is purely subjective and up to developer taste." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [18:35:10] 3Wikipedia-App-Android-App: too hard to click links near left edge of screen - https://phabricator.wikimedia.org/T78240#933454 (10jeremyb) Seems better to me in Android App 2.0-beta-2014-12-17 [18:36:39] ok i gotta feed the cats than back to the code cleanup, i want that done [18:40:40] 3Wikipedia-App-Android-App: App unexpectedly closes on Samsung Galaxy Ace II X (S7560M) - https://phabricator.wikimedia.org/T76279#933504 (10Dbrant) I'm not totally convinced that the above patch deals with this specific issue, since the user says he's able to use the app for a while before it closes. (I think t... [18:48:39] jdlrobson: I'm fixing the watchlist test(s) [18:48:41] (03PS9) 10Bmansurov: Hygiene: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 [18:48:53] chrismcmahon: thanks just in a meeting right now will catch up in a bit [18:49:27] jdlrobson: just wanted to make sure not to duplicate effort [18:54:29] (03PS1) 10Esanders: Rename caller of '_prepareToSave' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180855 [18:57:49] http://hatjitsu.wmflabs.org/70230 [18:58:17] (03CR) 10Krinkle: "Depending on how "mobile"-ish these modules were intended, the bug may be the other way around. It may be that the 'desktop' target should" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180748 (owner: 10Phuedx) [18:58:22] jdlrobson: https://gerrit.wikimedia.org/r/#/c/180748/ [19:02:38] (03PS7) 10Bmansurov: Hygiene: Update notifications, preferred languages, and references documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180667 [19:02:45] (03CR) 10Esanders: "??? Take your pick from the many well reasoned arguments above. If it were a matter of developer preference I'd use border-box everywhere," [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [19:05:47] kaldari|2: isn't it correct, that i can force wikigrok when i append wikigrokid= and wikigrokversion= to an url (like http://en.m.wikipedia.beta.wmflabs.org/wiki/Anne_Dallas_Dudley)? [19:06:22] bmansurov, jdlrobson: ^ maybe you can answer this, too :) [19:07:21] FlorianSW: yes I think that's how you do it [19:07:30] FlorianSW: and alpha also I think [19:07:51] bmansurov: yes, and logged in, but it doesn't work for me: http://en.m.wikipedia.beta.wmflabs.org/wiki/Anne_Dallas_Dudley?mobileaction=alpha&wikidataid=Q3784220&wikigrokversion=b [19:08:04] let me take a look [19:10:01] FlorianSW: hmm, that's weird. maybe it's been turned off by admins. kaldari|2 maybe able to answer. [19:10:35] bmansurov: there is an api call to wikidata, but i don't know exactly how wikigrok works :( [19:10:52] FlorianSW: that's for the infobox i think [19:11:09] bmansurov: on every page load? :o [19:11:27] FlorianSW: wikigrok doesn't make an api call to wikidata untill getting labels, which is the 2nd step i think [19:11:35] FlorianSW: looks like so, but once you hit expand [19:11:50] FlorianSW: 'More information' [19:11:56] bmansurov: i haven't clicked "more information" :) [19:12:11] FlorianSW: ok let me see what's up [19:12:53] FlorianSW: I don't see any call to wikidata before hitting more info [19:13:13] (03CR) 10Catrope: "@Krinkle: Ed DID in fact readd the rule in the places where it was needed; although there's only one such change in the commit so that see" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [19:13:54] bmansurov: props:descriptions|claims i think it's for wikigrok? [19:14:28] (03CR) 10Catrope: "Everyone: Can we at least agree to stop applying border-box *outside of the content area*? I'm not convinced that it's a good idea even in" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [19:14:40] FlorianSW: In wikigrok I think claims are loaded on page load, but there is a call for labels I think. [19:14:44] (03CR) 10Esanders: "I'm trying to bring as much mobile integration code into VE-core as possible to remove the amount of hacks we have in MF to get VE working" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [19:14:53] (03PS1) 10Cmcmahon: QA: watchlist icon is no longer a link but a span [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180863 [19:15:06] bmansurov: hmm, i take a look on it later, but now i want to see wikigrok b :D [19:15:30] FlorianSW: would you like to test it locally? [19:15:38] 3Wikipedia-App-Android-App: main page last modified time confusing - https://phabricator.wikimedia.org/T78005#933596 (10jeremyb) 5Invalid>3Open >>! In T78005#834447, @Krenair wrote: > This is consistent with MediaWiki core No, it isn't. Err, yes it is but enwiki has a local CSS hack. https://en.wikipedia.or... [19:15:50] (03CR) 10Esanders: "@Catrope the second one was the toolbar which grew by 1px so I didn't think it was worth it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [19:16:00] FlorianSW: let's see what kaldari says [19:16:07] bmansurov: let me do it... [19:16:36] FlorianSW: this may help: https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok#Local_testing [19:17:28] bmansurov: loaded page: index.php/TestTextExtracts?mobileaction=alpha&wikigrokversion=B&wikidataid=Q936499 and without any interaction on page i have this api call: https://www.wikidata.org/w/api.php?callback=jQuery11110027915024664252996_1418930182390&action=wbgetentities&format=json&ids=Q936499&languages=en&props=descriptions%7Cclaims&_=1418930182391 [19:17:41] (03CR) 10jenkins-bot: [V: 04-1] QA: watchlist icon is no longer a link but a span [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180863 (owner: 10Cmcmahon) [19:17:45] bmansurov: logged in and alpha. Can you test it on your local installation? [19:18:03] but no wikigrok [19:18:53] FlorianSW: I'll test the api call, but to see wikigrok you need to follow the instructions in the above link I pasted. [19:19:40] argh.... i think this is it: "Assign suggestions to the page in the database" i never did that :P [19:19:57] FlorianSW: The api call seems to be related to the banner image [19:20:14] bmansurov: ah, that's possible, yes [19:20:15] FlorianSW: the image that you see on mobile [19:23:13] (03PS1) 10Cmcmahon: QA: update locator for talk button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180866 [19:26:55] 3Wikipedia-App-Android-App: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#933630 (10jeremyb) 3NEW [19:29:49] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180863 (owner: 10Cmcmahon) [19:34:33] (03PS7) 10Bmansurov: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 [19:34:39] (03CR) 10jenkins-bot: [V: 04-1] Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [19:41:49] (03PS7) 10Bmansurov: Hygiene: Update uploads and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 [19:43:52] (03PS8) 10Bmansurov: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 [19:44:16] (03PS9) 10Bmansurov: Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 [19:46:16] (03PS1) 10Dr0ptp4kt: Add X-WMF-UUID to Wikipedia for Android requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180868 [19:47:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [19:47:33] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [19:47:36] 3Wikipedia-App-Android-App: top bar flickers when scrolling up past end of page (android) - https://phabricator.wikimedia.org/T76985#933699 (10Deskana) I also cannot reproduce this. [19:48:06] joakino: phuedx you off for the night? [19:48:18] about to leave [19:48:22] do you need anything jdlrobson [19:48:25] nope [19:48:28] have a great evening :D [19:48:40] thx, have a great day :) [19:48:52] (03CR) 10jenkins-bot: [V: 04-1] Add X-WMF-UUID to Wikipedia for Android requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180868 (owner: 10Dr0ptp4kt) [19:52:08] (03CR) 10Dr0ptp4kt: "@dbrant and @bearND, feel free to run with this, or let's pair up. For now, per meeting yesterday, we want to avoid tearing up the existin" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180868 (owner: 10Dr0ptp4kt) [19:52:51] ^ Deskana, mhurd that and https://gerrit.wikimedia.org/r/#/c/180846/ are hopefully a start. i created that vcl patch at https://gerrit.wikimedia.org/r/#/c/180812/ and bblack said he'll be looking at that [19:53:21] dr0ptp4kt: awesome! was just looking at the patch [19:54:04] (03CR) 10Dr0ptp4kt: "@dbrant and @bearND, of course "to the batcave" if you'd like to pair up on this!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180868 (owner: 10Dr0ptp4kt) [19:56:31] (03PS2) 10Dr0ptp4kt: Add X-WMF-UUID to Wikipedia for Android requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180868 [19:57:32] dammit [19:57:35] missed jdlrobson [20:03:57] (03CR) 10Esanders: "@Jon/Joaquin you say this will cause "lots of headaches" and suggest this fixes a lot of issues you have with padding/width. As I stated a" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [20:07:58] Unit tests pass again! Now to fix the rest of the actual code. ;) [20:18:09] lunch bbiab [20:18:37] (03CR) 10Trevor Parscal: [C: 031] "Ed, thank you for taking the time to clean up this mess." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [20:24:01] (03CR) 10Jdlrobson: [C: 032] "Thanks Ed!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180855 (owner: 10Esanders) [20:25:24] (03CR) 10Jdlrobson: [C: 04-1] QA: update locator for talk button (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180866 (owner: 10Cmcmahon) [20:26:03] (03CR) 10Jdlrobson: [C: 032] QA: watchlist icon is no longer a link but a span [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180863 (owner: 10Cmcmahon) [20:26:31] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180833 (owner: 10Jhernandez) [20:27:50] (03CR) 10Jdlrobson: WIP: TableOfContents uses events map (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez) [20:28:52] (03CR) 10Jdlrobson: WIP: Refactor Watchstar view to use EventsView (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez) [20:29:45] (03PS1) 10Florianschmidtwelzow: WIP: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [20:30:02] (03CR) 10Jdlrobson: "as discussed let's see if we can reuse the OO.EventEmitter (Mantle synonym is EventEmitter)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 (owner: 10Jhernandez) [20:30:12] (03CR) 10Jdlrobson: [C: 04-1] "-1 so you see my comment :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 (owner: 10Jhernandez) [20:30:43] (03CR) 10Florianschmidtwelzow: [C: 04-1] "This is WIP and still needs a lot of work and adjustments." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [20:30:45] (03CR) 10Jdlrobson: [C: 04-1] "See comments. I really like this direction." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez) [20:31:04] (03CR) 10Jdlrobson: [C: 031] Hygiene: Remove redundant include in uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180833 (owner: 10Jhernandez) [20:31:13] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove redundant include in uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180833 (owner: 10Jhernandez) [20:31:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [20:33:54] (03PS7) 10Jdlrobson: Hygiene: Update editor documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 (owner: 10Bmansurov) [20:34:00] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update editor documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 (owner: 10Bmansurov) [20:36:44] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Update uploads and watchstar documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 (owner: 10Bmansurov) [20:37:54] (03CR) 10Cmcmahon: QA: update locator for talk button (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180866 (owner: 10Cmcmahon) [20:38:30] (03Merged) 10jenkins-bot: Rename caller of '_prepareToSave' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180855 (owner: 10Esanders) [20:38:38] (03Merged) 10jenkins-bot: QA: watchlist icon is no longer a link but a span [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180863 (owner: 10Cmcmahon) [20:38:48] (03Merged) 10jenkins-bot: Hygiene: Remove redundant include in uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180833 (owner: 10Jhernandez) [20:38:51] (03Merged) 10jenkins-bot: Hygiene: Update editor documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180662 (owner: 10Bmansurov) [20:39:08] (03PS1) 10Bmansurov: Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 [20:39:15] (03CR) 10jenkins-bot: [V: 04-1] Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [20:40:30] (03PS2) 10Bmansurov: Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 [20:40:50] (03PS2) 10Florianschmidtwelzow: WIP: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [20:41:22] (03PS8) 10Bmansurov: Hygiene: Update uploads and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 [20:42:33] (03PS9) 10Jdlrobson: Hygiene: Update uploads and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 (owner: 10Bmansurov) [20:42:41] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update uploads and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 (owner: 10Bmansurov) [20:44:58] (03CR) 10Jdlrobson: Load correct page actions images (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [20:46:33] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [20:47:04] (03Merged) 10jenkins-bot: Hygiene: Update uploads and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180669 (owner: 10Bmansurov) [20:47:38] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 (owner: 10Bmansurov) [20:47:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [20:48:51] (03CR) 10Dr0ptp4kt: Show noscript HTTPS to HTTP tap if HTTPS charged (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 (owner: 10Dr0ptp4kt) [20:48:55] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update notifications, preferred languages, and references documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180667 (owner: 10Bmansurov) [20:50:10] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180683 (owner: 10Jdlrobson) [20:50:45] bmansurov: do you want to prepare a patch that merges the jscs scripts? [20:51:07] jdlrobson: sure, is there a card for that? [20:51:17] (03Merged) 10jenkins-bot: Hygiene: Update mediaviewer, mobile redirect, and nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180665 (owner: 10Bmansurov) [20:51:21] (03Merged) 10jenkins-bot: Hygiene: Update notifications, preferred languages, and references documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180667 (owner: 10Bmansurov) [20:51:21] yup adding you now [20:54:12] (03PS4) 10Jdlrobson: Hygiene: Require new lines before function keyword. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174398 [20:54:19] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Require new lines before function keyword. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174398 (owner: 10Jdlrobson) [20:54:27] kaldari|2: holaaa? [20:54:50] (03PS5) 10Jdlrobson: Hygiene: requirePaddingNewlinesBeforeKeywords for function keyword. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174398 [20:54:51] nuria__: howdy, meeting starting soon? [20:54:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: requirePaddingNewlinesBeforeKeywords for function keyword. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174398 (owner: 10Jdlrobson) [20:55:24] kaldari|2: ah you are coming ! good, somehow i do not see you in the invite, talk to you then [20:55:34] cool [20:56:42] (03CR) 10Jdlrobson: [C: 04-1] Let PHP check, if the user can edit a page or not (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [20:56:59] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [20:57:24] ^ kaldari|2 [20:58:03] nuria__: I couldn't really follow your comments on the Phabricator ticket. Could you perhaps create a page on mediawiki.org called 'EventLogging debugging' and write it up there? [20:58:37] kaldari|2: sure, the dev server on vagrant is already documented [20:59:03] kaldari|2: see: https://www.mediawiki.org/wiki/Extension:EventLogging/Guide#Installing_the_EventLogging_devserver [20:59:41] nuria__: I need to be able to debug eventlogging on the cluster mostly [20:59:57] nuria__: Also, I haven't been able to find the logs you mention on terbium [21:00:20] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [21:00:32] kaldari|2: that is what i do not get, what is missing on vagrant/beta labs for you to test? [21:00:40] nuria__: edge cases [21:00:44] kaldari|2: we can talk about that now [21:01:25] hi kaldari|2. when are we planning to stop the test? is it some time today? [21:01:31] nuria__: My issue isn't so much QA, it's debugging production issues. Basic QA for EventLogging I can handle [21:02:07] lzia: yes, 4pm [21:02:31] great! I'll run the analysis on it then. thanks kaldari|2. [21:05:09] (03Merged) 10jenkins-bot: Hygiene: Update documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180661 (owner: 10Bmansurov) [21:05:33] (03CR) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [21:05:41] jdlrobson: what should I do to make jscs run as part of Jenkins? [21:05:52] bmansurov: it uses the Gruntfile [21:06:06] so just remove the make jscsdoc and port all the config over to the existing jscs command [21:06:52] (03PS10) 10Jdlrobson: Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [21:06:59] (03CR) 10Jdlrobson: [C: 031] Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [21:07:07] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [21:08:21] (03PS1) 10Bmansurov: Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 [21:08:37] bmansurov: there are still some warnings it seems [21:08:40] want to divide and conquer? [21:08:43] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [21:09:02] I'll take loggingSchemas api.js, Icon.js [21:09:28] (03PS17) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 [21:09:32] jdlrobson: let's merge this last one first [21:09:58] (03CR) 10jenkins-bot: [V: 04-1] Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov) [21:10:10] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [21:11:29] jdlrobson: can you +2 ^ now? [21:11:49] (03CR) 10jenkins-bot: [V: 04-1] Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [21:13:38] (03CR) 10Jdlrobson: [C: 031] Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [21:13:49] bmansurov: even with that patch there are still issues [21:13:55] hence why i'm working on loggingSchemas api.js, Icon.js [21:14:00] i tested it locally after all.. :) [21:14:13] jdlrobson: sure I want to get that and then work on the issues that you're not working on [21:15:18] jdlrobson: does a +1 merge too? [21:16:21] (03PS18) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 [21:17:04] bmansurov: you need a verified and a code review, both +2 [21:17:16] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [21:17:44] bmansurov: jenkins fails tend to be due to race conditions so i'm giving it time to breath [21:17:45] bmansurov: you can manually merge without jenkins to pass the test when you add yourself a +2 to verified [21:17:56] never do +2 verified though [21:18:04] unless you have permission from the team due to a known problem [21:18:30] jdlrobson: yup, i just said, that's possible :) [21:18:47] that's not the reason why we use a ci system to bypass it :) [21:18:53] (03CR) 10jenkins-bot: [V: 04-1] Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [21:19:39] (03Merged) 10jenkins-bot: Hygiene: Update search, talk, and TOC documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180668 (owner: 10Bmansurov) [21:21:05] (03PS19) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 [21:21:59] (03PS1) 10Jdlrobson: Hygiene: Complete documentation for logging schemas, Api and Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 [21:25:47] jdlrobson: i'm working on wikigrok and nearby documentation [21:26:02] ok i'll take what's left [21:26:18] I'll do uploads to start off with [21:29:11] (03CR) 10Hashar: "The followup is tracked in Trello: https://trello.com/c/47nS4Be4/55-spike-audit-rl-module-structure" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180748 (owner: 10Phuedx) [21:30:49] (03PS1) 10MaxSem: Expose Wikidata descriptions via mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180895 [21:32:18] (03CR) 10jenkins-bot: [V: 04-1] Expose Wikidata descriptions via mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180895 (owner: 10MaxSem) [21:33:00] fuck you jerkins [21:33:38] (03PS2) 10MaxSem: Expose Wikidata descriptions via mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180895 [21:34:11] (03PS2) 10Esanders: Give editor an empty label to prevent rendering bug [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180772 [21:34:21] (03CR) 10Dbrant: [C: 032] Go to first suggestion on search submit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180848 (owner: 10BearND) [21:35:25] nuria__: Where are those logs on terbium? I checked in /var/log/ and /var/log/upstart/ but didn't see them? [21:35:41] kaldari|2: in beta-labs? [21:35:53] (03PS1) 10Jdlrobson: Hygiene: Add documentation for PhotoApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180897 [21:35:56] nuria__: oops, nevermind... I read your comment wrong [21:36:01] kaldari|2: the ones that list errors? [21:36:33] kaldari|2: ah, sorry.Those are avialable to all in beta labs and -as christian said- restricted in vanadium [21:36:45] (03CR) 10Jdlrobson: [C: 032] Give editor an empty label to prevent rendering bug (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180772 (owner: 10Esanders) [21:37:32] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add documentation for PhotoApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180897 (owner: 10Jdlrobson) [21:37:40] nuria__: got it. I just found them. Thanks! [21:38:10] (03Merged) 10jenkins-bot: Give editor an empty label to prevent rendering bug [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180772 (owner: 10Esanders) [21:38:31] (03PS1) 10Bmansurov: Update WikiGrok and specials/nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180898 [21:39:15] nuria__: Tried to tail the log for beta labs, but looks like it's restricted: cannot open `eventlogging_processor-server-side-events.log' for reading: Permission denied [21:39:30] kaldari|2: argh, sudo stuff, let me make them 777 [21:39:37] nuria__: thanks [21:41:45] kaldari|2: sorry, not 777 but +r, try now [21:42:00] (03PS1) 10Jdlrobson: Hygiene: Photo upload overlay documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180900 [21:42:02] nuria__: yay, that works! [21:42:07] (03PS2) 10Bmansurov: Hygiene: Update WikiGrok and specials/nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180898 [21:42:32] kaldari|2: ok, you will see also url-encoding errors there those are pretty useful [21:42:50] cool [21:43:16] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update WikiGrok and specials/nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180898 (owner: 10Bmansurov) [21:43:25] bmansurov: what are you working on ow? [21:43:31] can you take a look at my hygiene patches? [21:43:34] reviewing your patch [21:43:39] yep [21:43:56] bmansurov: i'm looking at PhotoUploaderButton.js : [21:44:14] (03CR) 10Bmansurov: Hygiene: Add documentation for PhotoApi (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180897 (owner: 10Jdlrobson) [21:48:05] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Complete documentation for logging schemas, Api and Icon (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 (owner: 10Jdlrobson) [21:48:28] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update WikiGrok and specials/nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180898 (owner: 10Bmansurov) [21:49:11] bmansurov: you know method isn't required right? [21:49:27] jdlrobson: is it not? [21:49:47] nope it's clever enough to imply it [21:49:51] jdlrobson: I thought method name was not required [21:50:05] (03PS1) 10Jdlrobson: Hygiene: Document PhotoUploaderButton.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180901 [21:53:21] (03PS2) 10Jdlrobson: Hygiene: Complete documentation for logging schemas, Api and Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 [21:53:33] (03CR) 10Jdlrobson: [C: 031] Hygiene: Update WikiGrok and specials/nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180898 (owner: 10Bmansurov) [21:53:39] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update WikiGrok and specials/nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180898 (owner: 10Bmansurov) [21:55:37] (03CR) 10Bmansurov: [C: 032] Hygiene: Photo upload overlay documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180900 (owner: 10Jdlrobson) [21:56:05] (03Merged) 10jenkins-bot: Hygiene: Update WikiGrok and specials/nearby documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180898 (owner: 10Bmansurov) [21:58:08] jdlrobson: i'm working on watchstar and tutorial docs [22:01:33] bmansurov: have meeting now [22:02:58] think talk, watchstar, mediaviewer and tutorials are all that is left :) [22:07:16] 3Wikipedia-App-Android-App: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#934106 (10bearND) The API returns always the current time for lastmodified: https://en.m.wikipedia.org/w/api.php?action=mobileview&format=json&page=File%3AFEMA+-+25380+-+Photograph+by+Bar... [22:10:43] (03PS1) 10Bmansurov: Hygiene: Update editor, mediaviewer, talk, tutorials, and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180912 [22:16:05] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Complete documentation for logging schemas, Api and Icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 (owner: 10Jdlrobson) [22:17:48] (03PS3) 10Jdlrobson: Hygiene: Complete documentation for logging schemas, Api and Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 [22:21:14] (03PS9) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [22:22:54] jdlrobson: how about a +2 for the new Talk page element in the interest of getting the build back to green overnight? It'll go red again as soon as the locator changes I think. https://gerrit.wikimedia.org/r/#/c/180866/ [22:29:49] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Complete documentation for logging schemas, Api and Icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 (owner: 10Jdlrobson) [22:29:57] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [22:38:38] reminder: the research showcase is starting at 3 pm PT on the Collab space on 6. We’ll be talking about mobile readership and how Wikipedia traffic data helps monitor flu outbreaks. Streaming: https://www.youtube.com/watch?v=xPO8XhmeUAU Discussion: #wikimedia-research [22:42:15] Thanks for the reminder DarTar, looking forward to it [22:43:49] bmansurov: same here [22:44:05] (03CR) 10Jdlrobson: Hygiene: Complete documentation for logging schemas, Api and Icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 (owner: 10Jdlrobson) [23:06:11] (03PS2) 10Jdlrobson: Hygiene: Photo upload overlay documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180900 [23:06:19] (03CR) 10Jdlrobson: [C: 032] Hygiene: Photo upload overlay documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180900 (owner: 10Jdlrobson) [23:07:20] https://trello.com/b/zirV6gr0/mobile-app-sprint-48-ios-5th-jan-19th-jan [23:09:59] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Photo upload overlay documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180900 (owner: 10Jdlrobson) [23:13:12] https://trello.com/b/QU74xgux/mobile-app-sprint-48-android-5th-jan-19th-jan [23:13:54] http://hatjitsu.wmflabs.org/27222 [23:18:06] (03CR) 10Kaldari: ">wouldn't scoping it to user generated content be bad as well? If there is any content on WMF wikis with padding and width it was almost c" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [23:21:48] http://hatjitsu.wmflabs.org/27222 [23:32:12] (03PS10) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [23:32:46] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [23:36:44] (03CR) 10Jdlrobson: [C: 031] "reheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180900 (owner: 10Jdlrobson) [23:36:51] (03CR) 10Jdlrobson: [C: 032] Hygiene: Photo upload overlay documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180900 (owner: 10Jdlrobson) [23:37:33] (03CR) 10Esanders: "Thanks Ryan, that's a good point. I know MF is a bit more agressive with re-styling page content than just a regular skin and I don't want" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [23:38:27] (03Merged) 10jenkins-bot: Hygiene: Photo upload overlay documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180900 (owner: 10Jdlrobson) [23:39:26] looks like the ios app allows anonymous editing, and from what I can tell it gets an edit token from a call like: http://en.wikipedia.org/w/api.php?action=query&meta=tokens&format=json [23:39:29] (03CR) 10Kaldari: [C: 04-1] Let PHP check, if the user can edit a page or not (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [23:39:42] but when I make that call without a logged in session I always get a blank token [23:41:14] guess I didn't even try to POST an edit with a blank token [23:42:42] (03CR) 10Jdlrobson: Hygiene: Add documentation for PhotoApi (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180897 (owner: 10Jdlrobson) [23:42:44] bmansurov: i'm back [23:42:50] how close are we to wrapping this stuff up? [23:42:54] (03PS2) 10Jdlrobson: Hygiene: Add documentation for PhotoApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180897 [23:43:11] jdlrobson: you're patches are the last remaining bits [23:43:21] can you review them? [23:43:31] jdlrobson: yes, it's pending your change [23:43:49] jdlrobson: https://gerrit.wikimedia.org/r/#/c/180892/ [23:45:11] (03CR) 10Bmansurov: [C: 032] Hygiene: Add documentation for PhotoApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180897 (owner: 10Jdlrobson) [23:45:40] bmansurov: cherry pick them to master [23:45:43] (03PS4) 10Jdlrobson: Hygiene: Complete documentation for logging schemas, Api and Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 [23:45:50] they are just chained that way. no need for them to be [23:46:11] tfinc: Can you come to Chambers? [23:46:19] (03PS3) 10Bmansurov: Hygiene: Add documentation for PhotoApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180897 (owner: 10Jdlrobson) [23:47:26] (03PS5) 10Bmansurov: Hygiene: Complete documentation for logging schemas, Api and Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 (owner: 10Jdlrobson) [23:47:42] (03CR) 10Bmansurov: [C: 032] Hygiene: Complete documentation for logging schemas, Api and Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 (owner: 10Jdlrobson) [23:48:01] (03PS24) 10Jdlrobson: Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 [23:48:21] jdlrobson: also https://gerrit.wikimedia.org/r/#/c/180912/ for you to review [23:49:13] (03CR) 10Jdlrobson: [C: 032] QA: update locator for talk button (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180866 (owner: 10Cmcmahon) [23:49:17] jdlrobson: https://phabricator.wikimedia.org/T78590#850957 [23:49:33] I need more data if you want anything to change on the Jenkins side. [23:49:34] (03CR) 10Kaldari: [C: 04-1] "-1-ing as the current patch may cause problems with our restyling of user-generated content (typically where we are applying max-width: 10" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders) [23:50:24] I suspect methods called from MF unti tests fire off asynchronous actions that should not be fired off and are also note waited for (e.g. maybe needs a callback or promise) [23:50:33] debug in chrome dev tools to find out :) [23:50:48] (03CR) 10jenkins-bot: [V: 04-1] Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [23:55:51] (03Merged) 10jenkins-bot: Hygiene: Complete documentation for logging schemas, Api and Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180892 (owner: 10Jdlrobson) [23:55:58] (03Merged) 10jenkins-bot: QA: update locator for talk button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180866 (owner: 10Cmcmahon) [23:58:27] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Update editor, mediaviewer, talk, tutorials, and watchstar documentation (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180912 (owner: 10Bmansurov) [23:59:39] (03PS25) 10Jdlrobson: Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 [23:59:48] (03CR) 10Kaldari: "@Esanders: grep for 'width: 100%' in our less dir and you can find most of the examples. Apart from user content, we would also need to ei" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)