[00:00:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Code format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171552 (owner: 10Jhernandez)
[00:03:38] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Fix broken switcher icons in alpha for VE (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) (owner: 10Bmansurov)
[00:04:19] <grrrit-wm>	 (03CR) 10Jdlrobson: Put icon and text on the same line in VE switcher dropdown (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171771 (owner: 10Bmansurov)
[00:06:32] <grrrit-wm>	 (03PS10) 10Jdlrobson: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow)
[00:07:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow)
[00:07:38] <grrrit-wm>	 (03PS4) 10Jdlrobson: Only load notifications and user module where necessary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171158 
[00:07:43] <grrrit-wm>	 (03PS3) 10Jdlrobson: Fix the language sorter mess [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 
[00:07:44] <kaldari|2>	 MaxSem: So Maryana and Jon have proposed pushing the current MF + WikGrok masters to en.wiki so that we can start doing our WikiGrok A/B test (without cherrypicking 15+ separate changes). The branch that was cut from master yesterday wmf7 doesn't seem to have broken anything. What do you think of this idea?
[00:07:50] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Kill unnecessary mobile.beta.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171170 
[00:07:55] <grrrit-wm>	 (03PS3) 10Jdlrobson: Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 
[00:08:08] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 
[00:08:19] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 
[00:08:24] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 
[00:08:28] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 
[00:08:37] <MaxSem>	 kaldari|2, I think all WikiGrok code should be in... WIkiGrok so that we woudn't need to commit such acts of violence
[00:09:02] <kaldari|2>	 MaxSem: I agree, but haven't been able to convince jdlrobson :(
[00:09:27] <MaxSem>	 you're tech lead
[00:09:37] <MaxSem>	 you just say DO IT
[00:09:37] <jdlrobson>	 Your funeral.
[00:09:50] <kaldari|2>	 I like to lead by consensus :P
[00:10:00] <kaldari|2>	 which I guess doesn't work so well
[00:10:05] <jdlrobson>	 if you want to slow the team down and make things even more of a clusterf**k go for it but i will continuously tell you i told you so
[00:10:27] <MaxSem>	 other than that, it's a question to Greg, really
[00:10:35] <jdlrobson>	 Wikigrok uses the same frontend code as mobile. its never going to be as easy as just deploying Wikigrok
[00:10:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 (owner: 10Jdlrobson)
[00:10:54] <jdlrobson>	 anyway once we have weekly deployments this problem goes away. At least see how things are when that hapens
[00:11:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 (owner: 10Jdlrobson)
[00:11:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 (owner: 10Jdlrobson)
[00:11:24] <grrrit-wm>	 (03PS1) 10Bmansurov: Fix close icon in image overlay (alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171773 (https://bugzilla.wikimedia.org/73052) 
[00:11:25] <MaxSem>	 our code already gets deployed weekly, right?
[00:11:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 (owner: 10Jdlrobson)
[00:11:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 (owner: 10Jdlrobson)
[00:12:11] <grrrit-wm>	 (03PS4) 10Jdlrobson: Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 
[00:12:19] <jdlrobson>	 MaxSem: soon it should get deployed weekly to enwiki
[00:12:22] <kaldari|2>	 jdlrobson, MaxSem: what if we made WikiGrok a submodule of MF?
[00:12:37] <kaldari|2>	 the front-end piece I mean
[00:12:56] <MaxSem>	 what would it change, other than turning MF into Wikidata?
[00:13:02] <jdlrobson>	 kaldari|2: you are still failing to show me why we need this. If Lightning deployments being hard is the only reason, that's a crappy reason
[00:13:12] <jdlrobson>	 1) we shouldn't need lightning deploys, we should be writing better code to start off with
[00:13:32] <jdlrobson>	 2) if we have faster deployment schedules we won't have to cherrypick patches against old out of date branches
[00:13:38] <MaxSem>	 there is no lightning deployments
[00:13:57] <MaxSem>	 you can't deploy new code dring SWAT, only bugfixes
[00:14:23] <kaldari|2>	 jdlrobson: well, I guess I'll see how things shake out with Greg on this 1-week cycle idea
[00:14:38] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 
[00:15:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 (owner: 10Jdlrobson)
[00:16:12] <jdlrobson>	 kaldari|2: it's looking good i just got a mail from him and the first reply was JFDI
[00:23:02] <grrrit-wm>	 (03PS1) 10Kaldari: Fix WikiGrokDialogB answer recording [extensions/MobileFrontend] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171778 
[00:24:45] <kaldari|2>	 MaxSem: In the meantime, could we SWAT deploy this one patch to wmf7 (critical bugfix that missed the train): https://gerrit.wikimedia.org/r/#/c/171778/
[00:25:12] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032 V: 032] Fix WikiGrokDialogB answer recording [extensions/MobileFrontend] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171778 (owner: 10Kaldari)
[00:26:11] <grrrit-wm>	 (03PS2) 10Bmansurov: Fix broken switcher icons in alpha for VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) 
[00:27:33] <kaldari|2>	 MaxSem: Thanks, I added it to the deployment calendar so there's a record.
[00:30:52] <leila>	 kaldari|2, what type of questions we're considering? Only ones for which the answer is Yes, No, I don't know? or we also can consider tags?
[00:31:37] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 
[00:31:39] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 
[00:31:41] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 
[00:31:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix WikiGrokDialogB answer recording [extensions/MobileFrontend] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171778 (owner: 10Kaldari)
[00:32:02] <kaldari|2>	 All questions should basically be: "Is this claim true: <property> is <value>?" No freeform text questions.
[00:33:17] <kaldari|2>	 leila: Generally any questions should be able to fit either into the Yes/No/Not Sure interface or as a binary (off/on) tag.
[00:33:50] <leila>	 yes, but we don't consider free form text?
[00:34:29] <kaldari|2>	 leila: No, because then we have to build an interface for moderation/oversight/legal issues, etc.
[00:34:53] <kaldari|2>	 Which is part of what killed ArticleFeedback
[00:35:28] <leila>	 I see
[00:35:46] <kaldari|2>	 leila: We've talked about it, but want to stay away from it for the first version at least
[00:36:42] <leila>	 makes sense, and I'd like to hear more about it over lunch. For now, it makes me narrow down my search
[00:37:23] <kaldari|2>	 leila: In theory, we can support multiple choice, but the fewer choices the better.
[00:37:43] <leila>	 yup, kaldari|2.
[00:38:37] <kaldari|2>	 leila: For example, for all US politicians we could ask users if they are Democrat or Republican. In the tag interface this would be two tags. In the binary choice interface, it would present one of the 2 choices randomly.
[00:40:37] <kaldari|2>	 leila: We can discuss more over lunch tomorrow if you like
[00:40:48] <MaxSem>	 George Washington -> US politician -> R or D? -> butthurt
[00:40:51] <leila>	 I'm looking at co-occuring properties to see if I can find couple of candidates quickly. If not, I have to think of more rigorous ways of finding pairs
[00:41:04] <kaldari|2>	 MaxSem: yes, not an ideal example
[00:41:16] <leila>	 tomorrow is wfh, next week, kaldari|2. :-)
[00:41:20] <kaldari|2>	 sure
[00:41:52] <grrrit-wm>	 (03PS6) 10Bmansurov: Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 
[00:45:42] <kaldari|2>	 MaxSem: Is that deployment complete to testwiki now?
[00:45:57] <MaxSem>	 everywhere
[00:46:38] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 
[00:47:49] <Deskana>	 jdlrobson, greg-g: Pretty sure we don't use extracts.
[00:47:59] <grrrit-wm>	 (03PS1) 10Bmansurov: Center the CTA drawer icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171782 (https://bugzilla.wikimedia.org/73059) 
[00:48:34] <grrrit-wm>	 (03PS4) 10Jdlrobson: Fix the language sorter mess [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 
[00:49:00] <grrrit-wm>	 (03Abandoned) 10Bmansurov: WIP Fix alpha icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170831 (owner: 10Bmansurov)
[00:49:27] <wikibugs>	 3MobileFrontend / 3Hygiene: Running QUnit is logging events - 10https://bugzilla.wikimedia.org/73106 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon We should ensure that eventlogging doesn't run on the unit tests...  Running QUnit tests... Using http://127.0.0.1:8080/w/index.php/ as a development environmen...
[00:50:26] <wikibugs>	 3MobileFrontend / 3Hygiene: Running QUnit is logging events - 10https://bugzilla.wikimedia.org/73106#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/zH00abpt
[00:51:06] <Deskana>	 greg-g: Yep, looked at the codebase and confirmed that there are no API queries with an "extracts" parameter in the apps.
[00:52:58] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Fix the language sorter mess [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 
[00:53:08] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Kill unnecessary mobile.beta.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171170 
[00:53:13] <grrrit-wm>	 (03PS5) 10Jdlrobson: Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 
[00:53:18] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 
[00:53:22] <grrrit-wm>	 (03PS1) 10Bmansurov: Set heading cursor to pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171783 (https://bugzilla.wikimedia.org/73054) 
[00:53:24] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 
[00:53:27] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 
[00:54:26] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 
[01:00:43] <wikibugs>	 3MobileFrontend / 3General/Unknown: PHP notice in hhvm.log - 10https://bugzilla.wikimedia.org/73109 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None Nov  7 00:57:26 mw1189:  #012Notice: Undefined index: lastmodifiedby in /srv/mediawiki/php-1.25wmf6/extensions/MobileFrontend/includes/api/ApiMobil...
[01:05:25] <wikibugs>	 3MobileFrontend / 3General/Unknown: PHP notice in hhvm.log - 10https://bugzilla.wikimedia.org/73109#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/7A2WdG6x
[01:06:30] <kaldari|2>	 DarTar: my username on stat1003 is kaldari BTW
[01:06:47] <kaldari|2>	 in case that isn't obvious :)
[01:07:00] <kaldari|2>	 for requesting permission
[01:07:12] <grrrit-wm>	 (03Abandoned) 10BearND: WIP: Disambiguation and page issues more like search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171442 (owner: 10BearND)
[01:09:15] <grrrit-wm>	 (03PS5) 10Jdlrobson: WIP: Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 
[01:10:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 (owner: 10Jdlrobson)
[01:21:52] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Fix wgMFShowRedLinks (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow)
[01:25:43] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Table of contents heading is not a section-heading." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171783 (https://bugzilla.wikimedia.org/73054) (owner: 10Bmansurov)
[01:27:28] <wikibugs>	 3MobileFrontend / 3alpha: Table of contents icon in alpha is small and not aligned correctly - 10https://bugzilla.wikimedia.org/73115 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 17068   --> https://bugzilla.wikimedia.org/attachment.cgi?id=17068&action=edit Small and not aligned correc...
[01:29:39] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Fix close icon in image overlay (alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171773 (https://bugzilla.wikimedia.org/73052) (owner: 10Bmansurov)
[01:30:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix close icon in image overlay (alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171773 (https://bugzilla.wikimedia.org/73052) (owner: 10Bmansurov)
[01:30:29] <wikibugs>	 3MobileFrontend / 3alpha: Table of contents icon in alpha is small and not aligned correctly - 10https://bugzilla.wikimedia.org/73115#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9bDtykVW
[01:31:27] <wikibugs>	 3Wikipedia App / 3Android App: 'edit' is not showing up as event_source for applogin schema - 10https://bugzilla.wikimedia.org/73116 (10Jon Katz) 3NEW p:3Unprio s:3normal a:3None In event logging, there are 0 instances of 'edit' as a source of either login or create account.
[01:32:26] <kaldari|2>	 MaxSem: For some reasons I can't get CSRF tokens to be accepted via Special:ApiSandbox on either test or test2, but they work fine on en.wiki.
[01:32:28] <grrrit-wm>	 (03PS2) 10Bmansurov: Set collapsible-heading cursor to pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171783 (https://bugzilla.wikimedia.org/73054) 
[01:32:52] <kaldari|2>	 MaxSem: Can you see if it works for you?
[01:36:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Center the CTA drawer icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171782 (https://bugzilla.wikimedia.org/73059) (owner: 10Bmansurov)
[01:40:20] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "See previous comments on older patchset" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov)
[01:40:32] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Set collapsible-heading cursor to pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171783 (https://bugzilla.wikimedia.org/73054) (owner: 10Bmansurov)
[01:41:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set collapsible-heading cursor to pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171783 (https://bugzilla.wikimedia.org/73054) (owner: 10Bmansurov)
[01:43:50] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Fix broken switcher icons in alpha for VE (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) (owner: 10Bmansurov)
[01:44:22] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Put icon and text on the same line in VE switcher dropdown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171771 (owner: 10Bmansurov)
[01:46:29] <MaxSem>	 kaldari|2, "info": "You must specify at least one claim.",
[01:46:38] <MaxSem>	 so works for me
[01:52:21] <grrrit-wm>	 (03CR) 10Bmansurov: Update reference drawer styling (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov)
[01:55:07] <grrrit-wm>	 (03PS2) 10Bmansurov: Center the CTA drawer icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171782 (https://bugzilla.wikimedia.org/73059) 
[01:55:47] <grrrit-wm>	 (03CR) 10Bmansurov: Center the CTA drawer icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171782 (https://bugzilla.wikimedia.org/73059) (owner: 10Bmansurov)
[01:58:07] <grrrit-wm>	 (03CR) 10Bmansurov: Fix broken switcher icons in alpha for VE (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) (owner: 10Bmansurov)
[02:00:43] <grrrit-wm>	 (03CR) 10Bmansurov: Put icon and text on the same line in VE switcher dropdown (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171771 (owner: 10Bmansurov)
[02:03:11] <wikibugs>	 3Wikipedia App / 3Android App: 'edit' is not showing up as event_source for applogin schema - 10https://bugzilla.wikimedia.org/73116#c1 (10Dan Garry) 5NEW>3RESO/WOR It's impossible to get from edit to create account, so it is correct that there are no such events logged.  I tested the login bit, by makin...
[02:29:54] <wikibugs>	 3MobileFrontend / 3alpha: Alpha:No cursor icon when you hover over a section - 10https://bugzilla.wikimedia.org/73054 (10Jon) 5PATC>3RESO/FIX
[04:05:41] <wikibugs>	 3MobileFrontend / 3alpha: Alpha: Close icon in image overlay - 10https://bugzilla.wikimedia.org/73052 (10Jon) 5PATC>3RESO/FIX
[06:08:54] <wikibugs>	 3MobileFrontend / 3alpha: When $wgMFAnonymousEditing is enabled pencil icon is preloaded locked - 10https://bugzilla.wikimedia.org/72851#c5 (10Nemo) 5RESO/WOR>3REOP No, it's still the same.
[06:22:25] <wikibugs>	 3MobileFrontend / 3alpha: When $wgMFAnonymousEditing is enabled pencil icon is preloaded locked - 10https://bugzilla.wikimedia.org/72851#c6 (10Jon) Okay yes I can see this on my phone. It wasn't noticeable on my desktop connection because of the fast connection.  I'll take a look at code tomorrow. Obviously...
[06:28:30] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 (owner: 10Jdlrobson)
[06:33:23] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Enforce requireSpacesInsideParentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171766 (owner: 10Jdlrobson)
[06:37:51] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Add CategoryOverlay to show categories of a page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow)
[06:42:57] <grrrit-wm>	 (03PS8) 10Florianschmidtwelzow: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) 
[07:07:22] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Fix wgMFShowRedLinks (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow)
[09:16:05] <joakino>	 phuedx: good morning
[09:41:48] <phuedx>	 morning joakino
[09:43:39] <joakino>	 :)
[09:44:35] * phuedx is gonna get ready for work
[09:44:59] <joakino>	 yeah!
[09:45:54] <joakino>	 phuedx: have you noticed a change of pace in the team?
[09:46:40] <joakino>	 I heard several times that we were going faster
[10:06:52] <phuedx>	 joakino: yeah, i think we're going faster now that the new guys (myself included) are sorta spun up
[10:06:56] <phuedx>	 i think we can go faster still
[10:07:16] <YuviPanda>	 Ludicrousspeeeeedddd!
[10:07:28] <phuedx>	 hey YuviPanda 
[10:07:42] <YuviPanda>	 heya!
[10:08:05] <phuedx>	 how're you?
[10:08:11] <YuviPanda>	 I'm ok
[10:09:44] <joakino>	 do you think the practices need changes?
[10:09:44] <joakino>	 phuedx: i feel like we've run out of time for prioritizing stuff in the meetings I've been
[10:09:52] <phuedx>	 joakino: yes
[10:10:01] <phuedx>	 see my email to jon/the team
[10:10:17] <phuedx>	 i really do believe that discussion is the most important part of feature development
[10:10:25] <phuedx>	 s/feature //
[10:10:51] <phuedx>	 joakino: but i don't think we need to change /that/ much
[10:10:58] <phuedx>	 more emphasis on planning
[10:11:02] <joakino>	 phuedx: so a bit more meeting time?
[10:11:05] <phuedx>	 story writing sessions, which i think happen already
[10:11:08] <phuedx>	 joakino: yeah
[10:11:21] <phuedx>	 if we ever figure out how to plan sprints asynchronously
[10:11:35] <phuedx>	 then i reckon we should quit our day jobs and become speakers full time ;)
[10:12:09] <joakino>	 yeah haha
[10:13:02] <joakino>	 phuedx: did you assist to yesterdays phabricator meeting?
[10:13:08] <phuedx>	 joakino: nope
[10:13:14] <phuedx>	 my connection is still fuzzy
[10:13:29] <phuedx>	 i'm currently looking into getting a fibre directly to my house
[10:13:38] <phuedx>	 /not from bt/
[10:13:46] <joakino>	 cool
[10:14:11] <joakino>	 50mb? 100?
[10:14:33] <phuedx>	 hopefully 100
[10:14:48] <phuedx>	 but the company that is offering to do it is saying that they'd like a few more people on my road to sign up
[10:14:59] <phuedx>	 so that they can make it cheaper for me
[10:15:11] <phuedx>	 ^ i.e. more profitable for them
[10:17:10] <phuedx>	 they'll lay to the street, then branch
[10:17:25] <phuedx>	 so it ain't /direct/ to the house at all, scratch what i said before
[10:17:39] * phuedx is reading their website again
[10:18:22] <joakino>	 sounds good in any case
[10:18:46] <joakino>	 you are going to sell internet offers to your neighbours haha
[10:20:41] <phuedx>	 if it gets me even 20, i'd be happy
[10:21:10] <phuedx>	 joakino: but back to the going faster thing
[10:21:17] <phuedx>	 i think we need more than one project on the go
[10:21:36] <joakino>	 phuedx: yeah that's for sure, all of us on wikigrok is too many
[10:31:05] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Center the CTA drawer icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171782 (https://bugzilla.wikimedia.org/73059) (owner: 10Bmansurov)
[10:31:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Center the CTA drawer icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171782 (https://bugzilla.wikimedia.org/73059) (owner: 10Bmansurov)
[10:58:11] <grrrit-wm>	 (03CR) 10Phuedx: [C: 031] Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow)
[12:12:55] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "I'm going to add the rule to jscs so that it is actually enforced by the tools" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171766 (owner: 10Jdlrobson)
[12:13:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Enforce requireSpacesInsideParentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171766 (owner: 10Jdlrobson)
[12:14:55] <grrrit-wm>	 (03PS1) 10Jhernandez: Tools: Enforce requireSpacesInsideParentheses in JS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171818 
[12:16:07] <grrrit-wm>	 (03PS2) 10Jhernandez: Tools: Enforce requireSpacesInsideParentheses in JS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171818 
[12:30:59] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Tools: Complain about spaces missing inside parentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171738 (owner: 10Jdlrobson)
[12:31:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tools: Complain about spaces missing inside parentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171738 (owner: 10Jdlrobson)
[12:31:56] <grrrit-wm>	 (03Abandoned) 10Jhernandez: Tools: Enforce requireSpacesInsideParentheses in JS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171818 (owner: 10Jhernandez)
[12:56:48] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Only load notifications and user module where necessary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171158 (owner: 10Jdlrobson)
[13:03:40] <joakino>	 phuedx: do you know how to set mw up locally with multiple languages?
[13:03:50] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Hygiene: Fix the language sorter mess [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 (owner: 10Jdlrobson)
[13:05:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only load notifications and user module where necessary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171158 (owner: 10Jdlrobson)
[13:08:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Fix the language sorter mess [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 (owner: 10Jdlrobson)
[13:08:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Kill unnecessary mobile.beta.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171170 (owner: 10Jdlrobson)
[13:11:04] <phuedx>	 joakino: sorry, was out for lunch
[13:11:19] <joakino>	 dont worry!
[13:11:24] <joakino>	 no rush
[13:12:37] <phuedx>	 joakino: how do you mean? do you mean forcing another language?
[13:12:41] <phuedx>	 if so, then: https://www.mediawiki.org/wiki/Manual:Parameters_to_index.php#User_preference_overriding
[13:14:13] <joakino>	 phuedx: not that, but for testing language switching stuff
[13:14:37] <phuedx>	 joakino: can you give me an example?
[13:15:13] <joakino>	 phuedx: you go to an article, scroll to the bottom, click on "Read in another language", then the overlay shows up, and you can choose a different language
[13:16:05] <joakino>	 this thingy https://en.m.wikipedia.org/wiki/Kate_Upton#/languages
[13:23:07] * phuedx just spent the last few minutes going down a rabbit hole
[13:23:24] <phuedx>	 joakino: https://en.wikipedia.org/wiki/Help:Interlanguage_links
[13:28:07] <joakino>	 phuedx: i've added a few links to an article but they are in the text and no changelanguage button
[13:28:17] <joakino>	 do i need to enable any role?
[13:28:21] <phuedx>	 hoom
[13:28:54] <phuedx>	 joakino: i don't /think/ so
[13:29:30] <joakino>	 [[ar:عوالق]]
[13:29:30] <joakino>	 [[el:Πλαγκτόν]]
[13:29:30] <joakino>	 like this, right?
[13:30:03] <phuedx>	 yeah, i think so
[13:30:57] <joakino>	 phuedx: not working, there is an interwiki role 
[13:31:09] <phuedx>	 i've just seen that
[13:31:11] <phuedx>	 go for it!
[13:42:10] <joakino>	 didn't work
[14:27:33] <grrrit-wm>	 (03PS2) 10Phuedx: WIP WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 
[14:28:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx)
[14:30:58] <joakino>	 I'm out for lunch!
[14:44:23] <grrrit-wm>	 (03PS3) 10Phuedx: WIP WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 
[14:53:00] <grrrit-wm>	 (03PS4) 10Phuedx: WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 
[15:25:55] <wikibugs>	 3MobileFrontend / 3stable: Unable to unwatch on Special:EditWatchlist - 10https://bugzilla.wikimedia.org/73098#c3 (10Sam Smith) I can't reproduce this locally.  However on mw.org I had an empty watchlist, I watched Extension:WikiGrok, went to Special:EditWatchlist and saw the empty watchlist page. When I ref...
[15:32:00] <phuedx>	 coffee time!
[15:45:20] <phuedx>	 hey jdlrobson
[16:02:14] <grrrit-wm>	 (03PS8) 10Dbrant: Face detection in lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168773 
[16:14:30] <grrrit-wm>	 (03PS3) 10Dbrant: Wikidata description under page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170698 
[16:17:25] <wikibugs>	 3MobileFrontend / 3stable: Unable to unwatch on Special:EditWatchlist - 10https://bugzilla.wikimedia.org/73098#c4 (10Jon) I'm not seeing any watchstars on beta labs either but am on my local wiki. I must be watching something problematic...
[16:50:38] <grrrit-wm>	 (03PS12) 10Dbrant: [WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 
[16:56:32] <grrrit-wm>	 (03CR) 10Phuedx: "I thought the purpose of this change was to allow the developer to fool WikiGrok into fetching suggestions for a particular ID, not simply" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 (owner: 10MaxSem)
[17:04:07] <grrrit-wm>	 (03PS1) 10Dbrant: Remove pinch-zoom in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171850 
[17:58:09] <MaxSem>	 jdlrobson, https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Error
[18:00:37] <brion>	 where’s my android 5 updateeeeeeeeeeeee 
[18:18:45] <jdlrobson>	 MaxSem: loookinng
[18:21:53] <jdlrobson>	 meh alpha icons problem
[18:22:14] <bmansurov>	 jdlrobson: when you get a sec can you reply to my comments in gerrit? thanks
[18:22:28] <jdlrobson>	 bmansurov: have you got a link handy?
[18:22:36] <jdlrobson>	 i have lots of ongoing reviews :)
[18:23:11] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] "Nice work!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow)
[18:23:13] <bmansurov>	 jdlrobson: yes, there are 3: https://gerrit.wikimedia.org/r/#/c/171612/ and https://gerrit.wikimedia.org/r/#/c/171768/ and https://gerrit.wikimedia.org/r/#/c/171771/ thanks
[18:23:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow)
[18:23:43] <phuedx>	 afdslkjhdsaf
[18:23:52] <phuedx>	 FlorianSW: ^ you want to rebase it, or should i ?
[18:24:26] <wikibugs>	 3MobileFrontend / 3General/Unknown: Unwatching does not work in Firefox (Chrome is OK) - 10https://bugzilla.wikimedia.org/73051#c4 (10Ryan Kaldari) I was seeing this bug earlier but can't reproduce at this point. It must have either been a duplicate of 72984 or a dupe of the module loading bug.
[18:24:46] <jdlrobson>	 hey bmansurov so on subject of icons. goal is to have a bunch of svgs and png fallbacks that are 24px*24px or 12*12px fallback
[18:25:12] <jdlrobson>	 at moment we only support the 24px by 24px ones
[18:25:14] <FlorianSW>	 phuedx: ican do :)
[18:25:34] <jdlrobson>	 TrevorP|Away has a concept of icons and indicators, so technically your 12px should be an indicator
[18:25:44] <jdlrobson>	 but since it's a cancel button i think that's a bad design and you should push for 24px
[18:25:51] <jdlrobson>	 since 12px is simply not clickable on mobile
[18:25:59] <bmansurov>	 jdlrobson: ok
[18:26:10] <jdlrobson>	 have a chat to kaity about tap areas and whether 24px would be an issue
[18:26:21] <jdlrobson>	 bmansurov: thanks for all your patience and hard work around the icons
[18:26:38] <bmansurov>	 jdlrobson: so, if I need an indicator, how do I create one? 
[18:26:41] <phuedx>	 bleh, icons
[18:26:42] <jdlrobson>	 it's in a weird state right now which i'm keen to rectify. TrevorP|Away is working on https://gerrit.wikimedia.org/r/165922
[18:26:48] <jdlrobson>	 which will add icon support to resourceloader
[18:26:58] <jdlrobson>	 as long as we keep everything contained it should be easy to switch over.
[18:27:01] <kaity>	 jdlrobson: bmansurov the cancel button on the citation thing?
[18:27:27] <bmansurov>	 jdlrobson: no, i'll make that 24, but image there is a case where I need a smaller icon
[18:27:50] <bmansurov>	 image -> imagine
[18:28:26] <bmansurov>	 oh kaity|away, do you think I should make the cancel button 24 px?
[18:30:04] <jdlrobson>	 FlorianSW: are you rebasing your categories patch? keen to see it in action :)
[18:30:22] * FlorianSW is rebasing :D
[18:31:05] <FlorianSW>	 jdlrobson: ^
[18:32:17] <grrrit-wm>	 (03PS9) 10Florianschmidtwelzow: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) 
[18:32:30] <FlorianSW>	 jdlrobson, phuedx: ^
[18:32:49] <phuedx>	 jdlrobson: you want to kick the tyres
[18:32:59] <phuedx>	 i've checked it out locally but i can wait
[18:33:26] <phuedx>	 with categories, with no categories etc
[18:36:27] <jdlrobson>	 FlorianSW:  phuedx: i will take a look in a sec :)
[18:36:35] <kaldari|2>	 phuedx: looks like wikigrok v B is successfully recording responses via the response API, but not version A on test.wiki.
[18:36:44] <kaldari|2>	 So that's good news somewhat :)
[18:36:48] <FlorianSW>	 great, thx jdlrobson :)
[18:36:52] <kaldari|2>	 at least we know the API is working
[18:37:19] <jdlrobson>	 btw sorry phuedx joakino about all the hygiene patches. Resources.php is a huge mess i'm keen to sort out
[18:37:50] <joakino>	 jdlrobson: i'm all for it
[18:38:46] <joakino>	 as long as I understand what I'm seeing and it seems to work, you'll wake up to a clean queue
[18:39:05] <joakino>	 jdlrobson: i'm starting to feel it, it is getting cleaner
[18:39:42] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Address template FIXME, introduce overlay header partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171866 
[18:40:14] <joakino>	 phuedx: so the sprint finishes monday night for us?
[18:40:20] <joakino>	 :p
[18:40:59] <jdlrobson>	 phuedx: technically it finishes at 5pm SF now :)
[18:41:15] <jdlrobson>	 phuedx: the watchlist bug is super weird
[18:41:18] <phuedx>	 kaldari|2: that's just plain weird
[18:41:18] <jdlrobson>	 wish i knew what was going on
[18:41:26] <phuedx>	 jdlrobson: yeah!?
[18:41:31] <phuedx>	 no errors in yer console?
[18:41:52] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Suppress rm-related cronspam [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171867 
[18:42:06] <phuedx>	 kaldari|2: nothing in the console?
[18:42:14] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Suppress rm-related cronspam [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171867 (owner: 10Dr0ptp4kt)
[18:42:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Suppress rm-related cronspam [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171867 (owner: 10Dr0ptp4kt)
[18:42:42] <kaldari|2>	 phuedx: no, the API result in both cases is just []
[18:42:50] <phuedx>	 hrrrm
[18:43:03] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow)
[18:43:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow)
[18:43:58] <phuedx>	 kaldari|2: i think i've got it
[18:44:04] <kaldari|2>	 phuedx: We should check the claim params that are being passed and see if they are different
[18:44:05] <phuedx>	 sec
[18:45:31] <phuedx>	 kaldari|2: found the bug
[18:45:34] <phuedx>	 it's subtle ;)
[18:46:54] <grrrit-wm>	 (03CR) 10Jdlrobson: Fix broken switcher icons in alpha for VE (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) (owner: 10Bmansurov)
[18:50:23] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "Code looks fine. Will need to poke around with it What was it in particular you didn't like about this code phuedx (as stated in standup)?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx)
[18:52:02] <grrrit-wm>	 (03PS1) 10Phuedx: claim.correct must be boolean for WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171871 
[18:52:11] <phuedx>	 kaldari|2: ^
[18:52:26] <phuedx>	 test locally and watch /vagrant/logs/eventlogging.log
[18:52:38] <phuedx>	 you'll see that currently, claim.correct is 1 or 0 not true or false
[18:52:54] <phuedx>	 now, we could forcefully convert claim.correct to a boolean on the server
[18:52:59] <phuedx>	 or error
[18:53:02] <phuedx>	 or fix the client
[18:53:19] <phuedx>	 i've opted for the latter because i know we'll be doing the former as part of the validation thing
[18:53:31] <phuedx>	 gotta go get george to bed
[18:53:35] <phuedx>	 be back in 20
[18:53:44] <kaldari|2>	 phuedx: Ah, nice work. The old Tool Labs API accepted either
[18:53:53] <grrrit-wm>	 (03CR) 10Jdlrobson: Fix wgMFShowRedLinks (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow)
[18:54:02] <kaldari|2>	 phuedx: sounds reasonable
[18:54:48] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] claim.correct must be boolean for WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171871 (owner: 10Phuedx)
[18:55:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: claim.correct must be boolean for WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171871 (owner: 10Phuedx)
[18:55:47] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Also looks like you have a jenkins issue to address?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 (owner: 10MaxSem)
[18:56:06] <bmansurov>	 jdlrobson: you said I should not change the background size. Instead I should change the SVG file. So I did change the svg file, but icons.less, the background is set to 24x auto, which is bigger than what I need. How would you make that icon look smaller?
[18:57:59] <jdlrobson>	 bmansurov: when changing the svg file you should be simply making the svg fit to the viewport.
[18:58:29] <jdlrobson>	 bmansurov: you can apply one the icon classes if you need to for beta/stable. e.g. icon-24px
[18:58:44] <jdlrobson>	 i'm hoping to get the new icons code in beta asap as i don't like the messy state we are currently in
[18:58:59] <bmansurov>	 jdlrobson: should I just not work on these bugs for now then?
[18:59:19] <bmansurov>	 jdlrobson: I was using icon-12px and icon-15px that are already defined, but you said I should not use them
[18:59:27] <grrrit-wm>	 (03PS1) 10BearND: Left/right animation inside page info dialog [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171875 
[18:59:30] <grrrit-wm>	 (03PS1) 10BearND: Just thumbnail and title for disambig items [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171876 
[18:59:56] <kaldari|2>	 phuedx: I owe you a bunch of code review too. Hopefully I'll get to some more of it today.
[19:00:16] <Maryana>	 kristenlans: can you add me & kaldari to the next sprint board plz?
[19:00:24] <Maryana>	 we're doing some story grooming
[19:00:27] <kristenlans>	 YES
[19:00:32] <Maryana>	 danke
[19:01:57] <kristenlans>	 Maryana shoudl be good to go
[19:03:24] <joakino>	 phuedx rmoen jdlrobson kaldari|2 MaxSem what do guys think of phabricator from yesterday?
[19:03:49] <grrrit-wm>	 (03CR) 10Bmansurov: Update reference drawer styling (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov)
[19:04:08] <joakino>	 bmansurov: ^ (i forgot you :\)
[19:04:39] <bmansurov>	 joakino: I think it's alright, it's just different
[19:04:57] <jdlrobson>	 joakino: i think it's a bit rough around the edges right now, it's basically bugzilla with a poor quality version of trello
[19:05:01] <jdlrobson>	 so it's a step in the right direction
[19:05:15] <jdlrobson>	 i think when we have code review in there that's going to be the killer feature that would make us consider moving over
[19:05:26] <joakino>	 jdlrobson: it doesnt?
[19:05:28] <MaxSem>	 joakino, definitely not as emo as trelo:P
[19:05:52] <joakino>	 trello is pretty good
[19:06:23] <joakino>	 I'll watch the video later and see your faces
[19:06:51] <rmoen>	 joakino: I agree with ^.  It seems like it needs to be polished a bit before the teams will want to switch
[19:07:12] <jdlrobson>	 joakino: not yet
[19:07:12] <wikibugs>	 3MobileFrontend / 3stable: Clicking notifications icon takes me to Special:Notifications rather than JavaScript overlay. - 10https://bugzilla.wikimedia.org/73149 (10Jon) 3NEW p:3Unprio s:3normal a:3None Eek.
[19:07:14] <jdlrobson>	 thats' phase 2
[19:07:17] <jdlrobson>	 ^ eek btw. nasty bug 
[19:08:45] <joakino>	 oh ok
[19:10:27] <wikibugs>	 3MobileFrontend / 3stable: Clicking notifications icon takes me to Special:Notifications rather than JavaScript overlay. - 10https://bugzilla.wikimedia.org/73149#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Ud2ECKTO
[19:12:11] <TrevorParscal>	 bmansurov: you were asking about indicators?
[19:12:27] <TrevorParscal>	 do you still have any questions?
[19:13:55] <bmansurov>	 TrevorParscal: yes, but my question is related to CSS rules, not indicators themselves. Basically, I'd like to scale an icon down or up using CSS, but jdlrobson says I should not mess with CSS rules, and use the right size icon instead.
[19:15:21] <jdlrobson>	 TrevorParscal: nothing to worry about too yet, we are just cleaning up our existing icons in prep for the RL image module
[19:16:44] <joakino>	 jdlrobson: you reproduced this yesterday? https://bugzilla.wikimedia.org/show_bug.cgi?id=73046
[19:16:52] <joakino>	 i can't reproduce it
[19:17:24] <joakino>	 fuck
[19:17:39] <joakino>	 jdlrobson: i can, just with iphone 5/5s, not with 6
[19:17:50] <grrrit-wm>	 (03PS3) 10Bmansurov: Fix broken switcher icons in alpha for VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) 
[19:19:10] <wikibugs>	 3MobileFrontend / 3stable: Swiping in the edit screen blanks the screen - 10https://bugzilla.wikimedia.org/73046#c4 (10Jhernandez) 5NEW>3ASSI In the simulator just with iPhone 5/5s, iPhone 6 does not present the bug.
[19:19:51] <TrevorParscal>	 bmansurov: yeah, also remember that we need to support browsers that don't support background-size, so it won't work using CSS backgrounds in some browsers, and even if it did those same browsers usually don't support svg so the scaled PNG will look horrific
[19:23:06] <grrrit-wm>	 (03PS2) 10Bmansurov: Put icon and text on the same line in VE switcher dropdown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171771 
[19:24:40] <Deskana>	 vbamba: Are you in the office, or are you at this conference?
[19:26:41] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Address template FIXME, introduce overlay header partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171866 
[19:26:43] <grrrit-wm>	 (03PS1) 10Jdlrobson: Tests: Talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171881 
[19:27:11] <phuedx>	 yo
[19:27:22] <phuedx>	 joakino: i've yet to watch the recording
[19:27:27] <phuedx>	 was going to tomo morning
[19:27:36] <joakino>	 phuedx: same
[19:27:38] <phuedx>	 (i get up at 6 am, george wakes up at 7-7:30)
[19:28:03] <joakino>	 phuedx: tight schedule hehe
[19:30:28] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 (owner: 10Jdlrobson)
[19:33:53] <joakino>	 I'm done for today
[19:34:54] <joakino>	 have a nice weekend!!
[19:35:13] <Maryana>	 seeya joakino 
[19:37:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Address template FIXME, introduce overlay header partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171866 (owner: 10Jdlrobson)
[19:37:34] <grrrit-wm>	 (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171866 (owner: 10Jdlrobson)
[19:38:43] <grrrit-wm>	 (03PS11) 10Florianschmidtwelzow: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 
[19:39:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow)
[19:45:28] <wikibugs>	 3MobileFrontend / 3stable: no border around textarea in Special:Export - 10https://bugzilla.wikimedia.org/73152 (10Bahodir Mansurov) 3NEW p:3Unprio s:3normal a:3None Created attachment 17074   --> https://bugzilla.wikimedia.org/attachment.cgi?id=17074&action=edit no-border  See the attached screensho...
[19:47:12] <wikibugs>	 3MobileFrontend / 3stable: Unable to unwatch on Special:EditWatchlist - 10https://bugzilla.wikimedia.org/73098#c5 (10Bahodir Mansurov) Not only you Jon, I'm unable to unwatch a page on mediawiki.org too. The watch icon is not there. This is the page I'm watching: https://m.mediawiki.org/wiki/Mobile_web/Team/...
[19:50:26] <wikibugs>	 3MobileFrontend / 3stable: no border around textarea in Special:Export - 10https://bugzilla.wikimedia.org/73152#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/pHiHyMKa
[19:50:54] <wikibugs>	 3MobileFrontend / 3stable: Collapsing and expanding sections does not work in Category: namespace - 10https://bugzilla.wikimedia.org/73063#c2 (10Bahodir Mansurov) After Max's comments during standup, should we update the UI (remove heading icon maybe?) and make sections not collapsible?
[19:51:18] <grrrit-wm>	 (03PS12) 10Florianschmidtwelzow: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 
[19:51:25] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Further recommendations on reducing cronspam [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171885 
[19:51:49] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Further recommendations on reducing cronspam [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171885 (owner: 10Dr0ptp4kt)
[19:52:12] <FlorianSW>	 jdlrobson, kaldari|2: is it right, that jenkins tests with wgMFEnableBeta = false? :/
[19:52:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Further recommendations on reducing cronspam [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171885 (owner: 10Dr0ptp4kt)
[19:52:55] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Fix wgMFShowRedLinks (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow)
[19:55:52] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Fix wgMFShowRedLinks (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow)
[19:59:14] <grrrit-wm>	 (03CR) 10Phuedx: "I don't feel quite right about it because there's no one module that tells us which version of WikiGrok to load. There are two currently. " (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx)
[20:06:17] <phuedx>	 ok folks
[20:06:22] <phuedx>	 am off for the night
[20:06:27] <phuedx>	 see y'all on monday
[20:07:03] <FlorianSW>	 happy weekend phuedx!
[20:07:11] <phuedx>	 \o/
[20:07:16] <phuedx>	 and the same to you FlorianSW :)
[20:07:30] <FlorianSW>	 :)
[20:07:32] <FlorianSW>	 thanks
[20:08:33] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Hygiene: Address template FIXME, introduce overlay header partial (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171866 (owner: 10Jdlrobson)
[20:09:25] <wikibugs>	 3MobileFrontend / 3stable: no border around textarea in Special:Export - 10https://bugzilla.wikimedia.org/73152#c2 (10Jon) 5NEW>3RESO/DUP Needs to be a mediawiki ui element  *** This bug has been marked as a duplicate of bug 71434 ***
[20:22:18] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Tests: Talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171881 (owner: 10Jdlrobson)
[20:26:23] <rmoen>	 How do I make transclusions (templates) from commons work on my local wiki ? 
[20:26:43] <rmoen>	 Wikitext looks like this {{Commons cat|People by religion}}
[20:26:54] <grrrit-wm>	 (03CR) 10Bmansurov: WikiGrok A/B test dry run (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx)
[20:36:31] <grrrit-wm>	 (03CR) 10Robmoen: [C: 031] WikiGrok A/B test dry run (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx)
[20:37:07] <grrrit-wm>	 (03PS1) 10Ori.livneh: Revert "Revert "Respect existing X-Analytics header, if set"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171891 
[20:37:55] <Deskana>	 I'm baaaack
[20:38:09] <MaxSem>	 good for yoooooooou
[20:38:16] <YuviPanda>	 gj
[20:38:22] <Deskana>	 Thank youuuuuu
[20:38:43] <YuviPanda>	 Deskana: yw
[20:40:05] <FlorianSW>	 rmoen: do you mean https://www.mediawiki.org/wiki/Manual:$wgEnableScaryTranscluding ??? 
[20:40:06] <Deskana>	 dbrant: I had the chance to meet the guys that did the UX review of the app.
[20:40:44] <dbrant>	 Deskana: cool!! did they say anything else?
[20:40:45] <MaxSem>	 YuviPanda, wh s shrtnd?
[20:41:31] <YuviPanda>	 MaxSem: s cld, cnt spr enrgy
[20:41:50] <MaxSem>	 and cold is like +10?
[20:42:04] <MaxSem>	 wait, +15?
[20:42:59] <YuviPanda>	 50F
[20:43:13] <YuviPanda>	 so +10
[20:48:06] <grrrit-wm>	 (03CR) 10Bmansurov: WikiGrok A/B test dry run (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx)
[20:52:37] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] WIP: add wikidata descriptions... somewhere (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171767 (owner: 10MaxSem)
[20:59:52] <YuviPanda>	 dbrant: bearND hey! I just made a commit to the alpha builds, seems up again http://android-builds.wmflabs.org/
[21:01:04] <bearND>	 YuviPanda: yeah! :) 
[21:01:16] <bearND>	 YuviPanda: can we access log files now?
[21:01:18] <YuviPanda>	 bearND: it was really stupid. https://gerrit.wikimedia.org/r/171900
[21:01:25] <YuviPanda>	 bearND: no, because I haven't done that yet :(
[21:01:48] <bearND>	 YuviPanda: good catch, though ;)
[21:02:24] <YuviPanda>	 bearND: I got copied on root mail today, so I get *all* cron failure messages, and then this was among them, making debugging easy
[21:02:39] <YuviPanda>	 bearND: I'm going to wait to see if I actually get cron report when this comes next
[21:03:36] <bearND>	 YuviPanda: I'm glad the build is working now, so the logs are not critical as long as the build is working. We're going to merge a bunch of stuff later today. So maybe you'll get more emails then.
[21:03:54] <YuviPanda>	 bearND: yeah! :)
[21:04:19] <dbrant>	 YuviPanda: very nice!! thanks
[21:04:49] <YuviPanda>	 dbrant: bearND sorry it took so long...
[21:05:53] <bearND>	 YuviPanda: do you want to sent an email to mobile-l to announce that it's working again?
[21:06:12] <YuviPanda>	 bearND: dbrant can one of you guys do that? :)
[21:06:17] <bearND>	 YuviPanda: sure
[21:06:26] <bearND>	 i'll do it
[21:06:28] <YuviPanda>	 thanks!
[21:17:39] <rmoen>	 FlorianSW: Exactly.  Thanks
[21:17:51] <rmoen>	 re: scary transclusion thingy
[21:20:25] <YuviPanda>	 oh wow
[21:20:29] <YuviPanda>	 it's actually called scary transclusion
[21:22:18] <grrrit-wm>	 (03PS2) 10Jdlrobson: Tests: Talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171881 
[21:22:20] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Address template FIXME, introduce overlay header partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171866 
[21:22:22] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Refactor talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171958 
[21:22:24] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Make add talk discussion a route. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 
[21:22:43] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "Questions, commenting and method name recommendations." (036 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171472 (owner: 10Yurik)
[21:23:40] <YuviPanda>	 dr0ptp4kt: btw, I sent yurik an email about his cronjob on stat1002, so do poke him about it when you run into him next :)
[21:23:42] <YuviPanda>	 online, that is
[21:23:55] <dr0ptp4kt>	 YuviPanda: yurik?
[21:23:59] <YuviPanda>	 yeah
[21:24:14] <YuviPanda>	 oh wait, he's not in the office...
[21:24:15] <YuviPanda>	 nevermind.
[21:24:17] <dr0ptp4kt>	 YuviPanda: cool, will do. i'm writing him an email on another thing, so i'll bug him there and next standup or sooner
[21:24:24] <YuviPanda>	 dr0ptp4kt: ah, yeah, worst case :)
[21:24:26] <YuviPanda>	 dr0ptp4kt: do remind him anyway
[21:24:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make add talk discussion a route. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 (owner: 10Jdlrobson)
[21:28:46] <Deskana>	 dbrant: Not really, but it's nice to put a face to the people who sent the feedback.
[21:28:54] <Deskana>	 dbrant: Also, one of them is a fellow countryman of mine!
[21:29:03] <Deskana>	 dbrant: Albeit a dirty Southerner...
[21:31:31] <Deskana>	 dbrant: In a nutshell, I'm sold.
[21:31:34] <Deskana>	 MATERIAL DESIGN
[21:34:10] <YuviPanda>	 Deskana: hehe, 'dirty southerner''
[21:34:26] <Deskana>	 OAI MAYTE
[21:34:32] <Deskana>	 BRAV
[21:34:40] <Deskana>	 I'M CATCHING A BASS
[21:34:46] <Deskana>	 GOING FOR A BAAAAAAARTH
[21:35:00] <Deskana>	 GOING TO THE PAB FOR A POAINT
[21:35:20] <Deskana>	 That's how Southern English sounds to me.
[21:36:03] <bearND>	 dbrant: are you making more changes to the patch that introduces description to the lead images?
[21:37:10] <rmoen>	 Deskana: lol
[21:37:47] <bearND>	 dbrant: if not then i'm going to merge it
[21:37:48] <Deskana>	 When Americans hear a Southern Brit say "Baaarrrth" or "Graaaaaaarss
[21:37:54] <Deskana>	 I cringe too :-p
[21:38:25] <YuviPanda>	 Deskana: oh really, that sounded somewhat glasgoweigan
[21:38:30] <dbrant>	 bearND: there may be some minor styling tweaks, but that can come later. If you think it can be merged now, then by all means.
[21:38:38] <bearND>	 ok
[21:38:42] <Deskana>	 YuviPanda: Hah, I guess it depends what you read in to it. :-)
[21:38:48] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Wikidata description under page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170698 (owner: 10Dbrant)
[21:38:48] <YuviPanda>	 :D
[21:38:49] <YuviPanda>	 true
[21:38:50] <YuviPanda>	 true
[21:40:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Wikidata description under page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170698 (owner: 10Dbrant)
[21:41:12] <YuviPanda>	 dbrant: bearND now to see if the cron picks it up :)
[21:41:15] <YuviPanda>	 another 20mins
[21:41:16] <YuviPanda>	 to go
[21:43:31] <bearND>	 dbrant: https://gerrit.wikimedia.org/r/#/c/168773/8 would need a manual rebase btw
[21:45:04] <grrrit-wm>	 (03PS2) 10BearND: Remove pinch-zoom in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171850 (owner: 10Dbrant)
[21:45:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove pinch-zoom in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171850 (owner: 10Dbrant)
[21:47:40] <grrrit-wm>	 (03CR) 10MaxSem: WIP: add wikidata descriptions... somewhere (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171767 (owner: 10MaxSem)
[22:03:31] <kristenlans>	 Deskana dbrant: do we need to sync up on Next Sprint?
[22:04:38] <kristenlans>	 jdlrobso_: I’m waiting for you in hangout ;-)
[22:04:42] <jdlrobso_>	 qahhaahah\
[22:04:49] <MaxSem>	 mf
[22:04:53] <kristenlans>	 HO!hoHO!Hoh!
[22:04:54] <MaxSem>	 erg
[22:07:42] <dbrant>	 kristenlans: anytime
[22:16:06] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "Per Sam, let's add the ability to test a real campaign with a fake Wikidata ID. This will only work for wikis on the cluster (like testwik" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 (owner: 10MaxSem)
[22:17:23] <rmoen>	 Arg.  trying to get interwiki to transclude tempaltes from commons on my local wiki is proving to be difficult, I read the manual.  Perhaps outdated.
[22:18:08] <grrrit-wm>	 (03PS2) 10MaxSem: WIP: add wikidata descriptions... somewhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171767 
[22:19:53] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] Hygiene: Address template FIXME, introduce overlay header partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171866 (owner: 10Jdlrobson)
[22:20:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Address template FIXME, introduce overlay header partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171866 (owner: 10Jdlrobson)
[22:24:42] <Maryana>	 kaldari|2: it looks like somebody still needs to update Schema:MobileWebWikiGrok to the latest revision of the schema
[22:24:54] <Maryana>	 cos the data in that table still looks like the data from the old schema
[22:25:00] <Maryana>	 is that on your list of todos for monday?
[22:25:18] <kaldari|2>	 Maryana: looking...
[22:25:20] <bearND>	 dbrant: any recommendation on how to best get a list of wikidata IDs from a list of page titles?
[22:27:06] <dbrant>	 bearND: hmm, not off the top of my head.  maybe legoktm or MaxSem might know ^ 
[22:27:16] <kaldari|2>	 Maryana: the code looks up to date, what is missing?
[22:27:31] <legoktm>	 bearND: prop=pageprops
[22:27:57] <bearND>	 legoktm: dbrant: thanks!
[22:28:05] <legoktm>	 https://en.wikipedia.org/w/api.php?action=query&titles=Main%20Page|Barack%20Obama&prop=pageprops
[22:28:53] <legoktm>	 you can pass 50 pages to titles in one request, 500 if you have apihighlimits iirc
[22:31:14] <bearND>	 legoktm: thanks, that's good to know. It's unlikely that I'll hit the limit but will check it anyways. This is for adding descriptions to disambiguation links
[22:33:15] <bearND>	 dbrant: hmmm, probably would be good to combine this request with the one we do for page images
[22:33:38] <Deskana>	 kristenlans, dbrant: That's up to Dmitry. I'm pretty clear on what's going on!
[22:34:00] <kristenlans>	 Dbrant take a pass through and see if you have any questions?
[22:34:24] <dbrant>	 kristenlans: will do! at first glance, the estimates look reasonable.
[22:36:47] <rmoen>	 tfinc: hey, i'm in https://plus.google.com/hangouts/_/wikimedia.org/rmoen-tfinc?authuser=0
[22:37:06] <tfinc>	 rmoen: great, heading to a room now
[22:41:34] <bmansurov>	 jdlrobso_: can you give me the link to the css/less styleguide?
[22:42:38] <jdlrobso_>	 bmansurov: give me a few mins talking to kristenlans
[22:48:59] <jdlrobso_>	 bmansurov: hey sorry about that
[22:49:13] <bmansurov>	 jdlrobso_: np
[22:49:19] <jdlrobso_>	 http://tools.wmflabs.org/styleguide/
[22:49:21] <kristenlans>	 dbrant: if you’re happy, I’m happy :-)
[22:49:25] <jdlrobso_>	 not sure whether it's up to date though
[22:49:45] <bmansurov>	 jdlrobso_: thanks, so in general I should only use icons with 12px and 24px sizes?
[22:53:06] <Maryana>	 kaldari|2: so we want to move this card back to the backlog? https://trello.com/c/xGwY2peL/9-5-new-wikigrok-campaign-language-of-work-in-uk-english
[22:53:12] <wikibugs>	 3MobileFrontend / 3Hygiene: Kill M.isApp method - 10https://bugzilla.wikimedia.org/73158 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon This is no longer needed.
[22:54:08] <kaldari|2>	 Maryana: Yeah, let's move that to the backlog
[22:55:13] <Maryana>	 anything else?
[22:55:17] <Maryana>	 kaldari|2: ^
[22:55:24] <wikibugs>	 3MobileFrontend / 3Hygiene: Kill M.isApp method - 10https://bugzilla.wikimedia.org/73158#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/dRIDhaBn
[22:55:44] <kaldari|2>	 Maryana: I'll double check....
[23:06:12] <wikibugs>	 3MobileFrontend / 3alpha: Main menu links are not being logged in alpha - 10https://bugzilla.wikimedia.org/73159 (10Jon) 3NEW p:3Unprio s:3normal a:3None Update MobileWebClickTracking.js needs to be updated so that it recognises links which use mw-ui-icon.
[23:07:11] <kaldari|2>	 Maryana: come find me when you have a chance
[23:07:59] <grrrit-wm>	 (03PS7) 10Bmansurov: Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 
[23:10:26] <wikibugs>	 3MobileFrontend / 3alpha: Main menu links are not being logged in alpha - 10https://bugzilla.wikimedia.org/73159#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/WlrgFxYY
[23:27:12] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Make add talk discussion a route. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 (https://bugzilla.wikimedia.org/71076) 
[23:27:18] <grrrit-wm>	 (03PS1) 10Jdlrobson: Enable routing on TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) 
[23:27:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make add talk discussion a route. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 (https://bugzilla.wikimedia.org/71076) (owner: 10Jdlrobson)
[23:28:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Enable routing on TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) (owner: 10Jdlrobson)
[23:32:12] <wikibugs>	 3Wikipedia App / 3Android App: SQLiteException: Can't upgrade/downgrade database - 10https://bugzilla.wikimedia.org/73161 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None android.database.sqlite.SQLiteException: Can't upgrade read-only database from version 4 to 5: /data/data/org.wikipedia/databases/wi...
[23:38:48] <grrrit-wm>	 (03PS3) 10Robmoen: Tests: Talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171881 (owner: 10Jdlrobson)
[23:39:00] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] Tests: Talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171881 (owner: 10Jdlrobson)
[23:39:13] <grrrit-wm>	 (03PS2) 10Robmoen: Hygiene: Refactor talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171958 (owner: 10Jdlrobson)
[23:39:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tests: Talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171881 (owner: 10Jdlrobson)
[23:40:21] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Fix broken switcher icons in alpha for VE (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) (owner: 10Bmansurov)
[23:43:57] <wikibugs>	 3MobileFrontend / 3beta: MobileWebWikiGrokError event logging isn't working - 10https://bugzilla.wikimedia.org/73162 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Table hasn't appeared in log database, which usually means that the event logging requests are not succeeding.
[23:45:26] <wikibugs>	 3MobileFrontend / 3beta: MobileWebWikiGrokError event logging isn't working - 10https://bugzilla.wikimedia.org/73162#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/uy7cs18J
[23:46:40] <jdlrobson>	 bmansurov: i see that florian's patch introduced some jscs errors :/
[23:46:55] <jdlrobson>	 bmansurov: are you able to fix?
[23:47:04] <bmansurov>	 jdlrobson: which patch?
[23:47:16] <jdlrobson>	 bmansurov: latest master `make jscs` fails. I cant commit anything
[23:47:17] <jdlrobson>	 categories
[23:47:26] <bmansurov>	 jdlrobson: ok
[23:48:38] <grrrit-wm>	 (03PS1) 10Jdlrobson: Fix broken switcher icons in alpha for VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171983 (https://bugzilla.wikimedia.org/73057) 
[23:48:48] <grrrit-wm>	 (03CR) 10Jdlrobson: "See https://gerrit.wikimedia.org/r/171983" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) (owner: 10Bmansurov)
[23:48:50] <grrrit-wm>	 (03PS1) 10Bmansurov: Fix jscs errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171984 
[23:49:01] <bmansurov>	 jdlrobson: ^
[23:49:01] <jdlrobson>	 bmansurov: like lightning! :D
[23:49:21] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Fix jscs errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171984 (owner: 10Bmansurov)
[23:49:38] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix jscs errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171984 (owner: 10Bmansurov)
[23:50:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Fix jscs errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171984 (owner: 10Bmansurov)
[23:51:42] <grrrit-wm>	 (03Abandoned) 10Bmansurov: Fix broken switcher icons in alpha for VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) (owner: 10Bmansurov)
[23:51:51] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Fix broken switcher icons in alpha for VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171983 (https://bugzilla.wikimedia.org/73057) (owner: 10Jdlrobson)
[23:52:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix broken switcher icons in alpha for VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171983 (https://bugzilla.wikimedia.org/73057) (owner: 10Jdlrobson)
[23:53:25] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Looking at the code it seems to be using Icon but not the hasText property. Let me take a look at this one too, it seems complicated." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171771 (owner: 10Bmansurov)
[23:55:10] <rmoen>	 jdlrobson: is there something wraps section content in a div in mobilefrontend ? 
[23:59:00] <rmoen>	 jdlrobson: nvm, i think I figured it out.